From nobody Tue Aug 25 23:51:07 2026 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5302C41CB47 for ; Wed, 8 Jul 2026 15:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; cv=none; b=lbxjZszC6vzPHQr8/kyJBwkvyHspBJz9HoACUj6I4WBOEIYgRoCkOFwmavRBrM1xA/KzXb4q6davWhe46fHN/wUGNZQ26v54Gy9A6goTajMmtPqI9YsGGS96hdMJI/S99/n9M0r90zISSQjfZ8imI6jDvycs62kxs94I0fp9K7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; c=relaxed/simple; bh=WktfnNh5jGfzjSav3b5N/VVjAcmD8b6r65gdn+nqaIE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c8sbMLZ/C0B0ADjpf5A/H+puWd26s6znkdVKWrgIv3AiWTHG0JHJRK3q3X2qNfsnLIle4Qyzjt3BGffpM5OXh7W2SnXeyeWVA6PiGBCD3IriTdCm54CwlJsuSMznC7F+oM2EiJ3zAUzvS0ZxuxN6mSsuTSARkUqvo7ED+UREbic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=N0o9DmW7; arc=none smtp.client-ip=117.135.210.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="N0o9DmW7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=CV BLJH7rKBv5MBPW37WAkqKOGbtV730hfHMoYmNuNmA=; b=N0o9DmW7WkP8SqvjQN l3jB89VpKXqrAWtTRxa+kTWigEB/xcrFp70EKF4qa5YekPWuNaxJlu55iBe+JdoD qUFmL+r7bOzaLUlGtzxVBMwhhKvzRryNs6qxt3Lh56bX86ZE6nP2Qoe80FTXx+Gl dBts5xOBtPLZDXw+B2ccJt4dc= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S4; Wed, 08 Jul 2026 23:09:37 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 2/5] staging: rtl8723bs: fix line length and alignment in rtw_mlme_ext Date: Wed, 8 Jul 2026 23:09:25 +0800 Message-Id: <20260708150928.74065-3-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S4 X-Coremail-Antispam: 1Uf129KBjvJXoWxtF13Zw1DJw48Cw1DGry8Zrb_yoWDGr4rpF 4vg34DGr48Wrn0yr4kZr4xXFZ3GrWrWFWxKayfta4YkFn7Ar9IqFyYyryYvws8Ar45X3WY kFnYgwn8uw4DCrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Ur8nOUUUUU= X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBqhFUW2pOaDGEZQAA3o Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding lines exceeding 100 columns and misaligned parentheses in rtw_mlme_ext.c. No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 66 +++++++++++++------ 1 file changed, 45 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index d7404a3a5e0f..2b706f1abd4f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -591,7 +591,9 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) } =20 /* check the vendor of the assoc AP */ - pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe + sizeof(struct ie= ee80211_hdr_3addr), len - sizeof(struct ieee80211_hdr_3addr)); + pmlmeinfo->assoc_AP_vendor =3D + check_assoc_AP(pframe + sizeof(struct ieee80211_hdr_3addr), + len - sizeof(struct ieee80211_hdr_3addr)); =20 /* update TSF Value */ update_TSF(pmlmeext, pframe, len); @@ -610,7 +612,8 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) return _SUCCESS; } =20 - if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmein= fo->state & WIFI_FW_ASSOC_SUCCESS)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && + (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { ret =3D rtw_check_bcn_info(padapter, pframe, len); @@ -1049,12 +1052,14 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.rsn_ie; wpa_ie_len =3D elems.rsn_ie_len; =20 - if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwi= se_cipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, + &pairwise_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(1); =20 pstat->wpa2_group_cipher =3D group_cipher & psecuritypriv->wpa2_group_c= ipher; - pstat->wpa2_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa2_p= airwise_cipher; + pstat->wpa2_pairwise_cipher =3D pairwise_cipher & + psecuritypriv->wpa2_pairwise_cipher; =20 if (!pstat->wpa2_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1071,12 +1076,14 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.wpa_ie; wpa_ie_len =3D elems.wpa_ie_len; =20 - if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwis= e_cipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, + &pairwise_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(0); =20 pstat->wpa_group_cipher =3D group_cipher & psecuritypriv->wpa_group_cip= her; - pstat->wpa_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa_pai= rwise_cipher; + pstat->wpa_pairwise_cipher =3D pairwise_cipher & + psecuritypriv->wpa_pairwise_cipher; =20 if (!pstat->wpa_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1105,8 +1112,8 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ /* that the selected registrar of AP is _FLASE */ - if ((psecuritypriv->wpa_psk > 0) - && (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { + if ((psecuritypriv->wpa_psk > 0) && + (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { if (pmlmepriv->wps_beacon_ie) { u8 selected_registrar =3D 0; =20 @@ -2106,8 +2113,12 @@ void issue_beacon(struct adapter *padapter, int time= out_ms) uint wps_ielen; u8 sr =3D 0; =20 - wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + sizeof= (struct ieee80211_hdr_3addr) + _BEACON_IE_OFFSET_, - pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OFFS= ET_, NULL, &wps_ielen); + wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + + sizeof(struct ieee80211_hdr_3addr) + + _BEACON_IE_OFFSET_, + pattrib->pktlen - + sizeof(struct ieee80211_hdr_3addr) - + _BEACON_IE_OFFSET_, NULL, &wps_ielen); if (wps_ie && wps_ielen > 0) rtw_get_wps_attr_content(wps_ie, wps_ielen, WPS_ATTR_SELECTED_REGISTR= AR, (u8 *)(&sr), NULL); if (sr !=3D 0) @@ -2240,7 +2251,9 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p return; =20 if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { - pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, cur_net= work->ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen); + pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, + cur_network->ie_length - _FIXED_IE_LENGTH_, + NULL, &wps_ielen); =20 /* inerset & update wps_probe_resp_ie */ if (pmlmepriv->wps_probe_resp_ie && pwps_ie && wps_ielen > 0) { @@ -2281,14 +2294,15 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p signed int ssid_ielen; signed int ssid_ielen_diff; u8 *buf; - u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + sizeof(struct ieee80= 211_hdr_3addr); + u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + + sizeof(struct ieee80211_hdr_3addr); =20 buf =3D kzalloc(MAX_IE_SZ, GFP_ATOMIC); if (!buf) return; =20 ssid_ie =3D rtw_get_ie(ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ie= len, - (pframe - ies) - _FIXED_IE_LENGTH_); + (pframe - ies) - _FIXED_IE_LENGTH_); =20 ssid_ielen_diff =3D cur_network->ssid.ssid_length - ssid_ielen; =20 @@ -2309,7 +2323,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p memcpy(buf, remainder_ie, remainder_ielen); memcpy(remainder_ie + ssid_ielen_diff, buf, remainder_ielen); *(ssid_ie + 1) =3D cur_network->ssid.ssid_length; - memcpy(ssid_ie + 2, cur_network->ssid.ssid, cur_network->ssid.ssid_len= gth); + memcpy(ssid_ie + 2, cur_network->ssid.ssid, + cur_network->ssid.ssid_length); =20 pframe +=3D ssid_ielen_diff; pattrib->pktlen +=3D ssid_ielen_diff; @@ -2687,7 +2702,8 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, pstat->bssratelen, ps= tat->bssrateset, &(pattrib->pktlen)); } else { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, pstat->bssrateset,= &(pattrib->pktlen)); - pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), pstat->bssrateset + 8, &(pattrib->pktlen)); + pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), + pstat->bssrateset + 8, &(pattrib->pktlen)); } =20 if ((pstat->flags & WLAN_STA_HT) && (pmlmepriv->htpriv.ht_option)) { @@ -3638,7 +3654,8 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) if (initiator =3D=3D 0) {/* recipient */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->recvreorder_ctrl[tid].enable) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, + (((tid << 1) | initiator) & 0x1F)); psta->recvreorder_ctrl[tid].enable =3D false; psta->recvreorder_ctrl[tid].indicate_seq =3D 0xffff; } @@ -3646,7 +3663,8 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) } else if (initiator =3D=3D 1) {/* originator */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->htpriv.agg_enable_bitmap & BIT(tid)) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, + (((tid << 1) | initiator) & 0x1F)); psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); } @@ -3671,7 +3689,9 @@ unsigned int send_beacon(struct adapter *padapter) cond_resched(); rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; - } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpr= iseRemoved && !padapter->bDriverStopped); + } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && + !padapter->bSurpriseRemoved && + !padapter->bDriverStopped); =20 } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); =20 @@ -4550,7 +4570,9 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) =20 psta->htpriv.ampdu_enable =3D pmlmepriv->htpriv.ampdu_enable; =20 - psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para & IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; + psta->htpriv.rx_ampdu_min_spacing =3D + (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & + IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; =20 if (support_short_GI(padapter, &(pmlmeinfo->HT_caps), CHANNEL_WIDTH_20)) psta->htpriv.sgi_20m =3D true; @@ -5273,9 +5295,11 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned= char *pbuf) u8 val8; =20 if (is_client_associated_to_ap(padapter)) - issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms / 100, 100); + issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, + param->deauth_timeout_ms / 100, 100); =20 - if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo= ->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* Stop BCN */ val8 =3D 0; rtw_hal_set_hwreg(padapter, HW_VAR_BCN_FUNC, (u8 *)(&val8)); --=20 2.34.1