From nobody Mon Jul 27 07:57:57 2026 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83613368953 for ; Wed, 8 Jul 2026 15:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523400; cv=none; b=u6ECV5XsWPk85yv0pgXZ5oTMf8SDMFGFoDGJQ3LyKOXAISyr6ZHilWEpOfqgnP9v3iL2QqRKi5RJcemdBryVFV8lIGIvWfGzb989O8spAfXT1INFTq72gdqW4OLdvRJkiQLIDczyPqYuN3imOZqiEgTeAqBTzmZLtIqLJzTmilo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523400; c=relaxed/simple; bh=NPmsPRvnG00REWIw/Yk+HIHxDWUVyzcRV4bARMxMgdg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=a5kXAmxh0/E5mi5qxjhOLZOwBv39TsbEnf/HBAfXL244aMEE/7JNxeKFduoIPO5Vm5grNH7NT5MF8cMathWo6E34izZkU0NN/V9ZunlDXbCscUWVsZS/QRmOYdL5BB6x1L1oYEC0/ZhcdqJwQGQUH2kcRjhEdTWEkGRjMKubMdg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=Et7vjtew; arc=none smtp.client-ip=220.197.31.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="Et7vjtew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=PU YYSxoXtfPx5OkDigMJgVBiZRETUIl8TkOb9nSaAag=; b=Et7vjtewPli8N5X9Ke Qc0GNI256HEF/mm+R1YiJGrPNm5wNASX3CcNPpWVXpomkpeaGLbBOLnNIm92unjs 1TYMKH6ox0C7+gikIpR/xJ1q5Ki9gsGZfOT1dQz0s+TvFYTzRsx0EQHKBaryKCi7 Pz+mOyQUAf1Ctrn1lPFnVXtmI= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S3; Wed, 08 Jul 2026 23:09:37 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 1/5] staging: rtl8723bs: fix operator spacing in rtw_mlme_ext Date: Wed, 8 Jul 2026 23:09:24 +0800 Message-Id: <20260708150928.74065-2-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S3 X-Coremail-Antispam: 1Uf129KBjvAXoWfAw4DZFykKw48Wry5Gr47CFg_yoW5Wr4UGo WIk398tw48W3yUt348KFy0kr9xur4Fgry3Cws3uwn8Xw47C3Wjvry3A3W5Was2qF10qF9F va1IvrWqqF1ktFWfn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73VFW2AGmfu7bjvjm3 AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RXL05DUUUU X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBlhFUW2pOaDGZSgAA3m Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding preferred spaces around operators in rtw_mlme_ext.c No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 198 +++++++++--------- 1 file changed, 99 insertions(+), 99 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 128213c97a61..d7404a3a5e0f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -522,7 +522,7 @@ unsigned int OnProbeReq(struct adapter *padapter, union= recv_frame *precv_frame) if (is_valid_p2p_probereq) goto _issue_probersp; =20 - if ((ielen !=3D 0 && false =3D=3D !memcmp((p+2), cur->ssid.ssid, cur->ss= id.ssid_length)) + if ((ielen !=3D 0 && false =3D=3D !memcmp((p + 2), cur->ssid.ssid, cur->= ssid.ssid_length)) || (ielen =3D=3D 0 && pmlmeinfo->hidden_ssid_mode) ) return _SUCCESS; @@ -591,7 +591,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) } =20 /* check the vendor of the assoc AP */ - pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe+sizeof(struct ieee= 80211_hdr_3addr), len-sizeof(struct ieee80211_hdr_3addr)); + pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe + sizeof(struct ie= ee80211_hdr_3addr), len - sizeof(struct ieee80211_hdr_3addr)); =20 /* update TSF Value */ update_TSF(pmlmeext, pframe, len); @@ -610,7 +610,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) return _SUCCESS; } =20 - if (((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmeinfo= ->state & WIFI_FW_ASSOC_SUCCESS)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmein= fo->state & WIFI_FW_ASSOC_SUCCESS)) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { ret =3D rtw_check_bcn_info(padapter, pframe, len); @@ -628,7 +628,7 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) =20 adaptive_early_32k(pmlmeext, pframe, len); } - } else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + } else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { /* update WMM, ERP in the beacon */ @@ -677,7 +677,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) uint len =3D precv_frame->u.hdr.len; u8 offset =3D 0; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) return _FAIL; =20 sa =3D GetAddr2Ptr(pframe); @@ -691,8 +691,8 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) prxattrib->hdrlen =3D WLAN_HDR_A3_LEN; prxattrib->encrypt =3D _WEP40_; =20 - iv =3D pframe+prxattrib->hdrlen; - prxattrib->key_index =3D ((iv[3]>>6)&0x3); + iv =3D pframe + prxattrib->hdrlen; + prxattrib->key_index =3D ((iv[3] >> 6) & 0x3); =20 prxattrib->iv_len =3D 4; prxattrib->icv_len =3D 4; @@ -933,7 +933,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) u8 *pframe =3D precv_frame->u.hdr.rx_data; uint pkt_len =3D precv_frame->u.hdr.len; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) return _FAIL; =20 frame_type =3D GetFrameSubType(pframe); @@ -991,7 +991,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) goto OnAssocReqFail; } else { /* check if ssid match */ - if (memcmp(p+2, cur->ssid.ssid, cur->ssid.ssid_length)) + if (memcmp(p + 2, cur->ssid.ssid, cur->ssid.ssid_length)) status =3D WLAN_STATUS_CHALLENGE_FAIL; =20 if (ie_len !=3D cur->ssid.ssid_length) @@ -1014,7 +1014,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) if (ie_len > sizeof(supportRate)) ie_len =3D sizeof(supportRate); =20 - memcpy(supportRate, p+2, ie_len); + memcpy(supportRate, p + 2, ie_len); support_rate_num =3D ie_len; =20 p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP= _RATES, &ie_len, @@ -1049,12 +1049,12 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.rsn_ie; wpa_ie_len =3D elems.rsn_ie_len; =20 - if (rtw_parse_wpa2_ie(wpa_ie-2, wpa_ie_len+2, &group_cipher, &pairwise_c= ipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwi= se_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(1); =20 - pstat->wpa2_group_cipher =3D group_cipher&psecuritypriv->wpa2_group_cip= her; - pstat->wpa2_pairwise_cipher =3D pairwise_cipher&psecuritypriv->wpa2_pai= rwise_cipher; + pstat->wpa2_group_cipher =3D group_cipher & psecuritypriv->wpa2_group_c= ipher; + pstat->wpa2_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa2_p= airwise_cipher; =20 if (!pstat->wpa2_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1071,12 +1071,12 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.wpa_ie; wpa_ie_len =3D elems.wpa_ie_len; =20 - if (rtw_parse_wpa_ie(wpa_ie-2, wpa_ie_len+2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwis= e_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(0); =20 - pstat->wpa_group_cipher =3D group_cipher&psecuritypriv->wpa_group_ciphe= r; - pstat->wpa_pairwise_cipher =3D pairwise_cipher&psecuritypriv->wpa_pairw= ise_cipher; + pstat->wpa_group_cipher =3D group_cipher & psecuritypriv->wpa_group_cip= her; + pstat->wpa_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa_pai= rwise_cipher; =20 if (!pstat->wpa_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1106,7 +1106,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ /* that the selected registrar of AP is _FLASE */ if ((psecuritypriv->wpa_psk > 0) - && (pstat->flags & (WLAN_STA_WPS|WLAN_STA_MAYBE_WPS))) { + && (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { if (pmlmepriv->wps_beacon_ie) { u8 selected_registrar =3D 0; =20 @@ -1137,7 +1137,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) } =20 if (copy_len > 0) - memcpy(pstat->wpa_ie, wpa_ie-2, copy_len); + memcpy(pstat->wpa_ie, wpa_ie - 2, copy_len); } =20 /* check if there is WMM IE & support WWM-PS */ @@ -1156,7 +1156,7 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) if (!p) break; =20 - if (memcmp(p+2, WMM_IE, 6)) { + if (memcmp(p + 2, WMM_IE, 6)) { p =3D p + ie_len + 2; continue; } @@ -1164,33 +1164,33 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) pstat->flags |=3D WLAN_STA_WME; =20 pstat->qos_option =3D 1; - pstat->qos_info =3D *(p+8); + pstat->qos_info =3D *(p + 8); =20 - pstat->max_sp_len =3D (pstat->qos_info>>5)&0x3; + pstat->max_sp_len =3D (pstat->qos_info >> 5) & 0x3; =20 - if ((pstat->qos_info&0xf) !=3D 0xf) + if ((pstat->qos_info & 0xf) !=3D 0xf) pstat->has_legacy_ac =3D true; else pstat->has_legacy_ac =3D false; =20 - if (pstat->qos_info&0xf) { - if (pstat->qos_info&BIT(0)) - pstat->uapsd_vo =3D BIT(0)|BIT(1); + if (pstat->qos_info & 0xf) { + if (pstat->qos_info & BIT(0)) + pstat->uapsd_vo =3D BIT(0) | BIT(1); else pstat->uapsd_vo =3D 0; =20 - if (pstat->qos_info&BIT(1)) - pstat->uapsd_vi =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(1)) + pstat->uapsd_vi =3D BIT(0) | BIT(1); else pstat->uapsd_vi =3D 0; =20 - if (pstat->qos_info&BIT(2)) - pstat->uapsd_bk =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(2)) + pstat->uapsd_bk =3D BIT(0) | BIT(1); else pstat->uapsd_bk =3D 0; =20 - if (pstat->qos_info&BIT(3)) - pstat->uapsd_be =3D BIT(0)|BIT(1); + if (pstat->qos_info & BIT(3)) + pstat->uapsd_be =3D BIT(0) | BIT(1); else pstat->uapsd_be =3D 0; } @@ -1211,14 +1211,14 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) } else pstat->flags &=3D ~WLAN_STA_HT; =20 - if (!pmlmepriv->htpriv.ht_option && (pstat->flags&WLAN_STA_HT)) { + if (!pmlmepriv->htpriv.ht_option && (pstat->flags & WLAN_STA_HT)) { status =3D WLAN_STATUS_CHALLENGE_FAIL; goto OnAssocReqFail; } =20 if ((pstat->flags & WLAN_STA_HT) && - ((pstat->wpa2_pairwise_cipher&WPA_CIPHER_TKIP) || - (pstat->wpa_pairwise_cipher&WPA_CIPHER_TKIP))) { + ((pstat->wpa2_pairwise_cipher & WPA_CIPHER_TKIP) || + (pstat->wpa_pairwise_cipher & WPA_CIPHER_TKIP))) { /* status =3D WLAN_STATUS_CIPHER_SUITE_REJECTED; */ /* goto OnAssocReqFail; */ } @@ -1362,7 +1362,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, uni= on recv_frame *precv_frame) pmlmeinfo->slotTime =3D (pmlmeinfo->capability & BIT(10)) ? 9 : 20; =20 /* AID */ - res =3D pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HD= R_A3_LEN + 4))&0x3fff); + res =3D pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HD= R_A3_LEN + 4)) & 0x3fff); =20 /* following are moved to join event callback function */ /* to handle HT, WMM, rate adaptive, update MAC reg */ @@ -1590,7 +1590,7 @@ unsigned int OnAction_back(struct adapter *padapter, = union recv_frame *precv_fra if (memcmp(myid(&(padapter->eeprompriv)), GetAddr1Ptr(pframe), ETH_ALEN))= /* for if1, sta/ap mode */ return _SUCCESS; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) if (!(pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) return _SUCCESS; =20 @@ -1670,7 +1670,7 @@ static s32 rtw_action_public_decache(union recv_frame= *recv_frame, s32 token) struct adapter *adapter =3D recv_frame->u.hdr.adapter; struct mlme_ext_priv *mlmeext =3D &(adapter->mlmeextpriv); u8 *frame =3D recv_frame->u.hdr.rx_data; - u16 seq_ctrl =3D ((recv_frame->u.hdr.attrib.seq_num&0xffff) << 4) | + u16 seq_ctrl =3D ((recv_frame->u.hdr.attrib.seq_num & 0xffff) << 4) | (recv_frame->u.hdr.attrib.frag_num & 0xf); =20 if (GetRetry(frame)) { @@ -1806,9 +1806,9 @@ unsigned int OnAction_sa_query(struct adapter *padapt= er, union recv_frame *precv struct mlme_ext_priv *pmlmeext =3D &(padapter->mlmeextpriv); unsigned short tid; =20 - switch (pframe[WLAN_HDR_A3_LEN+1]) { + switch (pframe[WLAN_HDR_A3_LEN + 1]) { case 0: /* SA Query req */ - memcpy(&tid, &pframe[WLAN_HDR_A3_LEN+2], sizeof(unsigned short)); + memcpy(&tid, &pframe[WLAN_HDR_A3_LEN + 2], sizeof(unsigned short)); issue_action_SA_Query(padapter, GetAddr2Ptr(pframe), 1, tid); break; =20 @@ -2026,10 +2026,10 @@ static int update_hidden_ssid(u8 *ies, u32 ies_len,= u8 hidden_ssid_mode) u8 *next_ie =3D ssid_ie + 2 + ssid_len_ori; u32 remain_len =3D 0; =20 - remain_len =3D ies_len - (next_ie-ies); + remain_len =3D ies_len - (next_ie - ies); =20 ssid_ie[1] =3D 0; - memcpy(ssid_ie+2, next_ie, remain_len); + memcpy(ssid_ie + 2, next_ie, remain_len); len_diff -=3D ssid_len_ori; =20 break; @@ -2089,16 +2089,16 @@ void issue_beacon(struct adapter *padapter, int tim= eout_ms) pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { { int len_diff; =20 memcpy(pframe, cur_network->ies, cur_network->ie_length); - len_diff =3D update_hidden_ssid(pframe+_BEACON_IE_OFFSET_, - cur_network->ie_length-_BEACON_IE_OFFSET_, + len_diff =3D update_hidden_ssid(pframe + _BEACON_IE_OFFSET_, + cur_network->ie_length - _BEACON_IE_OFFSET_, pmlmeinfo->hidden_ssid_mode); - pframe +=3D (cur_network->ie_length+len_diff); - pattrib->pktlen +=3D (cur_network->ie_length+len_diff); + pframe +=3D (cur_network->ie_length + len_diff); + pattrib->pktlen +=3D (cur_network->ie_length + len_diff); } =20 { @@ -2106,8 +2106,8 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) uint wps_ielen; u8 sr =3D 0; =20 - wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(str= uct ieee80211_hdr_3addr)+_BEACON_IE_OFFSET_, - pattrib->pktlen-sizeof(struct ieee80211_hdr_3addr)-_BEACON_IE_OFFSET_,= NULL, &wps_ielen); + wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + sizeof= (struct ieee80211_hdr_3addr) + _BEACON_IE_OFFSET_, + pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OFFS= ET_, NULL, &wps_ielen); if (wps_ie && wps_ielen > 0) rtw_get_wps_attr_content(wps_ie, wps_ielen, WPS_ATTR_SELECTED_REGISTR= AR, (u8 *)(&sr), NULL); if (sr !=3D 0) @@ -2239,8 +2239,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p if (cur_network->ie_length > MAX_IE_SZ) return; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) { - pwps_ie =3D rtw_get_wps_ie(cur_network->ies+_FIXED_IE_LENGTH_, cur_netwo= rk->ie_length-_FIXED_IE_LENGTH_, NULL, &wps_ielen); + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { + pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, cur_net= work->ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen); =20 /* inerset & update wps_probe_resp_ie */ if (pmlmepriv->wps_probe_resp_ie && pwps_ie && wps_ielen > 0) { @@ -2258,13 +2258,13 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p pattrib->pktlen +=3D wps_offset; =20 wps_ielen =3D (uint)pmlmepriv->wps_probe_resp_ie[1];/* to get ie data l= en */ - if ((wps_offset+wps_ielen+2) <=3D MAX_IE_SZ) { - memcpy(pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen+2); - pframe +=3D wps_ielen+2; - pattrib->pktlen +=3D wps_ielen+2; + if ((wps_offset + wps_ielen + 2) <=3D MAX_IE_SZ) { + memcpy(pframe, pmlmepriv->wps_probe_resp_ie, wps_ielen + 2); + pframe +=3D wps_ielen + 2; + pattrib->pktlen +=3D wps_ielen + 2; } =20 - if ((wps_offset+wps_ielen+2+remainder_ielen) <=3D MAX_IE_SZ) { + if ((wps_offset + wps_ielen + 2 + remainder_ielen) <=3D MAX_IE_SZ) { memcpy(pframe, premainder_ie, remainder_ielen); pframe +=3D remainder_ielen; pattrib->pktlen +=3D remainder_ielen; @@ -2281,14 +2281,14 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p signed int ssid_ielen; signed int ssid_ielen_diff; u8 *buf; - u8 *ies =3D pmgntframe->buf_addr+TXDESC_OFFSET+sizeof(struct ieee80211_= hdr_3addr); + u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + sizeof(struct ieee80= 211_hdr_3addr); =20 buf =3D kzalloc(MAX_IE_SZ, GFP_ATOMIC); if (!buf) return; =20 - ssid_ie =3D rtw_get_ie(ies+_FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_iele= n, - (pframe-ies)-_FIXED_IE_LENGTH_); + ssid_ie =3D rtw_get_ie(ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ie= len, + (pframe - ies) - _FIXED_IE_LENGTH_); =20 ssid_ielen_diff =3D cur_network->ssid.ssid_length - ssid_ielen; =20 @@ -2296,8 +2296,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p uint remainder_ielen; u8 *remainder_ie; =20 - remainder_ie =3D ssid_ie+2; - remainder_ielen =3D (pframe-remainder_ie); + remainder_ie =3D ssid_ie + 2; + remainder_ielen =3D (pframe - remainder_ie); =20 if (remainder_ielen > MAX_IE_SZ) { netdev_warn(padapter->pnetdev, @@ -2307,9 +2307,9 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p } =20 memcpy(buf, remainder_ie, remainder_ielen); - memcpy(remainder_ie+ssid_ielen_diff, buf, remainder_ielen); - *(ssid_ie+1) =3D cur_network->ssid.ssid_length; - memcpy(ssid_ie+2, cur_network->ssid.ssid, cur_network->ssid.ssid_lengt= h); + memcpy(remainder_ie + ssid_ielen_diff, buf, remainder_ielen); + *(ssid_ie + 1) =3D cur_network->ssid.ssid_length; + memcpy(ssid_ie + 2, cur_network->ssid.ssid, cur_network->ssid.ssid_len= gth); =20 pframe +=3D ssid_ielen_diff; pattrib->pktlen +=3D ssid_ielen_diff; @@ -2347,7 +2347,7 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p /* DS parameter set */ pframe =3D rtw_set_ie(pframe, WLAN_EID_DS_PARAMS, 1, (unsigned char *)&(= cur_network->configuration.ds_config), &pattrib->pktlen); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { u8 erpinfo =3D 0; u32 ATIMWindow; /* IBSS Parameter Set... */ @@ -2687,7 +2687,7 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, pstat->bssratelen, ps= tat->bssrateset, &(pattrib->pktlen)); } else { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, pstat->bssrateset,= &(pattrib->pktlen)); - pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n-8), pstat->bssrateset+8, &(pattrib->pktlen)); + pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), pstat->bssrateset + 8, &(pattrib->pktlen)); } =20 if ((pstat->flags & WLAN_STA_HT) && (pmlmepriv->htpriv.ht_option)) { @@ -2697,18 +2697,18 @@ void issue_asocrsp(struct adapter *padapter, unsign= ed short status, struct sta_i /* p =3D hostapd_eid_ht_capabilities_info(hapd, p); */ pbuf =3D rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_CAPABILITY, &ie= _len, (pnetwork->ie_length - _BEACON_IE_OFFSET_)); if (pbuf && ie_len > 0) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); } =20 /* FILL HT ADD INFO IE */ /* p =3D hostapd_eid_ht_operation(hapd, p); */ pbuf =3D rtw_get_ie(ie + _BEACON_IE_OFFSET_, WLAN_EID_HT_OPERATION, &ie_= len, (pnetwork->ie_length - _BEACON_IE_OFFSET_)); if (pbuf && ie_len > 0) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); } } =20 @@ -2719,10 +2719,10 @@ void issue_asocrsp(struct adapter *padapter, unsign= ed short status, struct sta_i =20 for (pbuf =3D ie + _BEACON_IE_OFFSET_; ; pbuf +=3D (ie_len + 2)) { pbuf =3D rtw_get_ie(pbuf, WLAN_EID_VENDOR_SPECIFIC, &ie_len, (pnetwork-= >ie_length - _BEACON_IE_OFFSET_ - (ie_len + 2))); - if (pbuf && !memcmp(pbuf+2, WMM_PARA_IE, 6)) { - memcpy(pframe, pbuf, ie_len+2); - pframe +=3D (ie_len+2); - pattrib->pktlen +=3D (ie_len+2); + if (pbuf && !memcmp(pbuf + 2, WMM_PARA_IE, 6)) { + memcpy(pframe, pbuf, ie_len + 2); + pframe +=3D (ie_len + 2); + pattrib->pktlen +=3D (ie_len + 2); =20 break; } @@ -2956,9 +2956,9 @@ static int _issue_nulldata(struct adapter *padapter, = unsigned char *da, fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) SetFrDs(fctrl); - else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) SetToDs(fctrl); =20 if (power_mode) @@ -3098,9 +3098,9 @@ static int _issue_qos_nulldata(struct adapter *padapt= er, unsigned char *da, fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) SetFrDs(fctrl); - else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + else if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) SetToDs(fctrl); =20 qc =3D (unsigned short *)(pframe + pattrib->hdrlen - 2); @@ -3627,7 +3627,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; u16 tid; =20 - if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) + if ((pmlmeinfo->state & 0x03) !=3D WIFI_FW_AP_STATE) if (!(pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) return _SUCCESS; =20 @@ -3638,7 +3638,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) if (initiator =3D=3D 0) {/* recipient */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->recvreorder_ctrl[tid].enable) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator)&0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); psta->recvreorder_ctrl[tid].enable =3D false; psta->recvreorder_ctrl[tid].indicate_seq =3D 0xffff; } @@ -3646,7 +3646,7 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) } else if (initiator =3D=3D 1) {/* originator */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->htpriv.agg_enable_bitmap & BIT(tid)) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator)&0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); } @@ -3671,7 +3671,7 @@ unsigned int send_beacon(struct adapter *padapter) cond_resched(); rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; - } while ((poll%10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpris= eRemoved && !padapter->bDriverStopped); + } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpr= iseRemoved && !padapter->bDriverStopped); =20 } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); =20 @@ -3867,7 +3867,7 @@ u8 collect_bss_info(struct adapter *padapter, union r= ecv_frame *precv_frame, str =20 p =3D rtw_get_ie(bssid->ies + ie_offset, WLAN_EID_EXT_SUPP_RATES, &len, b= ssid->ie_length - ie_offset); if (p) { - if (len > (NDIS_802_11_LENGTH_RATES_EX-i)) + if (len > (NDIS_802_11_LENGTH_RATES_EX - i)) return _FAIL; =20 memcpy(bssid->supported_rates + i, (p + 2), len); @@ -3958,7 +3958,7 @@ void start_create_ibss(struct adapter *padapter) /* update capability */ caps =3D rtw_get_capability((struct wlan_bssid_ex *)pnetwork); update_capinfo(padapter, caps); - if (caps&WLAN_CAPABILITY_IBSS) {/* adhoc master */ + if (caps & WLAN_CAPABILITY_IBSS) {/* adhoc master */ val8 =3D 0xcf; rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8)); =20 @@ -4009,7 +4009,7 @@ void start_clnt_join(struct adapter *padapter) /* update capability */ caps =3D rtw_get_capability((struct wlan_bssid_ex *)pnetwork); update_capinfo(padapter, caps); - if (caps&WLAN_CAPABILITY_ESS) { + if (caps & WLAN_CAPABILITY_ESS) { set_msr(padapter, WIFI_FW_STATION_STATE); =20 val8 =3D (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_8021X) ? 0xcc : 0= xcf; @@ -4033,10 +4033,10 @@ void start_clnt_join(struct adapter *padapter) beacon_timeout =3D decide_wait_for_beacon_timeout(pmlmeinfo->bcn_interva= l); set_link_timer(pmlmeext, beacon_timeout); _set_timer(&padapter->mlmepriv.assoc_timer, - (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO*REASSOC_LIMIT) + beacon_timeou= t); + (REAUTH_TO * REAUTH_LIMIT) + (REASSOC_TO * REASSOC_LIMIT) + beacon_time= out); =20 pmlmeinfo->state =3D WIFI_FW_AUTH_NULL | WIFI_FW_STATION_STATE; - } else if (caps&WLAN_CAPABILITY_IBSS) { /* adhoc client */ + } else if (caps & WLAN_CAPABILITY_IBSS) { /* adhoc client */ set_msr(padapter, WIFI_FW_ADHOC_STATE); =20 val8 =3D 0xcf; @@ -4098,7 +4098,7 @@ unsigned int receive_disconnect(struct adapter *padap= ter, unsigned char *MacAddr if (!(!memcmp(MacAddr, get_my_bssid(&pmlmeinfo->network), ETH_ALEN))) return _SUCCESS; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) { if (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) { pmlmeinfo->state =3D WIFI_FW_NULL_STATE; report_del_sta_event(padapter, MacAddr, reason); @@ -4159,7 +4159,7 @@ static void process_80211d(struct adapter *padapter, = struct wlan_bssid_ex *bssid if (fcn <=3D 14) channel =3D fcn + j; /* 2.4 GHz */ else - channel =3D fcn + j*4; /* 5 GHz */ + channel =3D fcn + j * 4; /* 5 GHz */ =20 chplan_ap.Channel[i++] =3D channel; } @@ -4550,7 +4550,7 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) =20 psta->htpriv.ampdu_enable =3D pmlmepriv->htpriv.ampdu_enable; =20 - psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para&IEEE80211_HT_CAP_AMPDU_DENSITY)>>2; + psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para & IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; =20 if (support_short_GI(padapter, &(pmlmeinfo->HT_caps), CHANNEL_WIDTH_20)) psta->htpriv.sgi_20m =3D true; @@ -4655,7 +4655,7 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) return; } =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) /* update bc/mc sta_info */ update_bmc_sta(padapter); =20 @@ -4704,7 +4704,7 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) join_type =3D 2; rtw_hal_set_hwreg(padapter, HW_VAR_MLME_JOIN, (u8 *)(&join_type)); =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) { /* correcting TSF */ correct_TSF(padapter, pmlmeext); =20 @@ -4721,7 +4721,7 @@ void mlmeext_sta_add_event_callback(struct adapter *p= adapter, struct sta_info *p struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; u8 join_type; =20 - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) { + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) { if (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) { /* adhoc master or sta_c= ount>1 */ =20 /* nothing to do */ @@ -4783,7 +4783,7 @@ void _linked_info_dump(struct adapter *padapter) struct dvobj_priv *pdvobj =3D adapter_to_dvobj(padapter); =20 if (padapter->bLinkInfoDump) { - if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) + if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) rtw_hal_get_def_var(padapter, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, &UndecoratedSmoothedPWDB); @@ -5273,9 +5273,9 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned = char *pbuf) u8 val8; =20 if (is_client_associated_to_ap(padapter)) - issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms/100, 100); + issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms / 100, 100); =20 - if (((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo->= state&0x03) =3D=3D WIFI_FW_AP_STATE)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo= ->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* Stop BCN */ val8 =3D 0; rtw_hal_set_hwreg(padapter, HW_VAR_BCN_FUNC, (u8 *)(&val8)); @@ -5296,7 +5296,7 @@ static int rtw_scan_ch_decision(struct adapter *padap= ter, struct rtw_ieee80211_c struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; =20 /* clear first */ - memset(out, 0, sizeof(struct rtw_ieee80211_channel)*out_num); + memset(out, 0, sizeof(struct rtw_ieee80211_channel) * out_num); =20 /* acquire channels from in */ j =3D 0; @@ -5535,7 +5535,7 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; =20 if (((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && (pmlmeinfo->HT_enable)= ) || - ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE)) { + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* pmlmeinfo->ADDBA_retry_count =3D 0; */ /* pmlmeinfo->candidate_tid_bitmap |=3D (0x1 << pparm->tid); */ /* psta->htpriv.candidate_tid_bitmap |=3D BIT(pparm->tid); */ --=20 2.34.1 From nobody Mon Jul 27 07:57:57 2026 Received: from m16.mail.126.com (m16.mail.126.com [117.135.210.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5302C41CB47 for ; Wed, 8 Jul 2026 15:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; cv=none; b=lbxjZszC6vzPHQr8/kyJBwkvyHspBJz9HoACUj6I4WBOEIYgRoCkOFwmavRBrM1xA/KzXb4q6davWhe46fHN/wUGNZQ26v54Gy9A6goTajMmtPqI9YsGGS96hdMJI/S99/n9M0r90zISSQjfZ8imI6jDvycs62kxs94I0fp9K7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; c=relaxed/simple; bh=WktfnNh5jGfzjSav3b5N/VVjAcmD8b6r65gdn+nqaIE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c8sbMLZ/C0B0ADjpf5A/H+puWd26s6znkdVKWrgIv3AiWTHG0JHJRK3q3X2qNfsnLIle4Qyzjt3BGffpM5OXh7W2SnXeyeWVA6PiGBCD3IriTdCm54CwlJsuSMznC7F+oM2EiJ3zAUzvS0ZxuxN6mSsuTSARkUqvo7ED+UREbic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=N0o9DmW7; arc=none smtp.client-ip=117.135.210.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="N0o9DmW7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=CV BLJH7rKBv5MBPW37WAkqKOGbtV730hfHMoYmNuNmA=; b=N0o9DmW7WkP8SqvjQN l3jB89VpKXqrAWtTRxa+kTWigEB/xcrFp70EKF4qa5YekPWuNaxJlu55iBe+JdoD qUFmL+r7bOzaLUlGtzxVBMwhhKvzRryNs6qxt3Lh56bX86ZE6nP2Qoe80FTXx+Gl dBts5xOBtPLZDXw+B2ccJt4dc= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S4; Wed, 08 Jul 2026 23:09:37 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 2/5] staging: rtl8723bs: fix line length and alignment in rtw_mlme_ext Date: Wed, 8 Jul 2026 23:09:25 +0800 Message-Id: <20260708150928.74065-3-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S4 X-Coremail-Antispam: 1Uf129KBjvJXoWxtF13Zw1DJw48Cw1DGry8Zrb_yoWDGr4rpF 4vg34DGr48Wrn0yr4kZr4xXFZ3GrWrWFWxKayfta4YkFn7Ar9IqFyYyryYvws8Ar45X3WY kFnYgwn8uw4DCrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07Ur8nOUUUUU= X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBqhFUW2pOaDGEZQAA3o Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding lines exceeding 100 columns and misaligned parentheses in rtw_mlme_ext.c. No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 66 +++++++++++++------ 1 file changed, 45 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index d7404a3a5e0f..2b706f1abd4f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -591,7 +591,9 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) } =20 /* check the vendor of the assoc AP */ - pmlmeinfo->assoc_AP_vendor =3D check_assoc_AP(pframe + sizeof(struct ie= ee80211_hdr_3addr), len - sizeof(struct ieee80211_hdr_3addr)); + pmlmeinfo->assoc_AP_vendor =3D + check_assoc_AP(pframe + sizeof(struct ieee80211_hdr_3addr), + len - sizeof(struct ieee80211_hdr_3addr)); =20 /* update TSF Value */ update_TSF(pmlmeext, pframe, len); @@ -610,7 +612,8 @@ unsigned int OnBeacon(struct adapter *padapter, union r= ecv_frame *precv_frame) return _SUCCESS; } =20 - if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && (pmlmein= fo->state & WIFI_FW_ASSOC_SUCCESS)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STATE) && + (pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { psta =3D rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe)); if (psta) { ret =3D rtw_check_bcn_info(padapter, pframe, len); @@ -1049,12 +1052,14 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.rsn_ie; wpa_ie_len =3D elems.rsn_ie_len; =20 - if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwi= se_cipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa2_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, + &pairwise_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(1); =20 pstat->wpa2_group_cipher =3D group_cipher & psecuritypriv->wpa2_group_c= ipher; - pstat->wpa2_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa2_p= airwise_cipher; + pstat->wpa2_pairwise_cipher =3D pairwise_cipher & + psecuritypriv->wpa2_pairwise_cipher; =20 if (!pstat->wpa2_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1071,12 +1076,14 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) wpa_ie =3D elems.wpa_ie; wpa_ie_len =3D elems.wpa_ie_len; =20 - if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, &pairwis= e_cipher, NULL) =3D=3D _SUCCESS) { + if (rtw_parse_wpa_ie(wpa_ie - 2, wpa_ie_len + 2, &group_cipher, + &pairwise_cipher, NULL) =3D=3D _SUCCESS) { pstat->dot8021xalg =3D 1;/* psk, todo:802.1x */ pstat->wpa_psk |=3D BIT(0); =20 pstat->wpa_group_cipher =3D group_cipher & psecuritypriv->wpa_group_cip= her; - pstat->wpa_pairwise_cipher =3D pairwise_cipher & psecuritypriv->wpa_pai= rwise_cipher; + pstat->wpa_pairwise_cipher =3D pairwise_cipher & + psecuritypriv->wpa_pairwise_cipher; =20 if (!pstat->wpa_group_cipher) status =3D WLAN_STATUS_INVALID_GROUP_CIPHER; @@ -1105,8 +1112,8 @@ unsigned int OnAssocReq(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ /* that the selected registrar of AP is _FLASE */ - if ((psecuritypriv->wpa_psk > 0) - && (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { + if ((psecuritypriv->wpa_psk > 0) && + (pstat->flags & (WLAN_STA_WPS | WLAN_STA_MAYBE_WPS))) { if (pmlmepriv->wps_beacon_ie) { u8 selected_registrar =3D 0; =20 @@ -2106,8 +2113,12 @@ void issue_beacon(struct adapter *padapter, int time= out_ms) uint wps_ielen; u8 sr =3D 0; =20 - wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + sizeof= (struct ieee80211_hdr_3addr) + _BEACON_IE_OFFSET_, - pattrib->pktlen - sizeof(struct ieee80211_hdr_3addr) - _BEACON_IE_OFFS= ET_, NULL, &wps_ielen); + wps_ie =3D rtw_get_wps_ie(pmgntframe->buf_addr + TXDESC_OFFSET + + sizeof(struct ieee80211_hdr_3addr) + + _BEACON_IE_OFFSET_, + pattrib->pktlen - + sizeof(struct ieee80211_hdr_3addr) - + _BEACON_IE_OFFSET_, NULL, &wps_ielen); if (wps_ie && wps_ielen > 0) rtw_get_wps_attr_content(wps_ie, wps_ielen, WPS_ATTR_SELECTED_REGISTR= AR, (u8 *)(&sr), NULL); if (sr !=3D 0) @@ -2240,7 +2251,9 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p return; =20 if ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) { - pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, cur_net= work->ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen); + pwps_ie =3D rtw_get_wps_ie(cur_network->ies + _FIXED_IE_LENGTH_, + cur_network->ie_length - _FIXED_IE_LENGTH_, + NULL, &wps_ielen); =20 /* inerset & update wps_probe_resp_ie */ if (pmlmepriv->wps_probe_resp_ie && pwps_ie && wps_ielen > 0) { @@ -2281,14 +2294,15 @@ void issue_probersp(struct adapter *padapter, unsig= ned char *da, u8 is_valid_p2p signed int ssid_ielen; signed int ssid_ielen_diff; u8 *buf; - u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + sizeof(struct ieee80= 211_hdr_3addr); + u8 *ies =3D pmgntframe->buf_addr + TXDESC_OFFSET + + sizeof(struct ieee80211_hdr_3addr); =20 buf =3D kzalloc(MAX_IE_SZ, GFP_ATOMIC); if (!buf) return; =20 ssid_ie =3D rtw_get_ie(ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &ssid_ie= len, - (pframe - ies) - _FIXED_IE_LENGTH_); + (pframe - ies) - _FIXED_IE_LENGTH_); =20 ssid_ielen_diff =3D cur_network->ssid.ssid_length - ssid_ielen; =20 @@ -2309,7 +2323,8 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p memcpy(buf, remainder_ie, remainder_ielen); memcpy(remainder_ie + ssid_ielen_diff, buf, remainder_ielen); *(ssid_ie + 1) =3D cur_network->ssid.ssid_length; - memcpy(ssid_ie + 2, cur_network->ssid.ssid, cur_network->ssid.ssid_len= gth); + memcpy(ssid_ie + 2, cur_network->ssid.ssid, + cur_network->ssid.ssid_length); =20 pframe +=3D ssid_ielen_diff; pattrib->pktlen +=3D ssid_ielen_diff; @@ -2687,7 +2702,8 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, pstat->bssratelen, ps= tat->bssrateset, &(pattrib->pktlen)); } else { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, pstat->bssrateset,= &(pattrib->pktlen)); - pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), pstat->bssrateset + 8, &(pattrib->pktlen)); + pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), + pstat->bssrateset + 8, &(pattrib->pktlen)); } =20 if ((pstat->flags & WLAN_STA_HT) && (pmlmepriv->htpriv.ht_option)) { @@ -3638,7 +3654,8 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) if (initiator =3D=3D 0) {/* recipient */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->recvreorder_ctrl[tid].enable) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, + (((tid << 1) | initiator) & 0x1F)); psta->recvreorder_ctrl[tid].enable =3D false; psta->recvreorder_ctrl[tid].indicate_seq =3D 0xffff; } @@ -3646,7 +3663,8 @@ unsigned int send_delba(struct adapter *padapter, u8 = initiator, u8 *addr) } else if (initiator =3D=3D 1) {/* originator */ for (tid =3D 0; tid < MAXTID; tid++) { if (psta->htpriv.agg_enable_bitmap & BIT(tid)) { - issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, (((tid << 1) | init= iator) & 0x1F)); + issue_action_BA(padapter, addr, WLAN_ACTION_DELBA, + (((tid << 1) | initiator) & 0x1F)); psta->htpriv.agg_enable_bitmap &=3D ~BIT(tid); psta->htpriv.candidate_tid_bitmap &=3D ~BIT(tid); } @@ -3671,7 +3689,9 @@ unsigned int send_beacon(struct adapter *padapter) cond_resched(); rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; - } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && !padapter->bSurpr= iseRemoved && !padapter->bDriverStopped); + } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && + !padapter->bSurpriseRemoved && + !padapter->bDriverStopped); =20 } while (false =3D=3D bxmitok && issue < 100 && !padapter->bSurpriseRemov= ed && !padapter->bDriverStopped); =20 @@ -4550,7 +4570,9 @@ void update_sta_info(struct adapter *padapter, struct= sta_info *psta) =20 psta->htpriv.ampdu_enable =3D pmlmepriv->htpriv.ampdu_enable; =20 - psta->htpriv.rx_ampdu_min_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_eleme= nt.AMPDU_para & IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; + psta->htpriv.rx_ampdu_min_spacing =3D + (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & + IEEE80211_HT_CAP_AMPDU_DENSITY) >> 2; =20 if (support_short_GI(padapter, &(pmlmeinfo->HT_caps), CHANNEL_WIDTH_20)) psta->htpriv.sgi_20m =3D true; @@ -5273,9 +5295,11 @@ u8 disconnect_hdl(struct adapter *padapter, unsigned= char *pbuf) u8 val8; =20 if (is_client_associated_to_ap(padapter)) - issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, param->deauth_timeout_ms / 100, 100); + issue_deauth_ex(padapter, pnetwork->mac_address, WLAN_REASON_DEAUTH_LEAV= ING, + param->deauth_timeout_ms / 100, 100); =20 - if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || ((pmlmeinfo= ->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { + if (((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE) || + ((pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE)) { /* Stop BCN */ val8 =3D 0; rtw_hal_set_hwreg(padapter, HW_VAR_BCN_FUNC, (u8 *)(&val8)); --=20 2.34.1 From nobody Mon Jul 27 07:57:57 2026 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CCC142DA2C for ; Wed, 8 Jul 2026 15:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523406; cv=none; b=iNEL5qLNJ2MEMbg0sFaLrMpkLxMFjhLVhzuNoyP3sQk+mLiYk35ZH+8jAKj9BM332z4HFqUwsAGns6OqMYOLEVynZOqBAyEq8SHtDW4e7PmXfG9H43WgqjsckDIviYFvJ0lYHB4kbJHZ57/mJgEEwIUPS69OGBpGj6c2lUMYk/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523406; c=relaxed/simple; bh=A7Zt6cpnDKZT6wcq1Fqz5u6uT9L0m2W1+YXHj0cwjrw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DUOg4MgG2y76YhyY1PyPdo8dHKx3yEvosPxUO18Pn9U7qPLonFfptbwTjgJ50wHEigMybFBq5dvy6a7bp5/LIW0DrFziKLXzmWQTBTvGmdOoHwDS+DgJrboR3Z8Zg83tRriycoppA7ZWWOuRU+oyJuhV5OF0DOH+xSwLZqAGgYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=CSr997Xd; arc=none smtp.client-ip=220.197.31.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="CSr997Xd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=gF eCce6TfaC0eDlNjWakIPQzpeyrPvtxIWnj/HSJMBc=; b=CSr997XdlPx+tbGmj0 iTM5EVC7Yilsl9q/vyGir9JGvLhi8X698qt8mI6HsI3IYX7mIw1p7Oz9ulaKFkel iK2dTzqkofShvWMaToWz2EQ7SdQgwlaInCOFHEqPxcvR/6EcIqpFDL2cimFKS/PZ A1sIS2FmqTsaulh9d8lzv7Wxw= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S5; Wed, 08 Jul 2026 23:09:38 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 3/5] staging: rtl8723bs: split nested assignment in OnAssocRsp Date: Wed, 8 Jul 2026 23:09:26 +0800 Message-Id: <20260708150928.74065-4-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S5 X-Coremail-Antispam: 1Uf129KBjvdXoW7GFyfuw1xKrWrAr1UKFWfKrg_yoWkZFg_uw s7Xwn7KFWUAFna9F47Jr4FvrWYg3W8Zw4vqF1qqrW3Zr4I9a43X34kXrWakw15Ja1UJrZ7 Cw10yr1Fkr1IvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUGXd5UUUUU== X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBlxJUW2pOaDIY3AAA3w Content-Type: text/plain; charset="utf-8" Split a nested assignment statement into two separate lines in OnAssocRsp() to improve code readability and conform to Linux kernel coding style guidelines. No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 2b706f1abd4f..5ea42f054249 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1369,7 +1369,8 @@ unsigned int OnAssocRsp(struct adapter *padapter, uni= on recv_frame *precv_frame) pmlmeinfo->slotTime =3D (pmlmeinfo->capability & BIT(10)) ? 9 : 20; =20 /* AID */ - res =3D pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HD= R_A3_LEN + 4)) & 0x3fff); + pmlmeinfo->aid =3D (int)(le16_to_cpu(*(__le16 *)(pframe + WLAN_HDR_A3_LEN= + 4)) & 0x3fff); + res =3D pmlmeinfo->aid; =20 /* following are moved to join event callback function */ /* to handle HT, WMM, rate adaptive, update MAC reg */ --=20 2.34.1 From nobody Mon Jul 27 07:57:57 2026 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3349941CB56 for ; Wed, 8 Jul 2026 15:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.9 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; cv=none; b=fCfSjvmIgy6XO3KZ7HKSZ4BVS1Ajc+MjLuTSCGWGaAuDwJqrDZOgRnCElIdX4qofLGhn2v3vylKdQxXR/0DArt/jDUy2m5tCIlek4PA2SolDtTpCsKTSUHa9uPw7Wa+pwwqzXF6fHmIk0qyo8dn/jiqYFfYaXn1mloAVyzm4cJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523404; c=relaxed/simple; bh=x499UiU43bP2vc4KSCL+qG2t4J/f3jCOIbZgGgyQXyY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uE5t+SOTPjt+FMZSQ3PKX0pyvATgLPGEElh6y1kjt8q13Tl6GvvOUX+b9nMSVzHnhUHqV8iUuii12Wq1qiuLfdsM6ZYjmLICmw2NUXeiJo1olJ+KusTUj1nkR0yv5cqvPxRjabtAzcJg3Xu3EosRWubOpUdBkVSnIsNUQDLhMII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=YQhp41I0; arc=none smtp.client-ip=220.197.31.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="YQhp41I0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=Lv LNSqaiDRojdyKrbTw/ty/wvlqR7c2lmaHtbC1rbHc=; b=YQhp41I0A2RKsqQ7k4 2J2CxnYuxOGmAS0g4ruWZXN7EP6xOOnj1ndH4JROiyCAhPrRw81Cm0uX2QpSdh0q YXBtwVF8i47GA6V9nUxqm+QmH/0QBEShbZO3oYjfS8MvBvsOwbb53OmULsAt7A6/ kDmv9CMtMDy1cvIzU3S6jxxYY= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S6; Wed, 08 Jul 2026 23:09:38 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 4/5] staging: rtl8723bs: remove unnecessary parentheses in issue_asocrsp Date: Wed, 8 Jul 2026 23:09:27 +0800 Message-Id: <20260708150928.74065-5-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S6 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw1rur4DXr15KFy5Zw4UCFg_yoWkXFXEkF 4Iqwn7Jw48AFn29a1DGa1SvFW0grWrZa10yF1qqr93Z3y7ZFWrJ3ykWrWDKr13uF45tr97 Cws2qr1F9w1xujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRAzVbDUUUUU== X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBqxJUW2pOaDJ7FwAA3k Content-Type: text/plain; charset="utf-8" Remove unnecessary parentheses from the pattrib->pktlen address expression in issue_asocrsp() to clean up the code and adhere to kernel coding standards. No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 5ea42f054249..ba84b933e25c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -2704,7 +2704,7 @@ void issue_asocrsp(struct adapter *padapter, unsigned= short status, struct sta_i } else { pframe =3D rtw_set_ie(pframe, WLAN_EID_SUPP_RATES, 8, pstat->bssrateset,= &(pattrib->pktlen)); pframe =3D rtw_set_ie(pframe, WLAN_EID_EXT_SUPP_RATES, (pstat->bssratele= n - 8), - pstat->bssrateset + 8, &(pattrib->pktlen)); + pstat->bssrateset + 8, &pattrib->pktlen); } =20 if ((pstat->flags & WLAN_STA_HT) && (pmlmepriv->htpriv.ht_option)) { --=20 2.34.1 From nobody Mon Jul 27 07:57:57 2026 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8EE42DA53 for ; Wed, 8 Jul 2026 15:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523408; cv=none; b=ohE1EtvIl3KEt8DvudM1b6dEL+yuqeV0U2pY6A7QVxtTszTt8VL2/tXFkPg81VWVQonE9CiKe6E6ZoEHJpSjziEkxdc5XsnyFVZV0AbBpL4rUYOHd7xRHQO4ppu+Ykscm6OKYwCJVS6Lcg7iZ9oTxGku4AJ7B2OtSnJ2hiFxGRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783523408; c=relaxed/simple; bh=TZUTfs8OviMyXwxmIucGXEYy0S6cLllZwaG8SeBIlGU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IZHrkgC9XnvrX4Np3W6MIm5in9hSfBZWjCTLGO+3xGbz5JP9lGZTyAC0eRB3zchzyRT5yGr2zchn9Oj0KLiOZeQRnOMDPJ5HQDLzJqV6AjJYqLgz1Y8vj1Vk8/yWo+ONk0ti6a1GYYahTi3wCWzr8VGIzSbUlPnSPbinoRRM4Sc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=NGrm7EuS; arc=none smtp.client-ip=220.197.31.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="NGrm7EuS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ou RkMhprhjXtlq0zpiWIdJV4KdSgRDhk7pK+VZYag0U=; b=NGrm7EuSa4DxZvhouw x7Yd7z7HROdiBlSgvjde3B3CLSBUnP3rt67kpv+v4vubDtDvGUj5VzSBNkXOBxI/ dEoRl51C7d+bEwvhOowJoC8XPkhsQ7FUsO6OGZALH9wCpnTJ0WtW6yk2IAkYByn0 AoDinUOPEua9WF0R/AnXuQMNU= Received: from jax-virtual-machine.localdomain (unknown []) by gzsmtp4 (Coremail) with SMTP id PykvCgDnz2MqaE5qmk9uCg--.53577S7; Wed, 08 Jul 2026 23:09:38 +0800 (CST) From: Jinke Wu To: gregkh@linuxfoundation.org Cc: error27@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, coolbeaner@126.com Subject: [PATCH v3 5/5] staging: rtl8723bs: simplify boolean comparison in send_beacon Date: Wed, 8 Jul 2026 23:09:28 +0800 Message-Id: <20260708150928.74065-6-coolbeaner@126.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260708150928.74065-1-coolbeaner@126.com> References: <20260708150928.74065-1-coolbeaner@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PykvCgDnz2MqaE5qmk9uCg--.53577S7 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFyftFyxAr45Gw48CrW8Crg_yoWDGFc_C3 97tws7Jr4rAF9FyF4DAF4rArWFga18Zw4vvF4DK3yfZ3y8uF93u3s7Xry7GFW7Wa13Kryq y34xtr4F9F18WjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xREF4iUUUUUU== X-CM-SenderInfo: hfrrzuphdqv2a6rslhhfrp/xtbBqxNUW2pOaDN7HgAA3t Content-Type: text/plain; charset="utf-8" Simplify the boolean comparison in the do-while loop condition within send_beacon() by using the logical NOT (!) operator instead of an explicit comparison with false. No functional change. Signed-off-by: Jinke Wu --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ba84b933e25c..e02ab2e2480a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -3690,7 +3690,7 @@ unsigned int send_beacon(struct adapter *padapter) cond_resched(); rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok)); poll++; - } while ((poll % 10) !=3D 0 && false =3D=3D bxmitok && + } while ((poll % 10) !=3D 0 && !bxmitok && !padapter->bSurpriseRemoved && !padapter->bDriverStopped); =20 --=20 2.34.1