From nobody Mon Jul 27 20:00:45 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AC6416CF9 for ; Wed, 8 Jul 2026 14:34:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521257; cv=none; b=MR+gRagHIm3qpXCh7qXQf75sgOW8Z3XdXPyH+4N0vSFbCplpv1OGNZ84h3Q7R7tis1BtZ4fxlVOl9/QlHjIUh5YXw2Np/vtGMwblMMT7eAA4ssyBlsFICKUe+4MXpziPU99fjOg/P1JF88tdIfuR00tOzsUwtKPiLC2a1IQSE2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521257; c=relaxed/simple; bh=gApFntNphrkEj64OxuZAI52P8keorc1vNbiZU5v7qHo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MV0rxmXx6Ue9Jgpi5JU4xikSOLcixX4S1oI+JIaYqVTEr9MqL4TrVZ5uKW+vpHkW7AmeFlw54Hbu//nwESclN81IrHCzvOby7tF07LH6vuMY+1ryNr2YEpPaDNh3mm0Vm3CStZBFNO2Oy00kQj+pVULDsOq0n9h6AhTC9xZG9OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CpdspI6T; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CpdspI6T" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso907709a91.1 for ; Wed, 08 Jul 2026 07:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783521255; x=1784126055; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=WuNm54zDBYgFWTaaIfLcL4nvGJqvulTHjWX7HmJCqiM=; b=CpdspI6TgopuHeaoRSMgBfGEEM5k2eGbGa0ZK2aejq27/6c7mIwXtjZddywW+lMHXS R79zRxqljqYEUZ8ABP9Tp0y0lTbYLUcLfsXosQpKxz/JIvz18fCXhFWRSshjqjmEgTyY xz+7tmGnuBkWCRWkF4LmQtDWRgqFdm9onNMpszsRab7X2Z2RueWlFttEPXHxRBZhMx+f abaS0wvWKTirI7+hWnEYcKk3LciNOwourA7f5enoqPZtqyqz2dkPhpTuym/6pMiHgWWM BqAKmlgC1kxunoGCbF68W79GR8iJOOo7LJDeIQkrntM5LRLllExsAr6z/IWeseQhSbEq c3BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783521255; x=1784126055; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WuNm54zDBYgFWTaaIfLcL4nvGJqvulTHjWX7HmJCqiM=; b=cps8RUUrFGKL7U38FgvNzCcv1m7t7Hk1p25u4jpfISzIsdYFxzfzDBUNUOXqdhrMAw FlF8I1Da0nPSTehu7lXbSWOuZ8weLduHrBDRbGJBiLZNHFc19BHUU9ITS0EAfoWfqX/k eDPthtRHvMHVtUZjjb2IkVJG8yGq+neHYIy2t8WWamX6AdAHffsEDLqLQstQfjvJ7YaM kYyADzXjJsHtpBFyB9h/81/PShBVV9puKBVDm9nLRbXBt+nc2Bf/MDsalNEwTzjsG+J2 GFroL+X6vABWiLwqFE+LA32Oc78u8j0qeMJgo82SDP5oxIERHVw3CmFPBvguRo+WtTvH Baog== X-Forwarded-Encrypted: i=1; AHgh+Ro4gWsmdI1xD6BzdN+uW10QftBzrbQMjLaNUr4Ba28Yo14jr+GiKpotu0KM0W5sdrPEpRbTHwoz14GLI+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz22g6x3C0wJqiBKVrRA64twxizIrFi/iiHxi16UHPIIo5NPXP2 x69M4ymP4M0/ZhOOOSq5g7Y04dtEsiF9R0nJynEDsE3/Vvp82+SbjSJw X-Gm-Gg: AfdE7cn9QyZ7nNpKESrrnNg6+sNhXoRorM3xRvrRTq+n4VLkdFyxh93DGEB/ne/KG8B amPX5jfSyPnEBGfk1l5ya7hPKHKLNsST1vyeN/KnmHCJwdb7+dykgguj4vEHrdO0XhSJGWCuDJm /pIRr4K3j5Nk1pH+R+tqKpCmmZ5w4OberwtX/dqKvRDr3VsfYk7AMWbTEpgC+esYA4/XeJ4fN3q mwbj8SLX0vvErfeCB6juImP79jB5nqFT1eLPgdB4HeunWm9YtWF5Nb7gp114ok+m1EaBQQhXtSJ y4rJuRHAoavgtzd12CYejw/6qgHMiiLIj9RQ0A29s6958DrVZeTN9TVZ7MHPmav9mgg7FwGGZrW JvQHQQp9EMeVrnuozwHOtESStheI7c8oAOqP3fIQAHUTW9n0nXnJ423Qb7PdiJ+hF9NWzQQU0W+ qZkSTvqT6yz5gRSWBu2cSD+bkMAHm9GvOXVyvYiezWIQ8= X-Received: by 2002:a17:90b:3bcb:b0:37f:c2a8:ce45 with SMTP id 98e67ed59e1d1-3893fd5ef66mr3086798a91.4.1783521255247; Wed, 08 Jul 2026 07:34:15 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1b95:b995:f60c:5c67]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d3d66036sm2837540a91.17.2026.07.08.07.34.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:34:14 -0700 (PDT) From: Ruoyu Wang To: kuba@kernel.org, horms@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com Cc: oss-drivers@corigine.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH net] nfp: Check resource mutex allocation Date: Wed, 8 Jul 2026 22:34:08 +0800 Message-ID: <20260708143408.3168425-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nfp_cpp_resource_find() allocates a CPP mutex handle for the matching resource-table entry and then reports success. nfp_resource_try_acquire() immediately passes that handle to nfp_cpp_mutex_trylock(). However, nfp_cpp_mutex_alloc() returns NULL on failure. If that happens for a matching table entry, the resource lookup still returns success and the following trylock dereferences a NULL mutex pointer while opening the resource. nfp_resource_acquire() already treats failure to allocate the table mutex as -ENOMEM. Do the same for the resource mutex and fail the lookup before publishing the rest of the resource handle. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: f01a2161577d ("nfp: add support for resources") Signed-off-by: Ruoyu Wang Reviewed-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c b/dr= ivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c index 6d5833479d123..237300b82b913 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c @@ -96,6 +96,9 @@ static int nfp_cpp_resource_find(struct nfp_cpp *cpp, str= uct nfp_resource *res) res->mutex =3D nfp_cpp_mutex_alloc(cpp, NFP_RESOURCE_TBL_TARGET, addr, key); + if (!res->mutex) + return -ENOMEM; + res->cpp_id =3D NFP_CPP_ID(entry.region.cpp_target, entry.region.cpp_action, entry.region.cpp_token); --=20 2.51.0