From nobody Mon Jul 27 21:44:28 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF54E3537F9 for ; Wed, 8 Jul 2026 14:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521226; cv=none; b=hzOv1SqMZWywnLa10cV70WHKZhOFQzQPyCe5ZWEsp7/+E++KMJt005d9BsE3pEIV3r4xddwQB7XUWcoKt3qmd0Z6g0hr2yFylDyL5wDqRLPSD/9dulpgbQaH9LFnVsdqIbq0d0zycEE7+q6SLVqBBdj+9qsSUA9AnuVWBUOeXIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521226; c=relaxed/simple; bh=u9dO4RA2N5zN22YNEBxk+nfIcAHajXTXBLPpIfycIaQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D/EMBWys7D8kIyeszqdwvpG3ozY0ju13hDzieX0DDMSbQJETyog8QM+tNWgf23xHelXzCzceYaWWeJ0PZ4qjiNk/aaQqE82uMvuiSz0KxhKT+QnrKdRpBanxrWT0A6HycnuBOLQf1Lj2bsnN6Mr9KXMBqiOrYIATGORiJkbe4UY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WC+049xe; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WC+049xe" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3811074a8c5so690724a91.1 for ; Wed, 08 Jul 2026 07:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783521223; x=1784126023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=q+o3zaIf/6b+dXxvdjQtRz9xf7Upt1jRIGIgkL0q8uY=; b=WC+049xeim7fDxBudynsSK/Hye80xquncFqOShTAyZW+koSiN7ycM1U3bzy1/PwGLi 9WqrI+7gfzB+2KVYxZD8KpFlVraO4bY0Lm681LfdWEgOfC/lDnDVAUqHtxOSzm0Hlv0q vAmZ4+XUTqXqbGBPGrzBylYjemcYv/tlRan4Nfpa/T0QV01gy3pxGfjge/hKGUhgtT7R lt2CX1Ev/QYhgFEp8PTvFqSMVuQAYqIctriLWqeHfLeDRpjgOgzcSv7JmwPPeFc2lItw vfKQzocyWufY1GvDa/jyWKTQDCR0m0j4IcPwft+F2dnT7pVt6b2q0oFATfM4oLzh/dju js+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783521223; x=1784126023; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=q+o3zaIf/6b+dXxvdjQtRz9xf7Upt1jRIGIgkL0q8uY=; b=sSZG1p/VNZUkApmiAmKMM0dyq3PY9rRHwREXJ5tGwQUFlHCpiuwICBULT6PyzhwKJh XRb/BnqctjTuBiyc5GWC3qCkh1ShEOZstiHVzAC/G6EjuWSHnLnSIkfQzEDXZoB0o2Lk X4Kpxy2HOTT2h0vnO5lAtprN8l5o93ys0UIMriPFu5IP4QdyRCbRZXwbkRtrYHwGRu87 uWxj483uaapW33K1I2/bHrTDeFz/APUYRsO6zLX3L1FS9083P+ewAunn20ftW4kEdFAS yjgvhJhy06ZXer5G9+pRcqVyKHMHlSt6ihgWaMcIwFv8jBk5prA30aLDagtWvmw/lCsM ELwg== X-Forwarded-Encrypted: i=1; AHgh+Ro0rlcA3k92lg7FUXGEgTmj4eFUO9HRapQJfV0BG4+m5FjqYmiTxQhWkc62rwpRRb6aKdlWLpF0bDc/YH4=@vger.kernel.org X-Gm-Message-State: AOJu0YyuRSViG63ECnITkuOmfB5Sjqfn1b+sT3vA9kLn4sRvcOFGewZo b5qcfKNuVtjni4teNjWdLTP/qNRf6mwb0QTYHJOoUVSz7s8vpn5FZ0os8W8eeaHVCi4= X-Gm-Gg: AfdE7cnAzbCKewzTUkbXTBCxzet1If7lhJFDRY2R/rl/WuFXzPpsqKWfoQk/TGny1lH 9ZDAeDdPQfzHikHSlzPwKMonx8j9Bv0OKrWAX3Lu8eEHLMYIN3lx5nLJQNN+v1SaFW48RA+p3Cc C7+kTKcpFJgHj9Smqjxr/23xAeAPaMp6vi1mLV/HJUbVxuTmS9f++5/UmuPZg+98g8ow1WcoHJf nlumYw/uSHNyhirQRla2Mwmex/2PQlhGpg6wwKF4Mh5f+SfftF7wQr1S8MfMzK9BDjDoqd1elsG d01AiVcQiBGW69IzctEtNDr24rD8C7Ysh12EPhXyMbwYMOtCMaHvuwjyB/7KTq3KOHbxVyIrl/s s0ola3RiV2OFcoMCZS+XU7vA64CowYE+X1Yqyi01Dwp4DlAtGUkk8fB2y9TPGt58V2XK/HQmGoz W6Zlb9UNq8OIlNTrtQwoRKM7vhz1QQt+4U X-Received: by 2002:a17:90b:2241:b0:36b:944b:fd81 with SMTP id 98e67ed59e1d1-3893fb70506mr2601550a91.4.1783521223082; Wed, 08 Jul 2026 07:33:43 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1b95:b995:f60c:5c67]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d12fcecesm2877584a91.1.2026.07.08.07.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:33:42 -0700 (PDT) From: Ruoyu Wang To: hverkuil@kernel.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] media: cobalt: Avoid freeing ALSA private data twice Date: Wed, 8 Jul 2026 22:33:38 +0800 Message-ID: <20260708143338.3164671-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_cobalt_card_create() stores cobsc in sc->private_data and installs snd_cobalt_card_private_free() as sc->private_free. From that point, snd_card_free(sc) releases cobsc through the ALSA card cleanup path. If cobalt_alsa_init() fails after snd_cobalt_card_create(), the err_exit_free path calls snd_card_free(sc) and then kfree(cobsc). That second free releases the same object again. Remove the explicit kfree(cobsc) and leave ownership with the ALSA card. This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 85756a069c55 ("[media] cobalt: add new driver") Signed-off-by: Ruoyu Wang --- drivers/media/pci/cobalt/cobalt-alsa-main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/cobalt/cobalt-alsa-main.c b/drivers/media/pc= i/cobalt/cobalt-alsa-main.c index 7bb7f13c70c0d..9ed547cd40af5 100644 --- a/drivers/media/pci/cobalt/cobalt-alsa-main.c +++ b/drivers/media/pci/cobalt/cobalt-alsa-main.c @@ -135,7 +135,6 @@ int cobalt_alsa_init(struct cobalt_stream *s) err_exit_free: if (sc !=3D NULL) snd_card_free(sc); - kfree(cobsc); err_exit: return ret; } --=20 2.51.0