From nobody Mon Jul 27 02:50:49 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A0B236A370 for ; Wed, 8 Jul 2026 14:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521219; cv=none; b=VrE49rZOnlddSQ+LCEK8GQXAWRxlTtR1+XL5JAJVSeCqI4tydji3H5FYY/SdbmIyR4AsFK1QPLOhhhv9CprAqkmoXfwmdxwRJxG9LiCrojcHdIW2mgOuhmsqjyppZZWc2R4bk95ir9HdC/1zuGw94WGNE50uofA8a3nlFjrVLWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521219; c=relaxed/simple; bh=NleMw6AgPd4XB4ySy6nvQ2KQEQuNUUZ2M855DPt+LYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eyjiULd54WXpx24Y6L1WKnApPjVkY6Axt7yDlmgBzhgujmjNCFxGleXafNmS7PB6CI3Ts1mMEMj3gbbFSPru8un8ZXPxLVqimDkqtV08WPJ8okmUa/maOtf3zYail6N7+6YWffNEpDw+38DKwOh83TXgTdO/dyrObpwv+D409oY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PG5zh6yO; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PG5zh6yO" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84347ad88edso1104384b3a.1 for ; Wed, 08 Jul 2026 07:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783521218; x=1784126018; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jgvbbLNHp/KFgxIR5/9qmMdPL1EMNH+l5TMV3551YgY=; b=PG5zh6yOc5EX/CUWglzfR2IiY5gGzSUbCZK4T6ZWBmKGgmoqidi35UmhM3EQcEAljc KjzgH9G7sy2IKjEhj+LELDv7PungHEh1qJYPRCpWX+BAOSF43SKGNzsganRYcEzvVIAb j+4vbMDsMOr1+T3lq5KzGXvb+3Q5I51zVULzE+V0xSqtL3wBnIybCb5c5FrasWddET6w x/S+tqq2zJbfNg172+oY/GV8VxRbZY5y9M0LJVjiUNWvPtgyQM7tYoWyO9NbQuXZlMLG vT2oWDEDz42p+Nsxh4WoAIZUmlIerwH9bjSlPM3RW0/cJPYEwpIW0xM27ND+/hVg0UJE 1H9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783521218; x=1784126018; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jgvbbLNHp/KFgxIR5/9qmMdPL1EMNH+l5TMV3551YgY=; b=YTv5+z2MYjSFpzngAuwNTaSN4v344NUvbz3SerfyPEcOM1LbSmgFbLKPH800KYvoFm X3HqbVDVZr1WxiU0CzT8pH57p4B9c6KkGeFDTrGkY9CDov9yW4MGvOFvFldEIEVHp4+P oE/au+mRNyt76YKoyr6uR0u8zLr21J7OEkXplfkoP9p52LAhIdEjzgdvQqS2o1Yn0OKC yRjRI5goi80F3EFm3syU7jXsL7YkxU34hx2lDVWl5BJT8Wr9pArzBRB2agsAZAckXCfj ESfvutA0ijpYdl5DzzK/Fhe3XIrUYU4aujoJ6XgGvxJDPIJWY3/bFACYlmltlAAvJSvG DQzg== X-Forwarded-Encrypted: i=1; AHgh+RrZ8vLyZQR9xgjecrzPZ6AnaPc+GwKYXZzfSeWY3aZyjzO1F7q5TTP6ie75SOfTiFia9WsjqcU9tHor5OQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzaCmYfXJ7sos5q3S/qxroxk0f+P4QaXJ7Xcq8tscPHdVO73QHM Gp31UdVJkdURhr7MMjorHc/2TxZwkVffLB8HTEAlm35A6Gb1P/yT9mpV4XDh3Lpz4HQ= X-Gm-Gg: AfdE7cnFMfsItdvLdgRLHRu0ES95Qha1rQwehku2qBBV1PfZRwNGRgzxqQmz1DQUxFQ 0Fw7PX/QndN273+np+vpl+q4wctfBMZGe2ljXlos7+61Wh9BomICazBm2xOnzCSOo2fQMabCyhJ fy20DSd1jEVUAYXWB/UedUv2aVjfqx0Sh9lfuLEx64oyIN7oBbWBWLQKAVMlcKyPw05E6Pp5p11 FTqQcFcV9BU+q73sMngjodD6stBKalpuI2lDmb/y+bEDKBRxuvmaJV8kojBw7JhB9Yj+b7CjHLA 3ZuOEBkRDy6eKF+PlD7hYao2rHYwIdnTAMvgPFKdiihqw3kIuH4frdggdNh8WO8WGIIVczNKiBn BoVVVx1BPPWLCChjwhl/vXWOuHMod3ndpJfbCC8L8Si+jeGIDmWq6XtAYwFL5NsDt+E0hh0nHrH E7FKclQcHyh0UCnx0F/CrhVO6cXJS37JfE X-Received: by 2002:a05:6a00:3486:b0:848:2f77:e2da with SMTP id d2e1a72fcca58-8484392a533mr2636138b3a.67.1783521217575; Wed, 08 Jul 2026 07:33:37 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:1b95:b995:f60c:5c67]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8484d465991sm460964b3a.47.2026.07.08.07.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:33:37 -0700 (PDT) From: Ruoyu Wang To: alexander.shishkin@linux.intel.com Cc: gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] intel_th: Let release callback free subdevice resources Date: Wed, 8 Jul 2026 22:33:31 +0800 Message-ID: <20260708143331.3163866-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" intel_th_subdevice_alloc() hands a fully initialized device to the driver core with device_add(). If device_add() fails, the object must be released with put_device(), which runs intel_th_device_release() and then intel_th_device_free(). The failure path freed thdev->resource before calling put_device(), but intel_th_device_free() frees the same pointer from the release callback. Leave resource ownership with the device release path and jump directly to put_device(). This issue was found by a static analysis checker and confirmed by manual source review. Fixes: 512592779a337 ("intel_th: Fix a double put_device() in error path") Signed-off-by: Ruoyu Wang --- drivers/hwtracing/intel_th/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hwtracing/intel_th/core.c b/drivers/hwtracing/intel_th= /core.c index 3924e63e2eeeb..1d33c9e42c595 100644 --- a/drivers/hwtracing/intel_th/core.c +++ b/drivers/hwtracing/intel_th/core.c @@ -683,7 +683,7 @@ intel_th_subdevice_alloc(struct intel_th *th, =20 err =3D device_add(&thdev->dev); if (err) - goto fail_free_res; + goto fail_put_device; =20 /* need switch driver to be loaded to enumerate the rest */ if (subdev->type =3D=3D INTEL_TH_SWITCH && !req) { @@ -694,9 +694,6 @@ intel_th_subdevice_alloc(struct intel_th *th, =20 return thdev; =20 -fail_free_res: - kfree(thdev->resource); - fail_put_device: put_device(&thdev->dev); =20 --=20 2.51.0