From nobody Tue Aug 25 13:45:16 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C48C480DF7 for ; Wed, 8 Jul 2026 14:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783522170; cv=none; b=p8LIHJNrqRqive764tlAK3lKucx6pEoK/ljIFHuqW1WUbGtFvfw5KlnFpA0wpdLh0R9WJ+7VbUxYvc5e+gmEOkMDwzIa55kwgch5zQWACUNSa0ivfZXYWAf8dHjBQCAXF8PGpGU3hxXl+ZX3fNeTeMjJYUdYhTpm+CegnGTVyeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783522170; c=relaxed/simple; bh=N22ub8y8rxVNpO5t6NfeXqjef5cDmG+VxKvP1KyhEqg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LE8HzXppHIL8CzSqSOjxOwM4eLEq1zfFYzNo4VhNN9qA0UK0kiqM41VwJD65VaN4b3D0Y52PLIB+kdFKY4+sXMHa4CWa5E10Tex7Q4Ooe4VayLkfTHNMDCI6VBPoihhnqUo3SGqOJb9tVVxAOBsWI1pgc+lAgJDSKuqTbNR6HGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=g1aL2E3E; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="g1aL2E3E" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493bc8fda98so6062755e9.0 for ; Wed, 08 Jul 2026 07:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1783522161; x=1784126961; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HmxbOG7rbE41JtbgC/kLoXXgZ/dEvF+BjHVvArFg/gY=; b=g1aL2E3E2VCMl5EZl+mm56PtLoA7f5ff/rFSpvITWgTbMpeIOZzoqy7QS90kJMWkXC Bqh0G5s564Ie+o2YL8Wx/i7GIur6KTzQlw08PpjYXje10FSl/wTgj0wFbIGMl6D2TZ+i HS7k8qMuw53iAwOYJ4edKlHtqs8ZBjGSHnQfvsL9EJeZ+l5OdDL//zRmvcbv8VRwSp6I p8Uj9VFNRIz5YASBcfBo4a6BJZ+aBbWNb/sbNRM828Dvi3PyrZCuJEyzVxghNPj91/6C n388e7R0EfEOseltmN4yKXyGkbhIxQG0IPqiHZLyoCi7r2dXRJ2skXjo/Q1IJE/kLzOi lzbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783522161; x=1784126961; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HmxbOG7rbE41JtbgC/kLoXXgZ/dEvF+BjHVvArFg/gY=; b=pf/RxcpLrmjUQhFG9bXTIhmrkMxs/sQ4uLjcR3k3YAYLDTekLSg764WprfmDQ9nuKU D38ps/tfVGL9mBJ6b9E827w7JJof7JjD/QwQe6aO9KkE1Rhd35HqOxxhAKgKlN4a6l1i 9XKxEbKGyUosvnxVxJJwh82+xm6bevyrzGXmdBvK5O1Jxjv2IMjB/u10RTrGWrAZWxMv 3qgfkUvYLqDy3v5xwtTzhoSLZ50sIwWA/ZQj36ZkBp5/BRgPfDOjBsnqQjIEbeIPFHJn y/hyneRJ4MmcCniPqw6qmemHEJ1pUfZfTKtm6w5qr9PL4EdvO4SMHDjuoofsbMwdpVGv f15A== X-Forwarded-Encrypted: i=1; AHgh+RoXWJxOc92NcN/qu+9DKe7wC+fg7F+ptXkwgoWIvHW+djxchwcePN2PylaMbUbLQQgOyik3+8qrUWLvup0=@vger.kernel.org X-Gm-Message-State: AOJu0YyykCS0AUitn3PJzgftK4oDElQIrCidrLMKaUp0H7hm1JSi3/Pq cSinVJJFb3CjAfnFG6SUQVjvtZfeoiDU3qmOu28vQlW8uwgaCVPp+nfsPPuI79bl3RFP/+6at2b oFHz3 X-Gm-Gg: AfdE7cmMWXAxUQCOZnca3F/OblNfvGhrDDejTjDW/xh8VeQSDnLRqXHhYPg0B9dITD6 Okk6W+/GRWPC49JE6XTuEFJszLz/48cqe7FGnrn/EIIZHcPFkUlgLG2NOW5oTeJRkEixnItDdQE vssp/R4x8DgIsOQVs4yjftKCKzF2RSuqjQu/98D+f2FAm0Eo02RYGMaH5EivCUlKG9KYvBynj0o FQOe3jjee1tlLVcyxDEk0pc0M0QzOZxM4zwYUhzjPD3tvLux2dAYUEmXBEKFK27unvq+woLCcPI EbiKvBFcwsGghg1bheu5MRaBVcRC18XdQtQPBHeoANoAq7J1DnE8yu6TZwjUHBy/zp8zIRpej6O 0JQs1TEV7xKjITHFqTgWrGOxnajhcbd0tRkv8fU+NY0pekFK7qrf1gz3OFyQwqGVh0a7eEWgJHa DuBbljTPBtOHreKhR0QN+kv/E/UVWH3bO64Cj7KcCuZMgvUM29RqFISTVxCofjGRb+ X-Received: by 2002:a05:600c:628b:b0:493:e947:b24a with SMTP id 5b1f17b1804b1-493e947b27fmr5523075e9.14.1783522161339; Wed, 08 Jul 2026 07:49:21 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493e0fbd355sm135363315e9.13.2026.07.08.07.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:49:20 -0700 (PDT) From: Dave Stevenson Date: Wed, 08 Jul 2026 15:48:51 +0100 Subject: [PATCH v3 15/20] media: imx355: Define the exposure offset, and use that define Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260708-media-imx355-v3-15-9df386a623d7@raspberrypi.com> References: <20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com> In-Reply-To: <20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com> To: Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Acayan Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg , Jacopo Mondi , devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 The difference between frame length and max exposure time in lines is 10. That had been used as a bare value in calculations. Move it to a define, and use that define. Signed-off-by: Dave Stevenson --- drivers/media/i2c/imx355.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 2bf8da7469fe..3b86bd2e2e5e 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -51,6 +51,7 @@ #define IMX355_EXPOSURE_MIN 1 #define IMX355_EXPOSURE_STEP 1 #define IMX355_EXPOSURE_DEFAULT 0x0282 +#define IMX355_EXPOSURE_OFFSET 10 =20 /* Analog gain control */ #define IMX355_REG_ANALOG_GAIN CCI_REG16(0x0204) @@ -635,7 +636,7 @@ static int imx355_set_ctrl(struct v4l2_ctrl *ctrl) switch (ctrl->id) { case V4L2_CID_VBLANK: /* Update max exposure while meeting expected vblanking */ - max =3D imx355->cur_mode->height + ctrl->val - 10; + max =3D imx355->cur_mode->height + ctrl->val - IMX355_EXPOSURE_OFFSET; __v4l2_ctrl_modify_range(imx355->exposure, imx355->exposure->minimum, max, imx355->exposure->step, max); @@ -1129,7 +1130,7 @@ static int imx355_init_controls(struct imx355 *imx355) imx355->hblank->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; =20 /* fll >=3D exposure time + adjust parameter (default value is 10) */ - exposure_max =3D mode->fll_def - 10; + exposure_max =3D mode->fll_def - IMX355_EXPOSURE_OFFSET; imx355->exposure =3D v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, V4L2_CID_EXPOSURE, IMX355_EXPOSURE_MIN, exposure_max, --=20 2.34.1