From nobody Tue Aug 25 20:42:00 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB6747D938 for ; Wed, 8 Jul 2026 14:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783522169; cv=none; b=ByqkWkbXjhK0/s6O4Z+/a/Lzc5CK1PY7orwnPpiflEsQzHJX8qGQFbiKYr+qIxw5lzDm1Coca5TXpMeOIFyXWrYLKTa57TdMpGXwIFGJXamwnQ44n+3x+BewIxihpboY7tUXxF1IL/lHCct8ZBoji4xyRkm3NDJwRsVQs5SgMfE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783522169; c=relaxed/simple; bh=WmGz4nPgmAYFKTk0UHv3cgym/1CZLfveDLzGzzdpKXs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nwsS6wVMHYTLYBoIgJ9VkKIG00IDpGaKJEMODOvy96BjYH+xrAwZfYPRL37a9sDTvF/M3sUxGYWzMYJqdZxp/o3Wq8CyeQGw1VIoYc5JfLTWGR9CtE5CyiRk3CPHqqAnQOdym+t8gY37+e5i+hYcNr3WOFtDT7gfsuSz5tilHhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com; spf=pass smtp.mailfrom=raspberrypi.com; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b=cAhn5afI; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=raspberrypi.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="cAhn5afI" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-493e8d4f4dcso2482875e9.0 for ; Wed, 08 Jul 2026 07:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1783522157; x=1784126957; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=poih6FWktQDQKgkCTECxgZzsFqMFD3r/FGOUzaesYvE=; b=cAhn5afI10yGdIL7k8Xblf5IvVuzKqghzNCIAiVKorHu+MCMFbxvAFjqhIWYKmX/9j GK+tEUQfxzYasmQLJ2fSZ4rjjTV8ukdC3qUiizfyB65oA7aQTBvC+CztyROKkBlEVrvq QNIAEAQqdPJZ24ox/nBJgusXu7pWwqnSv1CfLQ47nWSYKE9J7D05KmApzHTpYy8xyjkd zLTa6vXRB+wb5IiKxuH6+7otBPm04RPa4QhtV+CmXPvVlDQDNiajxgPespI0oR3i0sPR Qnc9atiaRS5GyjKQAIVWs+vMQ8Z3+IvNuTfb/Z9cYRjMrur5j0CBmmRhgplYCpIxSzqZ OgtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783522157; x=1784126957; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=poih6FWktQDQKgkCTECxgZzsFqMFD3r/FGOUzaesYvE=; b=M0GdF/JVy9v+Fl+PlkUSdhGUbrqwN9lOIc/dqnY53tnORZGMMC2anw9ZIX4WgftqZn EgQSKoDT+/MPlN0qIWdaScBiqHMBBcE3Tq2BEmanKhqU3xYz3ZbSzFhlPXB6J9xaA9FC cgr0RoEEdPc4WC3jfe+JNjeKTVxpZ0QLpEUf8h1v8EcIyy445uavzflQX9PY28HDGx9C +mNXDSmXRvmoBWZZ1dPRXlaZugQ199HYB6KWqsfKidZx2DB158eB+sYxcf38WD47zqBR Bp5fKYLfvc1EaOkOdu8wgqxQZqgsrklV+3jW3Gmhfgic3AcplOE8NrzAmu/zFj2wJkGG 0oug== X-Forwarded-Encrypted: i=1; AHgh+Rr9sn2NAxOG92imxnqtqmLPpyPZAgD7Sbs81Bqnjw2wvdmlONnrdD7Aq7IwUmvacOr1d4CMw+LqTWlE4WI=@vger.kernel.org X-Gm-Message-State: AOJu0YynHQcDkQlcphjDLN7ziIH+DCHLPrzMK0SZePCqQ1i5G0f94OCx weOiDSg70DA1HfDi+J/SV4nfVonbElHfpJNq3W7dZggPOUD7NMQBto9HitxD5JPUle0= X-Gm-Gg: AfdE7cnUjoJMHCVDoWRf0nmf3AxKKDC3SVGmAcrWNIiIDwR0jVcD5c4NdhvU6NnnQoU +w4wqE3CjALYkGimfA2AlazFk77tOPl+nxXMfYIGZ3xvkFel9c6aG0/djonHp7MwzcipWNjBi/O uIoxGmQxy4bMIUkxg1AJ8uNMjL3VsqB1PYqkLvxyTpkQdzkKgSLiw+4ZXdpKi0Ylyw/cqRu1Nlp bGkhjwLvfZtsEte7/tILvyhFnODaprT1/2Hj7EsOjSI1tzf9fMU8wscWluBpNwSzrwrFL/Uoa2+ u9F4hNFPjqnhZe80sHGPPDdEzcifNvh8RYSwFkz76g/kPkSTwOd+/1DTWF8lys3FfTqCNZ5tJ2Y JggfqWUCXvjprM4AJE8yBz87e19qxtolYAQiz5d+/uUqHhSE9a0eWD2LP/0hfruKnOGlS6F2CIl yFMgd9U2HX3LXS7CVE5ZsGEefGqUCjYT0potCrphrIEjX+wrUUK3UYG/a4DhzL4bJj X-Received: by 2002:a05:600c:4796:b0:493:e97b:3b9c with SMTP id 5b1f17b1804b1-493e97b3bcfmr1416705e9.29.1783522157466; Wed, 08 Jul 2026 07:49:17 -0700 (PDT) Received: from [127.0.1.1] ([2a00:1098:3142:e::8]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493e0fbd355sm135363315e9.13.2026.07.08.07.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:49:17 -0700 (PDT) From: Dave Stevenson Date: Wed, 08 Jul 2026 15:48:46 +0100 Subject: [PATCH v3 10/20] media: imx355: Remove redundant fll_min, and implement fixed offset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260708-media-imx355-v3-10-9df386a623d7@raspberrypi.com> References: <20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com> In-Reply-To: <20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com> To: Sakari Ailus , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Acayan Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg , Jacopo Mondi , devicetree@vger.kernel.org, Dave Stevenson X-Mailer: b4 0.14.1 fll_min (Frame Length Lines) is set to the same value as fll_def for all modes, which makes it redundant. The actual value is also erroneous as the sensor works in all the defined modes with FLL set at the mode height + 20 lines, so set the vblank control minimum to 20 rather than varying it. This also improves the maximum frame rate achievable. Signed-off-by: Dave Stevenson Reviewed-by: Jacopo Mondi --- drivers/media/i2c/imx355.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c index 2a97e076bff7..c6f27cf269b4 100644 --- a/drivers/media/i2c/imx355.c +++ b/drivers/media/i2c/imx355.c @@ -32,6 +32,7 @@ /* V_TIMING internal */ #define IMX355_REG_FLL 0x0340 #define IMX355_FLL_MAX 0xffff +#define IMX355_VBLANK_MIN 20 =20 #define IMX355_REG_LLP 0x0342 #define IMX355_LLP_MAX 0xffff @@ -105,7 +106,6 @@ struct imx355_mode { =20 /* V-timing */ u32 fll_def; - u32 fll_min; =20 /* H-timing */ u32 llp; @@ -359,7 +359,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 0, }, .fll_def =3D 2615, - .fll_min =3D 2615, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_3280x2464_regs), @@ -376,7 +375,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 8, }, .fll_def =3D 2615, - .fll_min =3D 2615, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_3268x2448_regs), @@ -393,7 +391,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 8, }, .fll_def =3D 2615, - .fll_min =3D 2615, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_3264x2448_regs), @@ -410,7 +407,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 684, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1940x1096_regs), @@ -427,7 +423,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 684, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1936x1096_regs), @@ -444,7 +439,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 692, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1924x1080_regs), @@ -461,7 +455,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 692, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1920x1080_regs), @@ -478,7 +471,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 0, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1640x1232_regs), @@ -495,7 +487,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 304, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1640x922_regs), @@ -512,7 +503,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 496, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1300x736_regs), @@ -529,7 +519,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 496, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1296x736_regs), @@ -546,7 +535,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 512, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1284x720_regs), @@ -563,7 +551,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 512, }, .fll_def =3D 1306, - .fll_min =3D 1306, .llp =3D 1836, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_1280x720_regs), @@ -580,7 +567,6 @@ static const struct imx355_mode supported_modes[] =3D { .top =3D 0, }, .fll_def =3D 652, - .fll_min =3D 652, .llp =3D 3672, .reg_list =3D { .num_of_regs =3D ARRAY_SIZE(mode_820x616_regs), @@ -864,7 +850,6 @@ imx355_set_pad_format(struct v4l2_subdev *sd, const struct imx355_mode *mode; struct v4l2_mbus_framefmt *framefmt; s32 vblank_def; - s32 vblank_min; s64 h_blank; u32 height; =20 @@ -889,10 +874,9 @@ imx355_set_pad_format(struct v4l2_subdev *sd, /* Update limits and set FPS to default */ height =3D imx355->cur_mode->height; vblank_def =3D imx355->cur_mode->fll_def - height; - vblank_min =3D imx355->cur_mode->fll_min - height; height =3D IMX355_FLL_MAX - height; - __v4l2_ctrl_modify_range(imx355->vblank, vblank_min, height, 1, - vblank_def); + __v4l2_ctrl_modify_range(imx355->vblank, IMX355_VBLANK_MIN, + height, 1, vblank_def); __v4l2_ctrl_s_ctrl(imx355->vblank, vblank_def); h_blank =3D mode->llp - imx355->cur_mode->width; /* @@ -1151,7 +1135,6 @@ static int imx355_init_controls(struct imx355 *imx355) struct v4l2_ctrl_handler *ctrl_hdlr; s64 exposure_max; s64 vblank_def; - s64 vblank_min; s64 hblank; u64 pixel_rate; const struct imx355_mode *mode; @@ -1181,9 +1164,8 @@ static int imx355_init_controls(struct imx355 *imx355) /* Initialize vblank/hblank/exposure parameters based on current mode */ mode =3D imx355->cur_mode; vblank_def =3D mode->fll_def - mode->height; - vblank_min =3D mode->fll_min - mode->height; imx355->vblank =3D v4l2_ctrl_new_std(ctrl_hdlr, &imx355_ctrl_ops, - V4L2_CID_VBLANK, vblank_min, + V4L2_CID_VBLANK, IMX355_VBLANK_MIN, IMX355_FLL_MAX - mode->height, 1, vblank_def); =20 --=20 2.34.1