From nobody Sat Jul 4 19:59:43 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7751827AC45 for ; Sat, 4 Jul 2026 17:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187636; cv=none; b=sjcOv/c+0rcKLKYiorFXI9uS78Mcl2HY3L8hZq4cRqYFFjj8/ioea1yC8UAXQ75AZ+TnIsX5aVffHmrbt6QEsf+rC89TrxRFp6Ir9a/UnHBlFwquuWMGA/Q2asUZBNGRSi+LUlbHN5s/2sUrexDzg5AfrLuCLz56IqMn33V8JOo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187636; c=relaxed/simple; bh=nqVTW6DH4ASUkqta93gyc9UKrqMdUX7EO+mifFx2woo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DoGVKFaRePWLF6gkUX5dXieDeFyeO2/3JpJIz7Kim25Q/kxTgy4GgDWktHl7iac/eXNgmKWrhzJlaQwjk723kt/GSSma2F/ajtSyffctziEjuauUH5+6w9keaU4B2oDBXta9XrzhMiRR5Z4Uxr0riGr1QB6TQTFpX2HgJdq44RI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=erba5iI9; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="erba5iI9" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-37df72c9984so1477526a91.3 for ; Sat, 04 Jul 2026 10:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783187635; x=1783792435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6KZPajTGZcSmUhFo1x8c8s6SejNqBr3EonFM7GD4NfQ=; b=erba5iI90Ihw06gOb4xgFcV22XBzSClfyDXy+RyEDHQcGE4gLQsUunK/RhSH1LLTsh ZfNhAi/VWi/z379ql3LDs4tSGgxbfo2/obOHsHl9MRAmn3nw/Pqn9bWpKtdSt4zVikxy j6wCdxxp1nd+Md1zlnHNRLV0IRv57wZXFA5/2O0CbGXg6ZWDeKs8S8gSg5n5pV9EIYVC 0VEML8wcbmsqvWtNZXZhELGYX0HsXbqN53pXi3tezD4cq+yUei321aao47Rr+B1L4/XF HCWYlrK9CdX55djaqrdIpn4pKMd1+BQnW71o9QJIQB3cxvvCcNjlHqxuwmRhROw1Pl0A bwSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783187635; x=1783792435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6KZPajTGZcSmUhFo1x8c8s6SejNqBr3EonFM7GD4NfQ=; b=Nkpt2Vg2bfkV2BndwhysszyxSojjB1SAtlU7f1GPhZT6KyjCIdvc4VrayfwUvhQO8J 658V/lZyKMplTueSEGzLXZP1hetd1Bv3Izwx56WBQgwTQC4XHUCrE3KTe448+sAL1g1R 0NFS5dl6k4EsP+WLUkc9MCBl7SJ4sY3E4YlmVGvKJsESHLPCQfD2nJxQxKe0vx269BQA hLVME7yCzYjxsu7qL8E26jbcpE2HuA0iKW1ffIEoBi9972D7pTfPixRbYuxfUD5esbqM Dbc2LY6TMyoVkb82ltUKDVQ6YvS7FMnsBkrA+Xi8ITgm+fkKoJPyROcba9ls34wEu1PC 3GpQ== X-Forwarded-Encrypted: i=1; AHgh+RoZd6ADmxnNU9eI3x4S3HgobnPS5+DXHu1xkxYHwT83jbjKtXVXRY+GGnXNkaOrhLVWI+EBhWieb5d3Oio=@vger.kernel.org X-Gm-Message-State: AOJu0YwJCPxf97/40dy//mo/0ykm43IBQJEaGRD5VRPKad2CtiBs4miN EijfpjPcxVxOsfp9FIqHGQS/BbacZPY+R/s6oalgP38iQ6s7lztIMDGV X-Gm-Gg: AfdE7cldV2+T22kHOJaGwAndvcIY3xFTMzrVGOP44HpW3+11aJVaVpH/YPsKssUEvTV s4nQFyOPUD/LYtzXsbXlfWoBtMG7LXQ0ubT9X5lT5CyybgHGVB/NQXlv4iBurld6SgKauUhwezH RuZl8kRNrrKDgMl9ql+U2XFoV8LgJCtDSn7UKkw7qA+Ggv+6zqX9BM91u+b3tXQEJle31nTUmdV JPtcxVfgo3T1bj7vm3IoZW4gCQmq36RmeWqLlqehntPQS8cgDTH+YP0DK0lJOi7zr8uwQhmUiGH QJC2P1cv9nsBfXjAwppljt987DNvG7EN+MxRBijFnOD4kpOfU5Vx8SPCOQl2TYLpmE7Bsl5m0XO vPk32S3I5dqjDtQcMPIIxDdP6m9lGe1fxNb5h5ij3rYGT/z7OBGJEnJ3Dgzpzzw5yMqlG8+PSW1 QnyQIevRgCWKZDns5uIqn/qMsnMxCWdPNEuypR4dpVcLiE8cMI8A0rbA== X-Received: by 2002:a17:90b:1802:b0:380:83fc:4315 with SMTP id 98e67ed59e1d1-3829f007711mr3908482a91.21.1783187634777; Sat, 04 Jul 2026 10:53:54 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f39e07e0bsm15588749eec.30.2026.07.04.10.53.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 10:53:54 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, Biren Pandya Subject: [PATCH v3 1/4] media: renesas: rcar-csi2: Add missing media_entity_cleanup() Date: Sat, 4 Jul 2026 23:16:40 +0530 Message-ID: <20260704174638.66302-7-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260704174638.66302-6-birenpandya@gmail.com> References: <20260704174638.66302-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The probe error paths and the remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op in most cases, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() calls. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-csi2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/pla= tform/renesas/rcar-csi2.c index 7305cc4a04cb..f9c818b0faf7 100644 --- a/drivers/media/platform/renesas/rcar-csi2.c +++ b/drivers/media/platform/renesas/rcar-csi2.c @@ -2631,6 +2631,7 @@ static int rcsi2_probe(struct platform_device *pdev) v4l2_subdev_cleanup(&priv->subdev); error_pm_runtime: pm_runtime_disable(&pdev->dev); + media_entity_cleanup(&priv->subdev.entity); error_async: v4l2_async_nf_unregister(&priv->notifier); v4l2_async_nf_cleanup(&priv->notifier); @@ -2646,6 +2647,7 @@ static void rcsi2_remove(struct platform_device *pdev) v4l2_async_nf_cleanup(&priv->notifier); v4l2_async_unregister_subdev(&priv->subdev); v4l2_subdev_cleanup(&priv->subdev); + media_entity_cleanup(&priv->subdev.entity); =20 pm_runtime_disable(&pdev->dev); } --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 4 19:59:43 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D6BE35F5E3 for ; Sat, 4 Jul 2026 17:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187640; cv=none; b=uanaBBqx/iW8uzKBEqf1RNR/Twlry/IUEofkIG7dld0On1jENKQlWW9/2dcyOKogKibiKTm96/zxqnhl3mEZDRbpxgxoOhhPX7157zvlaFIMNvdnUV5HbXnCKSXacsqfRymuhNX+X75Dta6TvYYeXbGvb2z8RQIUzS2I5Kd6RZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187640; c=relaxed/simple; bh=9qmog2n5b0kAnBBF60IWPrMQr/t9YzSmnsx8p6G1sFM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AfiPmEvFmH2MO0figmmblzeMjpqIK8H4j4SIg70ya1+rErZlvKPe0hY9XFDrH/7D2l6F9OCLZaWrzkVKzceOW3g/e7B3PMozKYZrcCGmyvL8ZCuSNt8ZZ2VMugELQtfnuLUsncHxAdWtGSYGo8XKqKjuokDAWexuBUTtmpMV29g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OhKr1X54; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OhKr1X54" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2c825c88744so13724765ad.1 for ; Sat, 04 Jul 2026 10:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783187639; x=1783792439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3npAVWjav7GMHxuMuHgdC6XUpyNeQBqQ4x3PSl9Xjcs=; b=OhKr1X5411Narl3bPGM01P5mhfwhl/nl5VOoXQJAcsmFmzWAUV/DLfdm/LUj52ANua 526qoSFaF5f3D1FTpz8PAj4suiUFWzICuwn8ceMermik0jjjMsrGCnFVk3c2Ul/7SM+n imks+OBKOzB6nG7d5O9w8ys+P3gMjBaeccnTDV20o11rXz94jmOLSxqoyUR1uT7EmZCQ yJC1wxmzX2BduEIKWcg/JUgt4g4a/aIQdMzT6+UOR7ZhMv3nmoItNwpy5n5D5EJ9p+wu Cv1nDo7nbgL8ffL9r1d03OG1aR9yWf+JVflaP0QfrbFvyrG+6x3aC1PxEqhUMgAmF02t IfnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783187639; x=1783792439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3npAVWjav7GMHxuMuHgdC6XUpyNeQBqQ4x3PSl9Xjcs=; b=Ds1bCbmExQHH1TjjNbxoFUdRj1Zb95PbMjFx2mEw7BBgnxCHH1Aey+96X/04HGomMO FVcGBjJ0FxIgllzA1PRLolKCtTYdCnVHBGZ6RSWEOOSy778zH1KYqyrb+RieVxYwCkLC WR1l5maKrGBhVf1pFhvfsJ0vPr/R3LoZyysi6LnxUAVJ0CoH0zjHiNFwRDIgaABxZxFS hCv+7pPENowPNLaLO98+hTO1g1s+HZEUDSKGjDCHoERaKg//2E4dYgpc/KrCDnzrW1vb zhltSNRpKJQ3+2Tx577mcj38qU52K80Z96cJg4o1wrp51mJgVuDNUUdHBxV6WXlZpnYP u3dQ== X-Forwarded-Encrypted: i=1; AHgh+RqwavpGJWHU8CTa3Dqx2P4UHY9n73rNJpSrdSSqJART+LmCewV/Ru9GsSSm3Jcl+NeCKP7ObnC6OU1PG/s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5Y7vK/GifcqTa9qBBQ7Whgl705AbpuyA6VfnBPDUsx87z2zYX ldw9Etm1MsW+DRyZhmzr/x9VUU13rQH2fLpYC2bfI8vRYNVNn5BWEcEG X-Gm-Gg: AfdE7cl8JQdP7hDIH+wRMR8go1nrOin08eGBZpIt6V7N/uIHjg6Puek/lOlEcRXW2Ov C+yU3e5QN5IhY0wYepCirNoYUea/CjaiiCyxAX5dUMLCo5KiI/XBoW9l3p2EcbNqD8AFOMBQNfg WyzP8fTmzPfxsF0AmpQ/NWRvzjmfANGovgwx+q0k7Mz0scYNMfvARs5z6UMjv1oz7aibbgJySS9 RbGk/IbdH94bGDSsMsrmP3MvZQmL2tFqUWimtbJb1h/bFMYRHrJZCVHrll4b/BKWavh1wg0Q6oj K9NOlbrYid02ZcSeX9SD+hiE9LRx8nkaGjkR7A4ytNMsSOuhgUdxzvjXYMBJodLQZCeNboldh+i ECG6cQvH9WEL8IEYNKqDTY85XxW1JeYdg8wmoW1CSjJoMbxgmK3OG8LTkR7LLFfiQ0mVe7U072s 2/qDiO3tuE4IBG1HT7Opy9oYw5JsTRZMS1ToeaWxU3SuI= X-Received: by 2002:a17:90b:48c6:b0:37f:9ce3:ca93 with SMTP id 98e67ed59e1d1-3829f8e55d2mr4357875a91.28.1783187638891; Sat, 04 Jul 2026 10:53:58 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f39e07e0bsm15588749eec.30.2026.07.04.10.53.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 10:53:58 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, Biren Pandya Subject: [PATCH v3 2/4] media: renesas: csisp: Add missing media_entity_cleanup() Date: Sat, 4 Jul 2026 23:16:41 +0530 Message-ID: <20260704174638.66302-8-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260704174638.66302-6-birenpandya@gmail.com> References: <20260704174638.66302-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The probe error path and the remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op in most cases, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() calls. Furthermore, introduce a dedicated error_entity label in the probe error path to ensure the cleanup is only invoked if media_entity_pads_init() has successfully completed. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-isp/csisp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-isp/csisp.c b/drivers/medi= a/platform/renesas/rcar-isp/csisp.c index 8fb2cc3b5650..61558a71ee35 100644 --- a/drivers/media/platform/renesas/rcar-isp/csisp.c +++ b/drivers/media/platform/renesas/rcar-isp/csisp.c @@ -539,7 +539,7 @@ static int risp_probe(struct platform_device *pdev) =20 ret =3D v4l2_subdev_init_finalize(&isp->subdev); if (ret) - goto error_notifier; + goto error_entity; =20 ret =3D v4l2_async_register_subdev(&isp->subdev); if (ret < 0) @@ -551,6 +551,8 @@ static int risp_probe(struct platform_device *pdev) =20 error_subdev: v4l2_subdev_cleanup(&isp->subdev); +error_entity: + media_entity_cleanup(&isp->subdev.entity); error_notifier: v4l2_async_nf_unregister(&isp->notifier); v4l2_async_nf_cleanup(&isp->notifier); @@ -569,6 +571,7 @@ static void risp_remove(struct platform_device *pdev) =20 v4l2_async_unregister_subdev(&isp->subdev); v4l2_subdev_cleanup(&isp->subdev); + media_entity_cleanup(&isp->subdev.entity); =20 pm_runtime_disable(&pdev->dev); } --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 4 19:59:43 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4D3F208D0 for ; Sat, 4 Jul 2026 17:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187644; cv=none; b=LUgkqwVIMuoqIcRZsaiOHzUQSVhQe0FdqiMpYZryoOBoOshgJ/kdyfi/DesUD/dQwLe19sG+Fcc7p6xc3ouAwkld/SV2TCu6tDj+io4DPA06FD4KADHxRNifdQfnnoaMQLJ7IdmFJlkbVEnaPIMwGzrp/hMNd3nlhd/sgQBOzZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187644; c=relaxed/simple; bh=Z9N6pEsigWAk2UWIWHJBzftcZEwVRuN0TCZwIeyDEcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T3q9cSTLBMt8g1dZDnYHRMEzrXwv9X8sPKLIi00mUMOsYFZygMYBqH858o7HIdiGZckbtWJI6KVm83SreDoYSnWmOwqjy6Omu937MFfkcmjg7CbZYJx4FNDwAxFAUtbnaWmhtIjLAFckoEH3pNIjPdVUzzIYKS2wvmdmE/bDAls= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mskwjMrL; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mskwjMrL" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso778969a91.3 for ; Sat, 04 Jul 2026 10:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783187643; x=1783792443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1BtSYlQaJpsM/z+8viYvtsDhnMR5+tk/oB714i1BVbU=; b=mskwjMrLePnHjiFK6ADgVOxM8F+UMdGCSlfwCB62u1OOF+NxJmoh8hJluwGZGXkDnZ uApmlaPnNmiuluxaNZXg1AesEX4IGf5o26v67edgNmeA830Tz74AE7XS3KkH3fpF3pRs wSblRu0HmTC4OEe0QekgJOkrKkku8HlHMhVFIJmBJVPJAWlprrtcZb/1meozVL3UCM80 dA7Ak4Jx7ql0BnQbv9uUsoh6ae4Kfmdglk70d/ajITGhT7Z7G4KOexWtiXO1ScIqpjD3 YzNFRCwincScoQJs64b03379crBsWT4EA8ddhudHqrSZCiQs/VLqvG6Soj9V70cUWpe8 SPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783187643; x=1783792443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=1BtSYlQaJpsM/z+8viYvtsDhnMR5+tk/oB714i1BVbU=; b=dP1QE9yZXjTpMqp+dVhHDwPBNdDH7vM92Mpci6IRmf0fPLWFgIoP/PDCYHstyDYvnh DrBpPLZT+Cans0bAxuPCF3XS5WjFe5AUPVDTZG5SMx3EpFlI5fj/nOJf6xj8AetBMdTQ 157E9yeJHWE0QxT8COmn49XGXGzdtcXaz7p+aCRVeiCPu2k5N5py4YktWlSCKgVe9kYm SEpJZC7lUgVIX2Q8CLN6zwk3JEA9HKHjZJwOxsfmqdEzAc0hLTVZyvpF/9UBKsCflX5G 4sINffbwIdkPCShX5M7PD2Ks0B7n/thj9o38901Nqk5RVzIOxesjETMAZhcH7RjEoMwV 4VEQ== X-Forwarded-Encrypted: i=1; AHgh+RqzD86NMsbEKk70XI0qWR5PQzh/At0/KnfAJtyJ6FSx5k9t3hfSUsEFpnRq+eEU2boA9+iWpW0s4P3/T08=@vger.kernel.org X-Gm-Message-State: AOJu0YxkyjHqUTVQi++25INGvJD0lcl0GN/nV2Y2RPOms7U/Senv7Rcv 5FatlcP2/4IhBSSg+TL9yIyIbIseVHdKp/VbTl91ISPUUmKONfPFPgZu X-Gm-Gg: AfdE7cksbZGTxK/Hf+EUOrZ53stbavjTABKcI3iBOZhw2FXJjFOXoqQ4iS5I7PHrlE7 uOTNa0rN1UM5tq+9iqPUvXD/iDLogbTsD3x8RHLHBMg0eBWhme5dzCkODha3F4EV1hqgIjU11Z4 6NvDAHFY7vHnJArgqPiMEwqfa0Bj80kiWB5IHkEx+K9DzUdvXGAucmMGRjANnaqqW/g2PNlh37X KbfVQR276D8/YhiXb5xhGHbvgJsG/bouzCds+eFazc+yclccHPpiv0TyHMB1GRr6bqxJEjcEGAf imEmECtuauo7L+5aBA4ymFyyrnRc9kg8TtLifdvDX2dcE/MXqs7qNFUbwZ3Q0hVhaB5DzNxNQIO m2Ek7hot5CAiiF3cDrBylnvIoklFSZNono4TZD2udTneRk+Roz6qZ6NhrcTWqBOnTckZ7ohXFZ2 fRdTxipRIjgOyAZ/dfeUrogvsp3i2y+vmazlzJJeXZJFg= X-Received: by 2002:a17:90b:2d07:b0:366:132:fda7 with SMTP id 98e67ed59e1d1-382808b2089mr4165513a91.10.1783187642936; Sat, 04 Jul 2026 10:54:02 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f39e07e0bsm15588749eec.30.2026.07.04.10.53.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 10:54:02 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, Biren Pandya Subject: [PATCH v3 3/4] media: renesas: rcar-core: Add missing media_entity_cleanup() Date: Sat, 4 Jul 2026 23:16:42 +0530 Message-ID: <20260704174638.66302-9-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260704174638.66302-6-birenpandya@gmail.com> References: <20260704174638.66302-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The probe error path and the remove function fail to call media_entity_cleanup() upon teardown. While currently a no-op in most cases, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() calls. Furthermore, introduce a dedicated err_entity label in the probe error path to ensure the cleanup is only invoked if media_entity_pads_init() has successfully completed. Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rcar-vin/rcar-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/= media/platform/renesas/rcar-vin/rcar-core.c index c8d564aa1eba..5bae8eb0ee19 100644 --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c @@ -1211,7 +1211,7 @@ static int rcar_vin_probe(struct platform_device *pde= v) =20 ret =3D rvin_create_controls(vin); if (ret < 0) - goto err_id; + goto err_entity; =20 switch (vin->info->model) { case RCAR_GEN3: @@ -1246,6 +1246,8 @@ static int rcar_vin_probe(struct platform_device *pde= v) =20 err_ctrl: rvin_free_controls(vin); +err_entity: + media_entity_cleanup(&vin->vdev.entity); err_id: rvin_id_put(vin); err_dma: @@ -1270,6 +1272,7 @@ static void rcar_vin_remove(struct platform_device *p= dev) rvin_group_put(vin); =20 rvin_free_controls(vin); + media_entity_cleanup(&vin->vdev.entity); =20 rvin_id_put(vin); =20 --=20 2.50.1 (Apple Git-155) From nobody Sat Jul 4 19:59:43 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73AF374169 for ; Sat, 4 Jul 2026 17:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187648; cv=none; b=TlS8DxTkZNfOm1RqtL7QNMP38frZhUbKFY4XvI45SPadtbl3umSKKTj17a+eSJn2IYe4b0tDHUwUDQLYsQwTzwjp/fQIN+H1hVbAXZIBqF6wtdXEopqysi5G5IYgpa+sa9ObaQeags3wwFmb99uy4ubEwiMIAUIb9SeWJT+mN58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783187648; c=relaxed/simple; bh=IleNu9kVSuAJm7Q5Fpv6O/DqKf3UI+pPZj/WHMAwnlQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BzNHyr0F927VhsvKmRQ4Kk8InxArMF+mlZgG21U32RV/iP+dkU2K6AP4Silg6SeuVxdXnO030dOQZo/gdfds74+34oM+Blgaj6XGardwBYuXXHDdZcylA74bBGWImWL94gHNp9lLunPRdPGagKgX0w/BeRB4pxMbISDEXcjOWxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BD14PH+x; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BD14PH+x" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-3817f800c8bso971916a91.1 for ; Sat, 04 Jul 2026 10:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783187647; x=1783792447; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5AbjPfAmyYbFJAi2zj/YWEJaXgs7wZq4d5KSovlCSmw=; b=BD14PH+xwb9tHPqiIEa+RKqn+ALMKxF5q/jBA2ikj8YGgo4k5JrcoHNZJClnRuRVYy CuBSdKsLahY+oHwf7ojaBb0+BkcX8yBy+nHV1o+6MGptxVnDK77e6LMXFQcSN4k6iAiG FBDr8mIeqiKXn3PfKnXtKDhx6u4uVqawehLAcb6D5lKLYjAixgRiBml7c2eY5ZFXHOW5 QAPbj88/bE+qvk+p+zcVuJP987WNaqM7iowiaXWwY6EEi325iSQd4r3NGTZ4V5jMqBmy c/VGO6ERaZ39gxA/GBc0gbzzyNoTh7BcbC9+fzpU0yP0MNfMlja/6bwZD4dQqEoE4u4d xTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783187647; x=1783792447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5AbjPfAmyYbFJAi2zj/YWEJaXgs7wZq4d5KSovlCSmw=; b=Afk9iEknxSh2ve/eNXJtVI7MliwWkwCWZn1g9i6lbiPiPJk28VVN/3/hHrrVE8N+YH sEMj886SiBtGOxJJD6RxHMWRtHjyVK6ptgkOXR2i1lYDJK5bRmeHxhxcpWY/ZPu27ST7 nYlFRLbXsfC68gaRl5Ftab8rN7ejVMmxCZQGlZ9cn3xagfN5rVxbQVPQomrjy5DyXbq7 pmGvrxkITRfaWu9euLeJWPsypOTAguuv/moQyhxAcnwqoampDzhuUrkinbqKee/2nVQ7 sXM8auD1Cs7yxUXqABSypuyvM4ykgdcOt6lu6/llJ41m/PcW0rq8Ubtf0x4CxR3D9q5C UlyA== X-Forwarded-Encrypted: i=1; AHgh+RrAOYNzLrj59VQEytDR3ey3bWwvjYEHMdR10aovzHNweaMroL9F+/0yZmxTF1tt/ODZ6QX7R5eBGeB4wUo=@vger.kernel.org X-Gm-Message-State: AOJu0YxEulZWMAu5tc7xKwJxA3OGOLCGB9aiMo7+4WfOAyvhNNYX4d5e lSsUw+dwqzClinpEoTSvhRBxg8mN1oJ33o+UfcDA+17w/pCHldkjHpif X-Gm-Gg: AfdE7cn1XLsREZM1aOTug873A6ndSCwAKUHRiwAqSiwmr6EGuyb4vn/AJfZbeN4Llmz r8I9KRYzgoM8pJLFMcJml3Aq0VGyfeP/3L/9aquRK/JV5vC0SuE5NFK3Q7LxRzJYpQou1oiW7Aq ISKyeAXpwsd5ASrhYAok1xoiC9YZOkz/Xa5fMJVLvySNmlC88pcjiuj/+ewntxSLbHVUsTpSvCv xPcr79I4xU63NMi/5wRbQ2A8QW6AjOP7Z8xPcfjFA/BYwKt2C6M+xB0YO5vgcjLAsLSls+YvKtq VO9AFzdzQUE5A0awqFZg5LWvdTLevb8lfCgw0A1/Xh9U5viXq7fsRXfTllikR35QUhDsZzRBG8t yVqN6TbVALX4+XEbppSxyz5g1SXF0SP7jj2CFnVLWn3StW/r2SwhFNIzLDF5V8z317IpEC+BZTT 964f49c9g2xXfS4/MrNV5tNjjfcMOwDvQzNu5/VLMA/Iw= X-Received: by 2002:a17:90b:184e:b0:37f:9cdf:f0ad with SMTP id 98e67ed59e1d1-3829f9e3ecamr3875517a91.28.1783187647012; Sat, 04 Jul 2026 10:54:07 -0700 (PDT) Received: from localhost.localdomain ([49.207.223.101]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f39e07e0bsm15588749eec.30.2026.07.04.10.54.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 10:54:06 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, niklas.soderlund@ragnatech.se, mchehab@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com, jacopo.mondi@ideasonboard.com, Biren Pandya Subject: [PATCH v3 4/4] media: renesas: rzg2l-core: Add missing media_entity_cleanup() Date: Sat, 4 Jul 2026 23:16:43 +0530 Message-ID: <20260704174638.66302-10-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260704174638.66302-6-birenpandya@gmail.com> References: <20260704174638.66302-6-birenpandya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The remove function fails to call media_entity_cleanup() upon teardown. While currently a no-op in most cases, calling media_entity_cleanup() is an API requirement for entities initialized with media_entity_pads_init() to prevent memory leaks. Add the missing media_entity_cleanup() call in rzg2l_cru_remove(). Signed-off-by: Biren Pandya --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c b/driver= s/media/platform/renesas/rzg2l-cru/rzg2l-core.c index 3c5fbd857371..84d4883e2fe7 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-core.c @@ -312,6 +312,7 @@ static void rzg2l_cru_remove(struct platform_device *pd= ev) v4l2_async_nf_cleanup(&cru->notifier); =20 rzg2l_cru_video_unregister(cru); + media_entity_cleanup(&cru->vdev.entity); media_device_cleanup(&cru->mdev); mutex_destroy(&cru->mdev_lock); =20 --=20 2.50.1 (Apple Git-155)