From nobody Sat Jul 4 19:59:53 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DE525B099 for ; Sat, 4 Jul 2026 17:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783186295; cv=none; b=iimLNPL88XmERg+iy5i7gqTRHUDq3vNUJhub3zOb+2XKHVovL9cATolakuluE7FI77RZ1GekFtBd0Fh5fq4F6v7VMJDzhCL6RhNKXBGXNPcfcn38t+Iadg5oOtrmjP4bKQOGXnGhnruDfNcbO9qmJp7K7v2Q9mzo6psmCTBpYoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783186295; c=relaxed/simple; bh=oMIoA9y2QwSIaP74LDSPSwPxm7m3CTzwpbsp1vWNVm4=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=gQvtHmr4uV8U9Asrdsc166CvC12g2/6WUZZL3RM3vW5Cx4rX+/wPl4XfUOmjn3b7q3JDh02d6oMKuyGgv9oTSaKoHza6qzzB6bDHTXJ6Dq7D7qrT6SvR3E6xEiChUSVoRKqXFIj2PYBpSbnL0AA309BHIRjdgEugaR08OgtEl3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O1hfn4YI; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O1hfn4YI" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cae134bdc8so7478245ad.3 for ; Sat, 04 Jul 2026 10:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783186293; x=1783791093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uGW3vnuOQowUku+yOKABC0SiawHjWOple2z61d4A5zU=; b=O1hfn4YIofHk/DmKspm0NbR+c6T9MVqMQ+rN2ClBI5A5AASLWPXNLvtaq6KZ+L6HHd Jwj5PkgsxGEMEAFkJTU/LdSWkB2zZLx33wbejZ2psahOub1NQSj3mf6CaX/1D4scBKzV Sc2SMoEeEHPAseFLSDLPZtHdFGwohp1UQOtLWSMLsAHezihpWfI3QbVIBcViPk8RgVLk jDdAMVoR8vn0cwddOABD5jwXY1dflPMa0qnq1SZ5y8ghs28AWISAzBkWovegWLF8lMiz DbUprNcHMyxyhCR4w7j7Zc7Tf0MXoxJshRPr/FZDYwW2hJKtKwZQkIhxH1foiwfuOtgq aMsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783186293; x=1783791093; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uGW3vnuOQowUku+yOKABC0SiawHjWOple2z61d4A5zU=; b=hDwV1PPrk4w4dDs7juo1XTzOnvny0zZRhhDW1kt1VJrzbhuZ3fqgwd9IaNG2OlwszL jCcroi1yhO3GY75Ks7u9jlyFQJJkpI/Lynp4z238rjQvhVMZV3GuKM41NFxPw8t0IyOi M3RQMEgFsmPyHsNTtTBcgqTcWbTkWpqF8ln1itB9lu7MOvEDSdRH6mJG+y3J0Qa1fHAf l4v7Q7Wc4YPlsfhUmnmtqvqtfijfUdaBoCm/ApdbAtQVKxdj24l6IoNuqwGuiZdmig0j qydOo5mn833LbHwRfLXVfaI2pRH5xegBEt2OtyKkBAtcIXuXNHjqfq5i9p7E3HXoJmv2 P3iQ== X-Forwarded-Encrypted: i=1; AHgh+RohB6JllJD05mvgbGEikhcX3C8O61yn8GehmQaNKw5KilhYC6SXWwpFnR3Cug8y9HiE4gYE6ct6R6POpGU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzmo736/wS/Luw+UELhYzyeTGaAiTeUcIgDrNxVLn91rFCpwC5j xLlNE4J+ttghjA/K6mnJ9jEsN0+aG2pHlhBs3vZITr5Ecc8I72456xM+KBqtCmHUKiU= X-Gm-Gg: AfdE7clxpHx+lDZ012Bi3ZTqxmCRHAJkloELs3bhysjuKLS+7xEdGoInKoVYbIFXgM/ 6HrtKwQCwKTx9KYcEsSzB4gSuza9jT0rJT0jt1ZBMMD34zOBquxbKSl8qq7k9rj9nfkG1H8N7IQ +Coj74gk0aDKfp/1gsnebrxmOKUnPLXl7gpvL7E+6k5db25JQ+VXOR9OS+apChsIaW+ZUEE6Kun gmPybz6xmbEPWVF5p2aUhJL3k1UuHTjlalAczPmJ1QKH9N/gUBbSxk3OaIodmVOiRCrq8LmoSsU DhYFSoOKXlTwGei8VjzPV20UUj/TExJONFNMhagDPJlESCzv6riVKXwDKaHvdHdnYm2yFUQeL1K rgs36LI8Le3tdHxFPUrScm4dV6Bz2bU4SkNXyhhY7ORJ/uwAWq50rkCxmpzTGv5lFLR8y4KBvH2 wR0w== X-Received: by 2002:a17:902:e74f:b0:2ca:ce92:6e44 with SMTP id d9443c01a7336-2cb97e58139mr41657465ad.8.1783186293171; Sat, 04 Jul 2026 10:31:33 -0700 (PDT) Received: from lgs.. ([118.193.39.55]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad71328d8sm25082305ad.29.2026.07.04.10.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 10:31:32 -0700 (PDT) From: Guangshuo Li To: Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Nicolas Dufresne , Guangshuo Li , Johan Hovold , Marco Crivellari , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Kees Cook , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] media: platform: mtk-mdp3: Fix SCP device refcounting Date: Sun, 5 Jul 2026 01:31:19 +0800 Message-ID: <20260704173119.254975-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mdp_probe() first tries to get the SCP handle with scp_get(). When that fails, it falls back to looking up the SCP platform device with __get_pdev_by_id() and then reads its driver data. The fallback lookup returns the platform device with a reference, just like scp_get() does. However, the fallback path currently drops that reference immediately after platform_get_drvdata(). The driver later still calls scp_put(mdp->scp) unconditionally from the probe error path and from mdp_video_device_release(), which drops the SCP device reference again. Keep the fallback reference until the existing scp_put() call, so that the fallback path follows the same ownership rules as the scp_get() path. Fixes: 8f6f3aa21517 ("media: platform: mtk-mdp3: fix device leaks at probe") Signed-off-by: Guangshuo Li --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers= /media/platform/mediatek/mdp3/mtk-mdp3-core.c index 8f4da4cf55d2..121b1006ffdc 100644 --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c @@ -294,7 +294,6 @@ static int mdp_probe(struct platform_device *pdev) goto err_destroy_clock_wq; } mdp->scp =3D platform_get_drvdata(mm_pdev); - put_device(&mm_pdev->dev); } =20 mdp->rproc_handle =3D scp_get_rproc(mdp->scp); --=20 2.43.0