From nobody Sat Jul 4 20:00:20 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26AAC208D0 for ; Sat, 4 Jul 2026 16:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783184392; cv=none; b=RM8ioNQqSi3s4mYunq0NpcccwdTDvesd/Rqj8yFhDEzHpEFBFejJYfarPdnrxls4Rqk9jyWGKIKDPpdBl5jh6Zzl8Yju2OQwlpTTOQ6GDuPyyxTh6O4G2/wskA0I1kXlULCPcGowLLsejLJelBNW6J+Qui9wTXgtJ0ywhiizN9c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783184392; c=relaxed/simple; bh=HEVVKRRtFEK07bdqaL55pH8VifBeCrrNWeA6YU2WtVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hxZNvfZpGT11Mn9V4/5wx9qZ4KhRCQwz1sL9YtftTTe8oCrgcVlesR0c6pPLAZMj6XXcnfEmupuD/V5E9Sifrx/BMku0MHJ6eelOPgPCYpnawgp746ripEqkOFYJDI+oKoW4ls2673E0clP4ayjax/WeCfozuXWdSfnWZXgW0fE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H26nB7E+; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H26nB7E+" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ca1479dfe0so17998845ad.1 for ; Sat, 04 Jul 2026 09:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783184390; x=1783789190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pGYt9Kdr9O3QYlwJbWJSnWPxgdY2R3nu6CurxtPWbAc=; b=H26nB7E+AnaHwWyZT60vLprH0j/d+0skSP0P0ke5qF9Wv4B2EiXkab7mGzEuDCftx6 bL4O2oPcZXm5efGUtGrWTL+94PMLbK3rTGCT1+deX9o3oM8RH4h5rC4BCZIgBUUxp7ke klIqfKtf2EkWH8U4X47RM7QrqtTdh32LCKPFSCLLVlPdphU8D+NwuKwUXBVbzEfNu5yp H1m5qms9al/cbl2uSWPqo3txefleX2eYDJIfVaKrtMEzDEasdk9lcv179cxOTrVKbIa/ szcEdW/HdLBMPhE2VYxVb217DYs++OEsZWyDlsXlAkINEYUf18kurKt0NKFWj6ocZ8yO qH0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783184390; x=1783789190; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pGYt9Kdr9O3QYlwJbWJSnWPxgdY2R3nu6CurxtPWbAc=; b=If1q/9EsZ0YuLuFFvyDiMPjlaWLQXcdJ6MFwgjs5/90lO2JRTyu3KmHoJZqY9KvMIv hCSmBVJJ1gOofDeNJHkNeMoCm6kvMvisTKat9N5iPZuq6k9BRsVk/wDuGHRrGYbX/zXJ 2VwnBTAD6sSCSlv3pbo+wI0/RRyA5RA5pFO7qYHDDHn6XPoVyN7d4/PGqsmkJ09COgO5 zlhR2lO5PT6Sq6wmN0Vd8GF8z4/oV4mQIIumxT4cwR5+2lg+1D+eUDCssKh2pPaveuc+ BUlUzRrV7le4R5UmsqEH61yTLPkUT/Nvnf3lP7RRmBdHx/n95d7N+c39pRGnBCw9fvvq gmtA== X-Forwarded-Encrypted: i=1; AHgh+RqxQ+s7pxxXl9bXM7QsZCDn12+9bDbF7WNAVwK5Q/j87MnA8DTFBIqAxszn6g3VoGDFp9EPocg28lSkkP8=@vger.kernel.org X-Gm-Message-State: AOJu0YzzV0Jw3cQiHTXCou5lng7YD3OGHwRxeRf1aMsPaCnJMPXkKXXF RtJ01o8GysDmi27PMlQWCgGdwgLYhviRP+xbVHldgVensnUL0WpzJ11Y X-Gm-Gg: AfdE7cmWdi23FOatwYtmA2gx4udQMr4YhvMnrwkzajABmqXtu8FG3sM8hjOxspbFqb5 ewAq7wkriwtp1L4iyshXBWPfipEwq1kXgkJLq6gUuk5ersBCWny4YFCfqn3jLmy19OG7Zy74znD etqdx3zsfuQxmO7ztDpomaXYAll9r7BYSn1zySUN5wpkR93KfjA7v2a92XUEMmp53rt389Y9006 BVqBttShhYU1ybqOZM28HYo+Mog9v4Zd19B6kg+Ggs5giZrKCN8RosK4Jsk55YBMCfCD/Zg1apm V5DHn63Qmimm83YHrwZ+++g0jMyyrqLiwm6eYmPUDJfYVSVXF5q9L3n1sj2a/DNE0kluwMvIKGb GdnSj8+8RZKDD+m/xuMvPQ5jSNWGctUz6HpRvR3QXFYWLuCLOm6GSFdqgmPKYqaN5fm0DB8E= X-Received: by 2002:a17:902:c952:b0:2ca:1479:d9dc with SMTP id d9443c01a7336-2cbb9e38f0amr36956325ad.12.1783184390385; Sat, 04 Jul 2026 09:59:50 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::f280]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cad789cb15sm24418075ad.80.2026.07.04.09.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 09:59:49 -0700 (PDT) From: Guangshuo Li To: Vincent Mailhol , Marc Kleine-Budde , Greg Kroah-Hartman , linux-can@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] can: usb: etas_es58x: Fix RX buffer leak on URB resubmit failure Date: Sun, 5 Jul 2026 00:57:17 +0800 Message-ID: <20260704165717.248880-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" es58x_read_bulk_callback() resubmits the RX URB after processing a received packet. If the resubmit succeeds, the URB remains anchored and will be handled by the normal RX path or by teardown. However, if usb_submit_urb() fails, the callback unanchors the URB and then returns directly. This skips the existing free_urb path, so the coherent transfer buffer allocated with usb_alloc_coherent() is not released. Reuse the existing free_urb path after a resubmit failure so that the RX coherent buffer is freed before leaving the callback. Fixes: 5eaad4f76826 ("can: usb: etas_es58x: correctly anchor the urb in the= read bulk callback") Signed-off-by: Guangshuo Li --- drivers/net/can/usb/etas_es58x/es58x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/= usb/etas_es58x/es58x_core.c index b259f6109808..da12a35dd2f9 100644 --- a/drivers/net/can/usb/etas_es58x/es58x_core.c +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c @@ -1476,7 +1476,7 @@ static void es58x_read_bulk_callback(struct urb *urb) dev_err_ratelimited(dev, "Failed resubmitting read bulk urb: %pe\n", ERR_PTR(ret)); - return; + goto free_urb; =20 free_urb: usb_free_coherent(urb->dev, urb->transfer_buffer_length, --=20 2.43.0