From nobody Sat Jul 4 20:00:41 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1A0A26B755 for ; Sat, 4 Jul 2026 14:47:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783176447; cv=none; b=SJxUhm6tFsTtfdPlz9LFPkUOJ6BJiZhupydVxL2ROjC5bpO387O4R2dXUQcoeHPT2eK0OAEhm/CrvQwpdHkVWRkXGLZuWqCg9dzaUwhMg3tu96Jlbaw9YK8gSS0grjzvMlRKFek5e/MdRjF907RSDeBcCOva4LzTnNJ122Hg9Uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783176447; c=relaxed/simple; bh=WfMU2urwJqwt+ljkL3l90nyQNyUWmMUFUVbvWRyAm2s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YIfY/i12fUPzljWHR0vG8ehub35fLFk1/o5mDmsgjH+EHkrjxQnKZB0r1LX4sYSl7usRKx6WDN0QzuOF+m/hXEBydbC8TcSZiZtlwQymmhEB3j7WFGFFLmQIOGq2GyXQADEdVivFVaSQrr72FtYO1sPYXaWdINoRqYlb63jynfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LZJFcthH; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LZJFcthH" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8478a25f268so997398b3a.2 for ; Sat, 04 Jul 2026 07:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783176445; x=1783781245; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=q/toZW9ACpEDlU3/MZ7E+GMiXFZ3Ph30hMbw/9t5kqk=; b=LZJFcthH1MjEBKq9EyDWZJ1zmd/nKQERynnnNg1ZMz6YOISDLULzfVvqS1uwtqMLMn 1YYxf6AqgM1/K+G8o78Jl4dXoAj2aVlGEBQCibOOvY9veAATBNSLaVBAwk87O7YnfKq1 xwlKIAhM7Kto1wGu4MDzrPNz4oKdfah3ab3R9jMxKrlTkQRhrDTxO4DP0T3m3OBBBBje ET2djXwRWWgFPWZ6YKp9mzJZAOO82EbQRX/rq41JFBYaXv0V9pSbdkSq+BcgJ1u+mRrg TVLghgUv5cNWo+hmtkrufP/JfsGrCaAJ7zokJA6jIR+RM80RiMY0dYoAdDm3F5ADYe+0 44TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783176445; x=1783781245; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q/toZW9ACpEDlU3/MZ7E+GMiXFZ3Ph30hMbw/9t5kqk=; b=IqXh0sasVvM3GlUQwjDt62jz2NDiuJIXUDydlG3yjYhCS6Q/Jntw8vhQuvWTikhVZo 0SgCKCjwRL97KHjmVRwbznIazUIugyUfpneRFb77ntG2jAV8d7HPXUjUN/gYG3+RZC7O tAti0QdkCvZ7la3sp9Xe8n7joRTbZijgUeAWGzJDHzDDZQsnQrBq/DSZcFuHVriZDbVn dcwTnuAH7r2RW9bDcV7pL1smxcfkqGr6sDQaUXePmqULu+6WmwfgVS8k0Ibciqg40oJn HmRtmHm7DOvJtIVOVeNdyAug6jIU3yOCYqOtFpk2X/gf0CnwiM6+9Cl6gwk8qGo551Nm TMbQ== X-Forwarded-Encrypted: i=1; AHgh+RpkbpDABl21JJ418Xziqqia1nSgaSOL0waOnF0i4YCjiQa5lRmu2TD11LCeK9eAFAJx10Mw3dNVOOzAyZ4=@vger.kernel.org X-Gm-Message-State: AOJu0YyvFwoTm+3/sqsa3GSdmw9l3PrAOrn/LcFXtjlVuIKbGYNq3bdI i75Ow3D7pqnEvV8BepA49s6slxiSlNbXSDcul4wAnXeB0UoIk3D4uN3/ X-Gm-Gg: AfdE7clTLGs7gN28qp3KIXUyMc9uyzm/DFU903itRqm3Yb4isq1ZU1Q5eUHuKDcKZuU pPkqy8WyE40cc88XkX8ibnDYKi0jXuVjt7q9uOGXmlIPp6yat8KfT/XkBPWQ/cPCqJRfKSFXC8c gpAI0gmjMWb1awoWU22zWO1NOyyo2JTIGXznuWmai6+UlyBNf7I9YrvTUEEOpDPo6I4i56kNmnY C+ie5XxS/j9M2WHnDgGNtglCvrKiXKEj/mrFLFEyQwW7s7yPHxYIVDKhFoTDbZ6ZIPtdYqTA0JD DWyQ6SHJo6LqiWHgywg/FFU+LtrmHaBe3FMB37EYS29SQ2X1sjIpuwxDtQTDUPKfuD5vZgbRvaY TGXbH9z3yaB5xwmwIp8XykFL7zBvtQdHdTNiSjW2O/p5IjMPtg7MvtvGOOJi575nxjPX+iyOpBO eNThqG7H/0QQ== X-Received: by 2002:a05:6a00:8d1:b0:846:169c:d815 with SMTP id d2e1a72fcca58-847f6fa81f3mr3617443b3a.60.1783176445109; Sat, 04 Jul 2026 07:47:25 -0700 (PDT) Received: from ubuntu.. ([2405:201:8026:213e:8cdb:2215:c871:e5f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6dddf8bsm1315445b3a.61.2026.07.04.07.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 07:47:24 -0700 (PDT) From: mdshahid03@gmail.com To: Namjae Jeon , Hyunchul Lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mohammad Shahid Subject: [PATCH] ntfs: dir: use kmemdup() instead of kmalloc() and memcpy() Date: Sat, 4 Jul 2026 20:16:54 +0530 Message-ID: <20260704144654.126437-1-mdshahid03@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mohammad Shahid Use kmemdup() instead of a separate kmalloc() and memcpy() pair, simplifying the code while preserving the existing behavior. This issue was reported by memdup.cocci. Signed-off-by: Mohammad Shahid --- fs/ntfs/dir.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ntfs/dir.c b/fs/ntfs/dir.c index 4b6bd5f30c65..df94603ec102 100644 --- a/fs/ntfs/dir.c +++ b/fs/ntfs/dir.c @@ -959,13 +959,14 @@ static int ntfs_readdir(struct file *file, struct dir= _context *actor) */ private =3D file->private_data; kfree(private->key); - private->key =3D kmalloc(le16_to_cpu(next->key_length), GFP_KERNEL); + private->key =3D kmemdup(&next->key.file_name, + le16_to_cpu(next->key_length), + GFP_KERNEL); if (!private->key) { err =3D -ENOMEM; goto out; } =20 - memcpy(private->key, &next->key.file_name, le16_to_cpu(next->key_length= )); private->key_length =3D next->key_length; break; } --=20 2.43.0