From nobody Sat Jul 4 19:55:02 2026 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E1827732 for ; Sat, 4 Jul 2026 14:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783173673; cv=none; b=uStgLacsadBkcwUYAUGMVoz29ev4wO5Q1qbwyGy928ceL81zJ8J664BnaxsQ50k28imB6TGw9OCCqVFs+iOGKVfU4zM/EuwexWDrGQWa3sCLUoc37Mf8klhv8Rf1mmAzzbF7ckAaGJZ6K8YS4ksY/A5awQQasJHYo4u+dJmjrFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783173673; c=relaxed/simple; bh=X9dhOW7szVP4R7YiwC+ooewHbP8bEQ5HGQ+9OTzrZ5o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dCmACMAg87oa4rAHVatVMH6YsX/ro7i5Iu6OIabijpasID5MnzTQ+w5EEgnEGLtqCURq9ti7kEA42A9D5IrQHca8JOOduEl1RIgbduj+VpTuOFX8TE9iN/YZVB8wcnpGQLQO6odcdhjfjn5IjgePRTJIm6Czq3hVTzvlNb3Qmfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jgGGSH3p; arc=none smtp.client-ip=209.85.208.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jgGGSH3p" Received: by mail-lj1-f196.google.com with SMTP id 38308e7fff4ca-39b14a7e53aso14068291fa.2 for ; Sat, 04 Jul 2026 07:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783173670; x=1783778470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QoW6wy5Ibs/c5PrDFE7Z/Vk7E0hnNjlbrEMZdtHLRLk=; b=jgGGSH3p2pW5QwBe/CQEwLXvtwJdahMoNi51l3ZAgOW2rabCGnhPc6pt7xdp+Tul2h nae64dJSL89s51MmTyJqFYByi5ME9j8C/Q0ChcAN13CH3VxJJrZJhs68SQKWRqJpcie/ vEvS13rCuow0rE4/nTn6eOpONRAMBwuEEEjxjd8mO6UeQeL/1wZdQzZQNyP3lnyG8+uz 1BQqXWjBDZuyBacu6BW/oqBc+wJbrTn/JP+C2OSkDmbdY+d+rUUzGGCQefUjQt1M/Q1l G1+e7jzEZq9qL0HLtMpOpcUpKzXhlR/rnyhbeQTHoYpCIMlu1Bp0YkiYVbcx03DrMjUP NptQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783173670; x=1783778470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QoW6wy5Ibs/c5PrDFE7Z/Vk7E0hnNjlbrEMZdtHLRLk=; b=rraBM1CBFnHVMfERa/mFWyt7pdA1WTbzYqUq8ad6cPhKF8CLwU2TiqH0QNXqBNJxF/ n0UsaDJAyLVbUi1zrZP0YVdpENXeiJy1a6ISydvXG3JGOcKrT/2YmGHvd3SMs3d1dzcY b/69S/7agvDl3lSWpPWoxHfFoSBazP3LDVwlQ4fqFB5mM7p7+y5ffNaZWyooLDYGKdro XSKX+u4vRVx1A1tkoa8XuALF/pHmeqr8Yx9pJGnyH/ogK+RhDBQxoCgTSpR8lsPgslVf Z+O3CGMp0ceouliO83rXHbAUpkpZUMbrjqQRuuqk1wbh8wQimQpRaatha29quylN0wEU Nm+A== X-Forwarded-Encrypted: i=1; AHgh+RqRyTYMnTB50XzHGAP9JrOYUBOeeGIoWaJDbqQN+4rR2M9gT2rUED577QS9BdkgDj4Ta+FhSRaIX2k9Lkw=@vger.kernel.org X-Gm-Message-State: AOJu0YyMDCr40DernYSSckchJ+BwL4qO9LqUXdLJjr60rK9y3IsBLFrL ovzAJ2BPZ/JF98SLuGIBHNsf1vNqVPlDCmyeYBxxd4DDiM8Q6twDmRMU X-Gm-Gg: AfdE7clO36GTkcwWmlME48oy9pmr/zAkPUXuW6Rkhj6YqN8haFpkzPdz0b1jnoVPkii uH+4EQuWNKMKGAIyR+MyASQqlZPNfFVBjOPiM1oNEDzU5pczPjcebFi5PLahHLWd1Wqd0/NCMBY eKkiGAWIsz+ivfkMgsjbIBW6jonhT4KjCZVoz8PX1beglmWC89ihMsXLZNgdZxc0JcOqtI6OGtN A7vZCZqwOw3dgDjvpRlC3u7bSq0FjSuAIHVaBJWk+VkbOaJ2kx+0Or25/5P3gLjh0XFww1D6vQS z8n2OCA5czn4/yTvMsuRZsuOgA4WMMWWQmSJ8c+knD/EiN0hZlxm3mw1rSZ1U1j5KKdv+o/b5eF akCProHHFpJr6yU4j+9SbB1z+CPLqY1fTLKxtvMegXkuAioCAYCdbR88+68ueBRux2zPujCljRE N7oELNhtn9ZcTqtfW7FKw= X-Received: by 2002:a2e:a107:0:b0:39a:cfea:f17 with SMTP id 38308e7fff4ca-39b53c9e119mr7914081fa.30.1783173669522; Sat, 04 Jul 2026 07:01:09 -0700 (PDT) Received: from myhost.localdomain ([89.253.17.10]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39b4ad18b5asm8604601fa.9.2026.07.04.07.01.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 07:01:09 -0700 (PDT) From: Ruziev Miraly To: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: andy@kernel.org, sakari.ailus@linux.intel.com, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ruziev Miraly Subject: [PATCH] staging: media: atomisp: clean up atomisp_v4l2.c style warnings Date: Sat, 4 Jul 2026 19:00:55 +0500 Message-ID: <20260704140055.88080-1-miraly.dev@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings in atomisp_v4l2.c regarding unnecessary ftrace-like logging and redundant else statements after return. Remove dev_dbg() calls that only log function entry, as ftrace should be preferred for this purpose. Also, remove the unnecessary else block following a return statement to flatten the code structure. Signed-off-by: Ruziev Miraly --- .../staging/media/atomisp/pci/atomisp_v4l2.c | 30 +++++++------------ 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 812230397..2d72467eb 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -345,8 +345,6 @@ static int atomisp_save_iunit_reg(struct atomisp_device= *isp) { struct pci_dev *pdev =3D to_pci_dev(isp->dev); =20 - dev_dbg(isp->dev, "%s\n", __func__); - pci_read_config_word(pdev, PCI_COMMAND, &isp->saved_regs.pcicmdsts); /* isp->saved_regs.ispmmadr is set from the atomisp_pci_probe() */ pci_read_config_dword(pdev, PCI_MSI_CAPID, &isp->saved_regs.msicap); @@ -400,8 +398,6 @@ static int atomisp_restore_iunit_reg(struct atomisp_dev= ice *isp) { struct pci_dev *pdev =3D to_pci_dev(isp->dev); =20 - dev_dbg(isp->dev, "%s\n", __func__); - pci_write_config_word(pdev, PCI_COMMAND, isp->saved_regs.pcicmdsts); pci_write_config_dword(pdev, PCI_BASE_ADDRESS_0, isp->saved_regs.ispmmadr= ); pci_write_config_dword(pdev, PCI_MSI_CAPID, isp->saved_regs.msicap); @@ -468,22 +464,18 @@ static int atomisp_mrfld_pre_power_down(struct atomis= p_device *isp) __func__, irq); spin_unlock_irqrestore(&isp->lock, flags); return -EAGAIN; - } else { - pci_read_config_dword(pdev, PCI_INTERRUPT_CTRL, &irq); - irq &=3D BIT(INTR_IIR); - pci_write_config_dword(pdev, PCI_INTERRUPT_CTRL, irq); - - pci_read_config_dword(pdev, PCI_INTERRUPT_CTRL, &irq); - if (!(irq & BIT(INTR_IIR))) { - atomisp_css2_hw_store_32(MRFLD_INTR_ENABLE_REG, 0x0); - goto done; - } - dev_err(isp->dev, - "%s: error in iunit interrupt. status reg=3D0x%x\n", - __func__, irq); - spin_unlock_irqrestore(&isp->lock, flags); - return -EAGAIN; } + pci_read_config_dword(pdev, PCI_INTERRUPT_CTRL, &irq); + irq &=3D BIT(INTR_IIR); + pci_write_config_dword(pdev, PCI_INTERRUPT_CTRL, irq); + + pci_read_config_dword(pdev, PCI_INTERRUPT_CTRL, &irq); + if (!(irq & BIT(INTR_IIR))) { + atomisp_css2_hw_store_32(MRFLD_INTR_ENABLE_REG, 0x0); + goto done; + } + spin_unlock_irqrestore(&isp->lock, flags); + return -EAGAIN; done: /* * MRFLD WORKAROUND: --=20 2.54.0