From nobody Wed Jun 24 22:06:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44FD2F5487 for ; Wed, 24 Jun 2026 11:26:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782300363; cv=none; b=RWQmOSeF1r0Stedf5kAKmUlrfx7YbKTC7H/xg59JYtFZn/eH6K6of7liEF7V14fnLBbVyFiboEIW7UXHmiL3ieQZXFFCXK7jyrILB5neipjQkYJfdP3hDWaH9xQXZs/p1cWrVFyRRRZGxOj4m7j7RxWrCehQQ2NORnHVKMP2rNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782300363; c=relaxed/simple; bh=UlqEJPDnLANpGaK/dBHE8jaHyoG1D+SwqpkXfmgtD/w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=gxrxezqTkiwsmucYhs5qyC1mdHEjZVvJgp7qOVdKrNtOneCAV9HA7w958oLV8wTZHMJ91+knuIFBrcaAyCYtlJV18p9OC91iG44MXAB9VUSp2LWE3x/8yEb10wDCirlDbLSj5iIsiZyGv2LzE5pJ+8CjHYQhe4MughsIIA9U2cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BsbNXGri; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RVFycnjY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BsbNXGri"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RVFycnjY" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OANXCb3134734 for ; Wed, 24 Jun 2026 11:26:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=90ylR7uLuQk3JCNdNWJu/F 0ziqsUiDApUuvh6r7i4ho=; b=BsbNXGriNbXYvFXihowILrbpb9PohztNG5brKK 06sAMARl7obJAblPvVBH3QYedMtEoPbA6fzuKIlBX2AdXjcUb35QWGtyCnRHQ7bg julHx5Vt56ntNr3S/MZNyAuJjItzpAwC3b2U0FdVMMRUAUF9L2uvjwxZJIxECMnd CVfBJCbh7RCOQL2Nv4Em7QPITRdOYXIbJmMwlNHor6S0gIQWU032xG3cnFTDTfna 8ecC84yXN87iGOpu/4oLOvnVq3tfgKWQvcH8rYatfHY2nYBynTmT82NhiPD/S5Qw iN3uOXnF50/Rl4QhNAN9bXNE4/yTHpIpGQj/KA2Lt9B8AVEg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f05ajj24j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Jun 2026 11:25:59 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-8422ca754d8so782180b3a.1 for ; Wed, 24 Jun 2026 04:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782300359; x=1782905159; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=90ylR7uLuQk3JCNdNWJu/F0ziqsUiDApUuvh6r7i4ho=; b=RVFycnjYmmAAWYx+kiRtV50quk100eR7yH4IY8GBDjiu4nldVDX2m1jw2Z7cpI+w4u aWDkdKQ/rzb34AGFgArWAh71HcqiFlBQmMaAMrMYWG0u++DiwEx5RBEuMnStfIj+G5mC 8iaEuXhWFUMevkUiBpCGX3dhG3HJNdtrIhSc5GAjHHHA/sGAHfF6k+x0XmuYtrLMtRrC UMLuZFXHr1vqxlVQagl41djAwTbWiJNjpQH4xE/KMS9q8PWrrJBPfCjdfZD4NReIuy7L ulCcLjNIeSIkvZmJLVxSr3Un1hNGmLL9imY+S3Mo0ioonR+Qaa1THgabTLnGP5Feq6mg doBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782300359; x=1782905159; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=90ylR7uLuQk3JCNdNWJu/F0ziqsUiDApUuvh6r7i4ho=; b=YsAmbaRdnE8GTemj9c2/zJXCHVPSEWVXDh901Ur7+1MbbdiF3L62K4MgLlYBBORrV5 Yzr3uAd76ynNvf+35Qgw/WNd6COGRrCQqueSNrIxaYijY9GO3sm+9mm7J8rh/0i7yvJ/ ENrA/+a543n0mPx13HtJ9PFPCTRi7R7kPEMnkIu9XjW5Lqnp6Y32AN6aIzl8BcL64Yq9 9TPW/DID0loPl15NZ67jx34DUzZHIpIkzOc7vEKysMoZz9/JFEu/V+Ud4LRYaAMI/UDy iAHdytWxFXv9Ke41SbWheIws6zlYSD4LaIQYOMOJQVgfA5tNrUWrfmeBP+mMKPK7iOoI c0/w== X-Forwarded-Encrypted: i=1; AFNElJ8pi/T8fFU/t/w+qgHcCuQBi5HnoQOgoLogedTb0pBWbuVhUZflaliBvuSC3IHIrTgyAlEBrwpAMalQGqI=@vger.kernel.org X-Gm-Message-State: AOJu0YyggP+9b0zeETuZqYm52xPHVqQk4KTSaUMSzmmxxjUfCKORg9p+ IZxzUmTDL5teyQSbYH1VhJnueMarIhlvPtqRsINlNrJQH1lllyXcefCmP4L1QtaX7IVl8+AkmVh kG07nS1T3IEGDdux7j8fYNlfTecRTWD+y/c6bInLeSR1YVtE5kHnqV6M4VJ90g8R5JCk= X-Gm-Gg: AfdE7ck/AT6YLC4ScpADVliawVa0pxuKs0lZUgQY2Yn87mqBS/SuHD2d+UGA/zSIY4z vFdnrIOBsk7+n65cubW1B2MG/cOGYJFymYmJ1WIS6dRAxjTxC64JjhCjGoXddmkwedrHZn+adTq Q6+AS2YgzAQMMe3iVQxUt56Z09zcPvqG7RKaXSPFkaU8zoWn3xShIjpD5qzytEG50VMr+RKuz1b tSgc8rHyjs+AHRsys/7JVYhm3JNZ541W5K3d8SXq2o/ixuW1O5DkTyy6OcAFkaiYo4UoiA5+qfY Xjho8eXstMyYWFOpKsllvQB0viHqP/Ri08W8cavaLyvR+fgbXWu3nAxazZM9J8fapRL8G79BGOh U9ZuJVfnS/TaeOteF14i5PwoedXPj4DdINSKbKkesXSIudg== X-Received: by 2002:a05:6a00:a17:b0:842:614e:cc97 with SMTP id d2e1a72fcca58-84562535516mr24170693b3a.23.1782300358616; Wed, 24 Jun 2026 04:25:58 -0700 (PDT) X-Received: by 2002:a05:6a00:a17:b0:842:614e:cc97 with SMTP id d2e1a72fcca58-84562535516mr24170651b3a.23.1782300358097; Wed, 24 Jun 2026 04:25:58 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a3feb7casm2008122b3a.18.2026.06.24.04.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2026 04:25:57 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 24 Jun 2026 16:55:49 +0530 Subject: [PATCH v11] PCI: Add support for PCIe WAKE# interrupt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260624-wakeirq_support-v11-1-120fbfaebe59@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIALy+O2oC/3XQ22rDMAwA0F8pfp6L5Pi6p/3HGMNx7NVsrVO7z TZK/n1OoWSQ5EUggY4uN1J8jr6Q592NZD/EEtOpJohPO+IO9vThaexqgTBgAhE4/bafPubze7n 2fcoXGgR3vLUWtROkdvXZh/hzJ1/fan6I5ZLy733CIKbqw1ILaxAUKJfcowrMMXAvqZT9+Wq/X Doe9zWQiRzkP4atMLIyEoLQGAxnIDYY9WAkMNRLRlUGOi610Q0wUBuMnpkGmyWjp6O0BaumhbX dYMzMcFhhTGXQtd6FphW629oGYXbqe5YO1qOoQ7DBOONbvfbkcRz/AAW9U/QbAgAA X-Change-ID: 20251104-wakeirq_support-f54c4baa18c5 To: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Danilo Krummrich , Bjorn Helgaas , Bartosz Golaszewski , Linus Walleij , Bartosz Golaszewski , Rob Herring , Saravana Kannan , Linus Walleij Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, quic_vbadigan@quicinc.com, sherry.sun@nxp.com, driver-core@lists.linux.dev, devicetree@vger.kernel.org, Manivannan Sadhasivam , Krishna Chaitanya Chundru X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782300351; l=14207; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=UlqEJPDnLANpGaK/dBHE8jaHyoG1D+SwqpkXfmgtD/w=; b=a9DH3JxCM0QErgtZcdC8AxGVSeWrcPQNWV6jtzf19clxKUZIlLuq9SGcV4Ly2qXmyDHkWdrHu qhk0+gGRTmLAsCDOvbqm5d7Hb//yjQ+XwH/EP7g14nDGasoaYg4qwGx X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI0MDA5NSBTYWx0ZWRfXx5/GMuCD2h4Z rteLOPbtwDXFKe5jwVdsPhl/zOpEigTqjQ7PzNDUPUeK2bpDpkAE844Zj80xt9VSrkPkU0oVJ5Z CGcUiQZ5O36GtXolIhFY6Fv2/wSD5O0= X-Proofpoint-GUID: kAKnaMnpdZtms2fgXm2aGQFzrJAZp5IH X-Proofpoint-ORIG-GUID: kAKnaMnpdZtms2fgXm2aGQFzrJAZp5IH X-Authority-Analysis: v=2.4 cv=DbUnbPtW c=1 sm=1 tr=0 ts=6a3bbec7 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=NEAV23lmAAAA:8 a=Ikd4Dj_1AAAA:8 a=s8YR1HE3AAAA:8 a=bC-a23v3AAAA:8 a=KKAkSRfTAAAA:8 a=1XWaLZrsAAAA:8 a=K-mQ55XP2AAS2IO8IhoA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=jGH_LyMDp9YhSvY-UuyI:22 a=FO4_E8m0qiDe52t0p3_H:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI0MDA5NSBTYWx0ZWRfX8VTAvdTaNxB6 gkOEf5oYBxCqsGeZkwIIm89WSpaJ1rfXymTWtO56zZZasj7iT9/E+spXr9Wmm/hg4Mn3+eTfXC6 QNgdSCSwXzjRKrKNnwRqfXJfsz7fje8KP82WGQsWnlmeSvGdqpF33ypNwVBuaQ99V9VBzlAMa8N 7WDs9bNayiOjqEukcAnimtN3jjlfe96Uut0Hdipvh+izIOnQ5pU28RDiWpPWkx4g9rNFZTo0CUB 2Q2jl2QrWuTBvQombhlJanEJIp4Sz8OefgLvDSK3Pg6VeCCFKPcmPyfideXpm9ED0/rOswTCEEg 6EO+KdIuzvafPvuaVZ4ao9IVMSTlBxbnpMtaRXsyh7VBTjUjjMwqzhldw+zMza04khDODe/ocBs vQXe0o1x3fBVmFwik1E1K2kHw7vm8Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606240095 According to the PCI Express specification (PCIe r7.0, Section 5.3.3.2), two link wakeup mechanisms are defined: Beacon and WAKE#. Beacon is a hardware-only mechanism and is invisible to software (PCIe r7.0, Section 4.2.7.8.1). This change adds support for the WAKE# mechanism in the PCI core. According to the PCIe specification, multiple WAKE# signals can exist in a system or each component in the hierarchy could share a single WAKE# signal. In configurations involving a PCIe switch, each downstream port (DSP) of the switch may be connected to a separate WAKE# line, allowing each endpoint to signal WAKE# independently. From figure 5.4 in sec 5.3.3.2, WAKE# can also be terminated at the switch itself. Such topologies are typically not described in Device Tree, therefore it is out of scope for this series. To support this, the WAKE# should be described in the device tree node of the endpoint/bridge. If all endpoints share a single WAKE# line, then each endpoint node shall describe the same WAKE# signal or a single WAKE# in the Root Port node. In pci_device_add(), PCI framework will search for the WAKE# in device node. Once found, register for the wake IRQ through dev_pm_set_dedicated_wake_irq() associates a wakeup IRQ with a device and requests it, but the PM core keeps the IRQ disabled by default. The IRQ is enabled by the PM core, only when the device is permitted to wake the system, i.e. during system suspend and after runtime suspend, and only when device wakeup is enabled. If the same WAKE# GPIO is described in multiple device tree nodes, only the first device that successfully registers the wake IRQ will succeed, while subsequent registrations may fail. This limitation does not affect functional correctness, since WAKE# is only used to bring the link to D0, and endpoint-specific wakeup handling is resolved later through PME detection (PME_EN is set in suspend path by PCI core by default). When the wake IRQ fires, the wakeirq handler invokes pm_runtime_resume() to bring the device back to an active power state, such as transitioning from D3cold to D0. Once the device is active and the link is usable, the endpoint may generate a PME, which is then handled by the PCI core through PME polling or the PCIe PME service driver to complete the wakeup of the endpoint. WAKE# is added in dts schema and merged based on below links. Link: https://lore.kernel.org/all/20250515090517.3506772-1-krishna.chundru@= oss.qualcomm.com/ Link: https://github.com/devicetree-org/dt-schema/pull/170 Reviewed-by: Linus Walleij Acked-by: Manivannan Sadhasivam Signed-off-by: Krishna Chaitanya Chundru --- PCIe WAKE# interrupt is needed for bringing back PCIe device state from D3cold to D0. This is pending from long time, there was two attempts done previously to add WAKE# support[1], [2]. Those series tried to add support for legacy interrupts along with WAKE#. Legacy interrupts are already available in the latest kernel and we can ignore them. For the wake IRQ the series is trying to use interrupts property define in the device tree. WAKE# is added in dts schema and merged based on this patch. https://lore.kernel.org/all/20250515090517.3506772-1-krishna.chundru@oss.qu= alcomm.com/ [1]: https://lore.kernel.org/all/b2b91240-95fe-145d-502c-d52225497a34@nvidi= a.com/T/ [2]: https://lore.kernel.org/all/20171226023646.17722-1-jeffy.chen@rock-chi= ps.com/ --- Changes in v11: - Add device_init_wakeup() as client driver is not expected to enable bridge dev wakeup capability. - Link to v10: https://patch.msgid.link/20260511-wakeirq_support-v10-0-c10a= f9c9eb8c@oss.qualcomm.com Changes in v10: - As sashiko pointed, shared irq has plenty of race conditions. - So we are moving away from the shared IRQ patch and registering with dedicated wake irq only, as part of wake irq the link will come to D0 as the parent controller driver will be runtime resume first and then pme service will kick in wake up correct endpoint driver. - Removed device_init_wakeup() since it enabling wakeup explicitly, which is not intended as this should be set by endpoint driver only. - Link to v9: https://lore.kernel.org/r/20260403-wakeirq_support-v9-0-1cbec= f3b58d7@oss.qualcomm.com Changes in v9: - Call device_init_wakeup() only if dev_pm_set_dedicated_shared_wake_irq() succeeds (Mani). - Change the IRQ_TYPE from IRQ_TYPE_EDGE_FALLING to IRQ_TYPE_LEVEL_LOW (Man= i). - Link to v8: https://lore.kernel.org/r/20260313-wakeirq_support-v8-0-48a0a= 702518a@oss.qualcomm.com Changes in v8: - Moved the stub functions under CONFIG_OF_IRQ(mani). - Added the description of how dev_pm_set_dedicated_shared_wake_irq() works. - Link to v7: https://lore.kernel.org/r/20260218-wakeirq_support-v7-0-0d468= 9830207@oss.qualcomm.com Changes in v7: - Updated the commit text (Mani). - Couple of nits like using pci_err instead of dev_err, use platform_pci_configure_wake(), platform_pci_remove_wake() instead of calling directly calling pci_configure_of_wake_gpio() & pci_remove_of_= wake_gpio() etc (Mani). - Add a new fwnode_gpiod_get() API that wraps fwnode_gpiod_get_index(..0..)= , similar to devm_fwnode_gpiod_get() (Mani). - Link to v6: https://lore.kernel.org/r/20251127-wakeirq_support-v6-0-60f58= 1f94205@oss.qualcomm.com Changes in v6: - Change the name to dev_pm_set_dedicated_shared_wake_irq() and make the changes pointed by (Rafael).=20 - Link to v5: https://lore.kernel.org/r/20251107-wakeirq_support-v5-0-464e1= 7f2c20c@oss.qualcomm.com Changes in v5: - Enable WAKE# irq only when there is wake -gpios defined in its device tree node (Bjorn). - For legacy bindings for direct atach check in root port if we haven't find the wake in the endpoint node. - Instead of hooking wake in driver bound case, do it in the framework irrespective of the driver state (Bjorn). - Link to v4: https://lore.kernel.org/r/20250801-wake_irq_support-v4-0-6b66= 39013a1a@oss.qualcomm.com Changes in v4: - Move wake from portdrv to core framework to endpoint (Bjorn). - Added support for multiple WAKE# case (Bjorn). But traverse from endpoint upstream port to root port till you get WAKE#. And use IRQF_SHARED flag for requesting interrupts. - Link to v3: https://lore.kernel.org/r/20250605-wake_irq_support-v3-0-7ba5= 6dc909a5@oss.qualcomm.com Changes in v3: - Update the commit messages, function names etc as suggested by Mani. - return wake_irq if returns error (Neil). - Link to v2: https://lore.kernel.org/r/20250419-wake_irq_support-v2-0-06ba= ed9a87a1@oss.qualcomm.com Changes in v2: - Move the wake irq teardown after pcie_port_device_remove and move of_pci_setup_wake_irq before pcie_link_rcec (Lukas) - teardown wake irq in shutdown also. - Link to v1: https://lore.kernel.org/r/20250401-wake_irq_support-v1-0-d2e2= 2f4a0efd@oss.qualcomm.com To: Bjorn Helgaas To: Rob Herring To: Saravana Kannan Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org --- drivers/pci/of.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ drivers/pci/pci.c | 11 ++++++++ drivers/pci/pci.h | 2 ++ drivers/pci/probe.c | 2 ++ drivers/pci/remove.c | 1 + include/linux/of_pci.h | 6 ++++ include/linux/pci.h | 2 ++ 7 files changed, 100 insertions(+) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 8b18c4ba845c..0f5effe1d702 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -7,6 +7,7 @@ #define pr_fmt(fmt) "PCI: OF: " fmt =20 #include +#include #include #include #include @@ -15,6 +16,7 @@ #include #include #include +#include #include "pci.h" =20 #ifdef CONFIG_PCI @@ -586,6 +588,80 @@ int of_irq_parse_and_map_pci(const struct pci_dev *dev= , u8 slot, u8 pin) return irq_create_of_mapping(&oirq); } EXPORT_SYMBOL_GPL(of_irq_parse_and_map_pci); + +static void pci_configure_wake_irq(struct pci_dev *pdev, struct gpio_desc = *wake) +{ + int ret, wake_irq; + + wake_irq =3D gpiod_to_irq(wake); + if (wake_irq < 0) { + pci_err(pdev, "Failed to get wake irq: %d\n", wake_irq); + return; + } + + /* + * dev_pm_set_dedicated_wake_irq() associates a wakeup IRQ with the + * device and requests it, but the PM core keeps it disabled by default. + * The IRQ is enabled only when the device is allowed to wake the system + * (during system suspend and after runtime suspend), and only if device + * wakeup is enabled. + * + * When the wake IRQ fires, the wakeirq handler invokes pm_runtime_resume= () + * to bring the device back to an active power state (e.g. from D3cold to= D0). + * Once the device is active and the link is usable, the endpoint may sig= nal + * a PME, which is then handled by the PCI core (either via PME polling o= r the + * PCIe PME service driver) to wakeup particular endpoint. + */ + ret =3D dev_pm_set_dedicated_wake_irq(&pdev->dev, wake_irq); + if (ret < 0) { + pci_err(pdev, "Failed to set WAKE# IRQ: %d\n", ret); + return; + } + + ret =3D irq_set_irq_type(wake_irq, IRQ_TYPE_LEVEL_LOW); + if (ret < 0) { + dev_pm_clear_wake_irq(&pdev->dev); + pci_err(pdev, "Failed to set irq_type: %d\n", ret); + return; + } + + device_init_wakeup(&pdev->dev, true); +} + +void pci_configure_of_wake_gpio(struct pci_dev *dev) +{ + struct device_node *dn =3D pci_device_to_OF_node(dev); + struct gpio_desc *gpio; + + if (!dn) + return; + /* + * fwnode_gpiod_get() may fail with -EBUSY (e.g. shared WAKE#), but the + * actual WAKE# trigger from the device would still work and the host + * controller driver will enable power to the topology. + * + * -EPROBE_DEFER cannot be propagated here since pci_device_add() has no + * retry mechanism. + */ + gpio =3D fwnode_gpiod_get(of_fwnode_handle(dn), "wake", GPIOD_IN, NULL); + if (!IS_ERR(gpio)) { + dev->wake =3D gpio; + pci_configure_wake_irq(dev, gpio); + } +} + +void pci_remove_of_wake_gpio(struct pci_dev *dev) +{ + struct device_node *dn =3D pci_device_to_OF_node(dev); + + if (!dn) + return; + + device_init_wakeup(&dev->dev, false); + dev_pm_clear_wake_irq(&dev->dev); + gpiod_put(dev->wake); + dev->wake =3D NULL; +} #endif /* CONFIG_OF_IRQ */ =20 static int pci_parse_request_of_pci_ranges(struct device *dev, diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index d34266651ad0..9d9777fe099a 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -1123,6 +1124,16 @@ static inline bool platform_pci_bridge_d3(struct pci= _dev *dev) return acpi_pci_bridge_d3(dev); } =20 +void platform_pci_configure_wake(struct pci_dev *dev) +{ + pci_configure_of_wake_gpio(dev); +} + +void platform_pci_remove_wake(struct pci_dev *dev) +{ + pci_remove_of_wake_gpio(dev); +} + /** * pci_update_current_state - Read power state of given device and cache it * @dev: PCI device to handle. diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index e8ad27abb1cf..8633c093385c 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -284,6 +284,8 @@ void pci_msix_init(struct pci_dev *dev); bool pci_bridge_d3_possible(struct pci_dev *dev); void pci_bridge_d3_update(struct pci_dev *dev); int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_typ= e); +void platform_pci_configure_wake(struct pci_dev *dev); +void platform_pci_remove_wake(struct pci_dev *dev); =20 static inline bool pci_bus_rrs_vendor_id(u32 l) { diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index b63cd0c310bc..143b0bd35b3c 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -2775,6 +2775,8 @@ void pci_device_add(struct pci_dev *dev, struct pci_b= us *bus) /* Establish pdev->tsm for newly added (e.g. new SR-IOV VFs) */ pci_tsm_init(dev); =20 + platform_pci_configure_wake(dev); + pci_npem_create(dev); =20 pci_doe_sysfs_init(dev); diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c index e9d519993853..d781b41e57c4 100644 --- a/drivers/pci/remove.c +++ b/drivers/pci/remove.c @@ -35,6 +35,7 @@ static void pci_destroy_dev(struct pci_dev *dev) if (pci_dev_test_and_set_removed(dev)) return; =20 + platform_pci_remove_wake(dev); pci_doe_sysfs_teardown(dev); pci_npem_remove(dev); =20 diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h index 29658c0ee71f..649fe8eafcfa 100644 --- a/include/linux/of_pci.h +++ b/include/linux/of_pci.h @@ -30,12 +30,18 @@ static inline void of_pci_check_probe_only(void) { } =20 #if IS_ENABLED(CONFIG_OF_IRQ) int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin); +void pci_configure_of_wake_gpio(struct pci_dev *dev); +void pci_remove_of_wake_gpio(struct pci_dev *dev); #else static inline int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin) { return 0; } + +static inline void pci_configure_of_wake_gpio(struct pci_dev *dev) { } + +static inline void pci_remove_of_wake_gpio(struct pci_dev *dev) { } #endif =20 #endif diff --git a/include/linux/pci.h b/include/linux/pci.h index 2c4454583c11..4289b60dcc83 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -588,6 +588,8 @@ struct pci_dev { /* These methods index pci_reset_fn_methods[] */ u8 reset_methods[PCI_NUM_RESET_METHODS]; /* In priority order */ =20 + struct gpio_desc *wake; /* Holds WAKE# gpio */ + #ifdef CONFIG_PCIE_TPH u16 tph_cap; /* TPH capability offset */ u8 tph_mode; /* TPH mode */ --- base-commit: 840ef6c78e6a2f694b578ecb9063241c992aaa9e change-id: 20251104-wakeirq_support-f54c4baa18c5 Best regards, -- =20 Krishna Chaitanya Chundru