From nobody Thu Jun 18 15:07:25 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012033.outbound.protection.outlook.com [40.107.209.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078BC3D811B; Thu, 18 Jun 2026 07:48:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768899; cv=fail; b=JmX9c8tXG+ya4DVRxyTNdvx3KzLC/ntmI/xuLMgQu3hCwpNjmlBokV7xA9jVY+t99aKQg/oI20StVE8yCy4xSWjGfC25xP97JANYP3GUIZ/vi32IF1iG2GBneq9fa335De5/q90kurF/gH/iGN2+tyv0o14ekXR9PzdBEcFf0CM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768899; c=relaxed/simple; bh=LGKnFAdkb6N98ET9DKmAWo54KVVmT5vCd2n4+LYYZl0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X+vFqtcc3TpQgTLmqe1eLf+sjz4RfqCUJX5bpCK1nrwcngol9JLxhKAVs9GiRMZZgD2FNX8+8tLrAw7YIaIaOy5RdgSgpDXevx2jAMjrUXow93iEW7Bz8bBf5Hd52/OHrHwibZVil4/5Iv9Ozk0PrcczkMb0wm5U5WT8RobqAus= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=NlLP26SI; arc=fail smtp.client-ip=40.107.209.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="NlLP26SI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ce1TfK7zdBepGKolMqWwvvNFRBh6KeefrmNngtRTYifuCdr8qjnM1r3tdHa1M6lU2kwr8h1kS1J7DhyQQlcImaxF+yHRHudVKbAcIA36Ej4AawYGpQ9wxceMc2kikDL3O8TRrxSXlTStkc+WmBYbmax+2CZsGdxIMCWWNIHnZX/Eb+eEjVxmGXS7/357akw9BYSG2UCIlKDmTR81WTOtL3OHhbV27KKOuXJXiNrDhtWTGFU3dsMiuQMyvqXWIHOBsqMXLygdp2FBSWQxsbhMGPwPlucen+MT+oXqC88R69vYdSdyAys2+0qGxly9Uxo/xxkm5aOvNo5v3s3UP8iBpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tHzPPDV0YSruCMy4c0wKpJ6wRbzMjnXtBWJCH7OCHbA=; b=OXIAsqV8+hLUjKS55/A7JvkrfIf5cVUVUkKkjm/dVrhtTpNGDHhwl3GAMXJDVD36EHbPguzHOtY00dh6N9lyh96LR4D3LUQt5RmbOWyuqqpje3Cvn+uX4Kzbd4ng3NVGl/B1UxHFeCmkfFYy4vZv1fbrD4p7irHJCeXgvmWM4OZIYCt2KmGHpPnOjDx6nGhyfv1RDWcs0JcOxg+jIbnOjisgytut8eVisqsyEYlliTykClV9FxK7Fce/pZVIBIL05VRhie9i7qUIKYG7B9NyUOBgCBOJ9dJLAIeNaaeZCDkWQYP7msee6YEATDX5mtEStwkKkITSW4IW4kUUJgKD+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHzPPDV0YSruCMy4c0wKpJ6wRbzMjnXtBWJCH7OCHbA=; b=NlLP26SIMGGMSaBB7SFefXI82H+eY/TuYV3Li515Kaj8Zftd+B5uXjzcyWrwO39aUOuqSXdFcBOJDfe+X+gQz6Nj8vC9jHZ4TQZ/R0uSOS9agMy8Mu1hAOFAnwFa+Lw4uaxtDY/ZencNaSBAhofjXAuCXxemyrgbH9T7PEPGTtA= Received: from DS7PR03CA0158.namprd03.prod.outlook.com (2603:10b6:5:3b2::13) by SN7PR12MB8057.namprd12.prod.outlook.com (2603:10b6:806:34a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.12; Thu, 18 Jun 2026 07:48:11 +0000 Received: from CY4PEPF0000E9CF.namprd03.prod.outlook.com (2603:10b6:5:3b2::4) by DS7PR03CA0158.outlook.office365.com (2603:10b6:5:3b2::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.113.18 via Frontend Transport; Thu, 18 Jun 2026 07:48:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000E9CF.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Thu, 18 Jun 2026 07:48:10 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:03 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:02 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 18 Jun 2026 02:48:00 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH v3 1/3] usb: typec: tipd: add error message for vendor ID read failure Date: Thu, 18 Jun 2026 13:17:42 +0530 Message-ID: <20260618074745.629638-2-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> References: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9CF:EE_|SN7PR12MB8057:EE_ X-MS-Office365-Filtering-Correlation-Id: 33a7c6d5-32a7-400d-262a-08decd0df1c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|82310400026|1800799024|36860700016|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Hf5om0hDHr6ffBPGefnqZe8OWLRHx+cklNsUyNT1K6EKuGEktWm78gaQWnCB9xqAnb6ajBJpboIlQtPpSrDTG1LqB9n0s48BoUvqtr/P3S12p+DJ9F24gbIkuN+va/qoMDmOTkeLPhr5Lghayg8OPexH0bj8MyyZuPTdA6GF2oshBMmuSznKKIGqqx0iP57MCGbVCT3NFaJVVAn3aHolviqDBmLYhqqks/TlWNoeoF1ZgwDcambYl/qDqUg1NP6VMbbVktzJTgNNcyN8ijH09nCgtlGSZqhroSuUg737sSJERdEZlm4RbPcEGx1dOk5sQMXiW17uz/B6EdrON5+/rGaWTBGu3H31C21KPKMGnFWOXZLT2eogdPvtPH8Azr3SldnoC/vExrH0fWOKtkai6VuukOMPo5JToLeS5IARGhZ4PH+yoP5VJubyTrnEMt4SoagZuLs9Zyzb5OsyKb5XosNikjKKmIP5gsUWdiqBSfHChZ/v/ilJxys/MxJrLGAMiX9tQrm5kSGjFQ1SdCxU8LfYrTZZzxG7mfXDnmw6GH5lFWoleW8MZjPWdz6xaNh2eI2Mr6pWoUi3NWfFTdfh0HhweVa6g19cARQ0C4KK1XCdr9o1kyaf7CDG0yK3CbNubnIjSvxKQYKELN6TMmCE+hg1CdacX3mBrUzkuPzf7jhXKt86BVppUTpuzSjiot2l6OTijPIYX8boTrak4iHcn+XZhFBUfnn/vJDR9Xj+/Ew= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(376014)(82310400026)(1800799024)(36860700016)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: w4H1Kr+v9EfaQkTVL+jXHlaG3aZtl2KIqGDhHnBQWgcL449Txqn5twG5r+mJVN1KLMU3f/KUj0vA85oDwsfELG2mCvucv5HzNaJIXrNYK1zza5jR+2JB3U0nOhBdDcDMjBm4beWooFHVkIB82oBzNI51YPOlz+HmUT82MqkKTTNNBnsDQejAIwHT86lSOVX+cvRWwox0g5MApYtcvPQ6eWEk9BJEfFAp/TXmscVlBgI9G5Wv9LN5pcJ5JceJ+YYrs92cytgo8R5P3eTI2Hf0wHzGRlSiETFVeAtgDTu98+mfEuCUUvl1OO9fl4ksQC+MVCGOi3RxtnOtkR/eOU+0R6mf8MZwiDmwTcR5RYnz6uEp7Kq03Fwg3CQwwwPmKeoBYg/K+7fhg14siwAx1MPSNy2asmxBSdZCWWUDFSLZgjcMnj754rpqgrrpAvqD9csh X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 07:48:10.7414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33a7c6d5-32a7-400d-262a-08decd0df1c8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9CF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8057 Content-Type: text/plain; charset="utf-8" Log an error when the vendor ID read fails or returns zero, including the I2C error code and register value, and initialize the vendor ID variable to avoid logging an uninitialized value on read failure. Reviewed-by: Heikki Krogerus Signed-off-by: Radhey Shyam Pandey --- Changes for v3: - Add Heikki reviewed-by tag. Changes for v2: - Extend commit description to justify vid initialization. --- drivers/usb/typec/tipd/core.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index d5ee0af9058b..465788f8490a 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1744,7 +1744,7 @@ static int tps6598x_probe(struct i2c_client *client) struct tps6598x *tps; struct fwnode_handle *fwnode; u32 status; - u32 vid; + u32 vid =3D 0; int ret; =20 data =3D i2c_get_match_data(client); @@ -1772,8 +1772,11 @@ static int tps6598x_probe(struct i2c_client *client) =20 if (!device_is_compatible(tps->dev, "ti,tps25750")) { ret =3D tps6598x_read32(tps, TPS_REG_VID, &vid); - if (ret < 0 || !vid) + if (ret < 0 || !vid) { + dev_err(tps->dev, "failed to read vendor ID: %d, vid: %#x\n", + ret, vid); return -ENODEV; + } } =20 /* --=20 2.43.0 From nobody Thu Jun 18 15:07:25 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013070.outbound.protection.outlook.com [40.107.201.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C92D3D75D7; Thu, 18 Jun 2026 07:48:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.70 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768893; cv=fail; b=LXHUuYUgQAF6Dcby4psEFRT0EnoAiSs62WMopXYAzU2X4fYb7feI8YYcUePWODhPoS8HiPsorEogfYi9MbPaOSkjGGgAKqs3WFKe0uHkEBfeOkDvA1sjWgfYkQjAgIZa5/3Isxx4NiTcFIOdMUytajKctY7nS0e3noYJ2V3z8X8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768893; c=relaxed/simple; bh=fSsEYnRHB5+mgyU69pQWCuk/zymrNKYHUhBYFavxgP0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QR+ffd6iG8MHJjqS6ml2esEcRwAQEldMjI8mGhYOdjrKeHPdcErXwzIEJdAFo09KM+hcf6Qifabp78s53mLM5CVwnNHoe8KvDx9kmZoMuAF0clXSIV6GXkCFFDTGaY1MP/n8GIFcOEjfpLEms2+a7qtFoSW/qM0z7Rlv/qJKE9M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=4y/P+Mcn; arc=fail smtp.client-ip=40.107.201.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="4y/P+Mcn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HyPzFwL/5wgUofaldFmZHBP55296eWzbDuTfyCrvRLLn1wrH0H9jttZ2UW7+jZxAkdUOm7uK7Wgwr2Ah+TGhm9Z8FEq3P5I4DETDuSXVbcBx3IX7yR1NNwIkQJuiBlNa1u9XdxCcceznFRX/qdrjTzBz8xyrJSjIFmFKO/JJIJE4AjcG0vgl4I8WK7sd4rQBxUtxKDyjUh9c8LiOtgV8+blPkR4MPMDawAKsQxADEuOCUqiZ/jhoraPSIZCNe3BY1Jzq4bfIE2wdJAc4Qi0mGLNrdNUXwBOencq96f2M84rEUjMjyzoz4RsZiGYgtnSNr8RpBpjB12W8owvcCyDlvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oO8qhwYCDfcmTbY9SZfwp7Habnoc+pXm9voB7z++IQI=; b=gCuirguXYxtu1B4omEkXnH4liCEzFWhbfqz0wEYSdMIEpVMRhsuq3RFirfe5WoqyT8k1EJlGlOTks2JgGMvPsHb70MBW25TbYMGaXxDExL0WPzQ3IR3FQiEVOM7IJnFI1slaFbze3arYi54u/agQUqUuOULvTO7vuwgfCmitkdu/rldhSSU16JZVj2ht7y/+zvBl3ZJI+CLOkS81ogHwOJfKkOHhASU8nMrJScN6GOoyKDW+3mibIaE+WD5ce2VAL6HZ5kw57Ox3kegD0JH5dollLRM+kkQKYGl4njJb2LDmuzxUmids0PdsLvcREvB/Yqmkd5mVYCMQKkXMQKg8yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oO8qhwYCDfcmTbY9SZfwp7Habnoc+pXm9voB7z++IQI=; b=4y/P+Mcn1dJv7O/5Jpra7BQhSBFFm+efho/DUfpFa6VpGbo9WkWaQNoP+geMov7aebtbwwjCHOc/WepREnzgDgx+PKiwRYzzqNl6VLoQ1VKUdrQ2XXthDi3J8XsDAzTYd8gNoxSxWl0DiGtEAN/GR65NtiqfLK0vmFRwkKe1wnM= Received: from SA1P222CA0065.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:2c1::16) by CH3PR12MB8483.namprd12.prod.outlook.com (2603:10b6:610:15c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Thu, 18 Jun 2026 07:48:06 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:806:2c1:cafe::a6) by SA1P222CA0065.outlook.office365.com (2603:10b6:806:2c1::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.139.13 via Frontend Transport; Thu, 18 Jun 2026 07:48:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Thu, 18 Jun 2026 07:48:05 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:05 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:04 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 18 Jun 2026 02:48:02 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH v3 2/3] usb: typec: tipd: demote missing IRQ message to debug Date: Thu, 18 Jun 2026 13:17:43 +0530 Message-ID: <20260618074745.629638-3-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> References: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|CH3PR12MB8483:EE_ X-MS-Office365-Filtering-Correlation-Id: c088f4c0-2993-47a5-c550-08decd0deed0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|23010399003|82310400026|36860700016|1800799024|18002099003|22082099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: HHZ0bL7RwR0zDJti/8dp/b8dVPaFhnJBDYXVR4KINrFPJiIIYma8WBv8o0X/+IEL1xfzp6s3SoMDdDdPDvEPofVp/7Hj73I6kNlZmCBq8B1W8hq90YmuegYyCsZEh2tn213Q9GxsRW073uhq9R+CKL2i7LA/ftkcylRMfVpXXFSbB5qFDHLWtWIADzHYZcbWVsD4p5tb6/MXIbEuGiIxCcrYUyU8bxGyZwG+lI8UQwRM6cWQqNKL5Ud2QSMCd2lKyKWNbF98oNPrKHm25giuKE23zYfr4K4LuVAFsNcAvLwnSXckAZMgKuuZAt638oV3FHS5/ZthaSJW9kfUPZc7c7l23Y9+ZmXmSVCnom2YTUg1dgdjsTcswQivoLDGaW5MfiuCQbVOjGvTtWeogm4/MtYXjt8Iif/s9rP9/fYnlG/jF7xvKr1CNKtnThFRnu3mvIJhpewbb5mZ8pyLABFBjgov/LBPRxwOz3ivMWMwfWL2uvUY0bfy4rOEiva5zF8vcTpvh5t05LPrOX/WMs9uc7pOKve7xzhXCX1lvNohXaYYb+uI3+rSYbMlYIx91CU9Bg1UWIRma66ot7woKe84Yt3zEYkTFFjvZlTfnKsVeqMOfV5d+GlaJWDhgdj303EyVdMeBBoM7919Zk8fUjYz8mQdamBeFwuzBtNw9osxUI/AjCH+nUpK8VEN1WZPESz5QYcKxfJ+n+ExGTHtRheuiagVE0b++p3SlWZFQ77M578= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(23010399003)(82310400026)(36860700016)(1800799024)(18002099003)(22082099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3kI24zDv8D9ILXGJP2+B7Uz92l5MV/44blHGk0zLMAmu1+TfwXesmTgEAM+b3v5FRXOyn7wt3/fHBWoCiqhp5O/VJdzlA0zmd44N3FaUKuqpLtXlYKPDhjTsczv/+xt/G+cEErzLU08rBiksNyK0y1qAa5ds8E2iEZeoGQSabfZ6qGae4BAg0mQxxA+91YLQX8ZhPF+yFP24pONvLwzGIhpj6p/4c03BDq3+yK8YmMeI5/Htno3JC5BZ1c5DNe6wAQbd66kCUjhjlAJ5Yc4xYS3VHakB6XFfg9iq21vvqidaq6jQtSp0zcrGRRcJHLT1NKPVbNF9QyUbJTOFqIsrpldlHMt1iYUAkXIYRpy+6mxpPyeFC7fVw8uEJixDKZ2ciBWkfpefdAUCAmqi1wLloRwYMeAOAuY7Mt7Oa3/JZr95R7r+bvYTn5u4Yi3tLkqO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 07:48:05.7491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c088f4c0-2993-47a5-c550-08decd0deed0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8483 Content-Type: text/plain; charset="utf-8" Operating without an interrupt line and using the driver's polling path is valid. So move the log level to debug instead of warning. Reviewed-by: Heikki Krogerus Signed-off-by: Radhey Shyam Pandey --- Changes for v3: - Add Heikki reviewed-by tag. Changes for v2: - Suggested by Heikki Krogerus - make it dev_dbg. --- drivers/usb/typec/tipd/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 465788f8490a..b6335b36d384 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1854,7 +1854,7 @@ static int tps6598x_probe(struct i2c_client *client) IRQF_SHARED | IRQF_ONESHOT, dev_name(&client->dev), tps); } else { - dev_warn(tps->dev, "Unable to find the interrupt, switching to polling\n= "); + dev_dbg(tps->dev, "no IRQ specified, using polling mode\n"); INIT_DELAYED_WORK(&tps->wq_poll, tps6598x_poll_work); queue_delayed_work(system_power_efficient_wq, &tps->wq_poll, msecs_to_jiffies(POLL_INTERVAL)); --=20 2.43.0 From nobody Thu Jun 18 15:07:25 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012055.outbound.protection.outlook.com [40.107.209.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 535C03D6CCF; Thu, 18 Jun 2026 07:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768898; cv=fail; b=Yvv0ympaIPhGfqScMS3loJHGHnlHcQuRmS8qaLPsMtRpM47QUfc24OYUvJSiKBcpzpBu+ZV6d0ewB4Mcdh6gb3aSa5arNpr4ZD8VCbqtZKFxUD0NJm+7xphnkb/6AOZYTY0IAXaI9e/jaNyHv5YagTolY0ymPraf87nIX2ELyzc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781768898; c=relaxed/simple; bh=LRKkVWsEwhH/OGNFZk3sF4SSOMkqPIgbFtnM9g1Jx2U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tk5fbjEIe5yzlIjtkEHbAJYtcYOGNOE5cXJTY17S2kTFgalHHTwWGY7VCODIrVhRsNYERXfeyAhzsCJ5EfsVAUrIn6jzHFFHah2YoTphGVImQG1NPrfDWLpDp6NBRJg1ErTZ7RO8AoNBqyOROOamXW6jYULpTW1h8dm8GAqWwJI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=WBJhS+jg; arc=fail smtp.client-ip=40.107.209.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="WBJhS+jg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NcAL7hXu+TVZShxcBLx8L9SFBORZn4BRNk3j7LjhMhU4G77KUl/KL709rvlSXl7LEZRwADvWGUF1Py1V3SPZNWIZVIPvKY7Y6t6SVH2U4Zs1bTKHucAur+ncI+17VnKj6IXqPc9Xjlas7UFSa6dM8YoCt1aLF+tjMXPobdLPSzWVVjrrNsIlhLOatJGazCHfWBXQ4iLjWefui0jGUIfdb50G1m+a3o58WC9u+od0vFnuAvtiD97TjXX6PR/RE2VgPiRtQNg5jk8vCf8OrG/KPvJOJiEKUGD3OkhA0QvXAf+z0KGeNeIW6DDXbrthTXid3JreAKb6vvjOaXPzijy5AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=swf2N69/xg2BPKziwjf2/HhhIZx4Fdjr7psb1c2Xejg=; b=bglJlkGSyrTxhZ+3mtvLcnGdknuPqoNWo/ex3FvVU31EpQlWCXNLg4+fIf4M+ZkSWgjuQfSc9D8JpgvaUFcbLTx+P3L8KxUe2ORJWTIMeNXJVPnJ4hb6lUDY2Ndu47kPVb+ubnSgmyzJfVvxDcLCzsrJlbz/QBa7UL+hAvuXz8fyp3xHZaZjEYYmAHFDoiE/SkGXU8rq4CjT1RlEzkxbsVsTcHj5VcJ5GzMBVQIVyVQVuZxU+gmwbJoM8q3mjKeFQJq1BD1JjDaKSl4901HHin1TvIRh6TN+i6+hWeYWZSbZuo1rchCfuQ2Fogs68NNWyKa7koE/qPWr+c2sfK8tpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=swf2N69/xg2BPKziwjf2/HhhIZx4Fdjr7psb1c2Xejg=; b=WBJhS+jg9RFF6EGRiCYyt9tO+M2j7N9mXf6raSyGdpatXj3Y1evZynY3tCY/cQ0Ai84QTalv1ono8g01cOxDw1D8Yz63D4VdJkAdnxiah6YG49jOjyXotDvE3ixFuNWkLrThXOp2OBST3crRgMmbEzlpiFvzdD1r67CkSQI6WU4= Received: from CY5PR20CA0014.namprd20.prod.outlook.com (2603:10b6:930:3::29) by SA6PR12MB999199.namprd12.prod.outlook.com (2603:10b6:806:450::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9913.11; Thu, 18 Jun 2026 07:48:13 +0000 Received: from CY4PEPF0000E9D3.namprd03.prod.outlook.com (2603:10b6:930:3:cafe::87) by CY5PR20CA0014.outlook.office365.com (2603:10b6:930:3::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.139.12 via Frontend Transport; Thu, 18 Jun 2026 07:48:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000E9D3.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Thu, 18 Jun 2026 07:48:12 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:07 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Thu, 18 Jun 2026 02:48:06 -0500 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Thu, 18 Jun 2026 02:48:05 -0500 From: Radhey Shyam Pandey To: , CC: , , , Radhey Shyam Pandey Subject: [PATCH v3 3/3] usb: typec: tipd: name TPS_REG_POWER_STATUS field masks Date: Thu, 18 Jun 2026 13:17:44 +0530 Message-ID: <20260618074745.629638-4-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> References: <20260618074745.629638-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D3:EE_|SA6PR12MB999199:EE_ X-MS-Office365-Filtering-Correlation-Id: af267079-a553-4fed-f92a-08decd0df2e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700016|1800799024|23010399003|82310400026|18002099003|22082099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: PbArJ/ykcfO+a8fLevOmbLqjShQajBEMAJYY+LropBztJbsn5smByFGARvdBBMl+JMdoS+kff0q/b7J1pdSKP0lxS4byg8eIBjHNxnBIWL1KzgSsOvUux6pTV385eQn4kCAbngUQGltnmSzWg4ebDr1q1QAany/MtGBmPFTGp3J5cuIVI8RU7leQfW71GFRyNg1mXt/EzMFgMtL5qDM8mV6onFUpIvLScPSgD99FPoGtUJfqtZXMdSRJA8F5SJLksmVhmDoSfbJBIO8mzjoIzXTr/PH1eg1lmcsdJ8o6H1ZG1lcocUX+vK1uPG14PR0nSzKEHnCg1xOnYHwUhlkieOLpFXcioU4adxYtP0PDwszgUiru1qu1UiULNlBZJwxf+iLXn3bNqNYaNj2cJhrCTRtikHfIuliHYCEKF+SFUt0iMIn57mu+Gdu62Z8uRVX3p4mn4kUI1XP/TufREbgz1B0o7hnlKUen09VKe/EKUPLGvQnwDvNewyIVHby4KpHyEZEioMefCoWH01/CBWeoai/GoVvlDW/81bU2Onixm1OqHLEeOOxkqGUYnpmMhUTMHgizjyLi7HuuP/ITt0dEOH5Hn7AxofEHxmW6TzpcQQa8ombqmFynHKD42qvHwaxAiGOWHHDWEVvs0263iGDmOjQD1f1E+20i5etzlRW9LDCQlmjT6Y9DiXrpNr9Dsycn7lYau8fYyiLLvg0DogIdzoP/dnUyks5wvcvBtmlkqPg= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(36860700016)(1800799024)(23010399003)(82310400026)(18002099003)(22082099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HGmOqEx0+d6CQ5rosWjPf/mB0XOlqCmL/1xj6kpmnTnJHtNwanbg5OQkeEHmAtZLC4C0A6Qe1iMRGYt/hl6/X0yPKvwootGBbXNcgkxWzikcwKxEz6aL2CHZd5VyuoQK0kJJ5M5Yn5S4ne32bBQQLKkEsLuxjYSRGvfWxUHRwNVTYcWuV7qoaAR7Mhoc8DYVX+XETam4YfXmXF1jJCGu1TZisy4LIR8BZndaWTle1kn+BGbYnhJEHClTQ1+lww1WJ1KjLjoAKLfP5UkBpT0coJngeIACztUR105EiKDfnsbP25EZxIYIEhF1S82BbcO9TLF9GvkiBUx+UqkqQFiYqQkkFVCkceXlTaB/HgJmQJU6dWFUpV69W2oq8QXL1YwGPkMXtaLEKZG1VyqkqTSLfun0SPSFLEs3cEi+tK8HVmVy84OHk/ZDLzO6qaT5fH/0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 07:48:12.6152 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af267079-a553-4fed-f92a-08decd0df2e8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA6PR12MB999199 Content-Type: text/plain; charset="utf-8" Define named masks for Power Status fields (connection and source/sink) and reuse them consistently for both field extraction and value construction. This avoids raw bit usage, keeps the definitions aligned. No functional change. Reviewed-by: Heikki Krogerus Signed-off-by: Radhey Shyam Pandey --- Changes for v3: - None. Changes for v2: - Add Heikki Krogerus Reviewed-by tag. --- drivers/usb/typec/tipd/tps6598x.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps= 6598x.h index 03edbb77bbd6..d4140f4da5bb 100644 --- a/drivers/usb/typec/tipd/tps6598x.h +++ b/drivers/usb/typec/tipd/tps6598x.h @@ -142,9 +142,13 @@ #define TPS_SYSTEM_POWER_STATE_S4 0x04 #define TPS_SYSTEM_POWER_STATE_S5 0x05 =20 -/* TPS_REG_POWER_STATUS bits */ -#define TPS_POWER_STATUS_CONNECTION(x) TPS_FIELD_GET(BIT(0), (x)) -#define TPS_POWER_STATUS_SOURCESINK(x) TPS_FIELD_GET(BIT(1), (x)) +/* TPS_REG_POWER_STATUS bits (masks shared by TPS_FIELD_GET accessors and = FIELD_PREP) */ +#define TPS_POWER_STATUS_CONNECTION_MASK BIT(0) +#define TPS_POWER_STATUS_SOURCESINK_MASK BIT(1) +#define TPS_POWER_STATUS_CONNECTION(x) \ + TPS_FIELD_GET(TPS_POWER_STATUS_CONNECTION_MASK, (x)) +#define TPS_POWER_STATUS_SOURCESINK(x) \ + TPS_FIELD_GET(TPS_POWER_STATUS_SOURCESINK_MASK, (x)) #define TPS_POWER_STATUS_BC12_DET(x) TPS_FIELD_GET(BIT(2), (x)) =20 #define TPS_POWER_STATUS_TYPEC_CURRENT_MASK GENMASK(3, 2) --=20 2.43.0