From nobody Tue Jun 30 01:23:23 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 997B93A48ED for ; Wed, 17 Jun 2026 23:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781737822; cv=none; b=aV98HyQQolaH1raZE1NUUNegqIzeniVLh4v0nw81HWx7Cz33DcqQzu0Mi6S/eTtoa/2IOniVyPkh07G17Gn/kV4H7HHDFZnAE1eHLQmXZ5IbfRLON4Wm18R5rClgR0Ntu2NUosobfFuvRLRbmjW5zAnPNa71n1xXXJ9pZP+m0uI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781737822; c=relaxed/simple; bh=u6wUHnxvwivQwuzu3HKhXhyqnsF7vcLu9HeL0jOJUk4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TgFKffdzGcASubc+hfm7NAeQhNPL6osvCVQsFuHNfFFi0NsLVE7nAAG7aRXYcphTajt4vp4g3Dw+vU77tCIlc+IwIF4u4ZSi8xzRGwizHJT3pEUjR7IgpAYLhNJqnqoT9KZ7wuMw58ZvTRAd9JgFgIRlMd2zxYXMtaIKdKBT0gE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HYirRgva; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HYirRgva" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-845369f60faso112566b3a.3 for ; Wed, 17 Jun 2026 16:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781737820; x=1782342620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Gor21PaBldXAdPuL5q1IPXFVFpwunO3DWx10Zn+d6L4=; b=HYirRgvaEK8OOyF3+HcVFSvfGL05KyLeg6SgQJwH6fIixHOuLV6nNI4LRVfbq1qpba jT1OIVU7NAfzNCVngxj2reel2Mg/RnOStj5o+K38JUsS2v7b1Pqkx4udZsiYDPI3qcTB 9lok3ynpoWu0GQ+JaV17ljPIbGSM3LsnCy7A2j9vlQ7aZBjWb7RBA3DnE4FXGWcOW7nB dYWy0NOyPRj64VFKdhgmt06txyTi2ssVgOTK7/KBWjTTecUsyH3jMb8feeyUw6DHSbFn EXTQwSTPiaBCEwANWpvgzWUATonI7tpyQeGujAQJ2Mv/HC+5NBaXuFEMah7L2Dm/4s8B dr9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781737820; x=1782342620; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gor21PaBldXAdPuL5q1IPXFVFpwunO3DWx10Zn+d6L4=; b=RG9ku+q77yUeD5DVULPbWSIX19AsSvpcelMmVk6MQbxmYuzX0UKxvrbW95sPXeBDDe zpwE+nmoqLk/7t3M+1BHkiBFUYVjZFDPWenkWfQExV/8VnWHrX0f7gg4ef69GfW1vrqY eeeghgJCgH3r/AiVgbq2W3wn7xfs4/R44WQuAbA1FhqgFpO8/asHR7yRbtytlBpY5IoX kb/V5EfGYQJSFsdCGkIvza30NwKo4b8nZZU/N0ZPaQYqsplX8kP6uTX85GewqdR9YY2t PPZd9Vcd2xipEItWuvh5EIlNa9Lb7U4229zOk3+Esk3ASlZY1AYHUD0cDTbM76AO2G5J d2TA== X-Forwarded-Encrypted: i=1; AFNElJ/eMlDlACiPK7fnBFHRgCt028BuTIMrYasBWLZfuk3EXwqQjHMP4DhXixzvT6D0Oo08+pEvUtvL7notdzs=@vger.kernel.org X-Gm-Message-State: AOJu0YxzgHnWMseyHh5ndqjtI1b2B3HbDlCtlXyceSY0JYXLmLd9O+uu 570tIcabLfKeIPmSfpwZyd5nJHk9jPBoMbAa9SdDFUj2jPXsFCzEUuwe X-Gm-Gg: Acq92OECgxICxnSsVoYlz+o65wIakN2pRfb6GFXPdbB+Enco1dLUAQlsNgHT8Q7TfWY +J7ZtCl0D98ufHIH72bFakmAzSRNi15K55Ena9XvKHQWgRcJutZiTVPM+Ze79jz0jqw+BGMzXod 8lapfVIatg4F2bqHFg01nl1Ako0dcRI3wmGfxSp73E0HwJsjndlZLqHhnZ5SbZuWdzqf/bSrJ4o D6nvdsiCtR17sKqd+6rxQC8+rjLHmMYTNuOb+niZkMKta1xpSZxBcr+00fS/H7boh4lWDFwg76z 6KzTdOcvawCbbqcjwYa9S7DtVLDCTV9ckneRs4UlLCU7oMjTEg2qctfdH0tRd14y81B20R1mSMb WMQvFZFWYCPl42qrwQnsuzA362bL+1LfywdnwdnbmWcbp5AgOxoQ39LRtlO+AubJy5dEPJuv9MM Kg7kSZKh8CbfeOXAN6n8L+tmNOJZwyWNkahMHvDPlvrPqqfAW0880qN6lG0+4RZKh6Zl+l30iFm LeKzKhs1qmr4xFRMaq6ehBo X-Received: by 2002:a05:6a00:2d85:b0:842:2382:a0ea with SMTP id d2e1a72fcca58-8452445d70bmr6060758b3a.14.1781737819864; Wed, 17 Jun 2026 16:10:19 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7305:54ba:2fb4:e198]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434acca7ecsm17640525b3a.13.2026.06.17.16.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 16:10:19 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 ath-next] wifi: ath5k: ahb: use devm for ioremap Date: Wed, 17 Jun 2026 16:10:02 -0700 Message-ID: <20260617231002.262820-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplifies the code by quite a bit in probe. Also allows removing a goto and returning directly. Signed-off-by: Rosen Penev --- v2: fix typo and remove error message drivers/net/wireless/ath/ath5k/ahb.c | 33 ++++++---------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/at= h/ath5k/ahb.c index cb3e891ee1bd..8d28e02c3418 100644 --- a/drivers/net/wireless/ath/ath5k/ahb.c +++ b/drivers/net/wireless/ath/ath5k/ahb.c @@ -87,7 +87,6 @@ static int ath_ahb_probe(struct platform_device *pdev) struct ar231x_board_config *bcfg =3D dev_get_platdata(&pdev->dev); struct ath5k_hw *ah; struct ieee80211_hw *hw; - struct resource *res; void __iomem *mem; int irq; int ret =3D 0; @@ -95,35 +94,21 @@ static int ath_ahb_probe(struct platform_device *pdev) =20 if (!dev_get_platdata(&pdev->dev)) { dev_err(&pdev->dev, "no platform data specified\n"); - ret =3D -EINVAL; - goto err_out; + return -EINVAL; } =20 - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res =3D=3D NULL) { - dev_err(&pdev->dev, "no memory resource found\n"); - ret =3D -ENXIO; - goto err_out; - } - - mem =3D ioremap(res->start, resource_size(res)); - if (mem =3D=3D NULL) { - dev_err(&pdev->dev, "ioremap failed\n"); - ret =3D -ENOMEM; - goto err_out; - } + mem =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(mem)) + return PTR_ERR(mem); =20 irq =3D platform_get_irq(pdev, 0); - if (irq < 0) { - ret =3D irq; - goto err_iounmap; - } + if (irq < 0) + return irq; =20 hw =3D ieee80211_alloc_hw(sizeof(struct ath5k_hw), &ath5k_hw_ops); if (hw =3D=3D NULL) { dev_err(&pdev->dev, "no memory for ieee80211_hw\n"); - ret =3D -ENOMEM; - goto err_iounmap; + return -ENOMEM; } =20 ah =3D hw->priv; @@ -179,9 +164,6 @@ static int ath_ahb_probe(struct platform_device *pdev) =20 err_free_hw: ieee80211_free_hw(hw); - err_iounmap: - iounmap(mem); - err_out: return ret; } =20 @@ -213,7 +195,6 @@ static void ath_ahb_remove(struct platform_device *pdev) } =20 ath5k_deinit_ah(ah); - iounmap(ah->iobase); ieee80211_free_hw(hw); } =20 --=20 2.54.0