From nobody Tue Jun 16 17:03:50 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B3943D4EA for ; Tue, 16 Jun 2026 11:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610906; cv=none; b=PY5z6tZm7g2otMgSTv3q4n2T7wsO951BIjWD9Wbl6K0uxaRa+niXln0LscP48uq56sp9BQ/SGUKetW5lNAJAL6ct+7wS7QYa5hC+Fjv627tHVyCCPTozbbGxhw3R/L2NrJOb1rIiC6UangNNQF4YD5b6eVUJPLNaCwqXw9Au7pE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781610906; c=relaxed/simple; bh=IkcWGshUEa4u7dhMzEQVwaerWwxFO++zUBrXJW6rS0I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LA8AZX8ELdjyKfQ4wk1NZ/bI03EN3v9FK2Q1g5A70gDvwCVvkypdcAQlkf24dg3aU5x+lei62jjwq8TXF9VIeanpkMby0B6rWFN9keGZoNldQCLTqUkt+0GLyOAYHvyrsq38c67CCv9Hvyo++7nxgpU/Bdf7DUBB/6PMvOvl+0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N7N5Lq1O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RZBShAU1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N7N5Lq1O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RZBShAU1" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GA9WiU249596 for ; Tue, 16 Jun 2026 11:55:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=BqZE6aH27VWQfilGircM46 jMc+11CYdxAMP4Jw18oyE=; b=N7N5Lq1OFoJ0CYokMHJIfzVUE42feUuuPAlMCW bSyiqjlXwezZCSZI9F/oa97kHLKqVxOj7anvgIpmJUy0Gxcr8X80b6d2mKK3mSn2 1U2R9rHDuJcJXsRYunJvEbT5L35aJLI0zy4x7fEbScFp1SNvoCHbIWYY7kA5objE WMtOQBIPMw0+QeK+Tvz4KMYjYmiKpN/0u/ra9Kuuw6j6zQOs57R85nKxxmT3+fAL 3rxTeiwjkZO6An/VLpzWfV+21F05CMl+8PUmOcjhQ6iRVK/jbNGfYtFxWx1mYb10 QQayrxpiLJJa9gLx3kpqT/kPxUhVicgjtgjIlJtHqj7o8jnA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eu2xs8v2p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 11:55:04 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84256bee9a9so3019560b3a.1 for ; Tue, 16 Jun 2026 04:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781610904; x=1782215704; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=BqZE6aH27VWQfilGircM46jMc+11CYdxAMP4Jw18oyE=; b=RZBShAU1r4mVUAEY6NAVlS6cabAgs/elnO92K6A54fnkm3Qtnq7+2EMTXi7FoBWO02 wqsbtL3Ypzy60y8GGVNkWTxBC5JFpjAa7OyanarbCo+jd0J9U5y0023QKaV0CfBViDmj W8H9ieZdx9lOuyASQW34gZXOoDJjjz7Zy0jQ8y6z6/r3u3Esb7mlXxezRejjwlOsIA0x +Jn93K3XRiW0fK6UUqtkW3gCqtFfk+RbwFtN4hIscjSqDMnbQM+9VefBdkv//bgnYddW +796gLj/2W8F4E+vVF8GZziY4h6kF4wyko0ciyPRyRrttxkOWCKWpGLX2Q82MqfZM3fD c/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781610904; x=1782215704; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BqZE6aH27VWQfilGircM46jMc+11CYdxAMP4Jw18oyE=; b=MSnoVCw1qhg9Ur2IxW8k6Gq/p3KurTxXtjmlp5PYVIC0pJasE4xqWcAXDvpReANH/w JOnIqIVYc1CU06YFxiZDLuEkdYsM67AlLCfmzTy38COHmNxM74wVp2YNi/TClRBwB/gW TehnBB3VMfoQTuaBc+WqFJsrkg2l/V/ErqCocf++RZInM/hphA4eKYqzFYvdcgCe3Uv6 CIJ756DglN+t5HqC4Oy/RS9zpe8M3ksQhWHtPvnvs5LIreqHZ/SrIfsawLwiRuW7LRYG YXGKjZIv80KRa3X4WdT69b8QR9rUpuo/d3AFzJAEd5Z6FYQ3wg5y3JkY/fZpgmiCS4pr gvcg== X-Forwarded-Encrypted: i=1; AFNElJ9JoL9ESzTY3sD90PHBzZZCb4Po5Bd10L2qn0FW9AEp0w62ZB2FLdYicbc8pSQbTWmw8PcH/8PzRQL81og=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0FpWkfmy7G8DcL8qvL7HXjCBVU8uRhS4PqYDJPAHvcR4ob1Ai 97GJ4XmsTTC2aAVS+AeFd2daPcqMc4yd0YwrQflMHvqm0Z6wg7UxqB2DA0UzKUmEycZZvCl5qKM 8R76cofC1S/V5ugXPZOVumyF2YPzj+0+636vaEmv5wxPFvJXYp3c7tcQ+S/spTWhTnqXHfbhKdR Q= X-Gm-Gg: Acq92OEtrHTHNBGCt9MtrbywQhuz7cPsefzy9mFLfklQnwxL5XFo7yHa1nHIb0nfpeM GSeqPwdp1ovEaAZ0ec6ySR/0sosIOc/G+rJo0O8Q14lEDUE3cX9gVU0CT1mJb7VXE5hkyAYn37X 7ZrGmovcFUkEiv1qOPtNIC6aKENIHbsckoKs3TDPl1F/kVfos66xPF2XQniNh/qGLv4FtH95ZmR 9Zs7X8ciKBgLirOUtHcsgSSlt3ajU1XMdyPKzWEKbmVNi0DHskg6GeXqbDm/3HzUzL7noMQdwt7 7nzHRTiW3RYrx7M3mGM0kWyGje7zrbKCt6MLRJUb50ZwMRO/B9hJsKg5YgcXfUY7nD4hHaMm1vx 7krtdgMZ53l3gYy6eQdTgDGGaYlkg9gqcYcFSwZa+62MpRrN7DWY= X-Received: by 2002:a05:6a00:1907:b0:842:2ddb:e305 with SMTP id d2e1a72fcca58-844e1ab9f5amr15874126b3a.43.1781610904053; Tue, 16 Jun 2026 04:55:04 -0700 (PDT) X-Received: by 2002:a05:6a00:1907:b0:842:2ddb:e305 with SMTP id d2e1a72fcca58-844e1ab9f5amr15874098b3a.43.1781610903559; Tue, 16 Jun 2026 04:55:03 -0700 (PDT) Received: from hu-smankad-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434acf4b5csm16050549b3a.23.2026.06.16.04.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 04:55:02 -0700 (PDT) From: Sneh Mankad Date: Tue, 16 Jun 2026 17:24:53 +0530 Subject: [PATCH v3] pinctrl: qcom: Unconditionally mark gpio as wakeup enable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260616-enable_wakeup_capable_gpios-v3-1-fb59647d89cb@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAIw5MWoC/5XNSw6CMBSF4a2Yji3pg1cduQ9jSCkXaARaW6kaw t4tjB3o5Cb/HXxnQR6cBo9OhwU5CNprM8XgxwNSvZw6wLqJjRhhOUk5wTDJeoDqKW8w20pJu2d ntfFY1SLlQkJZFAxFwTpo9WvXL9fYvfYP4977WKDb9zc3UExx1gAXdUtyItKz8T65z3JQZhyTe NDGB/YHySJZKpZLVYiM0/ILua7rB21wq4IgAQAA X-Change-ID: 20260430-enable_wakeup_capable_gpios-cb9439ae8772 To: Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sneh Mankad , Maulik Shah X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781610899; l=3105; i=sneh.mankad@oss.qualcomm.com; s=20250818; h=from:subject:message-id; bh=IkcWGshUEa4u7dhMzEQVwaerWwxFO++zUBrXJW6rS0I=; b=63/ySxmq4UtHp74zjtRfXCIVzdA1nKbfE7WhjCV7hFsTX1yJph99Hoiu7jCnjvdAcpGXY05M0 dZta5VjWstWAVVUwVYWl8QdLDmgBclpumiWMGiMuBcfMIu4tufXwvQj X-Developer-Key: i=sneh.mankad@oss.qualcomm.com; a=ed25519; pk=sv57EGwdcfnp6xJmoBCIT1JFSqWI+gawRHkJWj/T2B0= X-Proofpoint-ORIG-GUID: zaMKTM4rkKkVGy5Tn7uqGsdQ6YPgvuta X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDEyMSBTYWx0ZWRfXxeNOi+EpUIJl nCr6rKjKVvRGxKik9tOcYdkiEoWhd3VjSL/e0jPi2QI+0DVqbRkyRaGKd9zDx4WqZ8393ivBQKl TmFwFeooc4yPWm33RqgbmlteCbKPFSrW5dgZIK3S4lvq1QP07BRhPFIFfkUUlVw7Lc9IlMq0iTJ 5gXghNcHKhhmsZy1spSQkut0lHAKhcrfKnLCdV2GExZI8DCQ63XtbqH8UFH+nI9HuMX/R31E/kQ OMiJJwcz1TlfOAsFW/9AdepFjm9844vXdb49/VZGnCyDDznfTuHSZbexvw3wnkpdQHrnile5S+E njuCeCBIoiIGR1Xq78QatLRy5Xqf8mfdhvAKLwHjo6mpHM0FejTSMX2jgy2EACb+POBCajV+c1F OXLOWOSd0GcrIwAucOqHc6krw6HfnxqRbpDh91YiRrnh5PVsivxM1p38e5WoksnHnjdr7P9mETW ehzZIloRlBSF/MzEv3w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDEyMSBTYWx0ZWRfX/jk7LJFyP40Y fhZxaDuFLHRZhNiU6DKsT843k3d5vQ0vHa4pUtF+6vWHq4UKd3ybu65WDw5qvfY9/lLmGW0HwRm SjNksspxrEv1xOVkA1WE4U0EJAsIvjg= X-Authority-Analysis: v=2.4 cv=MdJcfZ/f c=1 sm=1 tr=0 ts=6a313998 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=SnbX5S4nitk782EHpS4A:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: zaMKTM4rkKkVGy5Tn7uqGsdQ6YPgvuta X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_03,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606160121 GPIO interrupts that are wakeup capable need to be forwarded to wakeup capable parent irqchip. This is done via writing to it's wakeup_enable bit. Currently the bit is set only for PDC irqchip by checking skip_wake_irqs. skip_wake_irqs is set to differentiate between parent irqchips MPM and PDC. It is set when the parent irqchip is PDC to inform pinctrl about skipping the IRQ setting up at TLMM. However, the functionality to forward GPIO interrupts during SoC low power mode is needed regardless of which parent irqchip it is. Without the functionality it is impossible for MPM irqchip to detect the GPIO interrupt during SoC low power mode since for MPM irqchip the skip_wake_irqs is always false. Remove skip_wake_irqs condition when setting wakeup enable bit to allow forwarding GPIO interrupts for SoCs using MPM irqchip too. Fixes: 76b446f5b86e ("pinctrl: qcom: handle intr_target_reg wakeup_present/= enable bits") Signed-off-by: Sneh Mankad Reviewed-by: Maulik Shah --- Changes in v3: - Added explanation about skip_wake_irqs in commit message. - Link to v2: https://lore.kernel.org/r/20260430-enable_wakeup_capable_gpio= s-v2-1-8c26ac795318@oss.qualcomm.com Changes in v2: - Modified comment to specify MPM HW as well. - Spelling correction. - Link to v1: https://lore.kernel.org/r/20260430-enable_wakeup_capable_gpio= s-v1-1-5de39bf06094@oss.qualcomm.com --- drivers/pinctrl/qcom/pinctrl-msm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinc= trl-msm.c index 45b3a2763eb85405fecdd4770ba3d4ab684563f0..6a24f9b5e4a979528ba6b5b87fd= 297c2783ec765 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -1242,12 +1242,12 @@ static int msm_gpio_irq_reqres(struct irq_data *d) /* * If the wakeup_enable bit is present and marked as available for the * requested GPIO, it should be enabled when the GPIO is marked as - * wake irq in order to allow the interrupt event to be transfered to - * the PDC HW. + * wake irq in order to allow the interrupt event to be transferred to + * the PDC/MPM HW. * While the name implies only the wakeup event, it's also required for * the interrupt event. */ - if (test_bit(d->hwirq, pctrl->skip_wake_irqs) && g->intr_wakeup_present_b= it) { + if (g->intr_wakeup_present_bit) { u32 intr_cfg; =20 raw_spin_lock_irqsave(&pctrl->lock, flags); @@ -1275,7 +1275,7 @@ static void msm_gpio_irq_relres(struct irq_data *d) unsigned long flags; =20 /* Disable the wakeup_enable bit if it has been set in msm_gpio_irq_reqre= s() */ - if (test_bit(d->hwirq, pctrl->skip_wake_irqs) && g->intr_wakeup_present_b= it) { + if (g->intr_wakeup_present_bit) { u32 intr_cfg; =20 raw_spin_lock_irqsave(&pctrl->lock, flags); --- base-commit: b4e07588e743c989499ca24d49e752c074924a9a change-id: 20260430-enable_wakeup_capable_gpios-cb9439ae8772 Best regards, --=20 Sneh Mankad