From nobody Thu Jun 18 19:23:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C6B3F44FC for ; Mon, 15 Jun 2026 14:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533032; cv=none; b=Uw9plJRcyEDXe90vECNGVv/hPU1hD9uBL5f97YmShCXQn7vR1jdBSsSA21TtzGpmFhpcsKoOqVsbyRd1tGnKg/E0iuwGOEzsxgPGLexfwygbP4FKuhxK3BXRPpx47FfDnwEgnf1tiKSg4fvlk3GRXKf1hPPOO0XvcJDrg6S9jV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533032; c=relaxed/simple; bh=QHuJbNfZclwAUqET6A1WfhO2/jqOdVEs9Fpda71LKyc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nntLhhbJgxN9Jir0/jSIEAKpfnI85Ewygf3Sc6hAaRMplcacWavFNNlAsebXLbSLDEEr8hy6m3plNWhDYNULz0uN/ZB5CQL2a3HvuFRzZgQj2F4mmOlJz1K/lqMs9PK7bxvz5zhRiz7uwNTIfWRleUh6cOeejMgQ8T6wW73Q09I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RdxzjBx3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R5epxaYz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RdxzjBx3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R5epxaYz" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FCZBWN2712649 for ; Mon, 15 Jun 2026 14:17:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8uZNp+VwhVSjExHeT5LvpX51VbIe9sjYP4PbK25Inpk=; b=RdxzjBx3vPSj+4Fk O35DdkAQivu0MDI4s114/uZR73tLeO83J7kWQRaZHoDsGMu/s3AAQ47PCbXNb3R5 J9cKCet35nYh3DS1hF/C+/wPAK3BTFKQXOao3yjV/LqwDM3ngWiZ/BqqQAcgxeGB 3NbZazocOJsCvFX64vLjy2vn89JTHc+PqrhJjyaa6GQrT3bqNTv1nm3ff9Ih5mDM dA0uP8P2iNNYXujqpMTDIVdpfW2GTYz1ogziayDvbckS9Z+2CfnGIgvAOiFWe2lm YQHBR4Yq1KGCkPJh5JS6A1kydnx95EIt404FO+CAV8rmcjhAABvmfyUbOAwblvXI cjA9ug== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ete9818mn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 14:17:11 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3773f1eaf91so2426770a91.2 for ; Mon, 15 Jun 2026 07:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781533030; x=1782137830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8uZNp+VwhVSjExHeT5LvpX51VbIe9sjYP4PbK25Inpk=; b=R5epxaYzHXJ6zVCrvYdwBM5X91xWdgQ8bzATIvo1Nmp2fkS6Va1MxY8sMInrh/3dsI BuFoqkA6WptDASu/M1BdOvbo7Hr/DXdNBGDYrYCk6om5/l7abC5wiac+lY625xT4XWwj 77+CromcPBWRuc7o9bW/Oa1RKbh40BFaSmfXK8fPWsVa1WvaDFN9yV3ciVgv3AdfCe1C 7cRNwULl/HK3W82MzYX1/FFn8xEMPSrQjvgmD+tOdz5ajL2TQ33eDyrrhS1jK7MTqSIP q9ohA/R1ikubUWBZCEJQLycj39kDISYMxbQGWRObFay6FjD8GqvQX7bwdWQ2ndKUs1rR qOdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533030; x=1782137830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8uZNp+VwhVSjExHeT5LvpX51VbIe9sjYP4PbK25Inpk=; b=P2g2P4ljcB1MTbU0Aj6YBDcvYlQ9OqDyaJdaSXHlRPdnLPVo5H55OrflBlnQlBAIQV r7Mi2QhwF9tpjWh4UFlSB9WdqEXATWFab55kRVfcPleXbHMG7T7in27dgIaTVM9ik+Iw HZckWSj5g3VFjPs09BCuw7edBTlkinqPMlkXPKcPuXfC1IroOssAIxDHm2E+kIREzBKz SgfiRLKNVeGjOfQo/xS5ct85GvofMCJwZC11/Q61egB5M3VJioNMmSiw4DFt6iW5vRJF JM1RUJmXq3IkPy7dZu/U5qXSMwaYbwmLS1l5paPd8Yl8GzruWurCuZiN4I7cJiVHg3WP J0bg== X-Forwarded-Encrypted: i=1; AFNElJ8FAywdtCEHUASs9plT9TEtko0C2wUqjNv5DSCaEJzPWW5XJAQnKkc6fGPrCIBD2QwG9p2/oWAf1lHu9jE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9bboytO5ATdXsfg86uSmW65uELlRwbQJgGjNSrWJDa7uDJibs DC4mgEXBg7HK4iFWrvaZYnKr7rS9ME7MD8gUlfM+USa1yOHgwQJ1npwFgd6SKxk9PRrR9uHO6LY BMTdzmw5udLUvkOG2WtulJ7rDeFUQUPwADY+ZeVMcyqWWA7mq76v+mi9l3gH7RwMBBjo= X-Gm-Gg: Acq92OGOAQ+mp1zCXaAQVFD8cBLA5f3tcXMpwvd3NOyXim4SPlXvnZrpRJUAoXQaC8W //GUrrFsSaR9+i195TfEMSwufnHLzlm/TsEssgqBW+wB8o+qzQtta+2ImifD4EbHVrfm0ADyMGL 88FcxEKIc3u8vqDTjsXci5qXJCBCJXNEwe5rniN7fL476r+8RnI9FBSTdj3E0MinEzyweGhfFmc +CHdWlIKt/mZ3Q/qhf9K3voIiR40zUJ8QcuUc+oCf/wWzAN0OBtXNtJKqXgxEZMQiMaHoZd9pQI Q/rAtMRu7hBACpSFLbOHLhYqwm1hV/00R04v/yUCR/bHY0T57G8hlhnv4ZD30Hh9yJb3hcKfzxL i1gtCwilCtF2BUwUlp3vHIXWuTiYoJ8RmlfkEhbeBv4DKonzj0CB8peI= X-Received: by 2002:a17:90b:57eb:b0:36b:ba9b:7efb with SMTP id 98e67ed59e1d1-37a01a3bfa9mr14972742a91.5.1781533030381; Mon, 15 Jun 2026 07:17:10 -0700 (PDT) X-Received: by 2002:a17:90b:57eb:b0:36b:ba9b:7efb with SMTP id 98e67ed59e1d1-37a01a3bfa9mr14972697a91.5.1781533029836; Mon, 15 Jun 2026 07:17:09 -0700 (PDT) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379e8cc467csm7172476a91.2.2026.06.15.07.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 07:17:09 -0700 (PDT) From: Praveen Talari Date: Mon, 15 Jun 2026 19:46:52 +0530 Subject: [PATCH v5 1/2] serial: qcom-geni: trace: Drop redundant len field from geni_serial_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260615-add-tracepoints-for-qcom-geni-serial-v5-1-2efa4c97e0e2@oss.qualcomm.com> References: <20260615-add-tracepoints-for-qcom-geni-serial-v5-0-2efa4c97e0e2@oss.qualcomm.com> In-Reply-To: <20260615-add-tracepoints-for-qcom-geni-serial-v5-0-2efa4c97e0e2@oss.qualcomm.com> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Greg Kroah-Hartman , Jiri Slaby , konrad.dybcio@oss.qualcomm.com Cc: Praveen Talari , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781533020; l=1611; i=praveen.talari@oss.qualcomm.com; s=20251114; h=from:subject:message-id; bh=QHuJbNfZclwAUqET6A1WfhO2/jqOdVEs9Fpda71LKyc=; b=LwNaeHXnoABG3t/pEhTPPctahozCFsxBP/IKBq8jFegkPwyzPiCxL7Yo7rTJOBH3ODTmsdmzd FmB9mHxSnI+BXmKaBGOvcbCvfn8r9msx+EOYbf0Ftnnq1DKmQmbQyCB X-Developer-Key: i=praveen.talari@oss.qualcomm.com; a=ed25519; pk=NGK/88fjyHXgfhIKwag7+uIytOmyOypvZ/hDFaYPEss= X-Authority-Analysis: v=2.4 cv=V5tNF+ni c=1 sm=1 tr=0 ts=6a300967 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=lKnyCkGSJWauGj82uDsA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: PUEu3Vi-5k44wOx0WypB3-1u09deHXv7 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE1MCBTYWx0ZWRfX53dStukMkgTx xtsARQWrBvXFNk6BiSq3vzsQc3xHcGFdKy8xQKcn3ULDM8QugNxxMQzYRrCyXWnuLhDcyO8/Lbs 09Z7576DdJbliEbDJ7f+tOZvX60Mrtg= X-Proofpoint-ORIG-GUID: PUEu3Vi-5k44wOx0WypB3-1u09deHXv7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE1MCBTYWx0ZWRfX9M+TYDRbfJlP H/57GZYbeV+2G1aKH9dd+vyY2Bu1FA9W/dBTFlA0zjkPkQBQpJGSeCYJLx0gi/q5niphF/phi2R MMOjwdPe8tWq0Gcvw4VLlFs67yn7DRRSFdG/Upy3G6txIQcyccL4fmaHfI9d6vLChD2JfCR34IQ eilvUjvBJWwkcTnQxbQlWdI3dF9xJUgpEYxVqNfEuUYh2pLccnqskTnGGSzNfDzmfRTzDhfbXJz UDAC6khqjhCXcNljNJLMrGQcWw7/oC5JL7BCwsKCCbVm2RrtDTUyFVxX2pMqu8dqW6X3UIjuOL1 MeSnKEydZS8sYb7iehWEAdpA7iTh3x6TXvRmou8Ae/xxAN5WUs1uw1fi4ZKXSETKUsUL9vCkbfi UCcqvcA9tpSMkRYv+5m9oZXvKvUcXfdaVdcOokug7qpUNkAr9cau48cpgL/NRvi3yt+JqtoXc79 G+Zi/PGtXFTiQ77M5uw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150150 The dynamic array stored in the ring buffer already carries its own length in the array metadata. There is no need to also store it as a separate scalar field in the entry struct. Drop __field(unsigned int, len) and the corresponding __entry->len assignment, and use __get_dynamic_array_len(data) in the TP_printk for both the len=3D%u format argument and the __print_hex() size argument. This saves 4 bytes per event on the ring buffer. Signed-off-by: Praveen Talari Reviewed-by: Konrad Dybcio Suggested-by: Steven Rostedt --- include/trace/events/qcom_geni_serial.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/trace/events/qcom_geni_serial.h b/include/trace/events= /qcom_geni_serial.h index 417ec01f9fc8..e1aa551d525e 100644 --- a/include/trace/events/qcom_geni_serial.h +++ b/include/trace/events/qcom_geni_serial.h @@ -97,18 +97,17 @@ DECLARE_EVENT_CLASS(geni_serial_data, TP_ARGS(dev, buf, len), =20 TP_STRUCT__entry(__string(name, dev_name(dev)) - __field(unsigned int, len) __dynamic_array(u8, data, len) ), =20 TP_fast_assign(__assign_str(name); - __entry->len =3D len; memcpy(__get_dynamic_array(data), buf, len); ), =20 TP_printk("%s: len=3D%u data=3D%s", - __get_str(name), __entry->len, - __print_hex(__get_dynamic_array(data), __entry->len)) + __get_str(name), __get_dynamic_array_len(data), + __print_hex(__get_dynamic_array(data), + __get_dynamic_array_len(data))) ); =20 DEFINE_EVENT(geni_serial_data, geni_serial_tx_data, --=20 2.34.1 From nobody Thu Jun 18 19:23:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2AAF3FA5F2 for ; Mon, 15 Jun 2026 14:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533038; cv=none; b=iXUaqo6SFaSJ6FkE4JNi02fnPcpLo54jjYXYVjSupC4D3NG3RXJ8OrrknccwKt+ZkT1OZ1T1WSPNR0mACxog33o2dxnWona0W9QD5xkFHRsTLso8v/zPhVMR1b7eBd/sYZJgWxT3L63BymbIumky0areXPMIZyqW5J20Vg4/A7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781533038; c=relaxed/simple; bh=UK0w8cVX6HonoLLMdXc+3FVa/9hg3gdhTjqWi4T6mns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jF/gkj22WeGAZztIaaf6vnMGcMF9+D6DLuBO0qVvVaySkaFV+6NUqWb5UagyxwM/xdf1FaqWAddwF++JoN5PpcncOa2dN7BI2f9FYWNW3gTD1N9rUr2L3s3NEJq+ka+3QRu1O2CVzsGOxGynxSTfN4njpSC213Zu2bZkB0GdhIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UJmt6HOi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A4vAyvgW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UJmt6HOi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A4vAyvgW" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FCZD0S022053 for ; Mon, 15 Jun 2026 14:17:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xxStlaNB4x9Mu659Ds+9UQmpLOGQ5xsUav0PKNZl0Yw=; b=UJmt6HOi/rwRra3t l8sp3S4SBw4CBG7/oogEe0jOCglWUD9Wyay1ePvVTVrC4m4S9C+3QPQEiYk2C1Bh 7acHVV2/bed6PEr7p4DsTv6sRHj1olZCdd585/6Rzui7TLXj6wkNp7iA7LMCZUMK QXbstIGi+U+8thXf68JzSaxUlBl50rYxap72vUxwabEsFnXzbZCjAYXrTNxBl1U5 +jxFsBVC31EE/fEdEjxjw/jASWeEBv6a77EnNE+P5qLJmnC4bbcXeeSYCCpuM4ov 0858wR1WVJs+iQbelDa8WSvl/6Xwshud2VfoOvDL8uRMev+REPj/Ac2kE+S1Mowe DYPHvQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4etfa70y95-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 14:17:16 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-36d97955899so3334329a91.0 for ; Mon, 15 Jun 2026 07:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781533035; x=1782137835; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xxStlaNB4x9Mu659Ds+9UQmpLOGQ5xsUav0PKNZl0Yw=; b=A4vAyvgW8d4tSA1qG9WHBJKH2rDZtVdyRVCJV0ZTbCM725BxdSaCpuGPqsbhbLJM9c gyO7/oBgc0mSKyGNlUmspys6DPw2dA0b/h0L/yLuzwczaeNtYBAwgcWmipDeoTjHH6t6 eSZ6z8TDJ6E/0jEOWOMx3omQEGVVQlc3p7Rv4qNfGvsm1vJZWV691EdyvuC5nBgNVOf9 coV28PYhqNko0J4ujE0G+EiOiAiD6yPpzoHyvcM9FXeZGqvqOr/A2HzQDVAioI1vaX/P AS+YUGziPWSkAUJoqMxGDDw+Sk1c9x6Xti4OtW+NKksDj4HMYt1fHdkPIsa4PPT34rjI VAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781533035; x=1782137835; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xxStlaNB4x9Mu659Ds+9UQmpLOGQ5xsUav0PKNZl0Yw=; b=DVQkftdueepcubG+ArdVMfJaylvLfG++J+ZZeBmVq9cOrCuFZilgv4Q8XcKmQQ3X1I ecpyqTgzsaPvmCuZ5aTwgf9lRt6a1UoHzjC7y1UWf/14gtZvR0Uu92rj0rMLqirpXFCu oq+i34hqEESD1xAetuO3gAhxWPdnCeC0yWgeouJFVKXnel4MyCm1A1q2DSBLBsC4IqiG nsgCKK1Msp5rlKjighSdTopK4aaCaB/DcuhnYRwkJWtwGuc2IvMw/G0wr5PNJ+q5CZz6 ponkBFMNQgRWVlCHJ2fIsezzM3vwdqZwcgNjKorhNWEF7W+RNc3e3HhHqwgWc4ClumV6 jVUA== X-Forwarded-Encrypted: i=1; AFNElJ+h3SBCHfXZla9jpAVah3I2kT6ZuTUdiLeWYV/0kHFBFPYmdLBcv7uzFEjz4ZiToOiO65vH6XipdORLrSE=@vger.kernel.org X-Gm-Message-State: AOJu0YyO0yPJZdEa6gVjvtmX39H2sKNHdB5CxZ+t/Esb72BK6EPA/LNY xMxt53EUebay05o4X5ovqFAPs76/p//wBpt8mFYup/44lEHBmKX8qG2vF8gQGmhVVVyiNt3j1Dt cHDVI/EEiHwbzZEESy+ngCzAd31Ot3/PePmded/LM7e6NvKxsugm54ePhWU74M4YyVeA= X-Gm-Gg: Acq92OFDBswiDgrlP7X5S2MtLlW4wYoTNYh3p8dvcWoTMslsNYo/+fnAiDC8OMIT74e I5Y586qXA9NFHEEb4RDRxviiiqYtySqjKhIqrEVnqahlsf5bcxxhw9XQeHn68eV1ZZT8NjJQqLw UI/Sf1Wan0+QtJqlIrAxSmydvWe6LMmJ2cuQHxyOdF2qqNt9hlqJV0n/wLkC9B4rdg+i5ITjfcj CeZTj2JVR+3DPjUNwQyctf8F0L/jzHg/XspUguzonuM+/QlqkBhIdsxRNy2p5acsxMDt9g1v0V/ TgOACy1nKVrlmsXCm1pBVbffYXkKrWEiWuKKY93o8wDRACiE5lbs+IP0SfnOd9VTTDgykJ/o0UN fp3ZDuteVnag99dQA9PVCv9qJPK1H99dtE+jBjcUec1nA8BQ4yQzlGF8= X-Received: by 2002:a17:90b:514f:b0:35a:189b:43db with SMTP id 98e67ed59e1d1-37a0184a3bemr15713042a91.4.1781533035407; Mon, 15 Jun 2026 07:17:15 -0700 (PDT) X-Received: by 2002:a17:90b:514f:b0:35a:189b:43db with SMTP id 98e67ed59e1d1-37a0184a3bemr15712968a91.4.1781533034731; Mon, 15 Jun 2026 07:17:14 -0700 (PDT) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379e8cc467csm7172476a91.2.2026.06.15.07.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2026 07:17:14 -0700 (PDT) From: Praveen Talari Date: Mon, 15 Jun 2026 19:46:53 +0530 Subject: [PATCH v5 2/2] serial: qcom-geni: Add tracepoints for Qualcomm GENI serial driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260615-add-tracepoints-for-qcom-geni-serial-v5-2-2efa4c97e0e2@oss.qualcomm.com> References: <20260615-add-tracepoints-for-qcom-geni-serial-v5-0-2efa4c97e0e2@oss.qualcomm.com> In-Reply-To: <20260615-add-tracepoints-for-qcom-geni-serial-v5-0-2efa4c97e0e2@oss.qualcomm.com> To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Greg Kroah-Hartman , Jiri Slaby , konrad.dybcio@oss.qualcomm.com Cc: Praveen Talari , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, mukesh.savaliya@oss.qualcomm.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1781533020; l=4256; i=praveen.talari@oss.qualcomm.com; s=20251114; h=from:subject:message-id; bh=UK0w8cVX6HonoLLMdXc+3FVa/9hg3gdhTjqWi4T6mns=; b=qTbvMsUOC65Bt7ZLTkLfW54/qFSjUxfHmp6BMI0qwDqiP42Ml3uTZGq2DsyEV+gNq55q3IPdH e6PCr/CrgyGCOLA+sYrx/D/Rywd9phNURw0u2ZI1ocRUpjEirRPcvKo X-Developer-Key: i=praveen.talari@oss.qualcomm.com; a=ed25519; pk=NGK/88fjyHXgfhIKwag7+uIytOmyOypvZ/hDFaYPEss= X-Proofpoint-ORIG-GUID: QtNGrWnf4EqiSAxrU6ZzoxdxQhdJOSsl X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE1MCBTYWx0ZWRfX1/hiahE1imIn T0qZxUSbAnTxPxsv01vT9BUOnmWNfLMWvhgYluLa/kB43U0t3lnPvzW5BQe2/FqVWIgeV3PlRXF U4YiCjN4CIxoizSToF/sapWEzIHvoPw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE1MCBTYWx0ZWRfX81uUaZ9Hqvhu pS0r0VH3VEbTEoxGJ91LDSRWblx9SY16e9TTkrqHd4JUR9VNMYjwOCxpUSepKUGgg4Xx3h6mgwm Ln/PaLi5iH67E2m+tQA7msUV6Ihx4H/JI+B83r/XIfyHZ07o7n/r4itI+rMvhJNvVhR6RbB9Y5x mP1+ScFuu2Q9jex8lIxofyve0FcNI19ILwTj3VweAqCA9f13jDCBL8PO/msLo3/JvgFAYT64yuH 9Mg5MXgcn681fvKeUlVl3Bz1DiYrEV2hVz8KZvP3mMFgojzYSOXh3rUTuwv2YMDyr7pFmvi7tOD ZHT9AZzHJ9DAYVgf1NzZ2oZanQUIr814VLyz5wMttJcoVjSmN7WK6DSxTpoFuogT3UHhvuLABz6 VYIt5ft+F5KPB0lDAyn+PQ+3aeNEOiRbODdY2W6Db2ADaE75GrHsZrgU4Z+ikRuXrqvt54SItYj lc9qMkXgVI/JxLM69zA== X-Proofpoint-GUID: QtNGrWnf4EqiSAxrU6ZzoxdxQhdJOSsl X-Authority-Analysis: v=2.4 cv=AN2yTM5Z c=1 sm=1 tr=0 ts=6a30096c cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KXSloCXmEunfo-Xy6rIA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_03,2026-06-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150150 Add tracing to the Qualcomm GENI serial driver to improve runtime observability. Trace hooks are added at key points including termios and clock configuration, manual control get/set, interrupt handling, and data TX/RX paths. Reviewed-by: Konrad Dybcio Signed-off-by: Praveen Talari --- v2->v3: - Updated commit text(removed example as it was available on cover letter). --- drivers/tty/serial/qcom_geni_serial.c | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qco= m_geni_serial.c index d81b539cff7f..4b62e58d4918 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -7,6 +7,9 @@ /* Disable MMIO tracing to prevent excessive logging of unwanted MMIO trac= es */ #define __DISABLE_TRACE_MMIO__ =20 +#define CREATE_TRACE_POINTS +#include + #include #include #include @@ -226,7 +229,7 @@ static void qcom_geni_serial_config_port(struct uart_po= rt *uport, int cfg_flags) static unsigned int qcom_geni_serial_get_mctrl(struct uart_port *uport) { unsigned int mctrl =3D TIOCM_DSR | TIOCM_CAR; - u32 geni_ios; + u32 geni_ios =3D 0; =20 if (uart_console(uport)) { mctrl |=3D TIOCM_CTS; @@ -236,6 +239,8 @@ static unsigned int qcom_geni_serial_get_mctrl(struct u= art_port *uport) mctrl |=3D TIOCM_CTS; } =20 + trace_geni_serial_get_mctrl(uport->dev, mctrl, geni_ios); + return mctrl; } =20 @@ -254,6 +259,8 @@ static void qcom_geni_serial_set_mctrl(struct uart_port= *uport, if (port->manual_flow && !(mctrl & TIOCM_RTS) && !uport->suspended) uart_manual_rfr =3D UART_MANUAL_RFR_EN | UART_RFR_NOT_READY; writel(uart_manual_rfr, uport->membase + SE_UART_MANUAL_RFR); + + trace_geni_serial_set_mctrl(uport->dev, mctrl, uart_manual_rfr); } =20 static const char *qcom_geni_serial_get_type(struct uart_port *uport) @@ -684,6 +691,8 @@ static void qcom_geni_serial_start_tx_dma(struct uart_p= ort *uport) xmit_size =3D kfifo_out_linear_ptr(&tport->xmit_fifo, &tail, UART_XMIT_SIZE); =20 + trace_geni_serial_tx_data(uport->dev, tail, xmit_size); + qcom_geni_set_rs485_mode(uport, SER_RS485_RTS_ON_SEND); =20 qcom_geni_serial_setup_tx(uport, xmit_size); @@ -910,8 +919,10 @@ static void qcom_geni_serial_handle_rx_dma(struct uart= _port *uport, bool drop) return; } =20 - if (!drop) + if (!drop) { + trace_geni_serial_rx_data(uport->dev, port->rx_buf, rx_in); handle_rx_uart(uport, rx_in); + } =20 ret =3D geni_se_rx_dma_prep(&port->se, port->rx_buf, DMA_RX_BUF_SIZE, @@ -1082,6 +1093,10 @@ static irqreturn_t qcom_geni_serial_isr(int isr, voi= d *dev) geni_status =3D readl(uport->membase + SE_GENI_STATUS); dma =3D readl(uport->membase + SE_GENI_DMA_MODE_EN); m_irq_en =3D readl(uport->membase + SE_GENI_M_IRQ_EN); + + trace_geni_serial_irq(uport->dev, m_irq_status, s_irq_status, + dma_tx_status, dma_rx_status); + writel(m_irq_status, uport->membase + SE_GENI_M_IRQ_CLEAR); writel(s_irq_status, uport->membase + SE_GENI_S_IRQ_CLEAR); writel(dma_tx_status, uport->membase + SE_DMA_TX_IRQ_CLR); @@ -1294,8 +1309,8 @@ static int geni_serial_set_rate(struct uart_port *upo= rt, unsigned int baud) return -EINVAL; } =20 - dev_dbg(port->se.dev, "desired_rate =3D %u, clk_rate =3D %lu, clk_div =3D= %u, clk_idx =3D %u\n", - baud * sampling_rate, clk_rate, clk_div, clk_idx); + trace_geni_serial_clk_cfg(uport->dev, baud * sampling_rate, clk_rate, + clk_div, clk_idx); =20 uport->uartclk =3D clk_rate; port->clk_rate =3D clk_rate; @@ -1455,6 +1470,10 @@ static void qcom_geni_serial_set_termios(struct uart= _port *uport, writel(bits_per_char, uport->membase + SE_UART_TX_WORD_LEN); writel(bits_per_char, uport->membase + SE_UART_RX_WORD_LEN); writel(stop_bit_len, uport->membase + SE_UART_TX_STOP_BIT_LEN); + + trace_geni_serial_set_termios(uport->dev, baud, bits_per_char, + tx_trans_cfg, tx_parity_cfg, rx_trans_cfg, + rx_parity_cfg, stop_bit_len); } =20 #ifdef CONFIG_SERIAL_QCOM_GENI_CONSOLE --=20 2.34.1