From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D7438F923 for ; Fri, 12 Jun 2026 18:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289031; cv=none; b=mlGCY3E1/74ZymlG+GVLh+lVR3pJADKbm9xiWWMCxIWk5YqtM4szej34sUtWF7btckBQBZgBSx6Nk9XwH7Isalk1UE9RlsyVUravcHRnW/82GuGCgi4WiB2ZVD8oShX4DAPszkzWCp4RJx44FEEPjjdVAMNc6r06/GY+sRozJSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289031; c=relaxed/simple; bh=ns6ZF2Athx6EXhPPsCUzdeEz8OHVy14bl5aTVdNnAU0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GxQRuzOLjxvdMVozdG8r3/CklbSxb4b7RPHuZfPgueyKuwA8RjFi3bdSAefeHIg8LliwicxAkpO1VUUXaT5unWgeMPHWYLHPJRcQtwzeDPn/9w213va+dMQz6r/2ekvbxO+GNBhnJesQgMPwABvyTtlKGKNuo+ZvHtbowHPy4YU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ivZnQjum; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GoCy7M90; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ivZnQjum"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GoCy7M90" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGVeaF4112816 for ; Fri, 12 Jun 2026 18:30:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VAc5Ikptycwe+SAdBBV6cT/v4cLIQIAkYHbY8Re0nJ8=; b=ivZnQjumAYn2ffrl Is7Sqx+bhSIzdvC7QxA7pmrNJEMhayWPE0cI+oG5wiLKNDeGlQayknv61BqZtUEf 67MjnN7JcLD5O8FfZ+hDb5kLXtfidZb6E6gg1YmI4eFOmmjuc2UKM//YSgSWs/R0 +seWyK/ZwXEJhtPfySsS6VMAkDWHI7Q4SdFa+SIjW/wY0aF+LEuO4M2bFJxRXjfa y12GojzejfbWsQSiK5GYXPfHPu+OOJTAxo11p2LznsRppvPat9ihKmXDafdqicG0 g1AhstVX2RVdddrKeSIhnvNsk2BxVw6kF2SD+uqShvJaTNzGfGk5hI7sBbs1feBs RuRDVQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er30gc2pm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:29 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9157ae36434so181046085a.0 for ; Fri, 12 Jun 2026 11:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289028; x=1781893828; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VAc5Ikptycwe+SAdBBV6cT/v4cLIQIAkYHbY8Re0nJ8=; b=GoCy7M90rpHsLKhLPjp89h3vZuO0e5aXnMI+mY/RyGeXPcrTqnxUCMJVc86R6bK2sn 7F4wjttpjxIVpvnIjOzxImq/9sg0riqDb7rOERgRuvMdE71IuKvvcHkK2gEPgn6ydrLK OEJRQIy4YXMAofV/fjnOhwCa51mNtyVIe7SfL4jNbynlaC96DIFYql33BhDIBmfRmIii INAO5x6ntdPXRCdyMu7ivQc71aSTp0szuVADfDs9IOfP2/t0QGEJi4sWZbx65kZcgwy4 0Sp+JTaO4rlTtN47/BDUjsbM+U+kHkFGBs0JKjDMnurY9xHjtCK8cfBjPLsOApBkSFtO ucQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289028; x=1781893828; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VAc5Ikptycwe+SAdBBV6cT/v4cLIQIAkYHbY8Re0nJ8=; b=Q+zcn3uF0lLoX3kGzOP11OPO3CBjUKZmjcAmlcpDDwH/ztk+GJwa0rb+KqcUvEvhrg NB5Ep6tmhMWtqXS6LEEmwakAQTR1SyRhcryI0/8IAqMAkz3o0vAbe57mf1PaQTxA9Dz1 x4GC2f7UP8TvYmACqkccKnIjOISCucxOgzZzXtmTAtd1+zreyjkVLVFSnseoq3B9/Coa mYZ9LbMgjljjP0RjKX2QP5JYIHRA3tj1ToLfcFc1SYBpkJw/EgEWyQoCRTtOl65adE30 i9ui26JdRJ306vlI5r1Jsku58yM3sp1iAKoay3HkI6miiAM8S81OAbdWcad9C5uDYGZO g2Pg== X-Forwarded-Encrypted: i=1; AFNElJ+1GGeLyEkMvyuCUSG0HpHXEXor8VAGuLDB/6qHkh9uWpvzFKKamTGuYWXMoHA82zX8GBCdjaNRMMQt16o=@vger.kernel.org X-Gm-Message-State: AOJu0YymhSISQfqj8jvEWnLIeZTh8pr4Htx820/CwOeL9SxLKQcBGqgZ vQmvSbIWxPmBWlpFWj3mv+j+rNZf5uMWpy2WuQxiVw9ojt+2kEmCIPCSlbeW//qHn6Y1kyBprAU e3m5AWgF7zf6RY80z46k++8NTO2jrWilJ18Kx2Bn2ODKRBP8SZ5paUsDJq5q0NfmRLMo= X-Gm-Gg: Acq92OEU+dRH7c2aqswGF7YqXJh0Z+tPWUvWv9ja6PKvFPkTqLsOtjXgQns1UXM6JXP +hNGeGtmNtedpfeC9ssPYbI+Uc40k+2Ctphw6Kpdk0xbf6WeUWxl59V/kofHTDp2Yy8y3oSBdFb 1QSWhzT2Z1n8ZHgu0WKHKtDEkoqgIT4WNmltqsld21NBRjgp0v5FutjUiyRC2yD+atBRgYvdzS+ S4UuVMz6bFfm5jl4suTxmZmrVnOEIq9sxY2U5xdAINFtSNHA7BmKmOS/lkMxf+uT7KVU0dsbFWv nqyFC/z2wQTFZLw9VkrKmnQfGfJez0lnah0VCJsqNnwG6cWlMbJ/yXAek2dmL1mJoD+p0AeiCd+ 1hcE+zvWLkNlaQYdDFiqwClYTyWehZLMpbt9jTvplMSdFTnLFCrt1PmS+7ZRfeRknLz6uRBVNGZ Rw+MzzazElpOHAyZ7wqhwMnFlMcUyQ4b+c1q0= X-Received: by 2002:a05:620a:bc8:b0:915:a73e:3544 with SMTP id af79cd13be357-917f1c56720mr144560385a.56.1781289024477; Fri, 12 Jun 2026 11:30:24 -0700 (PDT) X-Received: by 2002:a05:620a:bc8:b0:915:a73e:3544 with SMTP id af79cd13be357-917f1c56720mr144477285a.56.1781289020618; Fri, 12 Jun 2026 11:30:20 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:19 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:11 +0300 Subject: [PATCH v6 1/9] drm/managed: implement managed versions of kzalloc_obj/objs() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-1-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1773; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ns6ZF2Athx6EXhPPsCUzdeEz8OHVy14bl5aTVdNnAU0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2BP6d00ejrEHxJYdHp2X9IJejczYLfY75d jXdts+qMaCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1YyuB/4/+1uiqA2fryPtK0Q7ctr1kG3ePgcUSkHFnblElLxP9p5KAV0NVSrsZu64PP9Uw8QhEHn eku5gVTB4fteWoAdmRV6MqED5jUCgtzKxXw31I6q2yE0HMzROPxsuZqjck649m6vQ+6gjWPoIYP tSvCAE8vpvPK2pQ8s47BDO71QWO174Xdq0Kyv6QPCsjDT1q5muBBfuIckdqMamMRRmXbJArYrNK GKbQ97M3DoUAW3s0S8dCBmtmiaDK2EvYKKZZ6xfYMjkleX/ieanilprQ/xFXxojPr8xMZnF96Zd t+bDLo/Q7QnIlQtPjN+RW8IeT2wx6PpYUovOoPNAnHFW6kFr X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXxdcjmGOQAdrl gatwpVhsFWN61n+sU/TwDCy7nv8XyhQnjiY7fHiEDN0+Ab12XWsbh1wEkF0S2cdlRXb5dlFRp2x rM4EqBO3/VEDKtkSyBee56KNuiN/FrA= X-Proofpoint-GUID: 5ACJD8_fA0-gpc8NJrG6AslhcITHANMu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX9GqaN1Frw7q7 2B1Fg0ngfK9V7RimY+v6xcnC6xlC055vEQAXsQJs6tv8xYYfAsWmlnaCW+mEYSVsq10YfrNHGel uW5CtglN969zMYVrVNzVJU9yrb9q3mK+ghKaScuC2dRRpjns4EqqsG2BmgGhDoTx5IYGp56FHoc WGeTaJix3AtsNYekBwODxqZa/NsNtG9SrdvhEQn4m9wbbOBeA62HqVmLY8mLzDAj//+X1lbJMu2 b52PHsQRZLh48FakI7dSLipHbI9ILxlxt3SfQy35L50f5FbQ9DSfOPA7KfirVoeE08GSZc/FuyL x5Cstkq0YHnNFkfjcuNdJ401PAX0LFPsrrJ2qahHJbZyG0rdTWID1NRGsblYiTZqIQAMk/x4b+H HINZsXIfaab4+yov0jHkTjVuTrAmCJxmxZICIHuzKS4CX4VEFUIXSN/dD+7xn8y0wKZJj1oDQl4 11/sRKJnTobqztqbLSw== X-Authority-Analysis: v=2.4 cv=evnvCIpX c=1 sm=1 tr=0 ts=6a2c5045 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=6OF_V-VfZv2apoI2bYYA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 5ACJD8_fA0-gpc8NJrG6AslhcITHANMu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The kzalloc_obj() and kzalloc_objs() functions proven to be useful and widely used for the reset of the kernel. Implement a drm_device-managed versions of those macros to mix the nice interface with the automatic freeing of the pointers. Note: the original macros accept optional GFP_foo arguments. They are skipped for now, making all allocations use GFP_KERNEL. If necessary, support for overriding the GFP type can be introduced later. Signed-off-by: Dmitry Baryshkov --- include/drm/drm_managed.h | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h index 72d0d68be226..79049bec277d 100644 --- a/include/drm/drm_managed.h +++ b/include/drm/drm_managed.h @@ -105,6 +105,28 @@ static inline void *drmm_kcalloc(struct drm_device *de= v, return drmm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); } =20 +/** + * drmm_kzalloc_objs - &drm_device-managed kzalloc_objs() + * @dev: DRM device + * @p: Variable or type to allocate an array of + * @count: How many elements in the array + * + * Returns: newly allocated pointer to the zeroed array of @P on success, = or + * NULL on failure. + */ +#define drmm_kzalloc_objs(dev, p, count) \ + drmm_kcalloc(dev, count, sizeof(typeof(p)), GFP_KERNEL) + +/** + * drmm_kzalloc_obj - &drm_device-managed kzalloc_obj() + * @dev: DRM device + * @p: Variable or type to allocate + * + * Returns: newly allocated pointer to a @p on success, or NULL on failure. + */ +#define drmm_kzalloc_obj(dev, P) \ + drmm_kzalloc_objs(dev, P, 1) + char *drmm_kstrdup(struct drm_device *dev, const char *s, gfp_t gfp); =20 void drmm_kfree(struct drm_device *dev, void *data); --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B373A641F for ; Fri, 12 Jun 2026 18:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289026; cv=none; b=cR9Nhstzr7R11WI3h5n5mGhOXa90XFLw4zhBzFZb0m6zXKw0aDujc/wQ7VeFs2a98h6SEBZRuiyf3raTdURmePVm7dMgDPxWY981wvwkWYNEwMOkw02MNX55jXf2uhn9sUnhd5VQNTYmNsEgXRJ5dr2tLqVE3GXWc8wCvulYuIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289026; c=relaxed/simple; bh=hLu1cwKI2bwQjArWh6mX4nFC7KW8Gok04gwgDGIykRs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdEQps9O+D4fF0lUFU8NqXs4+J+6fDu0FgeWLlxMMWVRX1oXbzKvGG6xGbuhuD1VcE3XRBTT9FEJKKUSNYI8hi1x6BrvicWdBTdatdbbCmXnAUYfjJybA5SUacIuqaphhi6nn3PEQIcbrpH+3nTcTVc5rxWL5+f7mtL3c8B/wIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fFyj2AKo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L/kHukEJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fFyj2AKo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L/kHukEJ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUkFm4153136 for ; Fri, 12 Jun 2026 18:30:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=fFyj2AKooKHoOJKA NJgTtdivW3JLm+klRZc4PpTlm1VQTdUOBgkHjpNv+opgjkfzFCbs/xXVHNoIb8IP tIY4D0YKYKra6h+5juTT/O0WTaHR67EJ8J9eZpI12fu03EjveSnXBiJXWkJnotN8 BdHxG7ipbukle14/tTq9WSiXQCQUTi+u0CK0zUnFql52yCXNdoNswkDV6/5bc4w3 3cUFwu5KE94MOEUlr6lGn10HTuHcGo+wfQfcqerphjxnbSWG7LPtvgR/XM5w+7vZ D+ZXrEgYUErJiDyl2MUJrkd4VornswnCb0xo0hjn6So7K1550uobZwDtjyCuJpC6 oR3wgQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1xcm9ge-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:24 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9157f1be083so216137185a.3 for ; Fri, 12 Jun 2026 11:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289024; x=1781893824; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=L/kHukEJez9pNilhYX3dXDygQ4lJntOREHj6i+9Sr5lfXbJoRBIIJxtUGPxa1Sv7Cq YFY3y5SV7PYidTkzRVG6LLA+fhaMs6rDC5v2yU0K3p40y1QO0zs5S4B1tpmxDNH5BMKC CK6iv+oGd1bdjRmhP1AAegxBRHAdlCeLc2/oYXhUke8++HF0XcfyWw5X38yvLiJSPcQF UBPflURDeQnA3DvTUTNO4BQSgnmIGtcL5u/mSXlD23sjyi87zDdFBjv7A1NbziC9llwK otCchmfZdwfZnJW+1O+4RL39E3EyWy3YalSxKJ+p0kLl+nLViLlxdxJ4Ca+hlxsIViRJ 9Phg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289024; x=1781893824; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=49OPqlKhqHIeEAhBZzcXi+3lZ4PA+n7d2F3AhuDo47c=; b=PqTS5PfbOzqRZHFD+HqPlfhf7hed8HfzW2MNEbOVmn/65dD9mYf52hSKpmaeBZWwbh Eh9stZJDw4QF8hSV0VSpuLKljR3WBrIxX/pooD3hJN3XNn4gJ5k6RQvnKWtGBg4ezVJw Vyx/yd8tKj5wAmUB7MRE9b8BGLIBA5OJ/aTQhzkZXnfGPJa6eFn4phlJB80l32V0IIeO 3xoEwQ0L1C1alRb21lxYOgznKr1wGPsv5aG+o7wkCBBmmElRh8MahFaHyD6tUZOnqMVC S4iMPNBuCDncEgUh+UT47eUsBLdIcOwP2vhp0dUdSzqByeu9hgExNr7C3AKzE3fAb8d/ JdiQ== X-Forwarded-Encrypted: i=1; AFNElJ/u/7GgN2pNkcIiy4pE7bP6leLdmr8u9YBd9RHvuBXq7+k4hIf4isDosOukQpT+j/Z3ruc/zFACVah1Pyk=@vger.kernel.org X-Gm-Message-State: AOJu0YwETqKqivqiMjakIPtdjZOP8gltfgE8WppZnb7my5iGhaTMyfLE p8AtQ8KtjS5Obk+9qSTxrrl4S4MUOQE4f6CwSBxKwzPeTfAs4lQMnWSRZyw2Ap0zfslKT7hNc+I ZJwKlojrG8IZtahlVsqr+SdSNouYPHojtr+t9F8eN1rI1JeApPSiWGqD8d+1+EjHEJVM= X-Gm-Gg: Acq92OHANsShoOISZ+N5hn+8QJEGPQdTFYIk28pa/URC21mY3lcw01ia81tJsmgprIO UMQemciRM2KyobDm0r/YqAxpA79Lo0BOy9kyPhfeMz3uhB92Jj42owuloAkcvWMsb/xPE/Pp39L x7Eo4ARNjW4x/Fyflf7SobhKXVy7n2+xZLPWiyHacg/7+cmzdd7idT+noZrB0FFRbbEd0krAt5v C1o4G6b0UTd7qx8uQ23NuTnHI2VoAxdlvkVjN6VDICNkokKHGZi5ppvRkggcxzQhOeGHlAt9iw9 6loSqUO8gBLkPvedh97EuuVbSdaYqgZF6MfnZgwkjWzlTyILu6m8AwwzdP4LvanGxV31POdoRVI kAuv0XAaklZFlUnPejZA/oSkYcHCtqBl2AQ8DV3uK5pHbteUOEkwXEbnn/P8XT1hGe+r+j/8d8K 0DF7Y/DDKPeMpBSyym/jRcNnEugF6v3nP7oEA= X-Received: by 2002:a05:620a:a0d2:10b0:917:fcec:cfe0 with SMTP id af79cd13be357-917fcfc208bmr80221385a.33.1781289023470; Fri, 12 Jun 2026 11:30:23 -0700 (PDT) X-Received: by 2002:a05:620a:a0d2:10b0:917:fcec:cfe0 with SMTP id af79cd13be357-917fcfc208bmr80214285a.33.1781289022999; Fri, 12 Jun 2026 11:30:22 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:21 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:12 +0300 Subject: [PATCH v6 2/9] drm/amd/display: use drmm allocation for writeback connector Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-2-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Christophe JAILLET , Alex Hung X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1809; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hLu1cwKI2bwQjArWh6mX4nFC7KW8Gok04gwgDGIykRs=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5ZOgNlx2RvH1rmncgWo3DgW+vltmevq93dm7mxf+Ev8u rbv61fHOhmNWRgYuRhkxRRZfApapsZsSg77sGNqPcwgViaQKQxcnAIwEbuv7P/965vCjkxfXj1Z UqjpR6ueWrD5vk8ixa0SSz5WMc8XTdxVdIpFd45lkOOtyH1s6ZwvigtCTzD8fhQZfGuZeX2NUCq jmUp84FsuuWjFjMrJO77/tTW6rmfIOl34nbv22bvT7/Dc//0o77D/+iLWy91JDV08gkb6s9lfTW VNm6U5rWI3x6HVK/ReKMvapE1RNnNg+CSurmvqGlGnONeQZa6/z4+jq6umiH9n4PvAu5/3Q8KN1 W9MOYN1eZLy/2icMarpbZNht9+lvoApLGfRMod9v/TO1drvk6y2Cj3qeNzSJHICi9vs7BbRTRoF aZuU0ta+m+y9gUWj4lbMr8edy14G3DWIM5qz+Ob2RttTAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX/NUBy7NbsylZ /QVEZOLuUiu/XCX1cIbh1s/TkF1zxOBXX5t9HxjV2GshSlEI1mQoSPIhas8BwHVkh3+USOodpEu pTsD9BCObOghn0W+pxtiVcVCP8EJDutBsRQnPM0BmLOpLqV4HFPWkM1Tzzk9NxeWQwoT12HVy78 VdnQk/cVrUxyNwdHrQEpF6T4QsOBuHF2qCmLEEH4ewCaU6xatDJGxZ38F6zy9BCxSTFOOiWuU4r mGtE1nEmE2bONOHfSVluDyLkWfUolgbG3mSkJho7gFufLs9H1iPEfAjOqEx6RuTGlbNAuIj8ys2 XwA60m0rEMnVo9CGCe7B3BbzSvYJR/JOxs0XDDWZ86kqFAGfFF5+FREgHFyNTsFx9lZ+nFH/kMj Fv1nO6JOzJir7zyIRWcq1TvM+rKILGwdHrDJ3ACanu1vGzlYxLCj6FGKQyaDwhbJz7XtL92k+Vp wOA/gUzS5tNiyjmbNxQ== X-Proofpoint-GUID: _AMrT76Gdjy_-JOECwslunudtSKAPhI- X-Proofpoint-ORIG-GUID: _AMrT76Gdjy_-JOECwslunudtSKAPhI- X-Authority-Analysis: v=2.4 cv=NZPWEWD4 c=1 sm=1 tr=0 ts=6a2c5040 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=zd2uoN0lAAAA:8 a=EUspDBNiAAAA:8 a=6a0IvY6ZUD0qJKO7u2MA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX91c/PiVAonGy kV8Ppsy6+qpaFhKx/18xaxuuZCw3XKNnpMFfG0v95HXqnjA4vOpchV4dVeQ3JELnUm19XSreMaL P39Dk8McB0EkQld3p30DkTdGq2Uy2g4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 Currently memory used for writeback connectors isn't freed on driver unbinding, leaking the memory. Use drm_device-memory allocation function for the writeback connector, making sure that the memory is freed on the driver unbinding. Reported-by: Christophe JAILLET Suggested-by: Alex Hung Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index ece581609cf7..436562e32e63 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -91,6 +91,7 @@ #include #include #include +#include #include #include #include @@ -5807,7 +5808,7 @@ static int amdgpu_dm_initialize_drm_device(struct amd= gpu_device *adev) link =3D dc_get_link_at_index(dm->dc, i); =20 if (link->connector_signal =3D=3D SIGNAL_TYPE_VIRTUAL) { - struct amdgpu_dm_wb_connector *wbcon =3D kzalloc_obj(*wbcon); + struct amdgpu_dm_wb_connector *wbcon =3D drmm_kzalloc_obj(adev_to_drm(a= dev), *wbcon); =20 if (!wbcon) { drm_err(adev_to_drm(adev), "KMS: Failed to allocate writeback connecto= r\n"); @@ -5816,7 +5817,7 @@ static int amdgpu_dm_initialize_drm_device(struct amd= gpu_device *adev) =20 if (amdgpu_dm_wb_connector_init(dm, wbcon, i)) { drm_err(adev_to_drm(adev), "KMS: Failed to initialize writeback connec= tor\n"); - kfree(wbcon); + drmm_kfree(wbcon); continue; } =20 --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 614BD3A7D98 for ; Fri, 12 Jun 2026 18:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289029; cv=none; b=bNMspz3zT/O89SmIJRSANhtRvy9mOC8JCwfvQyV3oXa4r5grhVkhKGMYvEJZYsivhv7Vy+MRu/v54oeoouxyvuyuQOYpT8wfGCW2h8Y4+Amcajbp+rVf7rsdA6dkhXunrpXzGFU+xMd34HFGMjwdp1u6d87Wt6EwY03i4hNs2gs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289029; c=relaxed/simple; bh=MbaRBOLwFT+ETgHAVWF3UBcaA1Q1ln0hWBI7tVGYbZw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KHnhJLliK8uuCmajCww3ex3x802zvB5p6VdydH/3ue+9Pq1ZwPsPhIyrPCztIogwghiNnl4+Yd+VsNLwIdIfFEIyHYUhALE2U98IB/1+0+KPDfvaza6sFkyO+Lc8y2bjjRCwpwsGurMGu8wBPwyAdAljNbWtXmohAcJImbdBBOI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j1kCkMsT; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gphPfVaP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j1kCkMsT"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gphPfVaP" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGVE0r047406 for ; Fri, 12 Jun 2026 18:30:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jRi4QyMfJKJttBAEFdi1P15sbORxIAP33IpeK1RT27w=; b=j1kCkMsTOh3LWhON 0QAKPzpA3acIfOXO/MvUweopgToy0P2xRi9aznHifE0+rqx+rgwxVa+amb51jiNS diq2pHZ3HdNXpLnuH/Y8YbB//wDxYLxd6pY0VEa6WNOA99OPxvS8iSEH3xtDC9up PoX4jX9sE5Vt6RQAkyTnGFs7JCsBrS37IDLHQPt/dsnc083oBVyOpRJUeGdP8ZKp Qq4EL7EYdFL6G6928vhzHGg7B3DIG3td+WYA9nEVqEAACrJxoWyf56n/pKwxPLti 7K+ENyiNIW9Ed/7pTcKcHCxJHJz7oQI4oBDmb0ax0667GojX8TOl4NPEYVMSq05v eL/I9A== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er2u440n7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:26 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9157d38ab37so122897785a.1 for ; Fri, 12 Jun 2026 11:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289026; x=1781893826; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jRi4QyMfJKJttBAEFdi1P15sbORxIAP33IpeK1RT27w=; b=gphPfVaPsHHQ8EfI4Ix4CxaU/HswAy5BAhRgTRMS5bAUpfiM55kfLXjYFzZGiwF0eQ gmcERF8hr2kwo9sEbdKMXuTyREZekltm3yb8fq8LHvWbFksiPRbLXaD3BQ5LATECZtNg tCDy0dI7qMWx/8HspVxDtOo/m5xPhWTk94c8VWtp7eL06FU0ziYyT4deWwhraYy7yEjg 5mBHAgapCA6ROs1wZoMlzWa0nYZqoJ1HspPv1RgaTkLtqjOPoHVuiW2ZMQG3ETQaGjsB EAvi673rN4JuxqNKx+yPyBL6e3sDipWdHqymPMfuM88rEFRThuFmSj3i3pSgRqydIcQb UYnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289026; x=1781893826; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jRi4QyMfJKJttBAEFdi1P15sbORxIAP33IpeK1RT27w=; b=Uwz3luV/oXKxRIjNf8KZLlsy6kPO2Pc7GP+6QAzt3x5STWaAqStcabj6qqwwtm1QnV ZTK2d/JYDBqH9zT2ODxJL40wfd8BIavIt0E0Wllhul840LEtKygr7iX48x5iuojl4CCG Oh2GHRi6w9Fmh20ItBFiGul+aZLpKNdmFZ046OYwuRiTKJjSukYQwT9uJWNXjP1P7H/h 0UvTlv5oYIVhRAVj7eLioared1JvKpCeV24nmyhxSiDrfMJl/QQ/UTo7cW1HuxB554gd 2h1ZMeXWkHZ8r7RKiNhSFThli2yl97gkfdkp/fJL0ldaLUstVnCoRilLujmX4qTPjDTA hkdw== X-Forwarded-Encrypted: i=1; AFNElJ+/PKzGfK5/HR4dH+x7aRskf2XbG5UD6WQnay/zfA85FNOsZm6H3HIalwU1Z6KTKyqK+8Cu4cUCfaO08Bc=@vger.kernel.org X-Gm-Message-State: AOJu0YwGmXSN7+gzqgUVd+0b0+TDUuB+FPvG1jM7uYZ/7tuCMqVR/N+t 13w6MyXVE0jo/Oxv5jXwEkC4Biqy+L6PwTbhhRfUXnGSZRgRu2i7FyRkLvpBsNShi5FlEnSs9FY bSXym0pG+8fHkM6pZ0RPrADza7rniQWgBBq8BbaTyIwSIQq71eI5WopoTW6+JtH/oi7M= X-Gm-Gg: Acq92OGqApqokJCsDH55jXo6YulvXsPG9qnDIhHuR7od2cci8P3U+tK72U6tVts75Yp xmDR5JbqbuQ3YZCaPhlOFhodp/cCjG8mcIRob10KCT1d9kxcSuI1ptt5Xaq7Ucjh8n8+Ox3cdZa UIj6gDPqrK5AHg4MiJYzHLP1xSCVb3TzyYQYNwt0wNogyVn0/YigE7B/FFwFEopiQ9I9zIC1LwE 59SOBv/EjusBUJ9CfR4j+r+S6hbLPIW2G49QYiedR1wb/r0nOyEwVwB6GcnazoxVQmeqZaV7rl2 xm9GUKbI4hczN/ttYp0Gq7uE+bnYuVEExhrsBIeRsRu2YFhvNbja2AHt5o0kSgdqY0GbyzpbOPz L3J8JUUSTcfZBRaI6WsT1act6AOCcHTuS9dHmF2y60GCIsNiHa83VsubTkjIvTNzEw/8V6tbEAD /moKXLRGWVb4eRabfVTyrzfPp4s2mC4VbPayE= X-Received: by 2002:a05:620a:2714:b0:8ef:ca26:dcf8 with SMTP id af79cd13be357-9161b954533mr612526585a.0.1781289025593; Fri, 12 Jun 2026 11:30:25 -0700 (PDT) X-Received: by 2002:a05:620a:2714:b0:8ef:ca26:dcf8 with SMTP id af79cd13be357-9161b954533mr612513885a.0.1781289024928; Fri, 12 Jun 2026 11:30:24 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:23 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:13 +0300 Subject: [PATCH v6 3/9] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-3-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet , Suraj Kandpal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3286; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=MbaRBOLwFT+ETgHAVWF3UBcaA1Q1ln0hWBI7tVGYbZw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2TF8iWOsdGp/XNhFFMMbJIh1AWUGAs9E8q XZNuCdRYNKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1edSB/0VjeuYOMaO2KkI6CX4me4o/IauFy8eyB2qW0cOD6x73XUrx6wzyhhmPiEQs9KITW95Aux vOlO1OGm4WTd10dda61ZQYwFQCxUQCr7hUhOhpYfjLILW8d5w6LcrB4e/y4VO+m9yt89EgCxZ84 m8nTMxnSfypw3OwMZya9EzwpgnFKQI/emxXRCB8fJh3mYb69roMD5FzqMiPiMJoG4uQMv9uPEea UQC3upMrVgAG8LSU+oom9Leb8S4NQuNZEWgRfKGNF0fMB+9rQvKjr7Ga6EL6VshD355ZdKH8cNv KCLIdEljpwWS5Cc5UowFwL+muSXLb74Lh/zEqFv53Rdxr5ax X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: paezdSCrBGlYv3zjfpfBTI_42_Yelth1 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0J1ALfw2u2fX jqpSPtRnRNXH2aGfatmNGp4Umy4+fi4xJtGZ2SsYG5Bfo+7vp43zwRfiF5XXrCe00hzfpjc2LHB z24OpvmVFYjvdZvOD/U1+NfwfiM2Kgs= X-Proofpoint-ORIG-GUID: paezdSCrBGlYv3zjfpfBTI_42_Yelth1 X-Authority-Analysis: v=2.4 cv=N94Z0W9B c=1 sm=1 tr=0 ts=6a2c5042 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=M-qvw7r3wQx8XY5Jx90A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0zOcRanCGyFU ctAQfdWThB1JTFd2Rsb7I395w9e8MtXcQXzf1LLxk2pPtPM3RihoJCRbxI5P2p9epo0CiVjRkUm NBu0buvZ06VvoUrkeAUtw7QXYjUIuZeNivKOFL3AwbNZXgbU1l4EyIMv52bHVHWYFlYt7SIMVwB 19KSdfG8QdAsHteN+oHYmuWKibNVzAzCHGi8TTstjaBektbVtxeL4g6ffNET6PHH6DrzsscucKr 0gOqUuHlvyIesvbJudSR6t3D8ITFwc6eGHgyuNjd1tdvOyot5/9oFCcRu5TFJLBX01YRMcy/dvK iMiY6lKDxoKr8qMi6ezVniyVApGjQ0Nb9fnFJvaPmEntqpaAzPvnxVlQxBNRqwdvHDV0q3aHqIu g8uOJGoIayJq6Lm+UvHBr46kSszdUccX6SAfnrG6z3iwNrQw0y2MgPledtDgi/6BDRy0h14V02t sfkafOr5a95jkeWLdBw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 436562e32e63..066ba6b6ef76 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10996,7 +10996,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index 110f0173eee6..fdc3da40452f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -169,7 +169,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -188,17 +187,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7C953793CC for ; Fri, 12 Jun 2026 18:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289050; cv=none; b=rSFo6uXwtARd+m8o+Ln/G30PPiKs+ryakjvJAGzI7/jjT+MFfIMuWk2/kxjN6rsyl/3o0pzOOL3NkMmIkTcSKplJFP5FVFsp9LSee7awxw3iY5jtKZj7wckPg2kkS6WBP3aXsxOIVqSUdrgVjABduOE4X1T6Wox8N5p/sbVi81k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289050; c=relaxed/simple; bh=hqraoBIhgsoA7488mFgE7E5Wa+zzdm/qHLJb+mlG/5g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nbi7Be0DT0quEHHkRe0sDpe3y87Qq7P79wb98hkG6DCti8/VytxRfOnSb7nvY+I4JDvZHaB0cshl+1pFpDl6aVO3eVRdZ2QXjnV3oMx6fXKHJu+mityOVPM0lBM+/gmRdl6MtHolqN99zdKI0QTZMol/qaQLBH2hljZPRggkbC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kVZGJZ3B; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VX1nnW3r; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kVZGJZ3B"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VX1nnW3r" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUqHs045987 for ; Fri, 12 Jun 2026 18:30:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NXtGNwSbn+23h3fU54/tQRScTCRPWnaT0vFvr7Sg540=; b=kVZGJZ3B4K+cuLTh etACClER7Ykn+bsfS/JR//XpLDhYKlAQx0U7vr3ZodJtVrrOUjyt0r2p0PBNm275 upsRU/dTJAlN8XvwxOjMs4r3v8iFLni1tY60wQueiS3dj1gaY6fjzWnPJr9kS1yx VQ7IJCdEY3P9Ak5VZTznpuvYgrIg0uSJOBvx4dsPqRMckHf/CBIeUN1yF3S0aZ0/ dTCDt1+NsbNt7qnAC2DiBDPmAx+SQjedamokeR36s+Iznj5XrmZFcGQoRPXs/Nh7 rTypSTH4AetIJoPDXl+xCvCRhljuMscXrQRWp2591WehC7AsHSBNLZN6xg1AZejZ nVY1wQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er76ek2jv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9156cb14b1cso191911085a.1 for ; Fri, 12 Jun 2026 11:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289047; x=1781893847; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NXtGNwSbn+23h3fU54/tQRScTCRPWnaT0vFvr7Sg540=; b=VX1nnW3rZ0yqqfs6e3T6R7QvhyNrIGBpDY2M4/Tl6kQq3vet5tqHRJuK2FZ5Ghkq92 9EwDmy8+TXG+wXj25oLa+HH2lHbjf2EWuElGsp4AsYzOx5H6f6Qz4cr4Lhbf8FQ35LsS 3r9nnW9Vo+IYaJgm4AqvPt5g9pix1um5vCj3ijMrxhyk7DdzxFY9P0Bm9NdwMFEyuEy3 k3vZm3F28z7pkjz9ohdBcxLj3lmkmy8WdgSWNBXv7LebJi37h4XdzCbCHhGxOgbOvP// krTtCCthAh5EliyFdaJBjChcLgDQpNBdIQdpNZMnsF6x1IYE6e0DVwyRPZJE3j3IBf5a 50IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289047; x=1781893847; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NXtGNwSbn+23h3fU54/tQRScTCRPWnaT0vFvr7Sg540=; b=c9Dy/p/mAdMmFJFZ4eFWmgUS8cNqsyHMsrrDE2XfponeSAj9ElBsklvREMvjTmJTID dwobbvQfjwY9yMiWJ9FSC4l0bXhDgQlDEC4hPwIqRWc//fAdrZObIyctUQU922gTe8j2 nwegDR4Wv2mYZocXjo98hGGrdFY18dWigw1q7QXSYgmbciFYcFM2gUilVjGOXajh3zwc rbfHyOkQBqxesl12LIennibGSoIxM16rFiZr3/Kqof+zFec54cb89KJOnql2aZnxBngp px9A3AkXXmad9bgVNJVz8i1sLiEn4n9tZGlZu0rSBiFlT/Nxuemqm4nmluekHCozPtDV CmBw== X-Forwarded-Encrypted: i=1; AFNElJ+RQfVGogR53Ges04w2tNzcRGJYrEQ475l9tf+RRFLw1lkmXQIvBLxH2klByU4Z04haaN42XyvBiQyOnAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzMugdC01h7K84oi4Yg9qmvgJYfspPDBCZBXqa6EWqb1bs7RPSb Rs1zG4jInFJx9bRTYeTTvRKcM1U2nstprYDTyJXzceB8/m4hCy7rZm1N/LLB7J9cHeK12BXuxHe 0WhXh8jy6GoUchna13ors+RZYPWiVXoetX+sJaKEhGaSaEIGgbEJ9/keybs0K8QYDMNA= X-Gm-Gg: Acq92OHr1scgUaLtNX79Yz9IePDPk3GZRs73rhJIlGfWmBX6X6ubRY1LvS/RW7LnoBj RuipQBLdt4jwMQaHX7Yhjhj8yeS+qCThu8N8RVtb9LvYX7iiiThuXQ9MwYiWq8023om8P+r5ShA bsRy5hQ4L0A8DIUczV2tKQdkqfUZ8jO10qOtJIQOKSYqbxnmhwWM9kgPuHSa7FmjG/mcoXzpGa4 u1B/ZeMxOqMMp94hDU/W3Q4P6TzMgVdfsNhCH8esLNCHwZsNPimewttORYzWiiZb2jJfm/14Hiy cBaffbJyxtSC+F/TYjrjiUUzNadVszZEArVGC+vk4GMmJtD6l28bbbG0AtmuqD+2KhSnPckhz0F deJBeVnEdfuYu4jZkJsKqii5fOJra9dx8orUdsWlL4wRrfLqM+HmSYyqJ00IuJytDHczJbPifRl gIV42SmVdbXUt+Zg6tn6ULAviQG7pzAdDWcpY= X-Received: by 2002:a05:620a:414a:b0:915:6e30:5bd8 with SMTP id af79cd13be357-917ee4d8cf8mr137814585a.11.1781289039668; Fri, 12 Jun 2026 11:30:39 -0700 (PDT) X-Received: by 2002:a05:620a:414a:b0:915:6e30:5bd8 with SMTP id af79cd13be357-917ee4d8cf8mr137549085a.11.1781289026842; Fri, 12 Jun 2026 11:30:26 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:25 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:14 +0300 Subject: [PATCH v6 4/9] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-4-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3297; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=hqraoBIhgsoA7488mFgE7E5Wa+zzdm/qHLJb+mlG/5g=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2aShkfQ4NWcs8hWSV/gJ8/87+hOs9SkyEQ I647fJsaOCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1aFGB/4lYLlcCC0eN4Dl4Jj27Lj0v182O24ArgNCoUv/0lOXuJBUpHJ3WQrRTWPQcktsb4msHdS zQM5LWwNwm4uSqkhlqE8zgwSBltp3eRPz8A3hJpAcBZxj3bRYxN0FZLq9qDHFYILD4kQ0TrIays BKCEWiDMd/NyT41rG/kuQQBqUR/Hqp/JKvvU0eeNHFnPo1wzO9+icOgiyChs7hnsgbacL15lz0f MXhI/HoKocbLvZ8gyux6T31biXcta4EaVpVdHwuVD5Q1+mGV2KQUGmkxI4dwALTAXTOzdIVqRXm AXQuEmxUAF0prLO9MqS6VTDsAd8tbX7KWWlBDVcTLRTAr0q5 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=O94Jeh9W c=1 sm=1 tr=0 ts=6a2c5057 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=gYs8AAvg_5cFonjPjrYA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: LxtC3xONl_u4y1r5RFS_Z2dv1NaUB25_ X-Proofpoint-GUID: LxtC3xONl_u4y1r5RFS_Z2dv1NaUB25_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX1JcM8/+yKu2+ f8eEbL8q0C4n+lOjfbVL4Ys4CgEb73W6TicMmfkmVq2GbIL5B/opqEL8HITLiknlFGFQ65rDtzO J3KAE/K0IkLXds/inW/82eCHUfRKWL2oQ2+J8ZmplCItZfGTl4GIAS+JUkW/BelpaRb9wR28rqB A1eeS0v65Ht9cVumErlGDtDiyz5xQYCKje/1FeXa2Kx7VH0Xg8nzz17zXSF4YcLdd9cQsPMAFWf m0Pz5biIOPw4pNkeyr5OIKjm0VtSe7bzRMIclPNDiJxp5WD4OIa0XRChfH68eO+WNtCsQUCQi5v 9I+1PO8q8uxNAqZ13/urBKxyWOv0CbWF3tbVxoeq7QUxLS7c2KiNNayqShQGIRWzXcMEZ6xb7t0 A5LsEojPvIyRTiCBdlQYkzX5ZrIQasJk5uQclJmPRbVi2DfQhUD3rY1B3FVu9+O7xSLNDRRk/dD 2By6fjBZ9CQstl2w8eA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX96fHcgGzt0lA 7oIIVrlYHXWICmrdL9lw3i+OCl7sCSj2wO0JdXXr8ZDDHkAWGzbMEi5H1XAfJZfcrXjLija91Mk +3EFZ0ihaDM93fzdbDshZPWGtwIWbls= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Reviewed-by: Liviu Dudau Signed-off-by: Dmitry Baryshkov --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 41cc3e080dc9..bcc53d4015f1 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc_obj(*kwb_conn); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49E96397347 for ; Fri, 12 Jun 2026 18:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289032; cv=none; b=FuHt5VDdf2mp4pm4Sclm8Yy6x8xnHpoqvAbsIYuorDaMReLBcRHmY2j4RqtpHnH1b4mx+pVbPCVyREFgbbz7H71Rw0z44Bfu3F5EPFxlyUZZKUEZyYXZWwxIm88V38rbOtXYy4ChqzTIUxA0pHSbE3nWRHGsjqp9xbOpnulVXm4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289032; c=relaxed/simple; bh=EekG2aEhKLuUzGk/MefJaYhFv2SLpgTabnBvDlYdrFk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ulaH0hNYWVZcfm2S9EnBjokVI0zY+fSqf3a6Oes8a3Om5JSQO/IJnfhPK7i5QoPvQwx0D4qJvuOFRHC+KJeT9/5OAycdsZeNpaLSJfY2ovDjmhwxjjOn8fvtwxIpmvEel4RuMsass2f7N2iEWF5zpWSOA97GYkwNtopbhuBbWfk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JDjJywkl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dBOxgsRF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JDjJywkl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dBOxgsRF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUQDJ054885 for ; Fri, 12 Jun 2026 18:30:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=JDjJywkl573Oppgc a/m3TBe+6a2JfecT9b3uIzacmtAK1q8qhgZtpoimZPEHqTfkTmpmVogPPmbYys90 cAwU+ANkYhc6AwLv7Pj3Ahz56Thyb+tH+qBa6uT/nEm32ARE/RlGwuSJ5Pdoa2ts P63Xf2JKBP6W12t4s6guCx1pTC0JZMeRAXjiw3M6Q6l5l8XPzmrA7p++0Qnjs/LO bvfOVyOu21xR7Avbo3pHgk+B/WgXUj8fx6YQy7EoFRZ3BkkfxkZhNgJgXqtfcb0E qrn8c7Aot/kKThewvIPHA97mqjq2zdeuZdMglDGJ8eSUA/tqJwHHG418RYVPp8QU tp/B8Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er29uv65f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-9157db42dd8so202885685a.2 for ; Fri, 12 Jun 2026 11:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289030; x=1781893830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=dBOxgsRFEtMqzytmCYEEgrmKyIdzSWs24D4+cQAGgjHTcUQzfJu1+h7GqjH6aoZFLK 7IjdmOI8cX++8e3WY5yQviDcpn4ysdXyJkiFE7tO0fEIH1cAWD+KBtIbHpZa9sHFno0b u5DTGhHXC/Zr1cHt7ptFmvXJ0f+rTm+wdWFhWrT/HtHHy0t3nNLZqn3SYAqgtJmQeSLo 1N3PnPtF2DCs/1HupghcrBy8ZTdre+Ie7BEgr/VChRm2xHdOPSIm5B8jqe4qkMggGFFV TCd8fMYXthpItPIRvdFRhoiRSW9/lIjuhs97Xon0POf22v/AP4R+3khT68C/KLGxo2iw k46Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289030; x=1781893830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QBJeYuGqe22P6k7nEfBN02fWJOuRECh3h974+RTUQts=; b=Wooox8isDc8E94SYWfoBOyc4AjXYWIh1OyTCTZ9NFfgTm/4bRpwf0LZDrzkUw9X4nV uVdSB4AvUvz8QrC0RV3WXZnyYb6l42gx0hpA080r+Mf5nP0KffoStPuf/fqHZ9MjBq4Z 89CCWuIjapwu+DcbTD7BArIb5OIefSfdlN5hmZa1/TX43YJNKcKlXrX3kevgZTQ/cY38 oT6B3ZMydC2q53YJsXq2uW45Dq/9MJU1JM/qhk1TXfp6iAYmtOPU3oRWcVDgySkPQwAw 0yhlDTeQADLQlBcIuK6+ms3D3qpqSBNGDHRUgW6FUdbMrjAOahjyQM1VSyIc/3UYXGLk xIiA== X-Forwarded-Encrypted: i=1; AFNElJ92DH2g6f5Cj36bwld3mQaSb91RnORU9o0kA4vyyGlMrf+4FzWyDrVR57slTvCaO9J3wfbJrA1bCvKYOl8=@vger.kernel.org X-Gm-Message-State: AOJu0YzznXRuYGwrUVd53+gE1o1qshr3j2xhKMP2mtDPSX44ln2i3O3v XGmF7TBaqFBm7vu4GO5B/I5MWKtVoj/C0+JITzUlysdB+P5cxfIjTfQAscG+0OgmoMfvGzdnMfM 45vglrjyOsMVBCJ+69nX+GAGOBntmcc7Q9RQ0P9OXUiXvWrmtBrRGhSFtcBfizdcRGj0= X-Gm-Gg: Acq92OF/3YiGbcv2nxdyNviDkcV9K7nLyTE0tNKxYWmQQDZ1tINtRa3O+3XV5nT3oGT 6a46c+ES0cit6gA63T6QbPNUcJ6XOHLX/SWxuDmJCTuYXdeknx+SrbzgqYs+ZlcfO66hac7sawX zcrWXol+s5uVbQonYEj0t9YvmdQq6kFzo9gIkydzKRaEMju7wzU+JigLAaa1D+HnNzFU400RIEO b9zj906Um4E8nnFwe/qxJytPV6X2cPduFa5VeOjJT4ELfJKqLRPvXiwe/HYqt/zXldk4YJapBnv wPI4FozyKPr5sjzcRFseX66TYsNatu6imSwpyXUTssIT4RoYXy7xdx0vcADwBJ8/3g/ZFBGjF5S vCQZx+5WEoRpsfOOu/93yFzM0sAlyQrkEZcial31Zrbq/c4pezDsjdVKVpEtCzSRcJlmK5YbbPQ gF1nYHzgXqCDxWrzDNg0HAP9aVOUI6yen/spI= X-Received: by 2002:a05:620a:438e:b0:915:2b46:eec0 with SMTP id af79cd13be357-917efac52d5mr130402485a.11.1781289029662; Fri, 12 Jun 2026 11:30:29 -0700 (PDT) X-Received: by 2002:a05:620a:438e:b0:915:2b46:eec0 with SMTP id af79cd13be357-917efac52d5mr130391585a.11.1781289029193; Fri, 12 Jun 2026 11:30:29 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:27 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:15 +0300 Subject: [PATCH v6 5/9] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-5-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2921; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=EekG2aEhKLuUzGk/MefJaYhFv2SLpgTabnBvDlYdrFk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2/CqgW8HuyhGiu6mrDQOaZfrC3PXXYFzVN Bdfw2R9NwqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1VKpCACMjzF++leJC1KZCPjZzLnYEoWLvNMfjha1yB3vZJDN+Gqn1YkZEgAJdK8jmV1tS9Rbjn4 hGjhf1aRkpmRYnFRnV6o8k4JDpOyKwyVh4y/cx6eGcsJRA+wJ0s+JETrf9hdKaZ3b7NUiWYiYKC /4Elx9R41ZvK7BLWGrPzY7fn9MR2UmVTSulSrdceb0yoEapLzh1zKSNdtci5eKN3ejmx53WQIY1 BWz66qjliBJVWDoYBfaYoKgEeAMDmoFgicMjFse8+5/M5vVq1bPshcIOVK0obX01xrE5zNmyZfZ UuQEkfMTQdZewSOEO6B0Dv6Knmy+ogKMWnz5CnhkeoTI0/rA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX+Sz8a+jp45oq YormE6DDwP97F0rJdX6Kyx830WZc4pGsEFdw87C4eLdWoeYnIjrg4rGRWWpKa6ILs20ephpLNAQ IC1ZYN8mAZuLmKCH6wUQrBUhLSj8XSM= X-Proofpoint-GUID: u62MQNDmBg6jEGnParRh4jMFw5W0PXj9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXyyEuyovRUp94 lOG+SZOSnfV/eFaswCMeehKQszui00BM6w/WoDO/841AH4d4HceRDHc9vVwS8K7rnkOXjzk55iV BgV440P6oCDJj+GFQwmuW6Q5UEIy9T5b7DtNDCBaY5bXGQwX0e+Hg1fzwCF5DC6W+vzLu4tzC4l tTO0mu4GriFyG7GU/fbzf4g1RmwsNjRVeZ/IqGysRjuqte4vtQzEnx5WTFk4EbneABdyuGN/ORd jHEH6BM0ZpNmBKMYtY9at7Z1T3LFH5UWo96C9v+GjdicPc1F5Zl8qUMN+k1cm1RSyKKXg1vD/eK o3FqQ8Xe8g0NLxchPMg/dU/0b/+8f2zGhUwsGAFzDPjY5yoYYtcYKqXP8XaMC0gelMPGBoInxi3 JP6gpvWo21DIwPgRTSobfUnfbWVYknRqcEd5JDu5YOzbb3LpUBCAZUfA4BdoTv/RVibBouRNcsy wlg8kK0poRQTx9xEx1g== X-Authority-Analysis: v=2.4 cv=DppmPm/+ c=1 sm=1 tr=0 ts=6a2c5046 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=d3PnA9EDa4IxuAV0gXij:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-ORIG-GUID: u62MQNDmBg6jEGnParRh4jMFw5W0PXj9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Reviewed-by: Liviu Dudau Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index f8be65119e3b..cfb7300e3e95 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D04A39B49E for ; Fri, 12 Jun 2026 18:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289034; cv=none; b=FKEpXYsCzcwcUl+s+U3VFF/PWeZDViEXXbJlBkG0UoB5GC6RNx5b17dhfu31nDTgWr6WXdkQkLx6JR5xkiIthH5qBb9vHOwB4Y0GcqlvYz02l/U+YbwL1RYIySDvQcfiiFad57/aWcj+SHC4RU+XSeAS5dg/XImfBK7CZpRb5kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289034; c=relaxed/simple; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J6D7IhO+sICEiy2xYR+BKfpFubydYGC28ElNIKAtk3AQrie8cbDVCwIAgs/f5QuZeBNEe0koh8+oOozD5XQYOrlEorHsh1GafwnFMWNTc9XDRivQatXu3+IwywNTQ8KMHchu3t8o+tSqmY/jjRYrgT+McJU++ZaXprtGi9YyQsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dVL5BU2p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b6U/eEhX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dVL5BU2p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b6U/eEhX" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGWMjP020179 for ; Fri, 12 Jun 2026 18:30:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=dVL5BU2p5TxAPTdi S28MTvYXq86i+lhwR0HsWJot0vqed5Q82o8xOa1w+PaY4AYkw+ZdIC9xho1H4G/R Eg+Y0ltF4oVtQaKmvMa3k1+d+qqvQH4lH2iU/R8iRFX4qKKkWy2Xo5RbRidP3OXH AMhXLIrYWFn5kc0TMkqkYmh/GNb1hFoFrJ60ZCiw1Wwx9EQ2svsj03axFNKFIwew QN/lhY36dlaRIUs3D2RD7VZBCRaSBE1HeA5XAqLUwwET9iNqA7Mzj/iGugIOBz3P ffxADznUhAPiWxkM3tnnwOxLqDUIkU9RESdvor7Ns7uK3ja5rX3xsS14XLJGvBIe t8SRgw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1cbmh17-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:32 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9159bc52211so181394985a.2 for ; Fri, 12 Jun 2026 11:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289032; x=1781893832; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=b6U/eEhXlcr7+Tp04+luHc6WjHWMpx2KsVfc0IWxbJ9YFnz3roTdata50YAJj2VJT/ 0lkavYjbThXT/YHr5ZZcPmdXc9qw7npR5wrfFmq9E7wwNtFyHf3zFO7X3vvYHYZgI87g 7/044scHuBpcXhZY+jZM6AS/epbAPmQpKY6rYOVRsNk/iDp7DD0dD8rdD58YDND4r4wn Tmh2/NwA8D5tscVuqaUwinRsJHEBNNHCsgQU6W5OjmPyt7SEM3ZG4aSjzhKsFxSga2pz pRPWjNb67QXyzIzQogTevwwxrdWLH5nh8a3jW8um+6yHOIBuQUznF16KJ5wfA5R4otC/ 6WkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289032; x=1781893832; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=Is4lbvBMDcRrBaTXwHxV0lKQyauv8Rb7tIhl67dcG66OEtNeF6JbVrVtWgPKnajTTt iac2YgtyILAhCfjEP+7xdiY7tmBRlZMn87EZyJpC1zSi0FVYYNyI5s1bp8qoeZ9E+ycF 0dfkFVya4Ih6leYV2Z+2sKBchQe8ulgXumL2HfPiUx6g+Eo9pFCge5fisoC0rpQpCzcq 9Ijw9wJjpvYqqYIg+kEOBlT3btb3TbQ3Z9Wgln47DMvPf1i5iOwHIwZpABD0rfN29/AY cPo/Viq71122+L4cR3ixWiy/DbCet9gXdtnDmBklrE+Yn0sILttXeXvXB52ul/60/lfW KGwA== X-Forwarded-Encrypted: i=1; AFNElJ8UD8G2pPp4FZXuQJG36Iw8+NHlgPzZrIwVtUROEKAhPVjfJpQX/pNvFBi0Wu71SEtJ/q0WPxayKMR/r0s=@vger.kernel.org X-Gm-Message-State: AOJu0YzMBq+Wl9oLHXQSShgZa6eLmnG9o1rNIQfiOPbUCKNBAOSbnaBg OZsu1c5rfuQDrhMbNfISCzW11CyPCl1ajTKO0VDOln7Uhlj/oIsnzPxQMqqL6eYlZeYQQafDXT2 WsPPHVy5cxd4pwfa9XczaxYhrR+NgTemySpXij9223nvgjZy/qnvPS29/X8Q4t+QbvxM= X-Gm-Gg: Acq92OHfwDnA5MPm6iT5LUF31x1Fn31lL+LRWYTt9s00snZmeNcF8XbV0iOfrsbLBm2 q09GzUFDZkQZ4nkm9mU5Ze/n3PtbxrtSgiJ8MdtrZuRGSu3NEgv2NUltX1CSiUVewzR5pftqrun H48N1Ea+VO+z7AmLgxlHQx1VsxXB9Cjm7Zjz41MDO82WVmd7O09lzBP68DCNnwW8G2xoj8jfOrf PZb32a/c0PzmuDjVd4sHb/7z1i19aTNnGhF7HVoSLPM7qPG2AcbjkIFUl0nvgiZi3nudGddC3sp AMhaxTXbAegHRSYf4zBrj7kgytBh3cB+8LoO5viF2g2KCq6Lqf1YJ+LJmAOv/WIc3ZngLZWx0tm 8nDdynTQOErvzbNiLDV7a5sdWFMWX/GV4H24e+vsZgCeNgQuqy6HcGrTXP9GP7vCQMph0/5/kYR ARqmeDfpeBjG4JJDICONyr/oO6jH4/UHXVops= X-Received: by 2002:a05:620a:6497:b0:915:cda5:2807 with SMTP id af79cd13be357-917f1c595d9mr132338285a.57.1781289031557; Fri, 12 Jun 2026 11:30:31 -0700 (PDT) X-Received: by 2002:a05:620a:6497:b0:915:cda5:2807 with SMTP id af79cd13be357-917f1c595d9mr132325485a.57.1781289031019; Fri, 12 Jun 2026 11:30:31 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:29 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:16 +0300 Subject: [PATCH v6 6/9] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-6-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2589; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA2qL8S5YQqKBPsRn9MTFivondiBpU/eAjZX v1710/GiaSJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNgAKCRCLPIo+Aiko 1bx1B/4qwPQtIu7I3Bwv5Sn6D3nPGP9G7fSvF58H/+/1e+BmXtWR0I52tzdypAxD6UGIshghp6r R9fC/vVHKY+cJlSIAkJvzdeviVpFG8H828Z976B2ZSeqgJ90a7o+vkfJEY03HCbBS9KVHQVmlWk wa43sUxKRxXS3xARc/fyWzjCVBtId3lFolo/JGuYlcdRpBqeoZB599OZQEeLetXVly3F13qILYK 2pztXlzGcfm5HDqC6ZOH+E2UHqSGHreRU202s3H9mR2LSXaYbnAc+lwUfurempYYfrNrKzpnXyA kqUq1HqnbLF9EiHxM4hNn5Dyyf5KvcLTbq6A43ZbRgqn8F9/ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: pevAKdC3tpWPWloZfd3gpa_uJW7kYCnE X-Proofpoint-ORIG-GUID: pevAKdC3tpWPWloZfd3gpa_uJW7kYCnE X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX4+dct2OdjrD1 nYN7TXdgrJgF7rGI+UIrIwytijr3xB3mGBeiR1M72mUHWe1K3JdfK+dApVIw6KdWioIxEMqPvUo 2By/tXGnGQ8AfTx6qj9udyT4IA7pjUY= X-Authority-Analysis: v=2.4 cv=S57pBosP c=1 sm=1 tr=0 ts=6a2c5048 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0VW4TReAXirR 3JZKWPfwNShrmJ+VW8tHtiKiMoSpFq61o37P5iy8m1N8JKWz4dp5EOPMUr9klTjwMFqpwYGq9yK vToI4bhanE4r3sysKqhrwWYIAxX2pQJWxjiWKTecyheLzQYPG7t6cjfXNZw+0yEtrLF1z1nCzvb JKSZnna1pRvpi8sImCrF7haGC+ZxupJ6b7jFkeyE/hJgFzkDusNLYCG6SsAmQZa0jJ92Tz59Z5v Nxouw/lcccOuqfG2JvPO6ZsaNZD4eWxecD5s6cPo26N8Rsyds5DPXkgJQzgSVdxbcK/vHqDW+i/ KQXlvXgkqplrTL6qcX8XD9MB+ewx5tVyxtjm0tkRvoia+NI/5U5jdzpQCf5CYFti5CoBSeTcy/v YQRXU3m5jMey29Jq5DFfbDspP97C3Rh+VvGKEnPa1rz++JsaPfdQnNR0Zyz06M010kC/ZUw467k Of6HSQfIGX6ghP5yFlw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 22 +++++++++++++++---= ---- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index e5e6e6a156aa..ecfd4fc1f210 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -201,16 +200,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, struct rcar_du_crtc *rcrtc) { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&rcrtc->crtc); =20 drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E934F39FCCA for ; Fri, 12 Jun 2026 18:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289043; cv=none; b=VDYtqfvaNSSVbN29+1oqJvFPaAGE6v/Re6hUYyN7XmPKEVE/LCuiSHbynB9ZmFMyEEcI56S9yLfGiXZ4NnDgSjhsnepUehXQW/QQc2BM4PBAr0sHLHFTZrTpfiURp6I9g9OPjnyVATxigi9zGXRgIILnRCux2y+Oz9bWRQlSxX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289043; c=relaxed/simple; bh=WHDRI+JhBcNuBgC+0OtPNMX06wOpYXQsdurLSHRrbWw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Iq+YDZHpBHtIv4TMynugBKpLXpazRLlLQpHE8HmAFuV7KO5PJoSc+N9R6Kh+GQzG2wpUvMb17+t+d+Xo/NnHUwlffZFAMxiF5Ix24oMiQ/PQ6SbNFsyudj50fijzNB7wptD7ga0mp1iYxMvCJ33gHGH2TSTzmkzdRxHG46DnG6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WR8zAQI1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HIdrVYP4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WR8zAQI1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HIdrVYP4" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGUM0Q4150487 for ; Fri, 12 Jun 2026 18:30:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=WR8zAQI1Ce48sbsQ iko4kevADzRuNsFys/yUaT2wA08EO8kntUazpR3SYgJ8qEQ1mCbCrkD4hWZ7nnet QfCrCERbHHPoErM3ZXgBgnCCnNGEM7pBbrXhpn/cghbYrkA5K8CRcHrbbRV6fLry HJ82D6zeU4RQJc8MeriCpWHeG0iZm4CscGQjMvXbE4fLGj1WNnffM6lrsBWfaWvi KTylmWw4szOJRozfVJ51Wfi+XQ87hv7dCUCOJ13ulkBrhsoOjurLWd/VhjbAV4dh CKIFwJkRM1ZOXusNS1w5n0T24KqXqhEoGpp8pv8qsaU3VCum5Ik7ZtCop5gh8sKk DoE0iA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er1xcm9j1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:37 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9158f2c4b55so201537285a.0 for ; Fri, 12 Jun 2026 11:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289037; x=1781893837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=HIdrVYP4s3OalOnYzAMpinsXHlKkk8d2la4IfgpqoRcyepIsDg5sbsRKooWQH9c41Q MnrAr37f0Li/6xDkRMjH4t8Rw+Ase6m7dtVdip+Q+p0nse4YdLY7B2KbgXTfo9jAY69Q GKO6dFQmFFtetbaPsrJXYNKyxBCPpZjWkNNDte8NTM9SbRxF7R5Xl5mRiGcAPjhQDtHP Lb9ArFjb6957OA/83AQqSoRYDNb1+yHt+UQUdqqo/4YptlleQikpkPA5QP9q5LX65TLG 5KThgoSw/GYiD0tPqJTFc/mlkD0ILKqpIZHExfXy1VClBGeJ5+NqMJjzQmGYLcJ3WzcC nvtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289037; x=1781893837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TPWo467A1KtBfknXLUhzGM05jfJhVUBGDG8kt4+2Duw=; b=Q69gsIXt+HZ2W58ldNentxPdg3ydHI9x11ugF7SXmjZez+YffOC4Pn4jH5kSp4P/1G IlFalDhda4Ip6Nx5vrdWjBU3k73CV/+1JNmCfr1NcprfoTKcHvdR3acYhH2BMPM/39OX NkSt3tsnkDR23fal+9YFIKCvy8ClyAFcOyRNV12ni9U11zGFNDEuIqM79IF+oe6/J+1u rPQ+VSFCxnj9UOPkzICQf7KtPouxHlzqaSP2p8c45wYo3synyLto0wW6lhe+wyVtzy2c 6PhSKHzDoGx+ie1m6w9hSrDdCCupJUjMVxpTyVod1GNkHqUATyxHGeepwiZGx+WFLh7O lLdg== X-Forwarded-Encrypted: i=1; AFNElJ9dS2+e405k1i6dM7xp//uKf3hXtRSFT3iQYckURqRY4OSSuvLIvp68w/dvcNLXlh9uyh0H26IbSdHw5jw=@vger.kernel.org X-Gm-Message-State: AOJu0YxRcpDumBsT5Drfpy26TPgOTYNgc0m0qCY45oFFY3+7SiIELTuE OSSKzqXML1gDRZoTZ7IchWeFtAmCIxa53e9GvlXVmGF8rA2Hn9e74pGWkrBaHdKWE3gpM1QE18I BOnh1Z4aY+n24ko1v8v8zy0DVR0BzVd/vCFTbiRex7ZTDFkSxVKa12v3FKLe4F+C3jlQ= X-Gm-Gg: Acq92OF6DlQjGMu25nkP5u0pS86E+m4SzGw04aDxXCMwyfoRYp904xNvzPZnTVS4C3l F+UJWCfOwUyvlJ/Uo8E762t8ZlKMBELD3k5M40cXiCMO12OyDxNcQLoIXtPnP0d8r7aDTf5xo+q L1Q3urnQB0Bf+6b7eBxIGPMRBdpN9s8I9pgCa4YfdjtH3vV7cVftTD3ZmOwrezfVt6Uplmtzn3s lttw5IhMNwg0LT78+wDt1auVD29rI2TlQY144jKV+40pxUuJPmBXXjRyWQbu3vWWSEBnMK8bR8B Toi09JzVzIdT3TMAHN4rRj5PmKPOjSdd3FsHgeBv64QOadfovKjK2uSFNfF8HoMcOFCz/0AFFa4 7/yuoEypjZqWmJBqACVK9fzzdqoQi/3lDRasI5k+9wvnqv6gyVPf3/i5epC2TiZ3P16XKXghxW+ Q1Eiqxa24yqXKZMOtm6WEtBasnfbsJCL465jM= X-Received: by 2002:a05:620a:6cc3:b0:915:a5bd:d82b with SMTP id af79cd13be357-9161bab53d7mr621083085a.9.1781289035518; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) X-Received: by 2002:a05:620a:6cc3:b0:915:a5bd:d82b with SMTP id af79cd13be357-9161bab53d7mr621044285a.9.1781289033033; Fri, 12 Jun 2026 11:30:33 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:31 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:17 +0300 Subject: [PATCH v6 7/9] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-7-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Louis Chauvet , Suraj Kandpal X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1991; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=WHDRI+JhBcNuBgC+0OtPNMX06wOpYXQsdurLSHRrbWw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA3w2eA8bVTfCfHWtbd+wRuk4WZ7UwSCELFb NxOkKpvyhmJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNwAKCRCLPIo+Aiko 1Zs7B/9AUhF9TKQrWA7mEHSfv7WVuiuih1udWVrnH9RNj8QpmTWalWgAaq88xcqtqfZQ1rKIgyi 0g9nwOMEU8kaWGhLFEbRXwS+0IEmVPcYdrtHtyILGIyAuThnCUQPQ85n5Pyko1tQY4J4AzY5gLx BO2pvW2aGpYAwpdiU5sipK7Wk6hcQnmS5tI7hYVq4utxYb761SSAMwC8E562cRt9Eodyi9aba5D xjvI7FKExDv/WlhOoJbXDAELkCQwM59yfhR2U+yn9b8sVAoGz9vceb5G8NgGI30BppAUwjAcJrU 82zcn3Il4qxGFNUlheHmOwHsDcH96KoaQpAjKpqqd+4WzXud X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXwAwnxPnLvoY8 jdWHwTVYuYtTdOuYO4FwGhwwU99zYqjjckWm4IzIaQiz2moVT/IHva4HD6YKJL482H0HUVrR9Bp WqPOVU9+gj9g1w7ZuG6OMOEer2TW2vFLV1liHLw3iOYuRUL3vRdFra4WBRBv14hXsw8WVwa8V0r JwEmRiA8AUJ75BsZm9EQJtNZhyAIUg5nr6vkChneLuCqeDMKfWcgOWOhGrMcUWrVtew5738hLxA 5WV2pzZ0v2Ztca08+9n+e5lz4QiyczLpFCss0QiPdDMBBfQ1atYeK7gLQR9gO/9xP4hPkuC7uQH 34FYnPg1guewxBAOY1w50nY8DAHD71xalv5prJuf0UcV0xjFYqitMj5X4q8IUU4IA4BU2sEZsGR zWQggYhhFfqGeyWFTI2QbChUTLshuxLpd8eFHX5CMiGOeVknfjSmupDfrXohubX4hHgh4c31mdP Gu/Vm7HPptuShb7mXbg== X-Proofpoint-GUID: YcdoicPkGdYjsbkW0246PsHt8LcKhFbb X-Proofpoint-ORIG-GUID: YcdoicPkGdYjsbkW0246PsHt8LcKhFbb X-Authority-Analysis: v=2.4 cv=NZPWEWD4 c=1 sm=1 tr=0 ts=6a2c504d cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=YDDQE0DzCl7hcZedIR8A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX+4nW4zWLUbBd p+C0Y9d8+GDkAX3hLqIJRkOZCrwijfloN+sJyDyGDni3B+GDq1mPYJMyq5xO14AtzPXCxrZjA2Q yhVUHjwMildrd5OnowE5//4PLq0zQ14= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 66b6f2acf862..3fd89fccfa10 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -378,7 +378,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -602,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB1837CD2C for ; Fri, 12 Jun 2026 18:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289039; cv=none; b=jbS1BQS8xLYTaUusRWAUi2AoScBPCaomdr0YRGjtDctoJkLqrnUyr3pVQ3gtxbjXuditX73ekN+Fjiz2x6lZKA9sZpPdlYD8CYdaLPqz5776VYhzbqAdoMnPslIBz7PpsBq3+ClYzyzeKvbMJs4GpWxJ23792Efk3rtbzs88ZZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289039; c=relaxed/simple; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qJ/P4Qx83unuMKcBKeo7UYD+vpba+HEmaNv2FL0mNo+1kj+LwIzf2wcjghWXbTenb0KDmsgu/cqxLOMx/w5hYtkP9vpVCC2lt44iYtN7hT4f6rzXwX8LBpC6BCF5r8/dVU6a/bc15oG/R+e+1EYlqn9lUtg8EBDJzQP15D2acyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oRWWBt6A; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aMajdtHq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oRWWBt6A"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aMajdtHq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGVe824112800 for ; Fri, 12 Jun 2026 18:30:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=oRWWBt6ABEqt5eXm crjECfTbmZn3hmv5zjdzfkecPBLuWdzAsMuK1dvbN9+4HEx4qoON0XSGX/thQhl4 FyW/EmTg8fdQ8PqTuKFQtilSnf54Rt/j5teGI7/rTy4p4hO8YHrhZi9m+kWqlexa 3jbOfFvYxLa1hz7XrbcFcUKIAlS0psOKYvSQAdB/+GVB+UDJUJ6KbYaffXC2Q9R4 /CZsJTzCnVEKd2nty0p7DZ7kVUOzNV2EUSPltDGnuvT80hmE/LPKnVIKJueVq3wB ILlcMdzhPT9MPmSLNvWDCv2BoJLG6kopu7HZ6vGka+HIux2UfrYpmo71qUaeehEX nlvHXA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er30gc2qd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:36 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915c1997732so295177285a.3 for ; Fri, 12 Jun 2026 11:30:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289036; x=1781893836; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=aMajdtHqbhDe0BO6nEpaDot9PBN8bC1te/oGrI45uY0GS4146jlkTEF7ArgH45+W+x i0n/kpzZ+P6DoCwzlAzK8IUGQPhT1RAbj6UMjCkZ8BtAEaNELAnW2FDQAPczeRmhQfvr qLzjhVcE/+lSYwAANHyFf26qBmkfcofpeecofw08wsvDKVmK+oaUwiE/apNdxo2O25Kf /kViI6nyqk7FyJXcpHjILNQyFKDfiVKuGCCD7Y529SHuBCDDXKN0cVpyDgz9YwHFhO4p XUfl1dFuhu6zGLjkGxPaZBygx504kgbaWGK2FPng5yXLcWGmkAxnflgMpdDD6+WPxTyc 7CFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289036; x=1781893836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=Mhqle3sLXw41llvBrBwEnr2wW7IUmh1ZPl/d4xP2nwlc8vpW+1slOlc7BgENOMUdZE 3fdcl/gvDRMyZblmD2p5bxAojZ775pLVipuwARyw9eYDovhZ6jDruehyQ4ev1wHmw1T6 FuuK1DCwxOQ4qPn1iiwumHBsOBnOruYDpIj/NRsV4YiPVzWxf1u7fzBAPNnQu4hCNOhV Hc/aVvWjVyE2GnIEhr701prbDuqGTuFe/srHDE7AScl5g0MFVjmJwLP4Ahe6EYouqocM BMXf3Lh3TrXAS5ZcCimPoLPgrH0xwmeEPkpo0CH4W17Dinn8a4SDyPUaf24HcBjcH2ag V/XA== X-Forwarded-Encrypted: i=1; AFNElJ8Db/P5vxPwIWvyOftQ5a+vhhdsPIMHS+jqADjA6i76Y3D2Ky9PoAGkJyTborI2xKbHy+eQprJYOjqLaxI=@vger.kernel.org X-Gm-Message-State: AOJu0YyYX21hN3+BaR0z9smo+CrpZl7Q/fH5daeFMa1L+HDbeZxtL3FP aVZEFaAC1q+FQKkChn49aHGuLDjYBurBSG9EovhRPbkSnc3PQ5TnS5jbgJJftDtP3iBQJ5lGRRP hF986QXyBoC6Ew1LPE5jo6Bks95BABS8vasuDGh4VIVRS00JumBVSaEnSZSJlPE+aOAs= X-Gm-Gg: Acq92OG/e3f4wmhViSElw3RR9wPdFYAFkgccBIekhEVVFRUOGw2SAkwe9yOe8CzWYzd 5uPxJ+LZ0mfdzeufY3/cqFmA35bfgu8OdQQRMPGfzETVCZS3krdCFuSvGKXpr1/Gfqk/+XoXad2 DE1flFQ8kPmTOeO3FiwzbslNg5LSyHt+MwMa2WoQaPZQIZSEIG/MeXniMEHVDRRJ6GuT+wp2jFX mVW+DXMnWqRoSmZzUVPKQmkGaBUmZP49vHgSYir4ZoLS6YGf7PKoiJAuO6WbDpch/Z0y/oq4tzo i7w6mB1ZTo1JhoHgQN8Pd71YDthHWdgyPaG5/Z79+5kWMMut5uQuhG/Tv3Qh+cSW42Bh/J+dggg W+J5KDZisJDn/UztvcB1uVTpj5J6HYFxU8i3vQKdtWcVd90u9U94MOZalbDim6zoE2jSgns10jC U8CPJBy/q5G5cgJVUaWl9ogkB9Q/zwQ8+zBbA= X-Received: by 2002:a05:620a:6288:b0:915:9125:e63d with SMTP id af79cd13be357-9161bcec31amr573647685a.43.1781289035952; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) X-Received: by 2002:a05:620a:6288:b0:915:9125:e63d with SMTP id af79cd13be357-9161bcec31amr573639485a.43.1781289035445; Fri, 12 Jun 2026 11:30:35 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:33 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:18 +0300 Subject: [PATCH v6 8/9] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-8-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4480; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqLFA3jhMYBxZuTwA5P8pC0iOzIEdJ7fr70b3ui c51TlxkhXCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaixQNwAKCRCLPIo+Aiko 1daWB/4u2v+4zU23e3Xdhf+ZULhAcCbc7KPvw3poBWoSLMiMVcozrKDBfgSWbwSIQaYyWKcl/0G rGIMRuyDsDJ34XQRo4oLUBfA9Y2piTv49SnLjBpEXNh3YK6BuIm0hpukouPxJWhBYpFmRsmkxUr 9pjBpnGdQDBbvDbPCX5DNzKxUYzMjoaULMuQ+yqa6fDQcsAhq9BcCp6ahC6z0whUx9BrKDtpc2G 1P9N+IGrF4eJivzCB/LhONe9SJLkY9NRiNsgbfi5nJ9+n6e8uAsjeXmPXHIdw3n+aBUTb2e5vj7 kTbZwrgAuTMpFWIQ36Q0w99dnWIe2bX9Fqir8Cebzr6dyOpm X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX8lpFeicRXL8a SvJW1qZfSBiNjXFxMlikSIgG8wvxUpdhED8E+gDalQtqznBLAeS0nqWrOHQTvsfU4lJihXlKf6s Ce+kseFFLiYlrHLiYDqJMobdGyS0+GY= X-Proofpoint-GUID: 7kM4SQ9PzJr1uXxZb19ussVPnPQUjmoE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX0kVQKSgr1fle uXnTKyaCCTRjE/oz8SQUvDhvSuzfs68iQ2RBjWa9pRwtM28an0jt44R4NYbdxIMEtpS10BE2Z5R J7xRJX9yBXI/d71Tqjd72ryglRinaokPjEAs5WVS9L0xTkeMQfdRbHyTfUIiERP5cB1JEuJyaVr mrwC7Xy0N0zZ422o13qWFhvuPkEd8NpsI9FFdJP0b0T/8VOA/1ag7KpbqVJmoNqpMD9AtGDw83k /7OMQ9mtDVzS9P3e72iFvNbjAnGXnG+HbO+411D3uTPw3HO2aJ9gXTMLV4EMuBCLL6StcmwhVfB EZTcmOmeEpKi/fWKL0HfwAKGZsx/+C96WbPt5B2land3GaifD4JE4ctqIZnC1HNix3r8GRuj36Q Pxzhw5pg47gNHMNmlsLUUJTNfrqcMMe9pEA7EqWGkC6qaYl4O0CmaT8CUoHho7+y9/JiIacDyYR +py1JugiCiyrGOek5kQ== X-Authority-Analysis: v=2.4 cv=evnvCIpX c=1 sm=1 tr=0 ts=6a2c504c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-ORIG-GUID: 7kM4SQ9PzJr1uXxZb19ussVPnPQUjmoE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 4da5d6094721..9fc15168c34f 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a..879ca103320c 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.3 From nobody Sun Jun 14 01:35:18 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C4DE375F69 for ; Fri, 12 Jun 2026 18:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289056; cv=none; b=n5m9TQ9FGD5ibqgkJKFFxtXfJNIz3jF1qnBpoS7/kY27qQBbbiwGABfLpw4l+bRk4DKF1yCPNOc6GtaQsgIxMuDzqSuaeVaCNEXpyONrhAW95CbZNffSVqo3KqDpV8Y2CpE44bGBVuTkH7wNsPgLcPRl2wLOVruB3e2ioQPPR9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781289056; c=relaxed/simple; bh=mE50BYUB/UAw+zq2VOqPPalyAMn1gAB1RtsYcBWwgx8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UP+bq4WGIIcSTq33igUCS+cFyHo9U4h9CXUknHd3dfMYDxvVdus0KqD1PR8t7bmVJ1pG0n140wJFoDS8v0ls6c6M1CxMXQjRC4sgSXK8Kynq1no0BBA6m3dBcdIk7tO+1vSzcecpR2DZdJusl2ftXOHBu4xqyEsXg3JyQFWVCFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UCgfg1hi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=knCumQ/z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UCgfg1hi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="knCumQ/z" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CGSa73001381 for ; Fri, 12 Jun 2026 18:30:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=UCgfg1hivTnuWEjv nioBWrIUwJRrqQ7jqClIPM7Q9GYwG0HQ7iDh8MAi0XjxAVvMqTyoEbx8KK/TIL3y vqjX7Rvr8tZ7E9ALoeN+8V6TSaiQUZ3EWRoKcR1R13mevpluMOzlrgeNrqcVQpg5 sBrUTk1uTzm2v0AP//5vx4kISvAxP7Rm7WRRSNQHBb2rEjHbae0bNQ67GMPV/GBk lI579hdewc4qZOzJT1FAnZWNBV2OWdHak+EwLedV+VXZE+mFynZmpx7f7TXmqhtd b5TCpsU79jhUL3L3pGUHnRxQ6y/3aa/h2ik5gFKkR7c4kQMG2ITTkq30i2qTU/Rw MBQNtA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er0x7mk12-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 18:30:54 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-914c8954923so223068185a.1 for ; Fri, 12 Jun 2026 11:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781289054; x=1781893854; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=knCumQ/z6wUSjYxMYK7ZVn0fzgccpGQT4siOUdKLn8N0p+23VAjDa27aC8h6nt0p4P oSZXjpdiRb8Kbzsd/q1WHhtr1bdMIWY0M5mhC4w/tTpb2SpkISXgnfEzvTQn3cCMOQTD NPGH/SKU5fEXD8hlma0LvO+rKo8hyYNOTz7qF1+GAnOVB7AF5KYl9qQfo0mKhL6k1gZV +umywimL7ygVorTKGbKXmzINuSA60Ae3/znVOeIbslnLMKqlQIKYOmXhSpeFhOH6Ga3/ 54etQ3POUS9CitwJoccf4ZpBulX391LjlAgJq9BMV4T1tZf6ENpzJfRpysM4AGEvuIwO aUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781289054; x=1781893854; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=QvkLH0y47Bji+e27e6NH0eYR1UmPVh4TFWWAYheZ7bT4AGlywwvUr+G8nNLXmzkuMx Bhaeh750hO4qileajLNG2Fqv/W3TWzQsFlcx9nn7S3IH7W0ZUi1FX6dbcSOlhezDJn0E A2JpdvYa+h1cK3MTEJrlrWa1lUJJczczU9xlyaRqr47uIOKGUkqCeUxNbXACEDsi6s+e iXCHAKpWf7WX5wUx6RwhFKkxM6n1PEIWMVkvquPMgLGykJ5lA82ikBsckyCPakJ/OtOR ARLarRzps1Yw1BakIuuirA86ffKJcUux+973PW4YEd2JQw7wcbjqR+YAPoh9Fs8C2OJ8 BZJA== X-Forwarded-Encrypted: i=1; AFNElJ9371XWwm2IcHa0CDSBYgvH3EdV+7N/j0y9S3LA6B7lO9BxoRRyb0nlaPnKPaOtl1LAq7SqDeYyyhmZUlk=@vger.kernel.org X-Gm-Message-State: AOJu0YyGNKtNBOMtj/Q+OusxxWIlfC0L9zUjgbMb3WZFIcUX0yRk7+/M PtHMDsGT4xAEAAlNXmYhPkOKnbQcECo5+RpWguA1UNBlaSwIUHrPt3mTNVQ+LK4fR81nvM9PqE8 qZI+8pqCP6Q7UOXRiCyLbj5WbcUcxQ6zIStmqs8t1dLRVuMmoHb6bhYbcD020TSID8c4= X-Gm-Gg: Acq92OE0S/IXtHOhRnTWJ/NvXd8dB5ZT96268tKRu/tg1VYrdqHiMRRtT6S9aBFkzXd FW8R0/UpvPpNMaeKP2+XGXJ5ctSEwd3satIpZZunPrnEe7fdnP4ysxnq8eAFRhcROSd1CGhQ6r8 5DwIohzfUmtaRlp9GSAyHtFDZtLHWlljN9B1vxlEHWKJ5VM0iY1B/friL1RtJu/wxFMwiiGFfdT 3l+cpgLeBz3gH1mSD5a+8Ab3Z70MsSIQeVItqCFMptvV3yz/55vW4mayqVt6pK7hREAdF6Yq9uT nZabDv4GHIOwTpKoPSD5pl30zL+UZFQADbmvIeB0w7u/fZa96liz+OGSHDj/JreIbzR6LsnFI6e AMv4Dl81uP+axpgaF0dBj8Tig6zgo7y1rZj77npqDT/qYhElBGFCkFiIo3Vto/wy1Ofnc8bgswZ xr42AmrKKXCL7lk38sEtje+/9bhfzWyU5vV4I= X-Received: by 2002:a05:620a:bce:b0:90c:a08f:c5f0 with SMTP id af79cd13be357-9161bccaed3mr616313885a.33.1781289047374; Fri, 12 Jun 2026 11:30:47 -0700 (PDT) X-Received: by 2002:a05:620a:bce:b0:90c:a08f:c5f0 with SMTP id af79cd13be357-9161bccaed3mr616175885a.33.1781289037649; Fri, 12 Jun 2026 11:30:37 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e161fefsm742173e87.8.2026.06.12.11.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 11:30:36 -0700 (PDT) From: Dmitry Baryshkov Date: Fri, 12 Jun 2026 21:30:19 +0300 Subject: [PATCH v6 9/9] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260612-wb-drop-encoder-v6-9-9f3a54f81310@oss.qualcomm.com> References: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> In-Reply-To: <20260612-wb-drop-encoder-v6-0-9f3a54f81310@oss.qualcomm.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Liviu Dudau , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Suraj Kandpal , Louis Chauvet X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3014; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=mE50BYUB/UAw+zq2VOqPPalyAMn1gAB1RtsYcBWwgx8=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ5ZOgPm7hKVaN3b0hT6bcClZSGAmt9jj62VfnGUivxSkl FVM9wnvZDRmYWDkYpAVU2TxKWiZGrMpOezDjqn1MINYmUCmMHBxCsBE0nay//c/97a2SbnxVfwx od8Z9RozxE2/d3rfOSh1P0zje3yeaSB/S/XRfVc0gwKz1j4p+rh++94Wl+wgxd8TAkNsea+yRuk IzkpZFXNW2f/Zg8wPmw1neZh0rLrQlVETKHpl3VR5PfVNW16uC39wPqQnxifsyP7V/znnhfAU8f 19MOXqHOZwNj8mX8a7OduLjdh/1QqcVFZQWWhREPJEaN6UF5xep5gyFXZbeHiX64vXxD6IMfQwS a6umKp2szu778CpkNkNe9qmsWueMrZnvzTvmvj93HkySrOP3JyWoKt/4CG/r2KBWtvqmXUH9zu7 xsdlhL1pebleUHSPr0iMxOp6xdx2Hdk7Pz6Lsx63C/cDAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 0yHFujMXSBYEVeUt2Wig1Z3uy8sW11VY X-Authority-Analysis: v=2.4 cv=c4abhx9l c=1 sm=1 tr=0 ts=6a2c505e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=By2WwYRBACVvdXAjiroA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfX+k+CyPgZvCA4 Sw6uTpNKUtVucA+tJ5XnG/lYnDPqFEztLlk3vrrGMkhwR7iEvfy3YVOncOxC8HYA0qDgs9QOVO/ U4Cl541w5epre3GRahthGuNBPTLarOyBxcdktaZ2/x+uCzBFQpJKcvkX5C/XxVIurbeZV/c8IZ1 WbO2hL8BihrmfTlHIAcqnb/4zPSQ99xls8N/FwNkyhoe+TUS4cg6rzP5hAOxYSkTB0WvTfsJe8Y 1jUIMKM72oZcRPxVaC6hJ9zCjuh56QPeLYPIF8RqyAmR+OqtfD1pUo8Q7jgt2RS+Eb2xlFa8bVJ EtokryL+ogLur5cf+v6NozeOlWgtQfxV6sHDnu3j5/WGjuak57+h2nu0I6j/kaO066pTyHtxuSX 5+shtcaXluafS1GSzyGc38JW8dCG8f30lPY2HEZL5SeC+3yvp3VgGtrXToAk4xcIZXCHi6yw7WX NmElTDgzBQvrVrPNn2g== X-Proofpoint-ORIG-GUID: 0yHFujMXSBYEVeUt2Wig1Z3uy8sW11VY X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDE3MyBTYWx0ZWRfXx2EnsYvW1JGp Si8cpCutPH3jGlLcuKHAFuAHKtanp0jpMvhfN3JbXa5Dt+9HyJE0fUKCpeMEEWq4qwf4B8l/No7 mGW4oROQxqeCHaBtHqquA/UToII7y3o= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_02,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120173 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 9fc15168c34f..68fdac745f42 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320c..958466a05e60 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.47.3