From nobody Fri Sep 25 19:19:52 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9838A3BB114 for ; Thu, 11 Jun 2026 09:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781170177; cv=none; b=frYa015YDGWTUtCAeincPP154S8pVQwIO1/gW0TVmF17IKcnz4OokLNMgHlib5UStBoEQBl/jrcQD6ELEZdBrFMPZHNxRmhUope7Q8+TipPnR67rR82D7/XNHvOWEa9ovc6TSsjy7RxdzwT7T5FN9MALLpNFXVYGK9lwW4frWhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781170177; c=relaxed/simple; bh=xZpkcRsjMyqwKXIMySA+dUyCEbiGC+Dy79GqvFaXwvE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Wqp3eYd0Plujvz4GX3aZJnZPek5JZ3/K0QsTkJzQ82XiiVw7rANY5jE/PR6tGvDEdDgW2MrNAleVR2HwbriCxmosvHB0ES7i6gA9f47E+Szw+3qX84GwU+O9nHDPVnkrgHuvkh8D9CbNAzXA45IKdRxAcbT8ECVRtlAb4kKipD4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QlHQTHy0; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QlHQTHy0" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8423f236418so4370766b3a.1 for ; Thu, 11 Jun 2026 02:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781170176; x=1781774976; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0JEM3IPEIHf7I0phAfhJo+nw+BnZ//a7nBgiLZ1jD44=; b=QlHQTHy0MlumQyPqeSFi7Um/DF0wRxpySH1Vr79D/Xx9GSMD6ex2nLJlVHSVfsJHch PqVoRXINQIg5g5PwK6auQdz8ip8GdDFTXgqPGSNoN9vshanalOvy3EjP6UHP90mZOR5P 2R4pZ4cVPg9HeHdW0auspIsA28HEgiiqLria8sSqAHBqsvS/WH7vWsstZ/dIwCRbgM4q Q/EnbwfLxAuSlIrfDkKjLSUkJToNjSSShiZfXgcWwseMT6gLFTlnc6KLXLk79KbJv/0R hEIVKk7R7ai+4uLRzLzvxZOyMvlD1v0xs3PrNDxg7Mb7GmhjrfVkGUOKwCDZntPx5cuH aCXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781170176; x=1781774976; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0JEM3IPEIHf7I0phAfhJo+nw+BnZ//a7nBgiLZ1jD44=; b=sdoUEjXkOeVrVjyeyV7qbn0NHdQb8Hpwh1CqfwQfEeMoIkwHuOQskq1GM5xG/LY7sk 7npSVQK6l7g1YMamzfop9/0KJ/ASTX+ijekPQrQbOToe+O+sb1XABuqMLXg/2n8bDH0Z zXFTxX1NinqW3k6L90bfDqZHCxkNX6eTNgvs5muUHAlXAd/2bYpbpr32Y0u+Wv1R3wh7 tS53kVrYmvFTN9Abu/W6RE/dx4pOgXsIptdxBKmt8hNm2aimJnBMGXwXDZogVP2WJA0K BkNNdkXv0YrPaFU+8pdHBm3wkpZoSHyVeTKhplXNQK5F2dVAJMOp33iDaDYCKQ7EYoNJ Scvw== X-Forwarded-Encrypted: i=1; AFNElJ+hKc4V0hKwmayO1w/JkWJ8QjpK3e3PlNiR+IJpxX/k/7qV9hBeX2FqmDZJTkDFr0DtXPOziuYZQA8PVU0=@vger.kernel.org X-Gm-Message-State: AOJu0YwrBI85Rkz4hhbw9H29BuGaStgAWxsZMcx4B3xdE96J/xJtAiMo DkwSzrto/VA1gailOsP5Hy/rrNGLsKyHpEaz0W7AnW6e0cfvXkbSHuEh X-Gm-Gg: Acq92OFkiLZ0CbGHivw9KHtfo/8OpkTx96Eq0Dv+SQCmZf99FPeiv3G5/MqvVTeK96F qS2qEvqzLKLidRhHipbkUNS1dpaXc0aPL0/SKoBcxDxZfhB5C6sm4X9Uyp3Mhe5KZ4bcvSpLl6v un5kjrKpUgJDQfQiHnCZ5kJ21bIy9zQxL1iBIPsPiCdmMIGn9zPBqUFUvCYiTz/5FVorLYTVkXv gjIaqElistB4GlJDrYYKsWZm/ylZt5JlfjLjqeFm/kl6AiOEhziY20MmBbGHLbvEHiytuL94WBQ RXyvsuyn4qQ4mHdHOgGAS0htbuoeKAj9VnnDi9Z1vcVIGfHY29bBnV/Gae4Z6fDpFGdettTuYln HgdK54iNyNp+XqqsQFBDmRVuqnJpFnd6lmZBoE1Kz6JyBSvGnIjnL92MPw4ErhGdUdVXH4n2PNY C4o/EEcTQXBoNJRwLqhqkENxYlckULhnfz6T42MCUyc8qK79e01rxo0KUcfz40mHLrHTdY3CIN X-Received: by 2002:a05:6a00:1412:b0:842:380a:1ee8 with SMTP id d2e1a72fcca58-8433690a40fmr2276378b3a.17.1781170175939; Thu, 11 Jun 2026 02:29:35 -0700 (PDT) Received: from cps-manycore-1.. ([147.46.174.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-843382f094csm1424334b3a.47.2026.06.11.02.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 02:29:35 -0700 (PDT) From: Sechang Lim To: Eric Dumazet , Neal Cardwell , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: Kuniyuki Iwashima , Simon Horman , Lawrence Brakmo , Alexei Starovoitov , Jiayuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH net v3] tcp: clear sock_ops cb flags before force-closing a child socket Date: Thu, 11 Jun 2026 09:29:18 +0000 Message-ID: <20260611092923.1895982-1-rhkrqnwk98@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A child socket inherits the listener's bpf_sock_ops_cb_flags via sk_clone_lock(). If its setup fails in tcp_v4_syn_recv_sock() / tcp_v6_syn_recv_sock(), the child is freed through put_and_exit, where inet_csk_prepare_forced_close() drops the socket lock and tcp_done() runs without it. If BPF_SOCK_OPS_STATE_CB_FLAG was inherited, tcp_done() -> tcp_set_state() calls tcp_call_bpf(), which expects the lock and trips sock_owned_by_me(): WARNING: include/net/sock.h:1799 at tcp_set_state+0x433/0x550 RIP: 0010:tcp_set_state+0x433/0x550 include/net/sock.h:1799 Call Trace: tcp_done+0xba/0x250 net/ipv4/tcp.c:5095 tcp_v4_syn_recv_sock+0x850/0xa50 net/ipv4/tcp_ipv4.c:1787 tcp_check_req+0xf30/0x1360 net/ipv4/tcp_minisocks.c:926 tcp_v4_rcv+0x1047/0x1b50 net/ipv4/tcp_ipv4.c:2164 The child is freed before it is ever established, so it should run no sock_ops callback. Clear its cb flags in inet_csk_prepare_for_destroy_sock(= ), the common point for the IPv4, IPv6 and chtls forced-close paths and for the MPTCP ->syn_recv_sock() failure path (dispose_child), which reaches tcp_don= e() on a child that was never established too. Suggested-by: Jiayuan Chen Fixes: d44874910a26 ("bpf: Add BPF_SOCK_OPS_STATE_CB") Signed-off-by: Sechang Lim Reviewed-by: Eric Dumazet Reviewed-by: Jiayuan Chen Reviewed-by: Kuniyuki Iwashima --- v3: - move the clearing into inet_csk_prepare_for_destroy_sock() (Kuniyuki Iwa= shima) v2: - move the clearing into inet_csk_prepare_forced_close (Jiayuan Chen, Simon Horman) - https://lore.kernel.org/all/20260610155946.894878-1-rhkrqnwk98@gmail.com/ v1: - https://lore.kernel.org/all/20260605094954.1374489-1-rhkrqnwk98@gmail.co= m/ include/net/tcp.h | 9 +++++++++ net/ipv4/inet_connection_sock.c | 1 + 2 files changed, 10 insertions(+) diff --git a/include/net/tcp.h b/include/net/tcp.h index 98848db62894..607298501e12 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -2942,6 +2942,11 @@ static inline int tcp_call_bpf_3arg(struct sock *sk,= int op, u32 arg1, u32 arg2, return tcp_call_bpf(sk, op, 3, args); } =20 +static inline void tcp_clear_sock_ops_cb_flags(struct sock *sk) +{ + tcp_sk(sk)->bpf_sock_ops_cb_flags =3D 0; +} + #else static inline int tcp_call_bpf(struct sock *sk, int op, u32 nargs, u32 *ar= gs) { @@ -2959,6 +2964,10 @@ static inline int tcp_call_bpf_3arg(struct sock *sk,= int op, u32 arg1, u32 arg2, return -EPERM; } =20 +static inline void tcp_clear_sock_ops_cb_flags(struct sock *sk) +{ +} + #endif =20 static inline u32 tcp_timeout_init(struct sock *sk) diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_soc= k.c index dbcd37dfdc15..6305da871e78 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -1279,6 +1279,7 @@ EXPORT_SYMBOL(inet_csk_destroy_sock); void inet_csk_prepare_for_destroy_sock(struct sock *sk) { /* The below has to be done to allow calling inet_csk_destroy_sock */ + tcp_clear_sock_ops_cb_flags(sk); sock_set_flag(sk, SOCK_DEAD); tcp_orphan_count_inc(); } --=20 2.43.0