From nobody Thu Jun 11 10:16:47 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8AF630E82D; Thu, 11 Jun 2026 05:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155810; cv=none; b=tQ/3bjMERhQ4+PlbhUd/TCgQy5cNmdQLmZmX206z4GdoBQgwmbAcoH7XcxcRIqREgq5vvhJA7D+ZyckHzGsxdtny3FT9GHRrSlp/MLOA5UtzNZ00r8jYOGWhNJPqjW7loE7f4o5kbciCNgqtUMVGDaVg1q4IL1O+0cu6VmU7qN0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781155810; c=relaxed/simple; bh=zPyDYXa6zGSFKayiHQHtfIPXQU2y4Rco+w2TGKlmhLs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VEai1ZoT7VdS+lRhkBga9DBoZ2zVdo0JIeK31KlO6nh67XsgS97VkJHNmc2NwzaRBjFAQ2CiZmxX6XKv1gH4il9qlGL/Hslr+HRlMxNIgXrisFu0YdauwZYtnf8dX0PpybCwKuR5AOTytqlN0B8PT0lCL4cEvllsFHaap6kiqio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a97rLwiS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a97rLwiS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A87711F00899; Thu, 11 Jun 2026 05:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781155805; bh=VlUmGwE0ILPgOg+KpZs1mxPqeBRs9I2PikBa8crC90o=; h=From:Date:Subject:To:Cc; b=a97rLwiSf/wopPh1XUAO3MQnqZCbyeIzz8OVwoND7Lc8TZ5X10f15Uo3QHpxuT51u s9U2ngqpgeoHDKUK002wtev5CqIq+4nSyH3+9DEHicAuDpfpDY65zKy8EbeVOnarnM N3keGgZZFd0VIBOyhxiVi58AEwER/T2GB/yh41r0b4XC69hra8gdTB1T4G66GOW7ZS LVaAHlR3Frl2vHbgZGlDi0rSdwaV2L8kiV7NofRmTlFT+L/cMYbNiTM0MMsWPkEQdu MEXUJR8F4iYCzV5SnN3wC/uqDSNb5/Jk2VM2RlLzFUtrPDJHpDPr820OJTtmxzFICo 3oDGQAMaXsWwg== From: Eugen Hristev Date: Thu, 11 Jun 2026 08:29:55 +0300 Subject: [PATCH v3] media: bcm2835-unicam: Fix log status runtime access Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-bcmpipm-v3-1-c609dacb029f@kernel.org> X-B4-Tracking: v=1; b=H4sIANJHKmoC/2WNyw6CMBQFf4V0bU0fUgor/8O4aMsFqvJIi42G8 O+2uFDjcpIzcxbkwVnwqMoW5CBYb8chAt9lyHRqaAHbOjJihAmSM4q16Sc79ViYvJBQcMZLg+J 6ctDYx1Y6nd/s7/oCZk56WnTWz6N7bleBpt1/NVBMMQetpKylJIf8eAU3wG0/uhalbGDfIvuIL IqK10oIo03ZkB9xXdcXx/qyHuoAAAA= X-Change-ID: 20260521-bcmpipm-6c578e73239c To: Raspberry Pi Kernel Maintenance , Mauro Carvalho Chehab , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Dave Stevenson , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Jean-Michel Hautbois Cc: Naushir Patuck , linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Eugen Hristev X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3216; i=ehristev@kernel.org; h=from:subject:message-id; bh=zPyDYXa6zGSFKayiHQHtfIPXQU2y4Rco+w2TGKlmhLs=; b=owGbwMvMwCXWkjcnuXne3fmMp9WSGLK03K92NnL93fC/x8y3t8BrT+aUBxzszr8cWucYfPzqv K/Q58mkjlIWBjEuBlkxRZZqk3+1wv073E+6WqrAzGFlAhnCwMUpABO5nMHIsG7zoq2HxM0zDzxq eKjwSfnkpg3LNY/+L9yamZKwPdl7cQPDf3fVv0zP/h/9+bh7xaVJ18yDHLv8p6Ts7lH8duqSnVQ pLx8A X-Developer-Key: i=ehristev@kernel.org; a=openpgp; fpr=AB184498D27A77B65D7852C81EB31E020EAC2FC8 When requesting log status, the block might be powered off, but registers are being read. Avoid reading the registers if the device is not resumed, thus also avoid powering up the device just for log status. Fixes: 392cd78d495f ("media: bcm2835-unicam: Add support for CCP2/CSI2 came= ra interface") Signed-off-by: Eugen Hristev --- Changes in v3: - Changed to check return value of pm_runtime_get_if_active() and only call pm_runtime_put() if the device is active. - Link to v2: https://patch.msgid.link/20260522-bcmpipm-v2-1-a3da66cbc9f0@k= ernel.org Changes in v2: - changed to use pm_runtime_get_if_active() - add corresponding put() - Link to v1: https://patch.msgid.link/20260521-bcmpipm-v1-1-3eba88d88045@k= ernel.org To: Raspberry Pi Kernel Maintenance To: Mauro Carvalho Chehab To: Florian Fainelli To: Ray Jui To: Scott Branden To: Broadcom internal kernel review list To: Sakari Ailus To: Jean-Michel Hautbois To: Laurent Pinchart To: Hans Verkuil To: Naushir Patuck Cc: Dave Stevenson Cc: linux-media@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/media/platform/broadcom/bcm2835-unicam.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/med= ia/platform/broadcom/bcm2835-unicam.c index 8d28ba0b59a3..96b51e29bba4 100644 --- a/drivers/media/platform/broadcom/bcm2835-unicam.c +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c @@ -2043,6 +2043,7 @@ static int unicam_log_status(struct file *file, void = *fh) struct unicam_node *node =3D video_drvdata(file); struct unicam_device *unicam =3D node->dev; u32 reg; + int pm_active; =20 /* status for sub devices */ v4l2_device_call_all(&unicam->v4l2_dev, 0, core, log_status); @@ -2052,6 +2053,14 @@ static int unicam_log_status(struct file *file, void= *fh) node->fmt.fmt.pix.width, node->fmt.fmt.pix.height); dev_info(unicam->dev, "V4L2 format: %08x\n", node->fmt.fmt.pix.pixelformat); + + pm_active =3D pm_runtime_get_if_active(unicam->dev); + if (!pm_active) { + dev_info(unicam->dev, + "Live data N/A due to device inactive\n"); + return 0; + } + reg =3D unicam_reg_read(unicam, UNICAM_IPIPE); dev_info(unicam->dev, "Unpacking/packing: %u / %u\n", unicam_get_field(reg, UNICAM_PUM_MASK), @@ -2065,6 +2074,9 @@ static int unicam_log_status(struct file *file, void = *fh) dev_info(unicam->dev, "Write pointer: %08x\n", unicam_reg_read(unicam, UNICAM_IBWP)); =20 + if (pm_active =3D=3D 1) + pm_runtime_put(unicam->dev); + return 0; } =20 --- base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83 change-id: 20260521-bcmpipm-6c578e73239c Best regards, -- =20 Eugen Hristev