From nobody Thu Jun 25 01:55:02 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064A92D7393 for ; Wed, 10 Jun 2026 16:49:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110151; cv=none; b=DWCcBLXlMijLRXazpZljEVkFMx0AY6oOM93MsMkd8Mw+exXq2xahE44MJiUND6XS7O2FOPVO5ndcfoIaGEOJEUbLH1LB+Pf3SWXuS7reoFsCz/yf5/FEHJmzXgj29qMgdqJXXcOw5+UlJs5mTqKzKzH0vYvZy+1Dt79EHGappK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781110151; c=relaxed/simple; bh=0BdLQkxHN4COZJDGg/Dp5Lo2uSOTcX5WYl+MpUrQY60=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XXwoVe5k4LwhBiPY6iB+ewK3fIyQp5vFJmJ5+X1Tm9X8dPV5QDhAtvbHp5tvyjL9hZDDZC1o1BmnpOzcX1MC67ioK9GYH3RjRwEyW4wk6kbDO9LfNOmbFN569LAiiNlpIm4POGXAfIRvB3LCKDHMnnb7brqiXXs24pk1wpXX/qg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jYU8s6kN; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jYU8s6kN" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490acbb0f89so48195675e9.0 for ; Wed, 10 Jun 2026 09:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781110148; x=1781714948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xmZOajtGMWq85o0vR7aIeRgh0GUAaSMaYR5OIw0N/tE=; b=jYU8s6kNJ6gVNSmakCVFk5aOu/mI7SE75xClBWPJhX0Twlc4AI69R19hTm2AupmljZ YzcuFPHD2X7055Bv9k/GGV3X7umPVjUpRjEpCrqNBBRZc4u/VeNfSSaPVsxPv1DItq4/ uGvwj7rBQB5WvFeHu1MXbW4PyQmLnhrit/4aK/g4ZS0I6cKiVmobuIj/iJqSyZllZrMi h7MW4QAXtPhORkUH3V8NGW8cUPhMfAFUUzq0QYQY63qNbzJaldRuCBfPLeXTH7n56scM 6hM4mMpv+1KSX9YCVIq4gdrhGlY0I5nGP8xuRNDu0aZ+5s/nfcMMjOTOKtPGUx61Ntvb WaUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781110148; x=1781714948; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xmZOajtGMWq85o0vR7aIeRgh0GUAaSMaYR5OIw0N/tE=; b=kQYndxIP4lqgilzYG4F9eU8hMGNsVox1HbFKnV5/VkfUEwn3sEMq2pZbX4uBOEZxq2 b35m8zV4vTH6Iboc4tSfJP+Ah5bQkPO/B7dWYEUUR1RuPcEpm/b5PhuloyBeFT7NdGAb ER5+BqJ0/1oG5auxoCSjaItfKA/9Yk0+NqQj7M61aX/gS8FQY7/GYwhe84PJI+gsHxph 2yYTjCSI8245bUSFsZQqwJq0sBRgrV8WXHack/juPvN2OCWyzpan2QtC/X1NR2OUcHbX in5WvDayXp7SWiuVGXBTIkVCGMW2KmRfSNMUmm5gEP8IXTzC4BNZuUUCZxYW+PMObu5x xZaA== X-Forwarded-Encrypted: i=1; AFNElJ+6bwWKmsngd5VC6TwWuwL8kaILMZzehm+ltbRAMq9VMZNJs9SXW4jTX0UCnC+7ilRjN0lCviZD7/xaq9s=@vger.kernel.org X-Gm-Message-State: AOJu0YydI/qSTnTkUhgA1/HOKa60e0uGRjTIct78BerH/mjCDQF1A/ZZ yfn6fJ7XTQ14T1CfT+M7JdoVW4agEz+Jw5udHV7RrKRuSoQnt2Qxbasu X-Gm-Gg: Acq92OHcQd2xronCO9LVnHGWo+8Y4jBjlZTtamiUwZSDW9RuyXNhfQaHPRIWxRYxOgo iD0iyhPEdE9r0fJWd4L+JgCo7OnFbs35bv03jIQC2h2e1bcLin4zRrrUi2lVaFb416uoG/667lE 3dqK5Wt9cywdXKD4FcofZrY4qedavIGLZ/sON7LnAnt2XRo5b6Hs+Yu2ZIXLUtnTMKfmDYv6jYf dG5zXG+bwj3J6JQktBV2FiHAWg4NzrNOnyNrhNQk+EDu89FJ1T68mSpaqIswnCtS3XqAyKhAZf/ msV1dPm1whM9LgoL0zDdrsnQE5bqW2Ze102SPSmjrNHwNho7QZAT84t2FHCLBCFQopsdA9KqmxA Ws1eCFjOPaQhP28WtRNIMi+L+C+LgE25ub9C+v11EtoxtgUOBblHw5WOqovNHT/7yXzH5TvI9LP XLyzeIjMrro3wXToTBsyEZKsWloH3OsbNj X-Received: by 2002:a05:600d:849c:10b0:490:b58a:e6ff with SMTP id 5b1f17b1804b1-490c26e1aeemr285070985e9.22.1781110148220; Wed, 10 Jun 2026 09:49:08 -0700 (PDT) Received: from omarchy ([212.58.120.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e28416desm1761735e9.1.2026.06.10.09.49.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 09:49:07 -0700 (PDT) From: Nikoloz Bakuradze To: Greg Kroah-Hartman , Khushal Chitturi , Archit Anant , Minu Jin , Andy Shevchenko , Kees Cook , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Nikoloz Bakuradze Subject: [PATCH v2] staging: rtl8723bs: core: avoid NULL pointer dereference in c2h_wk_callback Date: Wed, 10 Jun 2026 20:47:54 +0400 Message-ID: <20260610164755.49626-1-nbakuradze28@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kmalloc(16, GFP_ATOMIC) in c2h_wk_callback() could in theory return2 NULL, which would then be dereferenced in rtw_hal_c2h_valid(). A 16-byte allocation effectively cannot fail in practice, but add an else continue; to the guard so the failure path exits the iteration cleanly to make the code more robust. Signed-off-by: Nikoloz Bakuradze Reviewed-by: Andy Shevchenko --- Changes in v2: - Dropped Fixes:/Cc:stable per Andy's review (kmalloc(16) effectively cannot fail in practice). - Switched to Andy's else continue; form inside the existing if (c2h_evt) block. drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index c1185c25ed369..8d06b9d0e9bbc 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1708,6 +1708,8 @@ static void c2h_wk_callback(struct work_struct *work) kfree(c2h_evt); continue; } + } else { + continue; } } =20 --=20 2.54.0