From nobody Thu Jun 11 02:45:01 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C412D0602 for ; Wed, 10 Jun 2026 02:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781059828; cv=none; b=IqosYigIP5DVtqUNR2KfEmRA7YwnvXRdKZ4EYWFRqK/d1tahkiwqyqlJXAvCMoHbFrBt0hhfNJ9HFJLxCzuC+sYYQmw7hOREdqzt7uW49tDljc/4xKtBg0MyLxo92z7qtkammm5P0s7dQR2mOXkVPotWkZi6qbALEW8Tx5cpDlg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781059828; c=relaxed/simple; bh=qqZUIAuofezY45TCSDHXYgH63SWhY1ip7eWShP9F73o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aDlK+IpLp2F4mAmU7RKN8LGlwNtXl40Pz410zvcGRoStvblVmaqCNktZrvePVZhu1goV0DgvOXYcGWmVb8Kjv6gKrLMJYTvn+uFECL6X84YBxe9UbskG8Oi3jL02qkPBWRm/Txfm1KMSFSLgcAR05/kzDoTE6vTJTuiOH0JSKns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nnq8Tm4B; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nnq8Tm4B" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-842d37438d8so1301232b3a.0 for ; Tue, 09 Jun 2026 19:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781059826; x=1781664626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=New9XIBi5RYOIip+hYx53iokI1SR5R7v21yzx2FBPSs=; b=nnq8Tm4BIm2woZV0ZSxL/T80/RE/VNjg7QCmXKBTYLHfEg8dOd3G0Jgt71OTnsGZfU x08LyVwEKihpdGZJCFNTfiPLNh2kd8pJrA8wnm094BOfPTPwEGCNdt2KBR+G0CjiDRT3 MIagq1aivAAyTkLeMPPU9mSbM32zX3Kt4Lh2ACaDN4u+c49lf+2mxZb/X+l30EGttV4/ r1Zn6FY3AYnHgP+u3TLg+5YsIFVHFAvGgCFwmKk5iG7C0c/UHqpgflFMI/xSFulXQNVX Rr0PpJ51kjRmO+km6oAJJ4K79akluVuwGukbi9heFhtBPCjr5cn1SLmgQpyxSUji+zyx kTzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781059826; x=1781664626; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=New9XIBi5RYOIip+hYx53iokI1SR5R7v21yzx2FBPSs=; b=HAJOVD5o2dDiautczDNsADJF6z60WxUZd9Qu4v0JyIpSdNqOyLC5VaczyZjfTvtoLf 4tAv9CCfoPZXdst0upaGyvh26sg9fO3p3niEqOYrsS2E6dS1wC+/1WoaTW5QykLPu54k ToE8t59LqnuSm8C+TA4azZs3Kbwa3sLHpyGG0dB72hGtOMaILN1tF3DAndcuI69B+bVW OS5TEO4xZIKDeTikUVal97kW12qxjMr9nWxfR3fthNysqhsN2HnFBHtYvIYBIyCEXU1H 7Zp3aljOuPtR6wrZPeoxBFG9VwYLy5dDXaIdrXz52ZXObTZIeG9bAkQpuv6kpHfesB5O JBow== X-Forwarded-Encrypted: i=1; AFNElJ+QWOFNn7vcdD962FyasuiRwv1yQ6+R+DIg4cGSfGEigfa6omDoscyfvpW3fWCSrpISWjH/xEGPQUoK/G0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxwh8e8rGDhAZCDCzvAITQ9jAAqbV1OKgjR7n05Bd/QZ07I+UDF vQACba+ooBCDKVeQoaZRwyNDNCYQUN1zVXG7yjBQqphjguBetQ7u90pI X-Gm-Gg: Acq92OGddEnxd9lhR1M3QpVNjUOB6PqNH3crDwPJofilF60K16Z9so2KkvSOm28kIOK wdF6kaDInmMfOpYcoIGG/BtDNx4jdsghDOfE9QHqRrU2r46saDlA8BXx1h1cWyV66pzM5RuwyF9 cvWrHHtJ3eAWrCSUHVnNnsnLKa0xp/K0G+aSnW0UoJppW4os5INSSTC+IxG31LNgsBxcSiLcSSp shIa/yNuXd3PAJ60poceOzp2gXigbcc3JHCSsiw3fgP+vQx9/5AyjO+J9WyHUTql/n6R5Ldb0b0 ZoV/TJFOr6YhQOo12ZedulfxvBWRO/6tDdpqQTWaUxCi0oYQBFZSBL7nANhVPFb0tCsmxOoTFAe yD4XLW+btPDwGAi58Bw0zL7egA26Bbz/nlNqHUI1RUNwzjEn162BEJeZ1bKprxM09clWT1FtIfn geT6pcIbZLndxa0v0HPiay09mAGCfWOivQdFbl58JNKUMEvo98cMLNXB+ghF1P/dft6tU= X-Received: by 2002:a05:6a00:4fc9:b0:842:5931:7b8c with SMTP id d2e1a72fcca58-842b0e20598mr22341362b3a.1.1781059826283; Tue, 09 Jun 2026 19:50:26 -0700 (PDT) Received: from oslab.. (n058152109039.netvigator.com. [58.152.109.39]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842820e8e6asm22196451b3a.0.2026.06.09.19.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 19:50:25 -0700 (PDT) From: Tuo Li To: simona@ffwll.ch, deller@gmx.de, tzimmermann@suse.de, kees@kernel.org Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH v2] fbdev:modedb: fix a possible UAF in fb_find_mode() Date: Wed, 10 Jun 2026 10:50:14 +0800 Message-ID: <20260610025014.5913-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If mode_option is NULL, it is assigned from mode_option_buf: if (!mode_option) { fb_get_options(NULL, &mode_option_buf); mode_option =3D mode_option_buf; } Later, name is assigned from mode_option: const char *name =3D mode_option; However, mode_option_buf is freed before name is no longer used: kfree(mode_option_buf); while name is still accessed by: if ((name_matches(db[i], name, namelen) || Since name aliases mode_option_buf, this may result in a use-after-free. Fix this by extending the lifetime of mode_option_buf until the end of the=20 function and using scope-based resource management for cleanup. Signed-off-by: Tuo Li --- v2: * Use scope-based resource management instead of manual kfree() calls. Thanks to Helge Deller for the helpful advice. --- drivers/video/fbdev/core/modedb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/core/modedb.c b/drivers/video/fbdev/core/m= odedb.c index 703d0b7aec32..b6926764a99c 100644 --- a/drivers/video/fbdev/core/modedb.c +++ b/drivers/video/fbdev/core/modedb.c @@ -626,7 +626,7 @@ int fb_find_mode(struct fb_var_screeninfo *var, const struct fb_videomode *default_mode, unsigned int default_bpp) { - char *mode_option_buf =3D NULL; + char *mode_option_buf __free(kfree) =3D NULL; int i; =20 /* Set up defaults */ @@ -724,7 +724,6 @@ int fb_find_mode(struct fb_var_screeninfo *var, res_specified =3D 1; } done: - kfree(mode_option_buf); if (cvt) { struct fb_videomode cvt_mode; int ret; --=20 2.43.0