From nobody Thu Jun 25 00:31:36 2026 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75E43CE4B6 for ; Mon, 8 Jun 2026 17:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780939644; cv=none; b=XUPemcO2u9IAq4tOD/7zOlw1xHqhiuk1PN2FxZR6wsLlyufkZTf7ukdL3ORo5lFJ6rGXCt5UuTHEeWyiJ0vSexhTi0UREe7eCcrazTkwBv+n+Xvxg1ICQ1j+Q9CIg7LcElyUa4NrFjSfdXBwlbGs6M6Bta08IIjbwON0/xZ4LGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780939644; c=relaxed/simple; bh=l9C75fcvWZvNi7gLPQfgdXteJ6Q9R3agLFtFkO6hVog=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LYjIO7AG0C7hzjd8VX+LiKJx/ueJF/qUk2MHC8nf31nkAf6Mk+F/ZNBXYrJstFLg3CrKK9vbCcHQsTed6+tCEO3gp/xpAkaDRu1WQIb0wSi2NwJJcQBa58jiphKp2wV91JuwfarmM5LybXIlLOrguBRtC9OCyodGapSvmjWkGlk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ig73A8ZA; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ig73A8ZA" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-9157b949fc7so518915785a.3 for ; Mon, 08 Jun 2026 10:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780939642; x=1781544442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wv6HsGvDV1p2p1paiycTLObnogj4qdnEwbEaC+PHzwA=; b=ig73A8ZAAhFIOFgBBIv8oNcXcPD8VGId9SUfTnEgMG7+fnWxiibjlyK4dgKwgDVVYV /dT45HzT1bb06VketFCHD91AyULA/01EGylZvQ6CvYtYZ/nFM2PzFUWErVjzixaZ3hSl DvSBXUETilD5O8aLWTlhWk++hXbgvXtO+pj9PLLtWt0gdGimNtwOBiF3lIUlbBosfyq9 QoBQn/fHkvU//pX2RfYY/eF7vpW/+y5OgqDD8xzSkS4t8mJGpoy8y6qUWVN1J0q3/Bu9 eLrEKCE4pDFiEVNnTwz/DGcVP/DPrPjqbXU8dNJrVSpd8ZKsIvcYJ6cLzRhkeetNqcng O7UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780939642; x=1781544442; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wv6HsGvDV1p2p1paiycTLObnogj4qdnEwbEaC+PHzwA=; b=GIGvbb0Jglfgp4ayPqmsACPI2t16JjOINoEUgjjz2Lp+GzAzhRBEF3FIQYVfnf4RZZ abooM3MspQzGmW+ztcqaG9ryz08Y59ERjrQVX6bCpbO2GO11jUbUPz5QloESyJJvuioV q8BCNv0Feoqjd+9JMJVoD5kBE4cWl0xpjPAQXMf1aVDFi9l8ZbMwopew1KU4cx2xTqwl MVdezA5qpQNIjXdoG0rPusQa1E6sfZrOaljyj6lbNcvYh/CEoyk5freviwAi7wIf/nP3 f+MljfKUETOaA8tD9ULXYPf7EA9FpcsLmC6JuHcyDTHIlKFhremWpxKlrwziBiYGOwIT cwnQ== X-Forwarded-Encrypted: i=1; AFNElJ9U49Ku5cDjgzAKwzP3E6rnhWyG0n0z79/rPiK212uTB+Xs/OGKYF9mcOqOtb8DMY0TSJdMk5JpEqbRcy8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0SMsBti9Ctui/NJsPA8sQ1bUGTf0DYS8dLSnSZhhBwF3+jAGs ecEwklRvGniNaJSrwZ1dX/WFGC0i1Do+PKOmRF3H8hvrAbfSheuNgmn8cWJL1yGrCIU= X-Gm-Gg: Acq92OERJkacgJachx56TyOnEFgG4pmTIEfqRXlgum9oXLElVnlOokOX3BIoEic8xLh uIgzffw9Qt/TfO/mHwaY6tgblVLbaUtHCDML+onJWPuJogtoAEICMhalACFpLQbL7wNnvNBEOum yMY3eDbPrQur11IiETlff38ebTGmuzZEAD+OJJQGCkPOjm0gySprnZJwKn8PGt1sjHe4H/TLz/I EYpIHEtP5tZalSKTU6vcVvkwdERz8zgG1N6/PTCO9NiiiziYhhtohQcSPCkIQOKkE91YKnJ6hhO HZceUrd+xxHIeImKcMuxdotYVfyER+IRAs0log/zA0ifBls1rY9KT+6W/R9RBSV22oh04nMmvtJ 4xTIHM5QE8oREIplpCtlEtpvgn6eNEOAeoiyVootNBEBNoReiJ4lnjFB0+B4X8f6GfhPPsEChXZ R+z+Mwz3V6ch5dUzM6pPzAqmoM5INx7ylvTCkHocxhRsqdI8cKL/c= X-Received: by 2002:a05:620a:29d0:b0:915:9fba:8794 with SMTP id af79cd13be357-915a9c4869amr2529413585a.6.1780939642525; Mon, 08 Jun 2026 10:27:22 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9158a3c2492sm1931802285a.34.2026.06.08.10.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 10:27:22 -0700 (PDT) From: Yuho Choi To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich Cc: driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] driver core: attribute_container: Unwind device_add() on attr failure Date: Mon, 8 Jun 2026 13:27:17 -0400 Message-ID: <20260608172717.88657-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" attribute_container_add_class_device() first calls device_add() and then creates the container attributes. If attribute_container_add_attrs() fails, the helper returns the error with the class device still registered. Callers use an error from this helper as a failed add and do not call device_del() on that path. Undo the successful device_add() before returning the attribute creation error. Signed-off-by: Yuho Choi --- drivers/base/attribute_container.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/base/attribute_container.c b/drivers/base/attribute_co= ntainer.c index 4ad26b8dd6a5..3c456374247b 100644 --- a/drivers/base/attribute_container.c +++ b/drivers/base/attribute_container.c @@ -425,7 +425,12 @@ attribute_container_add_class_device(struct device *cl= assdev) =20 if (error) return error; - return attribute_container_add_attrs(classdev); + + error =3D attribute_container_add_attrs(classdev); + if (error) + device_del(classdev); + + return error; } =20 /** --=20 2.43.0