From nobody Mon Jun 8 04:20:40 2026 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08625331A44 for ; Sun, 7 Jun 2026 23:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874946; cv=none; b=eKlF57cPbbTdz1GQc9wMoCTVpZdvWb0R9jyu4fatbyZ3ua+lYN6S90eHLUpMCWLY9nGSwBz5gl4MDRqavJ8BOuzSsRwe7G36x4hhEK6XaueAXeu9zunyJnyHjOrG9x0/9/vuEP5DXgapUXCKz5+8LLNgVXGq8iKlWEuwFsn9DGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874946; c=relaxed/simple; bh=uF2wjp27XrM7kHX8L5fBcMf7DUs8iOROkUMfrrvG244=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gFlQKmpMI6yZLajTpV9osb7FfC9/Cs24bjMS9bjbWSEWJmPVae2yzIw5/7Zrjv0cwbUBmKhUectG8OjxZ19bV4tA5gApZ1RCWZs1HfIR+U5g21Ce9X271Rlu43RmS3SSJA7rWarV+1B5rWhWOj7BlnK3yzuCxj7NzLqzIzF8NSY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tdr5/Ljw; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tdr5/Ljw" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-1382533d428so1022979c88.1 for ; Sun, 07 Jun 2026 16:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780874944; x=1781479744; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=47lZbQjzRT+z7mXqB+2Qw4HmxmsdDinlE58vVE96Z3M=; b=Tdr5/LjwLn9OzOyOnFElgchxqVxbkztJW9iR+j+Ka7a1ge6jSD6IgCP2s+5Lqu9LFk jZM674W8tqT/oSBH1P+XllqSlFBT3zSk8zKxNVdidHPDPWWJZFxR0HJrl72zzeWbxle4 XiQWplFeAmtXcQpOuiqOLh+WoHNGLpxtJbNb4IgP4xS+7xnct3T6KZGypnaNBhs7/Hvp oyI0DteJ9l4TxW8Lg9KXso02Md7AFP/BEIc1d+xA/lCeZS5p2Y687io/2hWeNm7MP3nj m2fX14qpoPZ3KWNgrddE704YjZb1TpDSN9RJPTjpb24QpPn0UiJZhDvK9oEf9MIfIgId 2ktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780874944; x=1781479744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=47lZbQjzRT+z7mXqB+2Qw4HmxmsdDinlE58vVE96Z3M=; b=MrnAn0JNG7RbVVlX6wNxq2EugtvTfC2Gbni0kv1XkYrCfOvBHFdo6n9BdKrxFcA05/ 2DIMSW/Q7kZR7rp+hpt9BtajGVAcYUr/uaBv6vLs1GPmRQsaETjKBbO8M4ZFoPWClhWj LxEHv52zvxqb9HAIivRpSgTGsX3tF5Blc/ZZXxz7Bu43JQ8qMC1p7Dmljtw3f04PQmgY b31Tj+ih3LkIPokLQeBwdnLI22m6SAex2AfSPH988mXDSZ1u/Mt+bfzA9AeOgL2Hok8s 6qNkc9oASGlOcRXL0nx1QIrQ4OKMkAPE2NEkfngTXt3N0ipFCVEQRtPXL9ueWQKWYeMp DbUw== X-Forwarded-Encrypted: i=1; AFNElJ+ZSr6Kit3rMm5WjoabMbR1/yq88MG8r/gVsvagR2ImEQhz4rUVX82P/z1OFFuH7K2Z/W1XGvS7jl5zv+8=@vger.kernel.org X-Gm-Message-State: AOJu0YxFCN9Tr3Z/nmeWPWI1aBHQXVEbzpM5CJpRQrX+AMyyNiui9BM8 IZBxDCwuc5siS7pDz9lwTBTVjcCeUYIcmXroFY/KPf/yVBSXOrlKWZcx X-Gm-Gg: Acq92OEIZKr4tiXVM0/q3HY1QR+lb7CnyamTM0dBwr8UhSywaxx+yV2SDaTtsdWCubc 9yHKLqLnrKeJJTfVLCsaRNyh2vI6WPP/QylNSxW9vefOloW0ylIKfNM2Tt6HfxKIFi7ETgGYRB0 PQU5duTsbxhWZGZGVJw+X6Y+/IXr4AmXcGU1SBFQw3uCzCtS7hGRrflQdjvCGr1JK60DF9m8NBM n2txltoZQHji5eq9vAEuT5XVkIMhVg03ib97GZ91W4n+DcZ4eQenuiXlqzYlDfN1O3b0PhxEayf 2adkOn8ywEcRAM7EmNK0S5cD/gsfszXCAM6GNTka9+/lt0jMCvAyOEb8UtWuKf3IeCiMyDHQ2cQ GX2nDgw9bib9koIn61/PPaxyDNhm/NArH1KTruIxa0AFbolTW9MENWORpQmLOr4smjWUn4eA318 9lBn1zPPPaduIwnMvDouYk1X0GawkH4g7O3vXkO6XbvwfBnuOnqMqHr3N1crlleN9MCw== X-Received: by 2002:a05:7022:3d84:b0:130:9b78:b17b with SMTP id a92af1059eb24-1380673ac40mr6778942c88.38.1780874944050; Sun, 07 Jun 2026 16:29:04 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137f5539035sm11324554c88.11.2026.06.07.16.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 16:29:03 -0700 (PDT) From: Hungyu Lin To: linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org, stefan.schmidt@linaro.org, Hungyu Lin , Dmitry Baryshkov Subject: [PATCH v4 1/2] media: qcom: iris: fix runtime PM reference leaks Date: Sun, 7 Jun 2026 23:28:40 +0000 Message-Id: <20260607232841.79275-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260607232841.79275-1-dennylin0707@gmail.com> References: <20260607232841.79275-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use pm_runtime_resume_and_get() in iris_enable_power_domains() to avoid leaking a runtime PM usage count on failure. Also ensure pm_runtime_put_sync() is always called in iris_disable_power_domains(), even when iris_opp_set_rate() fails, so runtime PM references remain balanced. Fixes: bb8a95aa038e ("media: iris: implement power management") Reviewed-by: Dmitry Baryshkov Signed-off-by: Hungyu Lin --- Changes in v4: - Added Dmitry Baryshkov's Reviewed-by tag. drivers/media/platform/qcom/iris/iris_resources.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/me= dia/platform/qcom/iris/iris_resources.c index 773f6548370a..f5e3341e1430 100644 --- a/drivers/media/platform/qcom/iris/iris_resources.c +++ b/drivers/media/platform/qcom/iris/iris_resources.c @@ -78,11 +78,11 @@ int iris_enable_power_domains(struct iris_core *core, s= truct device *pd_dev) if (ret) return ret; =20 - ret =3D pm_runtime_get_sync(pd_dev); - if (ret < 0) + ret =3D pm_runtime_resume_and_get(pd_dev); + if (ret) return ret; =20 - return ret; + return 0; } =20 int iris_disable_power_domains(struct iris_core *core, struct device *pd_d= ev) @@ -90,12 +90,10 @@ int iris_disable_power_domains(struct iris_core *core, = struct device *pd_dev) int ret; =20 ret =3D iris_opp_set_rate(core->dev, 0); - if (ret) - return ret; =20 pm_runtime_put_sync(pd_dev); =20 - return 0; + return ret; } =20 static struct clk *iris_get_clk_by_type(struct iris_core *core, enum platf= orm_clk_type clk_type) --=20 2.34.1 From nobody Mon Jun 8 04:20:40 2026 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C99B337688 for ; Sun, 7 Jun 2026 23:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874947; cv=none; b=tdOQeYCQjlaIqTEwJsBTocyMmBXUbG+9j6UTVM9eCsejOyNmCa3XdlhrkDwB8K5Lax6zNZvafZ2Uf7YSjKMCA5aAOz4KFABgByNkOw/wWfOBdXM9/jhU9GkRpLecHSDb8FGTetFVBNgNvl++V1gbc2baL7yuwR947hQ3NWn3N9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780874947; c=relaxed/simple; bh=Qdn7lfFv1Qy9y7QLkJ6IB5ugP3HJ7KhQ77rqkSIgdAU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=huf7NgOnHSYH+Sne8L1YxUr/xiaARibR4fWMGZiIh2fOnVrAiD05q9VAxMfoO90/WtD6s201ewNhCE5pr2nSQd3BGOnlp/NABXsFDUqbFHqpWm6BGAXKPNKLRMjHM3GPzrq+oWSjeCYSIQXFI3RP1eQV2d+/il2jPNoHRhWdON4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mmf+b4bb; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mmf+b4bb" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1363e78746eso3884285c88.1 for ; Sun, 07 Jun 2026 16:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780874945; x=1781479745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gb7ZJjfKb99h5+YHieJkW6NM4/xOtMM48PIruUZX4LI=; b=mmf+b4bbR1lSOK0qHt5r4p5O6oABcLgznR7CBJHsDVo6vU+PxV+/mHpOYURDarYgEr 8ujCQfsayAZaXTa/sItNdP2Y89EJFvtvwC+TSmONcxDYfqNAG1DBW3U8jl6UavY/5if6 KWMBZrx5sy5YXomT5FtNkcyliAcNoIl8sTT7xyw6f/mbUvtguBiythQiMvQvgxRGebnO pQC2E3iZwODYpe/YG79S6RWoK7sRPcmW6fUpU0mnQoUczsrKx5bKdoHMH8/euYSMrjga gcaYEEp4CZnrNwzn+93pv5jN+zhfFD7/CMrEeI7HnYthCPTJFKRDheuG8sbKcjXArysV k0Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780874945; x=1781479745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gb7ZJjfKb99h5+YHieJkW6NM4/xOtMM48PIruUZX4LI=; b=pZzvCLMeu3HFQL7Cch/zjHNc23U3w2uVBWYr+aAzd1ABwrKcxDoCK6olxt/AGssnnm yNH2kqzMXHfrWAHv9BI4dDzXxRpldw1aLi/iGKfD16nhJEVRsZsXToude9ctbhfy0Lok YAzE7kXaUTab/yh6J4qgWgL3UAPTMtp9KegJSOyES12WmQddJk4/3IMGTwHIv4cU2WKp xQ5FqSLcCsE6Uev/VQIu/JIfGfqRkBxSMTg7YnUxwFDFJT2ppqhDjYgKHF3eZjSYumMj 26dokhUBldyCiAEUozbk4OVgXbxDJYBJEsPM5L7fzm6fsznsma9yNG7hBzVIApqarn5d LqsQ== X-Forwarded-Encrypted: i=1; AFNElJ85U4u9Nak8VnISDptJq8VwAxHereAAuiuzDvJAl4XFC3nE17raCKycyyG/4brxnmf9EdFtJ1/FwVuNN6g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1G02gPdPuw4AXYF3U18G53HFDaURoLchdmWkWxjDChHJly+PX 5waUsdqVGFd3ehd/1cprv1lH7dire+ISwF7Y+fgnWJgfJt7lDKMKdqD2 X-Gm-Gg: Acq92OFL2rj5qf4V6U8PLYMuRSBjCXPChU506WMSkH7zHOde7X23YNUdA3m1ksLJ/gy HgIktai9qJ1g97nGu1bt76CkYj1G/M0GCBib7k+Qy34zw+eldcMAQiMOWG/zIfFOT47YnsT7UtD YwYGPVo4anv3bXHwoiH6ZB+jbciY9KUi31uWElRRUiYPf/EKGSZtMW7FQVzF73+RbdDcILMZ+FW xPbb/dvszcXc7usot0fwhn4u0bjQ6TURl9RNHVIHqdgFEdpnw2IfYgSXF678Hwdjg/75pSHPHXV G+cM6SVOwdwuprB4suoAVRmO1ZqFi6crifhrQwsrjd0JiU1sUMMuiCDQVyG3pCsZpABjb13GPfQ D0P2yfjQC1oa6sALey8Mp5gHt82m/C0R6LCNzr9Vf23vED97/w1idYw2gGrtMgQyrRVZbtoI/W3 Ojgy0F/RWNoqYkU6RRo52iRyiTBd1b/8j1/LMUD7/H2nGJAz8Iew+EIALc9xXHaBNk+A== X-Received: by 2002:a05:7022:6899:b0:137:edfa:6f34 with SMTP id a92af1059eb24-138066834b9mr6466787c88.1.1780874945236; Sun, 07 Jun 2026 16:29:05 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-137f5539035sm11324554c88.11.2026.06.07.16.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 16:29:04 -0700 (PDT) From: Hungyu Lin To: linux-media@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikash.garodia@oss.qualcomm.com, abhinav.kumar@linux.dev, bod@kernel.org, mchehab@kernel.org, hverkuil@kernel.org, stefan.schmidt@linaro.org, Hungyu Lin Subject: [PATCH v4 2/2] media: qcom: iris: rollback OPP vote on PM resume failure Date: Sun, 7 Jun 2026 23:28:41 +0000 Message-Id: <20260607232841.79275-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260607232841.79275-1-dennylin0707@gmail.com> References: <20260607232841.79275-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rollback the maximum OPP vote when pm_runtime_resume_and_get() fails in iris_enable_power_domains(). Use a standard rollback path to release the OPP vote when power domain enablement does not complete successfully. Fixes: bb8a95aa038e ("media: iris: implement power management") Signed-off-by: Hungyu Lin --- Changes in v4: - Addressed Dmitry Baryshkov's review comment. - Reworked the error handling path to use a standard goto-based rollback flow. - Roll back the OPP vote from a dedicated error label when pm_runtime_resume_and_get() fails. drivers/media/platform/qcom/iris/iris_resources.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/me= dia/platform/qcom/iris/iris_resources.c index f5e3341e1430..9059cbe8fe5f 100644 --- a/drivers/media/platform/qcom/iris/iris_resources.c +++ b/drivers/media/platform/qcom/iris/iris_resources.c @@ -80,9 +80,13 @@ int iris_enable_power_domains(struct iris_core *core, st= ruct device *pd_dev) =20 ret =3D pm_runtime_resume_and_get(pd_dev); if (ret) - return ret; + goto err_opp; =20 return 0; + +err_opp: + iris_opp_set_rate(core->dev, 0); + return ret; } =20 int iris_disable_power_domains(struct iris_core *core, struct device *pd_d= ev) --=20 2.34.1