From nobody Mon Jun 8 04:25:57 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8915273803 for ; Sun, 7 Jun 2026 19:31:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780860665; cv=none; b=Wee7VU9xk4W83OxG0qV9jpXZ3v21j6c5bh0KFN/7G0p5c90cOkU8XQrHks6/7GOOjussf1s47fMRc7XYmpfSDEOQ14i7MwPktTCFt26rDBK9Cif0UwslfTotqPyggpvIv6DGUdjyIfav6d85zzY8bSSmU2N8zTWxJYtVvA2uMNU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780860665; c=relaxed/simple; bh=UqBn+YJY7M+u065RMcQHz1GgsUI7JWcXHJmj8EfdyBk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=D8QhWFqKitgtUz/Fb9jUnAM/bC2AOgYrwqCLqMiytRocKb2vtz24t0bFhabWTcAVMsEOWTanRhy4/3J8AmmuHvGnGShU7CRFTS3FIpFPmQLoDVCopavGliIr0vUwchkNaq5aci7WkiB2E+bii3mmqeC52S1tTgDLpHPP7kpr5yo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lh5enM3B; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lh5enM3B" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2bf1f074a12so37668595ad.0 for ; Sun, 07 Jun 2026 12:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780860663; x=1781465463; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Js68PLPyN3XjWqEU0fIOqcPtf+mTXJxmFseuifo/CDY=; b=Lh5enM3BZ9aNrJWeUNtyQMjlswsGR2q0v+ChADDSaNo0XB2Qbw20fhhDh5TTuvIjcA tUhxhmPGM9zeuk/rJzbY5bP/+BgmM+aV3moO+qLFGxgTW9/0Bb/SX0LEDLWoYj7dVphD 2JHTv3YjLX9xqGGGP3aimhD4Q419CIvMOMKjiuvZLeURnBvxZk2O5JgNCqsG9nb2nixJ BGCppcSfhzdtmXOEgFWRu9iVOYPUMQKlrRqk9d9V78bBs/mKOrpe5+Euwq+/IGbMP2zm Q921z8jtEfpVGEbLmaHvtuGolvXT1rfCf99KR/LP36btnzm3qNa1yEG4PeeCv9E8rypx mPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780860663; x=1781465463; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Js68PLPyN3XjWqEU0fIOqcPtf+mTXJxmFseuifo/CDY=; b=eMMjmYeJrmH66UD5M+oZgmCiLn4PW8LQMPeLoB775LkI84ep+0DlcWvygYPxuiBUwI 2e58DCDvJ83t+plveioyUkek8w+Mazwntn4kIXkz4JZq3GpqP9xPvtw2PH9xhZqG0MCK 7LlGkWR2kcrASrN5DlEdOdDY0sZmmKJCdyveuTnydDlrvWluxTTS5JmEFzOMfsUR17tg BSpGxYAkH32TvqavbhLXIJLWUtA/I43NDFRYajuMDaNf00pu2o9/t2LVM0yQ3fMhR14O 8Oudtx15pSx6ZHkWCU8uBWjzXJ/7kG1bYimBmtO2d+agOLSA3ns8nmFDTmFPgOhJ2O2z HluQ== X-Forwarded-Encrypted: i=1; AFNElJ/JaR2D2e681UYVsNx9eFXM+yJbgyWBNcacPclVRbte824ciTJx4oWMWoVGHjJjwgkCst6QDpAaFp5lnwc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywnl4zJLTYSCSqaq5uJncWAq7ueXHXekBl7KfnaJoBr3tU9avWp JyVlxuD0j1/sWzEHMkjZ6MUjvNt8HcFKLkrnp8xjQi3BEXYJfGLdX2B8 X-Gm-Gg: Acq92OH0ZFb2+qi1yIHhBAXE25/L3f5UO326jklWS+Xoj9sJ4sgjeyXK9cLsXM/7gx5 k58kXPmyss1BqXtd8XV3Sd+LwmNjxkTl8zCSyiS9tpFzoh2Ut9WKe0JfglQnEGTw5cWRYs2bUak 0a0ZBoJjVOMfAbE5rqUMbGysv2LRz1WVVEdF/nVx3idBN95J1pqc4OE9jwnNGZAFVXzmCoFoazn 143AfGrxnGs6g4WvwBR/hvnbrJtoOChuKN69nD6tCBi3wtth58V3r+J9oorKM0Mmj/9QAOr4haM RUvc8ZVhRXT3O0fZExlyMqV6/tT1uKQke9+9v+gTa/gxO3Re6hKIHUGgjgpsUxV6hPTXXOdAWVs V2/r0D6MoiugNoja6NVMpDGK6VXPgSFW7rWgFT/Cz1UbwXgNnrN9Mq3VfAS6DBCG9nLzobdq29X 3EvJsACHvw1VfZUX1YSYMXOFFhX+4k8YuGCLoZMMLYenxgPBGJA2stPEer7rLQG/EQbBOQfItv X-Received: by 2002:a17:902:c94c:b0:2c2:33a4:aa8f with SMTP id d9443c01a7336-2c233a4ade9mr63422735ad.13.1780860662802; Sun, 07 Jun 2026 12:31:02 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16629d55esm157971855ad.63.2026.06.07.12.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 12:31:02 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: Wells Lu Cc: Andrew Lunn , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , stable@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH net] net: ethernet: sunplus: spl2sw: fix phy_node refcount leak in remove Date: Mon, 8 Jun 2026 01:00:29 +0530 Message-Id: <20260607193029.589736-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mac->phy_node is acquired via of_parse_phandle() in spl2sw_probe() and stored in the mac private data, transferring ownership of the device_node reference to mac. On driver removal, spl2sw_phy_remove() disconnects the PHY but never drops that reference, so each probe-then-remove cycle leaks one of_node refcount per port permanently. Drop the reference after phy_disconnect(). While at it, remove the redundant inner "if (ndev)" check; comm->ndev[i] was just verified non-NULL on the line above. Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021") Cc: stable@vger.kernel.org Signed-off-by: Shitalkumar Gandhi --- drivers/net/ethernet/sunplus/spl2sw_phy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/sunplus/spl2sw_phy.c b/drivers/net/ethern= et/sunplus/spl2sw_phy.c index 6f899e48f51d..a4889c52e00e 100644 --- a/drivers/net/ethernet/sunplus/spl2sw_phy.c +++ b/drivers/net/ethernet/sunplus/spl2sw_phy.c @@ -79,12 +79,14 @@ int spl2sw_phy_connect(struct spl2sw_common *comm) void spl2sw_phy_remove(struct spl2sw_common *comm) { struct net_device *ndev; + struct spl2sw_mac *mac; int i; =20 for (i =3D 0; i < MAX_NETDEV_NUM; i++) if (comm->ndev[i]) { ndev =3D comm->ndev[i]; - if (ndev) - phy_disconnect(ndev->phydev); + mac =3D netdev_priv(ndev); + phy_disconnect(ndev->phydev); + of_node_put(mac->phy_node); } } --=20 2.25.1