From nobody Mon Jun 8 04:20:18 2026 Received: from mail-dl1-f66.google.com (mail-dl1-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A07C2E7370 for ; Sun, 7 Jun 2026 16:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780849891; cv=none; b=bE564ktu9eynF2RDdcnJqLqgs3R7M8WhB7nNyHvAP40zh+Tf9YnBuuJ1uYtqIsEPrDJOmzYgEYRFN1UdtIpinKLxZtmg2dSDaQAjTx7/qrUJji6ylH0SZDOaOZzRN2N55viyxiqfmyMW/ZJLSjSJ32LIsUbqvRGWEz26b6OZ/Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780849891; c=relaxed/simple; bh=wimcoFeduwwwS/y+4oRKJmv0H4adw0OCIARl89GeYC4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=bMJb+URr+oBsagJ+DTJ2VA79DQAHi2VE1YryfVJ746eDUFwxmkMaD6U7BxZpsZxluV1pzYtUknrJoQfXm9nv0BTgzy7pcBSVFrECSC/AZWiwDu9Ss6Er6Yrr51gC9enFxsrWzD6rT7TcxbfsOo4v/BgRJWuwK+tM+NlZEsE4AUo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C8gnJ/pW; arc=none smtp.client-ip=74.125.82.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C8gnJ/pW" Received: by mail-dl1-f66.google.com with SMTP id a92af1059eb24-137335bc3caso4184588c88.0 for ; Sun, 07 Jun 2026 09:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780849889; x=1781454689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=99zC0kq72jgYAVQdZ1ccwSMj89YTa/EzOnilbO1qrX8=; b=C8gnJ/pWnqBeRkGUey20uoujuXcanRcSe5gq18RVuAUQnHeZqzNAymcSkh56Mluvcd jyXwxyv8M4FdKzF/T6imbzlKPH9woeGXxONKgNFi62lnjOuzQlpwmAk6A2ACkLGsF9xl 8CDRhoVo+8Jb4H4YClNI7FWqzPRa/Hj/7cbMcmfXlNC6Da4Syh8lWzY7UNWBynrdjbAn J32e/oJRp2SAIzDGwW1Z062c3lc6TtUzkbqlEBY3xsGAe0Rf+XWCYjA2v0GhpzYKymCu GzGBzjvLYQ2fXHRc5bUuxQASPnOIq8hxMz1lKICr+qaCrBrYByVg+cFJDLICK20obz/V Wepw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780849889; x=1781454689; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=99zC0kq72jgYAVQdZ1ccwSMj89YTa/EzOnilbO1qrX8=; b=mgaX2ftHUeQxNJmi2JzUMMsP+0eJSVY4TkyVZD1j2d28wGfBmOU9LdKuZiCyjVzxok daAvzxD6qIV9M1TyBo0WLt/U8YiuMSGG/EiaWVzxh+CxmOlWzi0DXDXRRMOv+CmiasN2 luhYMT1aNBYB4z/xQlKvZ/GKjV+ZTqMugEAw8RVK6dTpBX8XLRRyRKpY2la9vBRf+dyA r/+op60gvsUhTr5vgr/Dkbtnr06IhqZ+Ij6xyZUMAi1y2H9V/gIMTWHqcY2CtwIiyjbh bqGn5BBNXWv3MbXd3ErPBPlzz4nuz00K6qVRHSvYvE3NQGSTx/Sg1jUStw+bfgEIgn4L x6IQ== X-Forwarded-Encrypted: i=1; AFNElJ9IbZdVzFpLnbZMkH1vsWPiHdMpH2Uq++vmL1gSXE9j9UiMgJ0OF748G/XLk8lLE4O50+RIG20oev4Dm5g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8yK9bSeFRWBdH/f8tXRvujvpB/hZpIvLPJk16nUyrR2U+ELyH ngADaEA0AX/n/7tJ7qYgaDQXaQq0O0pxuVK2bkbAVz+QTpPGNP80voTI X-Gm-Gg: Acq92OHbYXuu1g7B59bzaH4tWRKjAUfLU4NzrK4ltutSOBsbFkWg3xDamgbx3nsP9uM rLTtS0bjlZYcLTWp1i/s8b4zTwydjix+9PFtZdNBs0wxm3OgJX5mlWt0AmOX/L5ktMu4fLLb/FZ UULkqheBG9L12MinITX5CvR8YQ5TFncHJ3pOwvJGFwGD34lui+8JrrqddqFLdk4IMzou/NGirgb vGzMqVIrf6voGW5YXga43TCK9UVctvEe18/5+NH9Ppd3OzRLtam6tQwM7PuVqefycgI/jl5a/+K lqUXk2sool5dClp/gcCv+Ro4jkGyWtzWJMgPrkxmZ39+2iSFNDa2+mZAbxI4/WaLtGiSEFqwIpd 7+ETm5ymP7FctISDMF1AgSqr5x6oBnto28Vx/WBz8gf2U97kmhs2kpeX09xeZyCkqJM+ttnLWtc frFMXRkTTaSQAj8enAZf3h+hBmZHkcu30/YE0ohGZdTVC5jdWjYQLTqE1StM7SXVyoRg== X-Received: by 2002:a05:7300:6d07:b0:304:df0e:9dba with SMTP id 5a478bee46e88-3077b79d271mr6580259eec.31.1780849889307; Sun, 07 Jun 2026 09:31:29 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30777ecf9e9sm8906108eec.28.2026.06.07.09.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 09:31:28 -0700 (PDT) From: Hungyu Lin To: okaya@kernel.org, vkoul@kernel.org Cc: Frank.Li@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] dmaengine: qcom: hidma: use sysfs_emit() in sysfs show callbacks Date: Sun, 7 Jun 2026 16:31:19 +0000 Message-Id: <20260607163119.78717-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace sprintf() and strlen() patterns in sysfs show callbacks with sysfs_emit(). sysfs_emit() is the preferred helper for formatting sysfs output and simplifies the implementation. Signed-off-by: Hungyu Lin Reviewed-by: Dmitry Baryshkov --- drivers/dma/qcom/hidma.c | 6 ++---- drivers/dma/qcom/hidma_mgmt_sys.c | 19 ++++++++----------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 5a8dca8db5ce..7a7f302a9699 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -624,12 +624,10 @@ static ssize_t hidma_show_values(struct device *dev, { struct hidma_dev *mdev =3D dev_get_drvdata(dev); =20 - buf[0] =3D 0; - if (strcmp(attr->attr.name, "chid") =3D=3D 0) - sprintf(buf, "%d\n", mdev->chidx); + return sysfs_emit(buf, "%d\n", mdev->chidx); =20 - return strlen(buf); + return 0; } =20 static inline void hidma_sysfs_uninit(struct hidma_dev *dev) diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgm= t_sys.c index 930eae0a6257..9672ef9ee8fc 100644 --- a/drivers/dma/qcom/hidma_mgmt_sys.c +++ b/drivers/dma/qcom/hidma_mgmt_sys.c @@ -102,15 +102,12 @@ static ssize_t show_values(struct device *dev, struct= device_attribute *attr, struct hidma_mgmt_dev *mdev =3D dev_get_drvdata(dev); unsigned int i; =20 - buf[0] =3D 0; - for (i =3D 0; i < ARRAY_SIZE(hidma_mgmt_files); i++) { - if (strcmp(attr->attr.name, hidma_mgmt_files[i].name) =3D=3D 0) { - sprintf(buf, "%d\n", hidma_mgmt_files[i].get(mdev)); - break; - } + if (strcmp(attr->attr.name, hidma_mgmt_files[i].name) =3D=3D 0) + return sysfs_emit(buf, "%d\n", + hidma_mgmt_files[i].get(mdev)); } - return strlen(buf); + return 0; } =20 static ssize_t set_values(struct device *dev, struct device_attribute *att= r, @@ -143,15 +140,15 @@ static ssize_t show_values_channel(struct kobject *ko= bj, struct hidma_chan_attr *chattr; struct hidma_mgmt_dev *mdev; =20 - buf[0] =3D 0; chattr =3D container_of(attr, struct hidma_chan_attr, attr); mdev =3D chattr->mdev; + if (strcmp(attr->attr.name, "priority") =3D=3D 0) - sprintf(buf, "%d\n", mdev->priority[chattr->index]); + return sysfs_emit(buf, "%d\n", mdev->priority[chattr->index]); else if (strcmp(attr->attr.name, "weight") =3D=3D 0) - sprintf(buf, "%d\n", mdev->weight[chattr->index]); + return sysfs_emit(buf, "%d\n", mdev->weight[chattr->index]); =20 - return strlen(buf); + return 0; } =20 static ssize_t set_values_channel(struct kobject *kobj, --=20 2.34.1