From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C813D2BEC43 for ; Sun, 7 Jun 2026 15:20:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845626; cv=none; b=EaT84ukdggfLwWX0tYZEZ1/2hZSxb6WI3zHzelqTo0gb7037n1j06UUnYs2bEIuCSW4WTZruBFbFHZ2VzO6dx+s0LE68IkP0bZ96+2TXHhfLii4cKMF+9sEpm7ZyEFIybbqgyHwL0sWC83aj2UPHmpxiN8/dhJH7AAfK41PRuHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845626; c=relaxed/simple; bh=pLPZ2qxy1mURLCfMx28oL72xNnXwdxw1jIyb7AYdfDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OCRCRvaSfyzdIhTMsCezyTMqedIu4HCouZ9qgsUNYxK5BBF7D28YRvyHypcSNZUY1MSZQHdWIQtLHV/3Et03GMjwDnX44Ba7cRLDmYRSgq3YeX4QAJOHNYd7q97AM2SvyMGZ+5+wdYp7Kr46gkr1fjurx3PWVCXByrwS1eSwXRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MaRCew9x; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MaRCew9x" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36dac5d5da0so1696753a91.2 for ; Sun, 07 Jun 2026 08:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845623; x=1781450423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1b+y0Qup+M/gjFnTORp7fBeyfCCPksUKAUMCQ266z2E=; b=MaRCew9x9QEwP2MF1sFigm2EpG3SNCiwiJRazVMdh4ORIje5o0CKvrx4VZQ4Z6pAs1 Gwwq/TjEt9BMiPAsQEMyujRDi/sGDtKCs7t5OYykaaeGaQHH9UWEbK1e9Wfh7Dy21zVW AEUsHoMx3Fivn2duMFmHv2r1/DGZqAe73jkOi9iR4tS+Ou6RKrs1vfAkFMPF11o/LDw5 kNRdTJFQ/BoZ3xPVnN+MyEdMQPpu7Zc5MDZjNRMik+CPPTJlB8vixNA7BmNxnz1xOfio qs7Fj6zmWU+OnMT5kkegCRUDjoERPsR4YQvI3O5SpsreyashVzlqtqdAMh0bngvCbLSf Otyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845623; x=1781450423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1b+y0Qup+M/gjFnTORp7fBeyfCCPksUKAUMCQ266z2E=; b=r1+0lSIOF0BTmsMkv9IhyZhNTm+c54qNmigKmrzpyvEH05nqUnEL94ytbSppnSWopM hlGnp4uOdr43uLQzTu2Kq/SO8I8bZRY0EQE39EjzqV6xcgRAVT6R5xR4o+JScjOm/Q69 8YbH/kLP5nI3EN8mVLXA1mCWKgaCAKG0TB1/wMXk+QTj9XwxgV/DF27sWfWM/up9F5gm F4E3ELoS9cDnLH1HyyKb1+T+74kh+oviWc/Blsm/9q6yJG21QmXsnhkr+y3CRq3UUbIu jiDo68cCijDP2LwMng8tlJvpTCsbDerx4fPOg6Y4uk2s+A91ORKqMUdk3qJqbHnA8xM6 X7hw== X-Gm-Message-State: AOJu0YyoR1pxADrYzGP92Lc8gSkK4SW+FVenMVu7PEspcV+bBk9r4c5j Cf2zO0500OcIkvmrhoiT486ykTJj2nSnu1snwWiVJXFRArXN/N+O462+tqnBIGFVemU= X-Gm-Gg: Acq92OEzgf3RFBggG8d8dvpPZlV69Iwb+oKrhBvGxevVjTXo/rgNSHsby3jzXA79KjU N6rdFTR6IKXb+gGyj87gAyaWgZblIgAIGmA1xERE102w7oL8vZ4W+G8kGkJtGCirtjhjhWl6pmk ODgJuAPhVEzkjHaLLMBKOSypk9yc8R1BVV95gBd5NoYK8JOYlTk1G/yPhAU8bfd24aWu41NKyxk K99SyPMaRZomStnXWND6E1SwMlGo4qlGBIoJiNkKHWfVMBslHfBI8pJUyNAaBEi1ojg2reeff68 cYBAqhmJaxk/8be+p9ER+NsEdFTc26Wigc31udk5Y79GbOYM2vmk8OJbkU9i5N33+XUItfdj3pG 8aUyELvG6yeyIARBtcfuMo4TW/VRAxP8FBui+r545hXow4TVhjCQgISTiiL+yUC2ItYE3RA6wsP WOx4k+Ihi1e845qZyH5hEPLcq/bbRZSoliZo0yJdrO6UUfElDFeg== X-Received: by 2002:a17:90a:d643:b0:36b:b4a1:2939 with SMTP id 98e67ed59e1d1-370efda7ab1mr14545460a91.15.1780845622994; Sun, 07 Jun 2026 08:20:22 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:22 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan , Krzysztof Kozlowski Subject: [PATCH v8 1/6] dt-bindings: leds: issi,is31fl32xx: convert the binding to yaml Date: Sun, 7 Jun 2026 23:19:57 +0800 Message-ID: <20260607152002.446617-2-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert leds-is31fl32xx to DT schema format. Co-developed-by: Lucca Fachinetti Signed-off-by: Lucca Fachinetti Co-developed-by: Pawel Zalewski Signed-off-by: Pawel Zalewski Signed-off-by: Jun Yan Reviewed-by: Krzysztof Kozlowski --- .../bindings/leds/issi,is31fl32xx.yaml | 151 ++++++++++++++++++ .../bindings/leds/leds-is31fl32xx.txt | 53 ------ 2 files changed, 151 insertions(+), 53 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl32xx.= yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl32xx.= txt diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml new file mode 100644 index 000000000000..81f1e30e493d --- /dev/null +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -0,0 +1,151 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/issi,is31fl32xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: IS31FL32xx and Si-En SN32xx LED controller + +maintainers: + - Lucca Fachinetti + - Pavel Machek + - Jun Yan + +description: | + The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple + constant-current channels, each with independent 256-level PWM control. + Each LED is represented as a sub-node of the device. + + For more product information please see the links below: + https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf + +properties: + compatible: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + +patternProperties: + "^led@([1-9a-f]|1[0-9a-f]|2[0-4])$": + type: object + $ref: common.yaml# + unevaluatedProperties: false + + properties: + reg: + description: + LED channel number (1..N) + minimum: 1 + maximum: 36 + + required: + - reg + +allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3293 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 3 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - si-en,sn3216 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 16 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3218 + - si-en,sn3218 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 18 + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3235 + then: + patternProperties: + "^led@": + properties: + reg: + maximum: 28 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + led-controller@3c { + compatible =3D "issi,is31fl3236"; + reg =3D <0x3c>; + #address-cells =3D <1>; + #size-cells =3D <0>; + + led@1 { + reg =3D <1>; + color =3D ; + function =3D LED_FUNCTION_STATUS; + }; + + led@5 { + reg =3D <5>; + color =3D ; + function =3D LED_FUNCTION_POWER; + linux,default-trigger =3D "default-on"; + }; + }; + }; +... + diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt b/D= ocumentation/devicetree/bindings/leds/leds-is31fl32xx.txt deleted file mode 100644 index 7082ed186dd9..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt +++ /dev/null @@ -1,53 +0,0 @@ -Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers - -The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple -constant-current channels, each with independent 256-level PWM control. -Each LED is represented as a sub-node of the device. - -Required properties: -- compatible: one of - issi,is31fl3236 - issi,is31fl3235 - issi,is31fl3218 - issi,is31fl3216 - issi,is31fl3293 - si-en,sn3218 - si-en,sn3216 -- reg: I2C slave address -- address-cells : must be 1 -- size-cells : must be 0 - -LED sub-node properties: -- reg : LED channel number (1..N) -- label : (optional) - see Documentation/devicetree/bindings/leds/common.txt -- linux,default-trigger : (optional) - see Documentation/devicetree/bindings/leds/common.txt - - -Example: - -is31fl3236: led-controller@3c { - compatible =3D "issi,is31fl3236"; - reg =3D <0x3c>; - #address-cells =3D <1>; - #size-cells =3D <0>; - - led@1 { - reg =3D <1>; - label =3D "EB:blue:usr0"; - }; - led@2 { - reg =3D <2>; - label =3D "EB:blue:usr1"; - }; - ... - led@36 { - reg =3D <36>; - label =3D "EB:blue:usr35"; - }; -}; - -For more product information please see the links below: -http://www.issi.com/US/product-analog-fxled-driver.shtml -http://www.si-en.com/product.asp?parentid=3D890 --=20 2.54.0 From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9423A2D12EC for ; Sun, 7 Jun 2026 15:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845628; cv=none; b=WQpYINeHNa9cOdhUKWhmR3Xnh/HuUAZHKDjUrCG4bhrfkC/SUOxu5pReLe/byg33bKwVdm8RK5aK70nU3fAkBOIAvRBE9vXZNwJsuBsJLg0XoA3ylEY0jJ8Ct6RlZA3APdv4eCceEkB3t/wuv8I+JTehYpYZqqvuS9urWoaGQBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845628; c=relaxed/simple; bh=tqRyoaZBs1tvjQrY9z9TFd/uxGf92frpQLPL1VyfqU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a+s7nVmyNMtUE3q7SB0ZLdMx1FQ7oDMxNwOKJ6HrBekX73D3nwo3yF1q2ju+O/KCdnl4bEgwWJo0+z+tF0cg8sUPBOFIiGhxCp73AQwgG1x6p2tG26nH1RqVsxmXCEdY86b2sXC0i0JSD8j9MyYJmUSRZw7oAV1sPuWdDKnnH64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hyqp46Oq; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hyqp46Oq" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-36b9b15af73so3070796a91.0 for ; Sun, 07 Jun 2026 08:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845627; x=1781450427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qC2QIpvU6HmG8jsTK89YMedFfyyJiHf9gc9ctAYYQYk=; b=Hyqp46Oq8KWqJXrSwPUWUb3qxVpg3GcXChKeASFd/c4MoO/YA2KVjGhmXIXsugneVT 2V8IN9ZhUAAnMAGWn2/hd1TWIxww2nW9e9uwMgrCegtOmKVudokQ2MdfLPcjFqO23wrX 1wU1qo7up56vqjcrs48TUFnC6zAabKWNL6a9o3bhs9Y5FQPdHE7arH4l2usUvqbFZIYM DNfk0PMiAx14aAYk0HN/VvI8fFxUHX/PLn9I+Pd0oygrJX4dCfgKD/JQNdezv1CHXfWl JDS16dtqzzV6u7bKMBJrg4DAY0EPNHvEHb0eV2HMi4UlmoGkOqYtKpuuWCmGg1EgzdNc lxEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845627; x=1781450427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qC2QIpvU6HmG8jsTK89YMedFfyyJiHf9gc9ctAYYQYk=; b=jxfoA1h/Rw9CM3h1vxzBWw2XouQMe7/HhKhn14SnmwUODq3wPE9sqY6Ihvao7dcqZt A3B38m5bSXKQbt1PkW2Y7f2KK1YF822PDThplwtkmEkdKLHZ5uKMXtbi2hF1owzjoj95 2n6I+TwsOj0Ux7Q0cRYPvUP1QRtLN04jjilIxFfxoC+WV7+wJd5q0BlnUda8aSwDVkEe PfkCT6eWhQK7sMdWWD/7OEMGgND5jRUBz8yuD8RFcjPx2Gs4lxyd4X2QMGkXa+sPPT/Y JQHROtO5K2O6P3Qt2WoeOx0fuI90YUGBdATqvT6ZUMvkvVKMOpFW0ota8d7se0N1uKSY P8Pg== X-Gm-Message-State: AOJu0YwPe2lOVcJptldzQgkT2n8+BiirAo1HABFiXyRlAHwXo3MQ5Fi+ Zz+bTo5xMLuPGEEq6n9eDGFNy38+QXkN/O307nPvs5yhJbDimDNpR1XeOnLIjH1ilMg= X-Gm-Gg: Acq92OHgFCpG+SeoLZ820jbWGhOgySqx6fJxG/5SHkEpjl1wCg+0iSJnmGEYPcnxaVV zYpHpS5QvdxX5iYdXvjNUJVr3vVjIHsprTLNcAfxKR3yFr+cEw26jO4Hw+hQunYP9dzwhQgsQCa zXccSV4SWqQOqPLePuIaH2+ozv/Cvzi2F3fIAIS8J+2tMDWC0ZfrIscRpvpS/lBrYMEgo240Apf 0kFxUOuXo1vXxQ2AK4Mw2mc1sqtgG2xf7ojKt+4/ca8cV2bEP4yCSjVbsadlUNHQ7Ph0ROS9oTa ZO/ivHsmjC/8AXXXgAOrhbPg1nHW4ht/RrLxM0hS7cSEhf+ETtJlj9CGMso4j/EbTNtxkHeFIYY NT5ukBoDi5dTGJK2WmGuE0cKVoFhFGGL8rsnTLhTpOetuViT5OqyYfzavlbsd2mZF+natwOzcTM f/M1RgZMW9kACfgr1IiiImejvcriBli2tlH348QkbLlWEkb2p2YcmDvnKezHUQ X-Received: by 2002:a17:90b:58e7:b0:36b:936e:73c8 with SMTP id 98e67ed59e1d1-370f0e4ad33mr14187674a91.19.1780845626785; Sun, 07 Jun 2026 08:20:26 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:26 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 2/6] dt-bindings: leds: issi,is31fl32xx: add support for is31fl3236a Date: Sun, 7 Jun 2026 23:19:58 +0800 Message-ID: <20260607152002.446617-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add an additional and optional control property for setting the output PWM frequency to 22kHz that exists on is31fl3236a. The default is 3kHz and this option puts the operational frequency outside of the audible range. Co-developed-by: Pawel Zalewski Signed-off-by: Pawel Zalewski Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../bindings/leds/issi,is31fl32xx.yaml | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml index 81f1e30e493d..5f22d8b77edd 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -21,6 +21,7 @@ description: | https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf + https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf https://www.lumissil.com/assets/pdf/core/IS31FL3293_DS.pdf =20 properties: @@ -30,6 +31,7 @@ properties: - issi,is31fl3218 - issi,is31fl3235 - issi,is31fl3236 + - issi,is31fl3236a - issi,is31fl3293 - si-en,sn3216 - si-en,sn3218 @@ -37,6 +39,12 @@ properties: reg: maxItems: 1 =20 + issi,22khz-pwm: + type: boolean + description: + When present, the chip's PWM will operate at ~22kHz as opposed + to ~3kHz to move the operating frequency out of the audible range. + "#address-cells": const: 1 =20 @@ -60,6 +68,22 @@ patternProperties: - reg =20 allOf: + - if: + properties: + compatible: + contains: + enum: + - issi,is31fl3216 + - issi,is31fl3218 + - issi,is31fl3235 + - issi,is31fl3236 + - issi,is31fl3293 + - si-en,sn3216 + - si-en,sn3218 + then: + properties: + issi,22khz-pwm: false + - if: properties: compatible: --=20 2.54.0 From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 481242C3248 for ; Sun, 7 Jun 2026 15:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845632; cv=none; b=Zajetkkq64YpKYbaY8zlutbcuJBVx82yCsuAzEdcWU2FUfHCEoXlQn9PoJxJ3wo/TQUI1Ht7ALb/koXwsd0j87F6Srab89EMDcdpE4BVTgTGzVk4qCY4oHTK/kvdyd/Ez6Q2tfL5T7R+pz6HYF3utq5jswIcFgYp11d+cqmHCL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845632; c=relaxed/simple; bh=K+tQdEa1w/oGtmN7/A0Fdc7GiMO7t+lg3h7hsUuhzkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HKFdaXEMABdt55uhFmQ1/Ss4kNVgtmLHmo1jRgaoV8UqjoBMtnK7ObUeVgTLSvBCz3qq6kopbSZbGlbXe/vuKfz4HoC/LOK1QY6Hejg/jpnFB/x60mv/osSwrhht8aDRsOVdIWLLA66gvsrHBobCnMaojhrQp7CsSPrrgh8g8oQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bxd7i88c; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bxd7i88c" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-36da151a152so2427366a91.1 for ; Sun, 07 Jun 2026 08:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845630; x=1781450430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XGxu9nJ7AW3a2oAYSUYkb6lYeXmMA2jA36FeW8nwHiA=; b=Bxd7i88c2CuuGqkXvIumVvqwG0E2RP7RTno4ndAQi/XYrJzVPB+if8cX6xVEjZcW33 zE3b/tToUCwbtY0xOza+LHiHHtgOFCWb8PKn6Y4xc6Y580Hy59YBe/k/e/xwH5iLOkxp wRxFiKio41aoXHHrtVsEnLbjU2eEWhyzNQ2Neu6BPmmxY/XwW3fwg+fTjIqpsQBPvE2C RraatU6jbJjlo6xjaIOY919ZfbbiediUe13xwxy2N/2UoN/S54qqAluUvUyRr3DUYqY+ LiRtpNspSpTMw8/ozwP/syqRXo++cRW3IC9iWHMosT1ZIH6qpIx/olEFK6MlLvauHacE Ci6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845630; x=1781450430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XGxu9nJ7AW3a2oAYSUYkb6lYeXmMA2jA36FeW8nwHiA=; b=Zf9Nw/oROCbx7gP+Syel/ZA6uqgpJdYypnB9oFwa/vFLnQprLuF2Vc+Ud0GT+nTpl3 yjgkxWBpNdOxzE2lLzIiEU++wo98LHNcqdrB+0/v55bcjJ8TsGtSGGwLNOSyToV+2NP4 vQF4Xl4sFqSen+JZ8okrxma8CxKyFHHrx+dIpSpJUqs1DDEmBJewABRiyp7dHRKLI3/c g1AR3qvJA6jpuWhmaOMyleAko5CCmaN1EET6M3Ecm+pZ63lFH2uD0bG83W40kdK3j6dV aoYQC5pgMnGEOKwdL4HxlvdIn5nO5+Hc8tGZ7Zp/CutCNnF9YJ2QLGjJnqFLGA8vCAdz 6jvA== X-Gm-Message-State: AOJu0YzpXscYTUf1DBjWp9qKrQn6Szqyv9QDk+wDttIbmwIY4ssBusmQ llVW+qYOGyd81qQRNi0HBuiW8dw0/S8FHB2SY3kIsAlUe/zhShm8CItABFOb9E0WyZw= X-Gm-Gg: Acq92OHXApwelrS2yP20wQNNhEwRBkksEtoVMNgyG+WiWo0uu+AWz9GkQ8j0W8DuPhp a0nhwUqpvwei8h4jTaWgqpf0Hs1sywZpJlhTcXxzvooDSV6+XzCMX4Th8qL2S45thLX/R3ET0f7 p1vQUe+S338SgkYcGjq6fcz89zR1vnzsloMkqnCxqONft6rPkwOXLlenb8OL6wrA6q6avYO1GcC RcKdWGJafbOiRh8OYwXW3byE3QUQazu+MT2a8FmuSDqFKrof+YjYg1DXV7OZLhdFGeiSzik3IDJ jburWNcx9+dw+zeyaEIOIVTdM1LErqefMnlOKbW7T0biauc6xXLfuDktCQXbykNs60zxoGkeOAY lHeB1AZ9/aBFMWrSvgNu6SBjjqUFYXP5ygmnxNyAJ9vOq+MWwUTlKSy8UQb3XYQEtyuNEJaPtdE qn0HyrRqhh0rHMgSmZ1Bezg9kaRYwA60mqL7T6Ife9adgbGaEDsw== X-Received: by 2002:a17:90b:4b04:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-370ee5444e7mr12488010a91.2.1780845630473; Sun, 07 Jun 2026 08:20:30 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:29 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 3/6] dt-bindings: leds: issi,is31fl32xx: Add powerdown-gpios property Date: Sun, 7 Jun 2026 23:19:59 +0800 Message-ID: <20260607152002.446617-4-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Add powerdown-gpios property to describe the GPIO connected to the SDB pin of IS31FL32XX series LED controllers. Signed-off-by: Jun Yan Reviewed-by: Rob Herring (Arm) --- .../devicetree/bindings/leds/issi,is31fl32xx.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml b/= Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml index 5f22d8b77edd..f33c8305e464 100644 --- a/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml +++ b/Documentation/devicetree/bindings/leds/issi,is31fl32xx.yaml @@ -45,6 +45,15 @@ properties: When present, the chip's PWM will operate at ~22kHz as opposed to ~3kHz to move the operating frequency out of the audible range. =20 + powerdown-gpios: + maxItems: 1 + description: + GPIO connected to the chip's SDB pin. + Driving this GPIO low places the chip into hardware shutdown mode + for power saving. All register contents are preserved and registers + are not reset during shutdown. The chip exits hardware shutdown mode + when the SDB pin is pulled high. + "#address-cells": const: 1 =20 @@ -145,6 +154,7 @@ additionalProperties: false =20 examples: - | + #include #include =20 i2c { @@ -157,6 +167,8 @@ examples: #address-cells =3D <1>; #size-cells =3D <0>; =20 + powerdown-gpios =3D <&gpio0 11 GPIO_ACTIVE_LOW>; + led@1 { reg =3D <1>; color =3D ; --=20 2.54.0 From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E51F72D29C7 for ; Sun, 7 Jun 2026 15:20:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845636; cv=none; b=DEThRy+fxYZ6pTGya+Hpl7vxzc8MMnf9DtMGnhcNIwc/MGfrWY957jPJoWbl1w480AZX1Nebjcgn2sx8SW9G9Gowi4uxTI2JfJgkZcOy38S+Ts4lW7/Dn//uw+ngqqAvZi5cYlAwISzEvwCwx4gE6pDzMqoHCMTlhYlXAuvvK/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845636; c=relaxed/simple; bh=e/H4yzSTRx9v1FO/nY2xDM9IAIIvMAnlcw/dCWJpsew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kc4k3VCRULSj9as46G7LIXPl7k/BeIbnS3pOMboKrVbGz4g+m6j9zjVYPcyii7iC37Q2cuH+MNznulpIa9s723P89tl2Jd1F5lMMB8NP0iKKBByUgocNpeS35OjWczsYGL+nz3CRUE4sTazJU9LTaMGMFMuRUUwqQhF4/uhSEmA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V9m3Kaak; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V9m3Kaak" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-36ba706ab46so2323377a91.1 for ; Sun, 07 Jun 2026 08:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845634; x=1781450434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r66DUruGKk6cGeKPaPeTjn7wW8sOwdyE3f6CXLHUbkU=; b=V9m3KaakBwuzCXKKTDhwblaFRzmkYYUm2AZ+bRBLeDlbduzVukpD9J9Ci2kk5yDj/I zZi7SQn98dWiBuFFeeXOIB4ZrigXUA7ljuzlA+5BgUdOd46TzNRMHNkIWvZ/+D6q0Ryl Zb3CVE5PCFk1EvmZPI5Xhxx14S4vA0IS37M0BIb0JBQPJSq9oM8qPnBvsq0JzcL+MRc5 DT79dSZPYVteBav44R33tOBM+JL+4DDfiYtZkzs+4g/VCZwdQb6aJa8WUJIyBBoQHyP2 PmhJTeHpdOMNCqlRFMZcUXCpEaMthbHElJErPWuMxSn2voSZAVQ4UXEU/UnzzhvxyKFB xXIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845634; x=1781450434; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r66DUruGKk6cGeKPaPeTjn7wW8sOwdyE3f6CXLHUbkU=; b=S/P1dxSWsO5mnQh60fIHL2tsTJTtLEhOc1hX9XwfGMbfZKPt0Jl7kVvl3C1VQzJa0N tgj4hcztWaEJvBfqt5S+1Rd0u1ja/coxrr+3eIGJ07U1+CvMYFsVFrpgx2Ez7TxK5/nr NFJddceY/1/N00ENv6yMvBs2EQx9kCAg4YQf8pi9NbPYq2bpVp1xqgT9Ntr7c+xIW4J4 PjNvaRMCXpvwkexJS/k/LAtwVPRrewgQmegaZn+UbfjBCNFGdjAiusvxobSkNfob77qv VB6qm/uF6U1iq/yeEUPSnzBjtihSNUEh9U7ZwaqwsID3eAVmCjLU26Bo8Cb8+wn+IHFe AqlQ== X-Gm-Message-State: AOJu0YzOGzeIE/Xl6HEqxedBA8pqtaDQ/O2UHW0lrEFFNZ11hEwTnbQV WaL+Nj8jegrc3hI5GuKdAB/MUFLoTPsTsH3KjyAmtywZcBc2Wjh63B2BQmc7cV4Nm5Q= X-Gm-Gg: Acq92OHx/0aJdupO/ViC6woFU6xweiNApa1O4uHwg2DB6WhnURW8d395Lt8iFpzuKaY OLXauMak/7YVd903ADK6kcr9fpNV68zkQg6Fx8pyYdCcNEW2h+aezadMvCLkPtTqe7X22vxqITz F57ZMOxLJcwIS6MYJsi4uPu1XF9DUgJ+2m1Or2vW7kIde81OgkScx05zv4sXXo1zqAPRR8myqvX UsyF5KtdDruIRR6NphHjcfcQHKTDDZpxdNF8na+UL/z+BDOudQ7vCqAOLGLbn6lkTe6xtaF/Snp uhB5LcxLbDRetN6+X0C131LxAAwrvdDZDGKcpQzpUjfAmC9Qw3y7fb6UuGEeWzgwW2MPackyrOi MNZDHkDs4lAPWyLkZRZo0S4RUc3b6VkOR8fBkBlhBSVcYpxlE3xRePLHqm1vqwq0IAV6HmV7UMO LV3SxbFmQgmZlEMhFKJgExds7y/PuMuda7o23aE0hdwsDLNJRRQQ== X-Received: by 2002:a17:90b:390e:b0:368:a297:bd3d with SMTP id 98e67ed59e1d1-370ee82f93cmr12620623a91.3.1780845634053; Sun, 07 Jun 2026 08:20:34 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:33 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 4/6] leds: is31fl32xx: Add powerdown pin for hardware shutdown mode Date: Sun, 7 Jun 2026 23:20:00 +0800 Message-ID: <20260607152002.446617-5-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IS31FL32XX series features an SDB shutdown pin. Driving it low (active low) places the chip into hardware shutdown mode for power saving, while all register contents are preserved and registers are not reset. Deassert/assert the pin accordingly during probe() and remove() to manage hardware shutdown mode. Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 6c8d6b833260..b34fcef2c173 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -10,6 +10,7 @@ */ =20 #include +#include #include #include #include @@ -60,6 +61,7 @@ struct is31fl32xx_led_data { struct is31fl32xx_priv { const struct is31fl32xx_chipdef *cdef; struct i2c_client *client; + struct gpio_desc *powerdown_gpio; unsigned int num_leds; struct is31fl32xx_led_data leds[]; }; @@ -421,6 +423,15 @@ static int is31fl32xx_parse_dt(struct device *dev, const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 + /* + * Driving this GPIO line low takes the chip out of shutdown, + * as it is flagged as GPIO_ACTIVE_LOW in provider (such as the device tr= ee). + */ + priv->powerdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", GPIOD_= OUT_LOW); + if (IS_ERR(priv->powerdown_gpio)) + return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), + "Failed to get 'powerdown' GPIO\n"); + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { =20 @@ -609,6 +620,9 @@ static void is31fl32xx_remove(struct i2c_client *client) if (ret) dev_err(&client->dev, "Failed to reset registers on removal (%pe)\n", ERR_PTR(ret)); + + if (priv->powerdown_gpio) + gpiod_set_value_cansleep(priv->powerdown_gpio, 1); } =20 /* --=20 2.54.0 From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D3162BEC27 for ; Sun, 7 Jun 2026 15:20:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845639; cv=none; b=QHtIZZqPEVk1AWM2wByMNu06yem4QseSRRVwObQ4nNV60Px9FJfRers1tDcwSJMSl3VoXKO6B6U7TZGG4ogRJvK61gPZGgf5fLf6JGOWkR0EzAuRQwulWdY2F5OtdmuAcPDhQYWxnsSekatXj2FnoSnUnkBp/VJbVnN6IC7luIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845639; c=relaxed/simple; bh=RUWoSSPMfAP/6bpsEyV8VEbxxYz0gmjyqX0rZdPDXnA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=umbBEwRNgI5oGzlqX1Ky0eGH4Gs3T7YJ8K51aLZmFTvGZZM5c0qeC01EACMnCcefnyuBkZlPy2QlqiqHxpaGbXSvGo9pQggHpBPGObkbP6zwF2hfxSQUzKatxN+HwoisqDSZkOQSnakQraj0IXffarpgjnYe/y0sso9UTHmr2Kc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7ymmgk8; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7ymmgk8" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-36d630c0e35so3496002a91.3 for ; Sun, 07 Jun 2026 08:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845638; x=1781450438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BmdAeJeF0AXVd87AP/9ds+dEzvwxxHLJKYbOYujemTQ=; b=Q7ymmgk8kcHzjX3b+X2dQAgikTh3tkbCNKXsLmaXqYlK7hZ5hpyBXnV0jPD6AkAbpr qpZon2bi8EIrk4bUANI4E19KXn41Ds0Ksw4ump+Pea1XV46EYd2PvkOUFd6vEfAV6Ivt mOX7Mw5bg5vJ4RKT6VBPcr0JqkiDlvmdIaVCGhcozjybJclT/MUdeW8wr84/O9vY2uq6 PH3JgoOa9tpew1cRUqS8vukiJaHiH9aij3PSry7LU594dQEkMTWW1CI+67+EDBm8mTbm EnIeOaZDxfBa33sihrGX/5Ik4HwV471L9vI2RF/lEJpmQpWXEh+x3wF8f0isVALsdTYI xSVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845638; x=1781450438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BmdAeJeF0AXVd87AP/9ds+dEzvwxxHLJKYbOYujemTQ=; b=evVzhUMXFhpch21xE5AsCnFc8wWOC/jmX9R+W/H8krVYsKyTLOaCRshAGHtPNr7fQQ DWN/eCkVkLHcXiOnYXR9427DlVxEIJqn9oKUV7wL/vZ8c0QDPVuunXst+yTF/5XHdm+d 1p6p3f7I5MCmUsLClwTlHfvwbricCKYdPBgMDaTl4nF6qfOzPfgJgYmvDRHSM9i1nnAq 4yiRTgHsgU4VIuSEHSby+WIuY19gajjzy80fZPtS4UbEBmgvJIY+j+LHaiXSxtZysnU8 KThE/p11dBUiYQvU9lLu/DI0/8qM7FJgVv5Whyyr9o3xeGCKecBzNpS5Po47uguPt9HN f4+A== X-Gm-Message-State: AOJu0YzsuFR56sADjoE9n8C1xD2m18TFmgT+Z72A2QwJ9xpvfea4tGeb NnZM4PyBZaO9NwTcEnElg6q9y0viTa1anJCs3OyyyxY02soihiMwXCMJyRZMsy7I6Ks= X-Gm-Gg: Acq92OEKwGiv0B4Rk2nJxIs/LxRJzjXJ4yCRmQ86hcQOaMBgBmmplqzUxJU5ounshVp OpemCZUS0hwadQuIHsogbgVvaowRAZhcO/N2xThaYzCeX0s/Re4Z3J32OOClRPjkIPXHx2q9sqm VuDwcQvcm3hJhOTUmNpFcadkQ/QtncwoHUFmfG7AQl2iOySSRjRyY/ss0ENl85RzM2ZEfdREkQa owI7S0jBnF3U2TfX3DjT8pYUWsYPFPe/n/ZZn1zm6xJFNVoRzQhCKOiiBFd7OrYs9JKUCWiTaFj xIAb1oG+ZhwIJ6yy/SHeEM1rX46vasZuk3KWlbNYJwBBXy/XNNOayHzJ1pu+Fl28JVKJ86OaYce /MO67VbO6pwwXttcjJohHnvmskOgFhFcnsNWc4S27/6QQBjU2IqlLr6ipmTnihnczoPKbbxRlci nyNXvJMBrWt5Rwa0B22qp+eqT9Ov7m5pz57KozivXADL5RUWUoUQ== X-Received: by 2002:a17:90b:1ccc:b0:369:932a:2b6d with SMTP id 98e67ed59e1d1-370ee344ce4mr13126921a91.6.1780845637686; Sun, 07 Jun 2026 08:20:37 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:37 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 5/6] leds: is31fl32xx: Fix missing brightness_steps for is31fl3236 Date: Sun, 7 Jun 2026 23:20:01 +0800 Message-ID: <20260607152002.446617-6-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing brightness_steps for is31fl3236 to fix brightness control. Fixes: a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index b34fcef2c173..cbda7edbfb48 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -492,6 +492,7 @@ static const struct is31fl32xx_chipdef is31fl3236_cdef = =3D { .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x26, .enable_bits_per_led_control_register =3D 1, + .brightness_steps =3D 256, }; =20 static const struct is31fl32xx_chipdef is31fl3236a_cdef =3D { --=20 2.54.0 From nobody Mon Jun 8 04:24:32 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386AD2D6E72 for ; Sun, 7 Jun 2026 15:20:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845645; cv=none; b=ZB11oIAfvhV15buVfj2mFD/ITXqf5gyXTWsC3eZp/7K4yo6cFCGmXTa5ie3fCfa99ORbuCXgSz0up+XJxS1B5wzlD7Y+QV7DabPArvEsiQqy3SNwjjq0L1m206g3vlelFjE6gpGQ3KdKlHPS2x/t5/PU+Y+Vtc9mmduxZEy5CZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780845645; c=relaxed/simple; bh=wBP0OSpgAxo0/pYTGNfYoRXG4ifPdWHIBzYCnZGGwag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9MDaGunDvq0cC0PDeTN5MICajfNWuOorv/JXUyFpGMZCHzVteBgs6fBF2Dk/dWgmhTW8jiYkCrRg3dk+ywa/mSwWCb/UZF0jfnuaaplJuwpjjY+HvamA1uhsG+le85cgi9VLOCHRB6e7jz7fjNWGF2DFJLbLUai89uH01vh1Sw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q1TqVbGv; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q1TqVbGv" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-36b9b15af73so3070902a91.0 for ; Sun, 07 Jun 2026 08:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780845641; x=1781450441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A1hc64Z/QAbKYaSOyZFcrmLRROVis1Ar462ZBj6enJU=; b=q1TqVbGv1ZMpvrXCjv866IQBMlZOruCRMm80J4ehBJd7WxWJpWx6jpEJDq2a5Omut7 hnqwznZQOOYRn/xy8OucunEsqAgRYi3x4MwL/3ATSx7hp/qg6dsJwYYnXEWDx9QHp9Hj JGa/l/OBsTxHSRoW1NQpyktI2yF8QIrYruRZEIXlAdMlF8EoIvFvKlALy8LJb3i+/sLC YwJQPotAwEhZmu+BdT6wTwJlv+Usl7RD7Z12wTgJIofnYHL2t1JHy9nxhGQFTRNMtrHl cqL+p3ISJidtR4kPG6NP8wp0V/QLO7eQa9jLZAKddwvgnE6dJwQ4SD88hVW+clZyuV7U v2UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780845641; x=1781450441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A1hc64Z/QAbKYaSOyZFcrmLRROVis1Ar462ZBj6enJU=; b=cfvTGkbbHSQZmROkqASNkEBwuGKhpqKPLafSOt03EiGC81vi/DYWt9fPVHWBQWW5W6 4uGJ6+RbLbpDLstWiNIiRIOEkbsdcgSp2fjCrOIL21LdtPezAqfFpLS4MuqnM6fuv4f8 g4JHTWU20ET/GflbEH58diRxqY+O4sr2DlF4kBWOuBmfsEsqcbFNcw9mXdpzGCWjEtBT Bn8duejHNn+nFqRbSWRYRQ4G2eVWult8CsA6lBZfFZmV/CRkIWAUGyLG5AHH4uy9AQpa NF+SzCIy4r8iaZp+smB/VCNaDGpIGxsLfX0/SKNe+20MFJzu6kV600ZIO98ORQLd5iPK U98Q== X-Gm-Message-State: AOJu0Yyq6WnhioOK+Lf3jIc+CAg/E9307eWGNJLjNnvaWh+fjZWHgn4W CuNNO6XGh16aXEvYMZ6ceEOuzZTxjMCXcmmJ/YFpayWW+I3thyqPDlJjI7XrC2U5UAY= X-Gm-Gg: Acq92OG1NVq/ylteDpK6vn2STBFB7Xk0wa5/7LzAfJom/Qq0+rr8WvBKDJqM5WvH4Ve MqQ0akL1n5bf3K2PmTE99eqa4ict6DIT8CAWxVhOBi2g/Aojr4bEUljTEyWFb/1eN04xE+HVbq/ op+WFCzZz/AwFLwd533bchCqyBlSoh3+O8/Hvl+JlbSp7f57WKRLtNypP/hhCW4XdDVXnRXe+Az zl7tlq8v/nN10u5O58rAtGVB9HgBJPZaY6bfJWq5wyjrYeiOagT1/2/Kjy12aNHaoDeHlwj6d7t Y7+S15ki+IRlY593N4KOLjlndC5A8Gy5KY78tcYDo43VgmqQwM4OtwSk+8Yp+vO2bFSHWNbektG MPIxkBN0+7urBrk4OD1IOhexj2w8vxfT0p8CN/KfKVEchAjudzcSOtVAXfII5i/Z/kmbmeH/4Ez DaxDB/wcUvYDe1ar5lnggOw3b/cSc+4UpWsnY4X6xN/4mcd8e93g== X-Received: by 2002:a17:90b:5109:b0:372:94b9:76d8 with SMTP id 98e67ed59e1d1-37294b97715mr5957208a91.6.1780845641361; Sun, 07 Jun 2026 08:20:41 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a54:e741:3a5a:3245:d3dc:4b5d]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37135861581sm4130659a91.2.2026.06.07.08.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 08:20:40 -0700 (PDT) From: Jun Yan To: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org Cc: lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, luccafachinetti@gmail.com, pzalewski@thegoodpenguin.co.uk, daniel@zonque.org, Jun Yan Subject: [PATCH v8 6/6] leds: is31fl32xx: Move pwm frequency setting to init_regs() Date: Sun, 7 Jun 2026 23:20:02 +0800 Message-ID: <20260607152002.446617-7-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260607152002.446617-1-jerrysteve1101@gmail.com> References: <20260607152002.446617-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") swapped the order of is31fl32xx_parse_dt() and is31fl32xx_init_regs(). This causes the PWM frequency configuration programmed in is31fl32xx_parse_dt() to be overwritten by the register reset operation performed in is31fl32xx_init_regs(). Move the PWM frequency setting logic from is31fl32xx_parse_dt() to is31fl32xx_init_regs() and separates device tree parsing from hardware initialization. Fixes: a18983b95a61 ("leds: is31f132xx: Add support for is31fl3293") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl32xx.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index cbda7edbfb48..b43879bffb06 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -63,6 +63,7 @@ struct is31fl32xx_priv { struct i2c_client *client; struct gpio_desc *powerdown_gpio; unsigned int num_leds; + bool pwm_22khz; struct is31fl32xx_led_data leds[]; }; =20 @@ -346,6 +347,13 @@ static int is31fl32xx_init_regs(struct is31fl32xx_priv= *priv) if (ret) return ret; =20 + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && priv= ->pwm_22khz) { + ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, + IS31FL32XX_PWM_FREQUENCY_22KHZ); + if (ret) + return ret; + } + /* * Set enable bit for all channels. * We will control state with PWM registers alone. @@ -420,7 +428,6 @@ static struct is31fl32xx_led_data *is31fl32xx_find_led_= data( static int is31fl32xx_parse_dt(struct device *dev, struct is31fl32xx_priv *priv) { - const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 /* @@ -432,17 +439,7 @@ static int is31fl32xx_parse_dt(struct device *dev, return dev_err_probe(dev, PTR_ERR(priv->powerdown_gpio), "Failed to get 'powerdown' GPIO\n"); =20 - if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && - of_property_read_bool(dev_of_node(dev), "issi,22khz-pwm")) { - - ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, - IS31FL32XX_PWM_FREQUENCY_22KHZ); - - if (ret) { - dev_err(dev, "Failed to write output PWM frequency register\n"); - return ret; - } - } + priv->pwm_22khz =3D of_property_read_bool(dev_of_node(dev), "issi,22khz-p= wm"); =20 for_each_available_child_of_node_scoped(dev_of_node(dev), child) { struct led_init_data init_data =3D {}; --=20 2.54.0