From nobody Mon Jun 8 04:14:52 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1990038A73C for ; Sun, 7 Jun 2026 11:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780830390; cv=none; b=cYFYU69IluGgLXdn9c9uEYMxyVdkgRRWDAtZtBuwfBmC9c3IHv5rzrYu1+6GqKvV84EqzTBl80Xdqzz0Y8BxVyCrae+a1Hnog1Z3/DKwxJE4X4AZMUzdb5DPwj2W9CqlrgcEvEbLACsrnZDSq5GY37DF+KtnTBZXbPjHbWUouxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780830390; c=relaxed/simple; bh=9n4iO9VgRTGZwsOkpr6hqey7LOXePB379ZbrIQuvA+s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Tp0uJEax1IBTuP2hpqXknlawNEg/K+hX/ojiySG/50RQD/JoWX0DuIpoaNhPdNLaFK48Ostg+uMOCdHS/c0Gg5A+BG0pmzyHQnrGrI81hjnt274ZytJd7U9Y9nkHyIglzv/WhSEpRNZl2EJw3lZPO3nGMAPz8taMpbvtCGJUxu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C3irkbsb; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C3irkbsb" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36b900f350fso3165630a91.0 for ; Sun, 07 Jun 2026 04:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780830388; x=1781435188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cSHKcQcPLYJJJW+spAIjHqERoe3xOlP4fC68/c2Zs+4=; b=C3irkbsbPHz8Wv97rhAowSLGtsJTV3I4qHnEsuf0FSms8YCy+YIm2G3CzLgWlNRhdk jF70sygzcRN6MkIxPs5NHzQmucjfe0YtJBOlGDWIMQ86BWcIz0lZjaEJbnw8lZbZWcn4 fF0KruxEoModhWc8ieW5LQEfWi2+nO42vmC6PKmvo1QqAoWJqeO1xinyqzF9QTHAgxLW ABavEYyVig/2ujkNfK19XFnAW6xf1qxTR5WzJlIH4eukR3UrGJamAsad9JwZJne7K/rM Jj2H0CShMmS/olCQ/DLrEkPncz8J2vTw7abgmBROhRSmIo3iEv9MFkBp6Z2cbzRuzFWo 7sfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780830388; x=1781435188; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cSHKcQcPLYJJJW+spAIjHqERoe3xOlP4fC68/c2Zs+4=; b=NxYc2THqbkoef19axEBk4m+8pWmZzwgGlGNlVksDmVgnqr019r3yTslqT0J1Ld1mjM lDaWs+hjNyeOK40xKtvXLKulD6NnQbZ4KgbLVz/VMFqe2B7ZQf3imzUCLY3I17iIxWkT EdGOgP509kXsOpW7acbqo47gKO5JNE8hmmKrDDyiLGnhZOkyshOOBmO1sbIrVqri22Pm NYw/yujnA38mnM8KIEPFy4DYifXtmiwh1ZcOq+259uIKMGxdYthgl7SlpHy+lnuUwQwO y2ffQusHzje/jrKxNA6wnotrYTLxmp6UjeIsUry6q7tgzuAjEnetcmMt7nu9cwoQRRiB BZSQ== X-Forwarded-Encrypted: i=1; AFNElJ//E1h73Ots8M2wuMpoV91gK16r4UQl3QRubQBLD7BYVBgFBDFdaWlU718Yk+pAQh5wKn4cCx7BxPaS1gw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm8cUsC7++wP4R21MbdtHby5mQBDLQKWP3xAEf2hp8zMSPdCwk EVGFjSKtAKhbO8BM8FRVhZdVQTZh0kepkU/cS1zfxtsj1y6TDIRIwJ5z X-Gm-Gg: Acq92OFBzn3sMmPktf8rUuJdgnfGYnewGZxUL0/GIlPu9w4enoXsjGDwFRMeQaO5Nho 8s3aW699fNl3gUVR1oK3xnfe/PiF/foj3thEX9rxP/9BzMmEzM9/zAuOtyu5y0hxxiWOvldjuGt 86NENzIbgaeQmavI8WnefkzwOAwvge1WwslO9ElYewPn8iDzNjL8aMRh6wvvX+aBxCg7Dixdd0C xCmggdSbM87ykXTuuVkqqcPDOUeeObwhEQgjgwTVFevpqJKcPilxl+VWmiVwmxNCOxhrMczXqOA w4cO7iLB52wI+1hNJVV7eR4OIZybZhT/ZotZr3ZEYupDPuquu/QIS3KugMvh9OM1oI8a3o2xE5Y 7nZBmd/EDTuTy4I5/eGMg+TphlmEnCRbJk1nkGiQL/U9PqYqorLOvJtsiwRK6sk+mSsGnp+wCWq CHJ+1b9KpYEXpuc0D+WHJxxv+lr1Tgo0V873Ej1uq3efOcNZNKO2jma6hkijnNg24dJmAIpbR+D QIh7qsUhxFKmAMDMs6GfDsTvRQqhWrmnb0UQaCdrZXPZdHdV6Mcg9WiS1WqC+QWonf8jrmZavPi LWpV4aZQetsUVQG64RQn+ZI= X-Received: by 2002:a17:90b:57c4:b0:36b:75:6387 with SMTP id 98e67ed59e1d1-370eea202f0mr11781488a91.8.1780830388267; Sun, 07 Jun 2026 04:06:28 -0700 (PDT) Received: from debian13.localdomain ([129.126.14.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f70a2892esm12357969a91.10.2026.06.07.04.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 04:06:27 -0700 (PDT) From: Adi Nata To: rafael@kernel.org Cc: linux-kernel-mentees@lists.linux.dev, Adi Nata , Pavel Machek , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] PM: hibernate: Fix kernel-doc comment for add_rtree_block() Date: Sun, 7 Jun 2026 19:05:55 +0800 Message-ID: <20260607110555.53248-1-adinata.softwareengineer@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel-doc comment for add_rtree_block() was missing @param descriptions for all four of its parameters (zone, gfp_mask, safe_needed, ca), causing build-time warnings (make W=3D1) kernel/power/snapshot.c:469: warning: Function parameter or member 'zone' not described in 'add_rtree_block' kernel/power/snapshot.c:469: warning: Function parameter or member 'gfp_mask' not described in 'add_rtree_block' kernel/power/snapshot.c:469: warning: Function parameter or member 'safe_needed' not described in 'add_rtree_block' kernel/power/snapshot.c:469: warning: Function parameter or member 'ca' not described in 'add_rtree_block' Add the missing @param tags, reusing the wording from the neighbouring alloc_rtree_node() for the shared parameters. Signed-off-by: Adi Nata --- kernel/power/snapshot.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index a564650734dc..cd582be86412 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -459,9 +459,13 @@ static struct rtree_node *alloc_rtree_node(gfp_t gfp_m= ask, int safe_needed, } =20 /** - * add_rtree_block - Add a new leave node to the radix tree. + * add_rtree_block - Add a new leaf node to the radix tree of a memory zon= e. + * @zone: The memory zone's radix tree bitmap to extend with a new leaf bl= ock. + * @gfp_mask: GFP mask for the allocation. + * @safe_needed: Get pages not used before hibernation (restore only) + * @ca: Pointer to a linked list of pages ("a chain") to allocate from * - * The leave nodes need to be allocated in order to keep the leaves + * The leaf nodes need to be allocated in order to keep the leaves * linked list in order. This is guaranteed by the zone->blocks * counter. */ --=20 2.47.3