From nobody Mon Jun 8 04:20:40 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2EC73876C3 for ; Sun, 7 Jun 2026 09:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780825893; cv=none; b=uOBDz9MUC38egTygjegHqhu1XUhq1Q77u+/jropvdX6mU/AAbSrcZ9EMW4Xs+QSS4UN6AuaQanSXDweb2RF0TFK/BOIAi9S1ixenSJ5XBSmZe/kwF4e/tfUQcGRCxOJAv6LnYOyKrUK8cgJfl9a3qXZc1nD/QMhnEg7q13/UTLY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780825893; c=relaxed/simple; bh=i1oCpfdFswALacqKWEmloOwuDuQecUWVE49heEfU014=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dMiC6bE0JUv/JiAA9cyZT+G9PEyJ7JjpUmxEaU0GPoNM4G9MXl/fnsldY2IVyDRx69Env88OZJwhTxVVMGM1agHpcuBE1s60lN8Kush7A9BpFptSngwhb9OXh5GB8H83oRDwswYjPoTX9metHXRmnxEs/nmdRUUvgSmGTfWxOyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Znyv3Hmq; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Znyv3Hmq" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-842338c18e0so2380748b3a.1 for ; Sun, 07 Jun 2026 02:51:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780825891; x=1781430691; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZZHHpy1q3ydpA2HSp+30PNQez/ja9FOTHakLXuwR4NM=; b=Znyv3HmqTjKyuCY+O3O6ouCk6TOtSkW8eiuXLoptskWS1NMZtNNC+m1kulYWGKz3pP DxzYGvqoCQ9jvFdNYpxK8+sGqWECqKGYgTcuT8a8ykh9Ssc3Cy6ZU9AMdIGD9rIO7+ZP WRCsOh366t3p6UDxhKVuTQnAknTAhVhmz9hV+CwqdjEoO2DWrCtrRuHpu2JnZLd9zYIH vVx1+TN7mASvd3zo43KVlQlGpActMTrbNYusgSXryePav56/eym0F80+CpqFAkWNJwzI tH3NP4qRFq39Kk31GXNxFZ3yYn35R886ybRURqRIruaEYbjdfv3lbxzEap6ialpbxYQs saAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780825891; x=1781430691; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZZHHpy1q3ydpA2HSp+30PNQez/ja9FOTHakLXuwR4NM=; b=N76XrfKrlpmSRV8YVyZm0xcECEqC/A49wuAbqlu7+LijjRale/4l+Y/mFZ11BwZy2t GTFXLLvaTI7yn3peiw23DAB7oXk+n1C+0xWOhAuTauv+PPcCrVKBXNRG/swUZJxv96mw uQkIsgpZoRic1Bf11HI1BUrcj7SK8OqOBlZKUJbitrUbyQ2FXItGEX4iLnZTIR43Xy/B rNTc1xKKu9ptujqKM/Of7hNys6KDwWJ6gyt73h1OJ8M08BtZ2DZzBYKpX5qnKyawIe9u 3mBfYlcncHqGJbnw7XTziD9BbxcyH2LpvH8zXPYG8nX+Ds6LIo7tnKXHa/5JYrGJI16y /Fxg== X-Forwarded-Encrypted: i=1; AFNElJ/q91B7stxicSS9ypHmV8zL06NqcEOKT/QY9NC7+V5fi+XIdJQUlHrp1kX9rPOh3QSO9Fk7cMlbFPX5bA8=@vger.kernel.org X-Gm-Message-State: AOJu0YzRuF9PKm/ZsNtrEHMl3UAFdtjmQCIc8uOTKSljVHaUazhCpWF8 cHTzIPNQbLsc8yFv7wSRpgtxqbEno1XS3agYGq9QRGBbf/gsTHDrUASP X-Gm-Gg: Acq92OFWZ83GDkBh+cOlf0lbbZ/iyQHeA/HbC0xvZhpuYTIb9HsKK1iF/pxGIioeqz2 EnsrvGu2CT8+H1VDgcfJhKBQ6n+3pD+43+uFIhp6Nh4fTdQVPclYwhH8UOrX3mey/ImJTJMNyMM Fsp2hW1k0b9wj3L2tOGy6uHrlvUu7pLL3m95ytEAUzEkD2L98Ezd+DeErlcYbqUi7gskHvM7pWP kkwksnB2rpZq9eYp/HngqaEftmJgLMhVbRh2MEw3od65phHsBsDzoK3oSld9GcEHQdnbnkDTxjN kl3eprPIZFVrz5MNVEVjxUESc/irvbzw/SwxNcrL+Dknz8GiDrgLBQ5TmTqvN+QAUnxQm2WcBgs fik4V+M4bmyVulUdGunPZtOsv/T6AqsZbGqy2i5kJ2uCsbEnVN955vXNyMNDfJ2UItxz5ZoaQHF r16/KUQbxVJCKdPuGt7awQVeFFfkeFXpb6uXiWgepNjr4GvyNQZifWWL6gQfMcDItB6aTKIHbKa JLO/5UJxlpqO8uEBa4KsBjZU2M= X-Received: by 2002:a05:6a00:9286:b0:842:4023:42c9 with SMTP id d2e1a72fcca58-842b0fc08c5mr11266234b3a.41.1780825891034; Sun, 07 Jun 2026 02:51:31 -0700 (PDT) Received: from nugod-NUC15CRHU5.tail9f095a.ts.net ([218.237.104.87]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282916b10sm14629670b3a.58.2026.06.07.02.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 02:51:30 -0700 (PDT) From: HyeongJun An To: Johan Hovold , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, HyeongJun An Subject: [PATCH] USB: serial: kl5kusb105: fix bulk-out buffer overflow Date: Sun, 7 Jun 2026 18:51:14 +0900 Message-ID: <20260607095114.9375-1-sammiee5311@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" klsi_105_prepare_write_buffer() is called by the generic write path with the bulk-out buffer and its size (bulk_out_size, 64 bytes). It stores a two-byte length header at the start of the buffer and copies the payload from the write fifo starting at buf + KLSI_HDR_LEN, but passes the full buffer size as the number of bytes to copy: count =3D kfifo_out_locked(&port->write_fifo, buf + KLSI_HDR_LEN, size, &port->lock); When the fifo holds at least size bytes, size bytes are copied starting two bytes into the size-byte buffer, writing KLSI_HDR_LEN bytes past its end. Copy at most size - KLSI_HDR_LEN bytes instead, leaving room for the header as safe_serial already does. Writing bulk_out_size or more bytes to the tty triggers a slab out-of-bounds write, observed with KASAN by emulating the device with dummy_hcd and raw-gadget: BUG: KASAN: slab-out-of-bounds in kfifo_copy_out+0x83/0xc0 Write of size 64 at addr ffff888112c62202 by task python3 kfifo_copy_out klsi_105_prepare_write_buffer [kl5kusb105] usb_serial_generic_write_start [usbserial] Allocated by task 139: usb_serial_probe [usbserial] The buggy address is located 2 bytes inside of allocated 64-byte region The out-of-bounds write no longer occurs with this change applied. Fixes: 60b3013cdaf3 ("USB: kl5usb105: reimplement using generic framework") Cc: stable@vger.kernel.org Signed-off-by: HyeongJun An --- drivers/usb/serial/kl5kusb105.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb10= 5.c index ed8531a64768..e72a0b45a707 100644 --- a/drivers/usb/serial/kl5kusb105.c +++ b/drivers/usb/serial/kl5kusb105.c @@ -330,8 +330,8 @@ static int klsi_105_prepare_write_buffer(struct usb_ser= ial_port *port, unsigned char *buf =3D dest; int count; =20 - count =3D kfifo_out_locked(&port->write_fifo, buf + KLSI_HDR_LEN, size, - &port->lock); + count =3D kfifo_out_locked(&port->write_fifo, buf + KLSI_HDR_LEN, + size - KLSI_HDR_LEN, &port->lock); put_unaligned_le16(count, buf); =20 return count + KLSI_HDR_LEN; --=20 2.43.0