From nobody Mon Jun 8 04:26:16 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E965930D3E5 for ; Sun, 7 Jun 2026 09:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780825303; cv=none; b=stCEkAgxDdGYZaq1ZpbTi1ZdlYq0dcRXvRSEhUbezNLF7B7aCtASBrqlX4n68MCDfVZjIwBq1j4qTCiuU2Y88jO8m506a7sMB8+3Yr7vRRweNzGgl2coYX0C4oIyET7GSR5gt2HDUhTTYfK9kM2NGPQp3g7dhPD7llrJMzV90uc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780825303; c=relaxed/simple; bh=QywTW40irK8IqwnvBK+h6/f+THk/pRFGPY/scGB2Nhs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CZ5Id1NNs02jumZgGtInzh6wi+acgjszoU62RK5MZM1s/tvapqCh4mD7GrkzeV0L5Bph7lYPo5cssuUPl3hWOODrgVFJnVK6DNZgNf2nDAky4ntiqqgvziRMR7ngtA9NKKI5jVALrsKG7FEWbPnLGABkRF1mQt1sTYTF76KeCRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk; spf=none smtp.mailfrom=tumelty.co.uk; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b=z4cqbgiO; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b="z4cqbgiO" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-490ae94a89eso27258035e9.1 for ; Sun, 07 Jun 2026 02:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tumelty-co-uk.20251104.gappssmtp.com; s=20251104; t=1780825300; x=1781430100; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YcUO2qlbLSpXDxVlPee2zV+Ws7mQqjUcC9V49A8g0m4=; b=z4cqbgiOiolDz6xoFJA/arxvztfq5oWkVVZZeYXP0QoxjUIa17SxeXH4UE14bfDoT9 AO+s7Ol4BIxZQtZ8x2GzniHLD33QYhNRytAqKpwpKAjCAonrmodBCBsMsNKlwswMHR08 FMc6YU9FIM/MQbobB3uOv9H57Q0ETlwVJrnMAzalpuNkSY6Mq9/0oG+uDQBinhyd9tFL 2i87ZbPpZS5UKibm2wy8rFE1XT8JKbEpe3ORXGLhUgBL+VNkPMOUyYu/ODYgv+FSwskw LVzr4SU52/p4nswj+k6ViO6971XLiJtTq7U4icubY+cLYdkeGkBbjyuYNJfGAIZvsZaz g9aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780825300; x=1781430100; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YcUO2qlbLSpXDxVlPee2zV+Ws7mQqjUcC9V49A8g0m4=; b=mDPqZ4TRLWrG6I0sBVYgpx0cBHUw/MMsd71GV7vKE9aHzM1cDBhlgPQKkONaGG7fJu xHvFkD5xk9v8qb6r944E3J13B0l2a2QyiXhTvpY+Q09XURBZkl1F1qxHMpDWmqzIz4y8 iDrcahcmuYc1InWH5uO1ZB8KLg28vBHm2gBFeFLZI6QpAh/S7bW0jVPGgDcLtUMa3XMu G4zphhJYfD/soon5TeLxK1WydUdVoFjFOhKvE4rokbHgqPN9hI7+bJ1V5kyWFyRSUj8/ oOyEnl/sJeqmcunnCgjplFkB+IgLOq2J3+e8/NRJGpOMHa0dLMsAhTrLZzy93kxKifNl oufg== X-Forwarded-Encrypted: i=1; AFNElJ+NQ4XOBDK4SYvSxFa5Pou3YwwrL4wfu4O+oy6bcmfBBibL2BGKpyXsnr0OzqSvaYpoGjW949Lm1HBmQTI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz17lYnz9XviciYokaJ/KneUE5jXQBmBYBKMFW7DaoJXs+3qUc8 7HlTpfa9utPYQRzBXN4duhJM6rkeHWxGYNZaOKXUxsPXLpXzkwyf251ulPh8NqwalgQ= X-Gm-Gg: Acq92OHx5TAYZfrOG1V+TDUh2TEpgIRykXycdd7i9lZz5lIxR6RexjOoblOg8d8U9mX vkpXP5sSa6ERFzZmpb2W1Da2px9vHiEeDrvDuv6CcHNvHKBXGL4An3rSDtaYPBQjTejv68EdyPW kvXf8ZwptsmvXfjVNLHlI4S3JwkBNXuClOln011RKJ+TI+GWu8+/4LPEDES6jsRDLhEq+L/PsgL l9sYgdzjumCfE2uo3P6qU2Ju9XxdzGu7c+R2CmInzfGllQC0o/W5xayTatALOYztdMIlgemTdUK mfXr3aqinmR7Q7zzCrkp8nuLL2MFaYgFAtXL21df8o1G8bBqOSSQqHJnsZudIpkiSL+cFYDPkLL DftL8/oVQJPB2n2XGBSvBRQlezGNT4Nc2OEy4/uIuARtFFF1KJ2Gg8Cg71Pbd7PNTHLY3PV1hiN qD9TrUisSpjP5P/sZD1tDCCwY= X-Received: by 2002:a05:600c:4ec7:b0:490:bd66:e523 with SMTP id 5b1f17b1804b1-490c25fc134mr178993095e9.20.1780825300369; Sun, 07 Jun 2026 02:41:40 -0700 (PDT) Received: from nixos ([83.217.168.175]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cc0f8sm295839285e9.8.2026.06.07.02.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 02:41:39 -0700 (PDT) From: Rhys Tumelty To: Andy Shevchenko , Hans de Goede , Mauro Carvalho Chehab Cc: Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Rhys Tumelty Subject: [PATCH v2] staging: media: atomisp: remove unused macros Date: Sun, 7 Jun 2026 10:41:30 +0100 Message-ID: <20260607094130.3208513-1-rhys@tumelty.co.uk> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused macros across the atomisp driver that are defined in .c files but never used. This was flagged as an error in a W=3D2 build due to -Werror=3Dunused-macros. Signed-off-by: Rhys Tumelty --- v2: Removed some macros that are used, or should be kept for documentation,= with feedback from Dan Carpenter drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 --- drivers/staging/media/atomisp/pci/sh_css.c | 4 ---- drivers/staging/media/atomisp/pci/sh_css_metrics.c | 6 ------ 3 files changed, 13 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 900a67552d6a..7c1fdd39d6a3 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -40,9 +40,6 @@ #define SUBDEV_WAIT_TIMEOUT 50 /* ms */ #define SUBDEV_WAIT_TIMEOUT_MAX_COUNT 40 /* up to 2 seconds */ =20 -/* G-Min addition: pull this in from intel_mid_pm.h */ -#define CSTATE_EXIT_LATENCY_C1 1 - /* cross component debug message flag */ int dbg_level; module_param(dbg_level, int, 0644); diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 6cda5925fa45..cd1be313c758 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -61,10 +61,6 @@ #include #include "timed_ctrl.h" #include "ia_css_inputfifo.h" -#define WITH_PC_MONITORING 0 - -#define SH_CSS_VIDEO_BUFFER_ALIGNMENT 0 - =20 #include "ia_css_spctrl.h" #include "ia_css_version_data.h" diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/s= taging/media/atomisp/pci/sh_css_metrics.c index edf473dd86ca..24cdd52283ba 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c @@ -12,12 +12,6 @@ =20 #include "sh_css_internal.h" =20 -#define MULTIPLE_PCS 0 -#define SUSPEND 0 -#define NOF_PCS 1 -#define RESUME_MASK 0x8 -#define STOP_MASK 0x0 - static bool pc_histogram_enabled; static struct sh_css_pc_histogram *isp_histogram; static struct sh_css_pc_histogram *sp_histogram; --=20 2.54.0