From nobody Mon Jun 8 04:24:37 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7620E377EB0 for ; Sun, 7 Jun 2026 09:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780824936; cv=none; b=BCoVfxFw11MvT8O7zSUSNRIQ9IKcsan79LPmZAZy+pwX8tIHpuLp8RCf86mZlnmjhY0p1tb4JQqL7yg8zGyiijb2UeR5rEjRBDmJjlG65u26TfqHET5XGpkBO8d3C3uMgvuPX9f/AUvDbWjhTFtM7WH6I9aMQf24+xDlJNZep1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780824936; c=relaxed/simple; bh=zLCqfI2KUraSLz9KH/5Y26s/yPLc/CEzNqtohR4IRGw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ClfDjy6DbtwOe3fxC6ny2KsTjT7Z/WH84sSGAmt68AswOgUXjv9znMB5RqHhMTnRdMpJ4IYj1jEEUa0R+s1l/FIrz2xYfKQilxlwweiWh3nIHnvsL52awpuobhnxtEn3D1mRlo2MgIGIlAOarWahGJxUMyokaoKP+qFzyPrHQE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JjoYRAeX; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JjoYRAeX" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bf3781ca51so33759615ad.0 for ; Sun, 07 Jun 2026 02:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780824935; x=1781429735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vXqLiv0ryX+iiE206r6yDGnu8izLUzYrW1MXuiWNlgg=; b=JjoYRAeX747mNq+tudHCTVgGJjHYO5BxvBu4mjyaDP3v5iTRv+L0hIZX4cSbdoThxz YeLOf8egpQFGH7mhIiC14dQ30KCWczitaetYZCEi/a2UVLmKHbVvQlvGbGcuY7toqacL x0GMI+FsudFP+GBPZjPmUmFsSZw6/fHhnZHXVgD2AsF75GzrhNkklM3ljE+XUewZ/Dit FWzQa/z7XWSfRssHTMiClCKe1lJCH0yvB1pbRAWyNJwRfRYw4hVyqRDY+YXRLUapU+gb TdgO3vUreXGxH2KJ69EfItgmC5U1OJW4evO/4FBhR2KtpF5MQf3IrEwUZ+/rlugkZy9f Bh2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780824935; x=1781429735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vXqLiv0ryX+iiE206r6yDGnu8izLUzYrW1MXuiWNlgg=; b=Ghwp/2gM1/8V9wvRE8W+FdAqrzQNjt1aX8wSDTtbXuGzgzcmCLLkutyvVroRF4+t7b FWa481IK8lpHm1z4I/UDUJEsDvI6GaNuxqI2IzWOXHvx8WEmod06W7TEc3sOEXemv2nY Yqaid+KPH0deVWlxmW0m+vugiXysFV8uCI1tGEk74EO/K0AEaWJccIWAWeHCqCqIGFZT l+w5gurskU5+qQlIzD8ey7HmEFyLKjVF4rm7w8WUUuCODwN+E/7rHJ4WWhRGsmTRE6K2 I4MRkH1J6swJTnzx/+M7HJREDt5I2keIxSO51MiIPG93KL+wW8kDMAInkQ7SEmXLnL3/ LaMw== X-Forwarded-Encrypted: i=1; AFNElJ9t7E0c+Z609pPjK5tNf0D/FhUKAaVSG9o4pxUcwsbTSDGGRQ4jlhBtyF0NCMOcieAjJd6UgSzv9sfgpQQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxpg6peBMI1zRirLBzXF3QUZOz991RWEaaFd5yHIQu0TB0jECyf LKEo6Vi2ta5zaHxSjzcL+3Rj30b6hXzd0mTZrCC9v+q4S8ZGHsoEk6IE X-Gm-Gg: Acq92OGxSclSe25yvUfW44vmHOTUv+8zsDOM/hJKW0eGDKVJCDoE8iflrLvPr3nRwWg mjP1x5y+Tm3er0wTHSaaTYI9BXq0VVvKDYn+Kdy5O+iYfKXejPmCg6jmVZVg4f7dmvzKUfMkKzd pnJPduQvuzwMLpmApNGQssB1EpIxpIk5gkp0+2VxdiPaa4PVD66bBvd801bP6nc2tQkcNirc/Nt d1ZNhZkLn0AuONJ/g0zZbvWlzNPayc+PCM30jyOzvj79xPDPhafLZsahO6T6pO+tqYBC+Rh3oRV 4CE4lki1/i7kOlK4qHVEPffmldG7lq3h5gtaZBk2WdZVv1QAuX2zd92gufyO7JLnbBwipfdRogd c/k7yQvrqYw7J+THm/m/vPbTx0FFWKP2ahd9OQKoQqLKoFdVGpx94p8W962UrGtfG/s7PvySH5f sVvG9CdkwY4e4M/trQvnXEurQ1hL5Tak/VdPSqRIF5VQj3wi6wK+Lw X-Received: by 2002:a17:903:2389:b0:2bf:305a:312a with SMTP id d9443c01a7336-2c1e820985amr130015775ad.22.1780824934589; Sun, 07 Jun 2026 02:35:34 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:5d57:2cec:64ac:50a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f96b3fsm150845545ad.29.2026.06.07.02.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 02:35:34 -0700 (PDT) From: Ruoyu Wang To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] media: bt878: check register mapping in probe Date: Sun, 7 Jun 2026 17:35:30 +0800 Message-ID: <20260607093530.3-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bt878_probe() maps the device register window and then immediately clears the interrupt mask through btwrite(). If ioremap() fails, the register write dereferences a NULL mapping. Check the mapping before touching the registers, and unmap it again on later probe failures after the IRQ or DMA buffer allocation paths fail. Signed-off-by: Ruoyu Wang --- drivers/media/pci/bt8xx/bt878.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/pci/bt8xx/bt878.c b/drivers/media/pci/bt8xx/bt87= 8.c index 62a6c4a80..245a5f0ef 100644 --- a/drivers/media/pci/bt8xx/bt878.c +++ b/drivers/media/pci/bt8xx/bt878.c @@ -445,6 +445,10 @@ static int bt878_probe(struct pci_dev *dev, const stru= ct pci_device_id *pci_id) bt->bt878_mem =3D (unsigned char *) bt->bt878_adr; #else bt->bt878_mem =3D ioremap(bt->bt878_adr, 0x1000); + if (!bt->bt878_mem) { + result =3D -ENOMEM; + goto fail1; + } #endif =20 /* clear interrupt mask */ @@ -486,6 +490,12 @@ static int bt878_probe(struct pci_dev *dev, const stru= ct pci_device_id *pci_id) fail2: free_irq(bt->irq, bt); fail1: +#ifndef __sparc__ + if (bt->bt878_mem) { + iounmap(bt->bt878_mem); + bt->bt878_mem =3D NULL; + } +#endif release_mem_region(pci_resource_start(bt->dev, 0), pci_resource_len(bt->dev, 0)); fail0: --=20 2.51.0