From nobody Mon Jun 8 04:24:31 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBC737C0FB for ; Sun, 7 Jun 2026 09:35:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780824923; cv=none; b=sypfzQJdUWOKWWLWkDetsYEeeVDOe11T0LznGdOAjS6uWYVUeOUQM2OMCuP58H5hM5pE8FR/epHEyjmR8Xy3HdYM+G6AXP0hsvj5W162P3Tg2EtNB/xNJrLgegpW8T2Fi32YfwYhvIuLjnC0gzFTcGHATyOOrpGcTvtN/AAhSZA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780824923; c=relaxed/simple; bh=qSDy0AfkxAYlNXnjkHbJOEepYE/1eEVQeyRmTN/eZDw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bnCK4hhqgAVbyxfwPWnrmyxPPwmSJ6Cp8l8ca2Wl9fPwcB8RZhZZEMcmlJwFhRp/WL3E84dj/2EsMWhQXhKfrXTrT64xqvcVlbMU2+J5VKl0+i+1Qot5vTl+92uPUsQ+9lqPsecM4mLGRGzwrG8//5zyX3BXFctJmc5/h7C3BMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OuEF+ZoL; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OuEF+ZoL" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bf125989f2so23686395ad.3 for ; Sun, 07 Jun 2026 02:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780824922; x=1781429722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hJ+nE3Gpnoe4Cp99JZ7VpoEQgM0qNrm472Qh8AEjSOw=; b=OuEF+ZoLaoDkgkY9w15XJ5nr9IhljCK7FNQLbrsLc4WgIPedvgpLQFubif8vTR0W5+ pEtlrrmx5zJ0lmW/G+EF41Q97/hZKV/7I026N01vdXGlrwBpPNijf4EqD0uxcwd+e4/T /S4chwU6pAKanjADRTgE2o1Yuis+RZ3U7k9FTJy47e1YIOh1f5muo0hPVtO6dDmOJGdk C/v3wo9l85Y+8rq1cAc2DgVPEYxJDyny8LANvQW6/OraW6WFKCaEy+vJeHwBJch4Kr9/ p4hHSQETE+rSMlvHSIRCFtBGNwpwWnaJmawfJzquckNQgwpZi05U7MjxyG0wQj93L5T9 nQew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780824922; x=1781429722; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hJ+nE3Gpnoe4Cp99JZ7VpoEQgM0qNrm472Qh8AEjSOw=; b=QYtzTIqNFPOlBmN9THspCeJ1siPfcI4P6Gf9Y5mtcCJdm8nhv4rbBj4muCHgpppHXo kHX9IO1ANCOZoFfziljeu8TnY5rQrelbx7fqp9vfaDAE7nm7WTWhDOERiQRm2jtjjbkA vHsL5SqWq1ow34lC798+gCoiQstpMfXFF0eEZUdXsQD7uBHtmpZOGnqB1hm1KK3cPWy8 MCb8NFrPmLWuxK5EKFChaJFAU/4jKV/LOAEEJYYgZncRs9WNelo1Jxdi709gG+5Z0U5P N3GuU/36V5Ho+0n3sZHXeS/JgQoiEJ4PfRIRgzlLrEH7fdwqGFGZRVLp/SPgpycnnU6o oPzg== X-Forwarded-Encrypted: i=1; AFNElJ9NKH/Q2RHBUMnIIE/0HhhVUd9f3K2fpo+nSpz+E9E9l5pwrokOirDcJcPWib7s+4MbYPIhYsL0B4vDgoY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtcnx8M6Pg7r3ru2i6ZqcC70yxGrazOTiE6Ej+r8osoEu1qG6U dY3fr2WlYQV7N1k0mhC1a2S61Z7dpivxzMRxNRGAS6Xgxy0hpP9+toqq X-Gm-Gg: Acq92OEEY2mXxzD9zdJHituveuEBTUvlL+7CYnGpqGaONfawd2zNzP8czR0gO1GWuso 8kUgMd0uNLBmJw/4mMCMcB8yUUuQM2qfSP6FaqyXB5eUXv8rPv3cMtIvQwqfmu1F4UuckuQlCfn /xpRC7d2FvgsFWSjug11N8RKcu1A8S7rgQdiTPkDRkqzLCo4fwgBKTofUhWe8JtX0JEOVogMaxV 4mcNw/phqgG97bHGXK9VRAEFH2SsKJWRPH/f/73MW7HR2sOfsq24OmFUG4iDwIn74Z9y669BgkV Afzp0RGuIqvOrtAxIdglWBUCL0Y8bA+avGCM7Zx2FanZpJF8LsvMg+hZF5XkX5zstBRK4FyqI8M NqVuMBuPrxNZdG8LGmDrGtNeBJnhYUU11E1LEHc5GTKTtVGpZT9KTP91G0Ikqon2sN0nO6eOMRd CMNtZ6Yj5w4fez2QzJW0O75NRP5HynAeOhwFa9jKeCNj0gFXO8QIB3 X-Received: by 2002:a17:903:1b47:b0:2bd:9c0a:32c with SMTP id d9443c01a7336-2c1e7f921bcmr127871045ad.19.1780824921886; Sun, 07 Jun 2026 02:35:21 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:5d57:2cec:64ac:50a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c166396fa9sm145238635ad.66.2026.06.07.02.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jun 2026 02:35:21 -0700 (PDT) From: Ruoyu Wang To: Chandrashekar Devegowda , Liu Haijun , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] net: wwan: t7xx: check skb_clone in control TX Date: Sun, 7 Jun 2026 17:35:15 +0800 Message-ID: <20260607093515.3-1-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" t7xx_port_ctrl_tx() clones each skb fragment before passing it to the port transmit path. The clone is used immediately to set cloned->len, so an skb_clone() failure results in a NULL pointer dereference. Check the clone before using it. If previous fragments were already queued, preserve the driver's existing partial-write behavior by returning the number of bytes submitted so far. Keep the existing byte accounting unchanged so this patch only handles the allocation failure. Signed-off-by: Ruoyu Wang --- drivers/net/wwan/t7xx/t7xx_port_wwan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wwan/t7xx/t7xx_port_wwan.c b/drivers/net/wwan/t7xx= /t7xx_port_wwan.c index 7fc569565..d2529df75 100644 --- a/drivers/net/wwan/t7xx/t7xx_port_wwan.c +++ b/drivers/net/wwan/t7xx/t7xx_port_wwan.c @@ -106,6 +106,8 @@ static int t7xx_port_ctrl_tx(struct t7xx_port *port, st= ruct sk_buff *skb) =20 while (cur) { cloned =3D skb_clone(cur, GFP_KERNEL); + if (!cloned) + return cnt ? cnt : -ENOMEM; cloned->len =3D skb_headlen(cur); ret =3D t7xx_port_send_skb(port, cloned, 0, 0); if (ret) { --=20 2.51.0