From nobody Mon Jun 8 04:24:57 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011010.outbound.protection.outlook.com [52.101.57.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE5C9175A62 for ; Sun, 7 Jun 2026 05:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780809002; cv=fail; b=HOyxO7sm08gsQEP1G4dISzb1NUdsIsIjZFb7Hk/wGcXV/XHCnI0mrhuZRUn0a9gyQVnCx6zsL6vzkdzOxxT5bLgDCBScO+f3ERXoUeGsmoHK648xW2ZEtt3btbG64AobBMqRj82RO3GNFGEnm4T9ni3x001xsFzmow/R3YEzGe0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780809002; c=relaxed/simple; bh=EWW8dVaUzl01Pvd7QbkwAeetbHPtObRa2jdiA1JlDX4=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=DRlW4okj5rUiYf/Ig/catzsbukda99BKu8J8O4dX4My9KkTW+jsBmcqmEQByLff2Wgluef5WjYduGyyr2fJOtn5geD05y6xkCvztg8maFL1oVdKFRMECGcVfViBnpVULGOAvB89Nr2Ys8edaMD02KciTk8RPr2FN2LdqhRN4Iqg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=tj3lV9/Q; arc=fail smtp.client-ip=52.101.57.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="tj3lV9/Q" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sPLXb07pED7XgtxlcZZyePXVx2SwwY9kl3SSAkUbgkDrAwqK8Nrz6lJ4R//MsTvH07tpP5T0Nn4jczY2MhuwPXvPNRoz7otyKV6ZPfHolNg1MYH8aw9HAveiuxOuo0eUQ5hUp01W/FTH89XoXzIc4xN0WQoKDNpWNyA9aMiuW+45TBeP/bvoH5knrxR7Ao598GjjPM9yB8QPnvR/vAoawXIpgWLzGgU8bUVQzeXpT5aN6fjEFgUCCUNBIy9j+jB6UsP7kNzl52gq7DQzG9c5ZjTvoiFNLphAibVZCJIwqQRtNs+pVlEftBDMTRYak4WnyaAzJRpkeK2EJh1DKwAnTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EeZDeaUVX3w9Nxu7fiy/Om7OMZfziYeUq2vleKVEtww=; b=thRqMDtb06yl3y04gucB/GOXKduej3ApxiWWYwFj9yM2aitGSisXFedyEvJlGi1rvGZJfSwCcoLSULHdqYIBZzsLauXgUmiPakoN7WoyNx1k5VosL3QeDD2maF9RhgvYZ0sarNtHqMFMmbgXYdj9XbAwhRR6tksGTziQi07mRRg8O0bY0I2brUpTHx+vR7vuuS5UoGbIlnXl9crBOpUsGcdKJR7MVAt+TghU7Hr+EuD/ezxqe52ck3bzvFbAKMAM6zR78LqvOa6n80JB89mNeMoFoa0ZiwaF/adAy3kjMkRYYJzgcrRoXiTVIVN15jpPGrIuwfQpo7It5O3zkitg5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EeZDeaUVX3w9Nxu7fiy/Om7OMZfziYeUq2vleKVEtww=; b=tj3lV9/QNWxCWO+07rdeHN3KQYcmnUEDcJe6I/ViW1+OZMYUZ9gzR7KjwwjSl0SCXS+K0tf6SDhyygoZrrtHb7tBts6FBVXNo8Gi5J4uHIh7WZc3AYpc+lXe3zeqeGJYFc0ZwDmOWT7DcJ/+dkXoQ7DDY3e/sBkvwRUYSoiPFPmwI30607qEaX/JF3Waga+KK9o2COfmcpEOQchlw5qSFyNP7/cFj4BeA/hOAmOsMUjdRxgR1BGOIdKzox5bkj+mz7ULe3lhDU8KvmxKuBCmxqkC6p/R9mVpF4jwjp0i/VRtvHVVWME1sZdS7FGrN2cp+yArh22xANBrPZSBGbPVRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM4PR12MB5230.namprd12.prod.outlook.com (2603:10b6:5:399::11) by MW6PR12MB8999.namprd12.prod.outlook.com (2603:10b6:303:247::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.9; Sun, 7 Jun 2026 05:09:57 +0000 Received: from DM4PR12MB5230.namprd12.prod.outlook.com ([fe80::6e87:1bde:1853:3b73]) by DM4PR12MB5230.namprd12.prod.outlook.com ([fe80::6e87:1bde:1853:3b73%4]) with mapi id 15.21.0092.010; Sun, 7 Jun 2026 05:09:56 +0000 From: Fenghua Yu To: Ben Horgan , James Morse , Reinette Chatre , Catalin Marinas , Gavin Shan , Shaopeng Tan , Jesse Chick Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Fenghua Yu , Matt Ochs Subject: [PATCH] arm_mpam: Fix MPAMCFG_MBW_PBM register setting Date: Sat, 6 Jun 2026 22:09:25 -0700 Message-ID: <20260607050925.252475-1-fenghuay@nvidia.com> X-Mailer: git-send-email 2.43.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0192.namprd03.prod.outlook.com (2603:10b6:a03:2ef::17) To DM4PR12MB5230.namprd12.prod.outlook.com (2603:10b6:5:399::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5230:EE_|MW6PR12MB8999:EE_ X-MS-Office365-Filtering-Correlation-Id: 86111ea9-e9e2-460a-5c2e-08dec4530418 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|6133799003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: ElXRiiXoujkki0KjVbmU/2bKJ8PgaqhId/uR6s2ODxvcB9HmZ18MpZ7cIJmkAkzpNgeR6qnpbVKAm4oFUurdqDXfc2N4ZO4XNUbMJ+GD41i+IdqQeWBjuOu34FlrXdS5vlYvOxltGFJLgrTkR5opwGhlc/dSO2zaTjwKjkkMlr2TJTZYq9X2vepsw7toY/LN+SEVDXBPdUT1vSyype4uhcRAur9vjiQYpCPjghjvrW9r0ykXYG/TBrMHCcKNUQoCKM4oQCiGdPa8raPo1FDn5Jq5BsGJuCcCtHADvL1yX6QLouFeWWPPz+Wbjt6PHmXjz5/uxKIq67ydm0niuIm+xOl9WR8YxdsUf8c2I83ruC30v3ePC/mOeJbGdJLc0FHzIhdFqzsjzjW+E2a+RZFzNfKsYN3Y9VMJbsFBe9FalsWUyKrK0GxshEvOvWNHOUnH+GIq7FHx2Hw01hkSlwTzp/MTmcO069LECReM/nexJmW0uarupMhJE7jsfPCPtTzi8EJOPGnhyeiGawqRWuWEFZpt5wcqUB33zLZ/LI07JRjysfK1sYm9Bhq6DT4awSA+DStuAeNy01f0okZPa/ZJqsyIOBlbaiFOcrhwzJddJyE0uGP/FZmkflDh1qpD0iv2fVBF/LJ15rL6Tsu6E1VYpY3TIWQ2wSNrzTFDe+oIPnRvToIZsHu4g7F4TpWvoOxU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5230.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(6133799003)(18002099003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GTtd83D3GAyYPcbBXg88qOPTEuE5j064YtHaLGYvB+DxvEhZ3Ol26pbcWOM0?= =?us-ascii?Q?A/IiREIgU00PIjtGI9i+GQNj9zAqV/7IubNLKfRq5f8oNYv5koERXtKEDW8I?= =?us-ascii?Q?8b/8/dqWE2hKyhZwxHy7jVudTFu/uDMlg34cd9A7YQ2Vukvorkxbsy4IW05G?= =?us-ascii?Q?yCvA5MU4rnTFtIG+LibQ8PUCIjJ3VLLFKaAAuouC6HPPxc7LtGdt08MZtRVv?= =?us-ascii?Q?NHD5s33lZDPwfOgwWSIOexrzKDKyh4LmwX5ZW3YiIk2V7R3Gr669GfaXR4sS?= =?us-ascii?Q?V9kCm3oKGziTV9SUXvyUJrrAttEB7gOzWF0ja3i6GCtL/MGrEVyk8Al0kMMt?= =?us-ascii?Q?ZErZHlp2eaYdwFHslL1ROZLVvIch6boTd/MI+T/6xE8o7x4rTqoM0p10Srh6?= =?us-ascii?Q?qiu/0ph6a92eCattrU/IAsdRrshiO38bCgpYXpVf00h+iXLfAT5z1b23t1SO?= =?us-ascii?Q?HLU8d6hjpFZjVBfuIj9GOGubSjsP+3mQdpjgpOu0nMirmqAiZKBIEGUjmiIJ?= =?us-ascii?Q?68nGQAau/m/lh5Ya+iHKRZFU6GgH/JClXWxx1kQFOXtwVg+I1+O2bjEjQJZf?= =?us-ascii?Q?3rWi7om7I5Ycq756IaTII1HKlBkG2bpFPamTC4zboT7sqkQ566im0e7sKu03?= =?us-ascii?Q?yDDInrkizZTdOrnhUHQ6ThB0PobdoRvsRf4DM7esXZxekeB5h7NvJdRPXBgD?= =?us-ascii?Q?b3t4S11lu2H8wsPjq0Pg1vxm5FQG5Lv757CbciCF3+EL14JYigZMlD26qdGi?= =?us-ascii?Q?I3U5E0aoIySprdbzLOZfp5ncczllsF6GKX6bEQgijMA7btx8zUgh2hxHXTcr?= =?us-ascii?Q?XPds7f3DUPkRZTdE/M5V1dRxpx+R6xpZt6kyAJVMq5HPZFP0aQIZlSrgdEbT?= =?us-ascii?Q?nyaiJ4a/uWzfN6niJBRfd91M/upg64taqn2QLkKctHMbr626Gly6ATgLf5lY?= =?us-ascii?Q?4f8IbWPCmbl0PgyKzIRgkAaaDeqYrGsDFba9c5YT481IuBBakITKZT4I154P?= =?us-ascii?Q?yZP6n1jmGz9DXfW7bVcEBnJKKFyTnWbP8Jow+XC5a5BD6rhQ7tp3iX8Ga8S4?= =?us-ascii?Q?r3qcjufh8wvBP5uICWHejFAW7EtURZBWQ+LkK6sKQmzjp865vaVCCUxHyldH?= =?us-ascii?Q?NRN2ZFRnzb6cliKujl22vohYB2VtpBlmFYmqaDIWsL6Y8gyZDmnAslUNJDsT?= =?us-ascii?Q?B5TJH8DMbUdTUJk/WbVv4r9yFivd07c+rESSr/1B6XT9ZQL/SjXplSsLoz70?= =?us-ascii?Q?2q3Vbg3w6s/SNAUPFFy+1MWuhx0GkmJLVUf3CBf88jvhchcr0QsasMDpRtql?= =?us-ascii?Q?0QuE9pBlk0XK4baOskXVPjuwcCX23zz4fkFdBGevpel30szA7NuL4TKYtAw8?= =?us-ascii?Q?mKHBD8e3LTl923Uf3W+XEOlz1ZPI1wYT2zBFB3RPe7G+8vZ0YE8vYtVn1kHm?= =?us-ascii?Q?4ug5o1KeLfpytU/yKj93ZT8WI6IbEjVr9wBDr4ZmfaCeyL4IWgmEy8RgoPQm?= =?us-ascii?Q?rZEo3yHK+HU9QlneWrbF1sizZC9Y8dTVBmPDx4wBZdMU9UdZtITV059AIEo0?= =?us-ascii?Q?yHZL1uWfmDOhc2jL+VebthrpPBED5ko5QbXZthVRFAzfuGPkyrMBQSQD0xPa?= =?us-ascii?Q?2C/ciV5C8SwF7RB47+zBU6lMmtEUOpHnNDQwNnFsiWi30RWL32uj3EbfZEyf?= =?us-ascii?Q?NTGFOBeTVy87kVMSa0wxQELh1U9fvlK9hG+M+2Mo/ZbNlWKnLqDgiiqutoGP?= =?us-ascii?Q?Jx8cZujjkQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86111ea9-e9e2-460a-5c2e-08dec4530418 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5230.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2026 05:09:56.5972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u3vAeha2liBiC+5zfNwgZmzbBV9PhqHIcowekRxHb8rPXOIPJe2oEGoOyyY+CYXaKEGnUIZGC6K/LmqE4r+DCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8999 Content-Type: text/plain; charset="utf-8" MPAMCFG_MBW_PBM is written from cfg if cfg has the MBW partition feature. It is reset when cfg does not have the MBW partition feature. But the register handling is reversed. This may cause an incorrect register setting. For example, during an MPAM reset, reset_cfg is empty (no MBW partition feature set), and cfg->mbw_pbm is 0. Instead of resetting MPAMCFG_MBW_PBM to all 1's, the current logic will set it to cfg->mbw_pbm, which is 0. Fix the issue by swapping the if/else branches. Fixes: a1cb6577f575 ("arm_mpam: Reset when feature configuration bit unset") Reported-by: Matt Ochs Signed-off-by: Fenghua Yu --- drivers/resctrl/mpam_devices.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index 4b93e89c2678..d8b0383cee92 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -1570,9 +1570,9 @@ static void mpam_reprogram_ris_partid(struct mpam_msc= _ris *ris, u16 partid, =20 if (mpam_has_feature(mpam_feat_mbw_part, rprops)) { if (mpam_has_feature(mpam_feat_mbw_part, cfg)) - mpam_reset_msc_bitmap(msc, MPAMCFG_MBW_PBM, rprops->mbw_pbm_bits); - else mpam_write_partsel_reg(msc, MBW_PBM, cfg->mbw_pbm); + else + mpam_reset_msc_bitmap(msc, MPAMCFG_MBW_PBM, rprops->mbw_pbm_bits); } =20 if (mpam_has_feature(mpam_feat_mbw_min, rprops)) { --=20 2.43.0