From nobody Mon Jun 8 04:19:36 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18350348C61 for ; Sun, 7 Jun 2026 03:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780804525; cv=none; b=GiK4XrD6kyUkER2v72pwwQ472zZAvobx+ZFU80XOqshkO4Y+GNR4sCUHiG5ranwER+7lAFKnb+3U6ehlhnuyrXBw5SPk71MN4Pnpy9N9JpNUhzQjWwDwu080gPlNV0JB1P8MnyDugNFhjRHHO3Wz68T9ig/1F+FS7E6wCIJxVk8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780804525; c=relaxed/simple; bh=U+1fcoqh8bDI9jHQwJaEhF1UlP6MvGcXiPsb798pay4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NX/NFzHYQyN2PUyzJq5TIFApTuvQ5Z3DNsaaKlkZHLov89TU0KEdz8AS4hNbWSTdSCAH+bvezBPy8R4aiYMm8AZM2YQXAY1BiPeQ4nL6EYdtpHt2ZUs+XDIe2Ua0mkotibEZqvOZDkyYRuJLtPJnyLjGXxz3ZwA6THjOEtSNsCk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AT/iD9+b; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AT/iD9+b" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-490b1bbcf3aso25479715e9.1 for ; Sat, 06 Jun 2026 20:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780804522; x=1781409322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=heWyTWAleDiilmjb5uZVSaEYhk3Wuf3YFJaYtSyYaV0=; b=AT/iD9+b9JLfpATr8TQj0qE+yusJkVq3Fq/6KJS4O86eRcsgZK8QGAHyJD4q20TpDB Ghht5pGSYs9+xNZvjU9FsGejXRYZT+G71fab8VkjUHv9nOHqj9EUwOJCAtgb+CtdcOIo aT3IQZVNhwh/xOlBlluaLYNzxju1h+mcEYqj6uScIVqgU2UOF05dqjV93tETLDS65146 nswF6VJTf4p40WbcBeVAIW9qaHnufxtbZOhePOOXN5/gzJ5gpXIQsWtpaaKPKI2R4nQw qCtPobq6dsalKeXVwt0Rqz7zSljHaha1RkgPhab2T/6IkNW3Yni8+x1SmZKwTQbS//RW NOIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780804522; x=1781409322; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=heWyTWAleDiilmjb5uZVSaEYhk3Wuf3YFJaYtSyYaV0=; b=fLAl37616+Em8/Axp4k3gBhHiaEb3Uw5gXTZo23Gw3RIHvA8r5p/qYxQ+iT9nxhBWl YZM9a2PDmYHeU1qb9OBjsbzqtaZ8TIdj5Ykjc2WXKYEYw1V17H73o0XIKWE9hRPp3Jvd 4fwpylK+3gS7ecb13r/5R5wVqjJhIVMWh0Hn/6Ir5UcCV79d4NeA/+c6rPR7CMt+kVKe F5l4jdnKjlaT3VeE92QIK8OsuIFtXLH5wGXaLbHY5NZraTTusIRrBb9zB0dlpt1TLpOH aYHCFCifW+CcjgM3I7fDjHyrNAOJlaUQb/TYXmdo9NmVYyFBgHZcOzdlYdAWoFHldX/X xMow== X-Forwarded-Encrypted: i=1; AFNElJ/WD999DcBJXbzmQrvfR97k8gdB1Olxu1402DQhdQj9DUDwgQe7h0VXA6VIfyjF57UBentmhL6TzkzS17k=@vger.kernel.org X-Gm-Message-State: AOJu0YxFYswypYPzfeGrrsURVSLqvm9KuIO8MV3zJeVMsHPupTBN6ED6 svVFzugO0xSR83V+OTwm7q/QCP/NPa5LfVNhXQNmeDuFmxhq8kiX8bkl X-Gm-Gg: Acq92OHoLJosxyw07pznyyTPuVrzsL5Tg4HWTcuZX57DrbYH0gd4pLJ8D6hvuJMykzo y7rgM9w/tNXCzmSx+zhrnMmOTuftuVdf6DZrh1dYu6R8cAVhXZtsRULYt9FlDqx4oHwIaW9Yd3Y ceDhM0Wim+q755Woxytk+KiglwKYYe9+puTEWEQuBeeBxEdcbCuqg1Xr5jenYGWlIngzQXZz6WG budHkjbwqbP3YLCeBR7hawzQWv0qqH/XIgJ0Q3DI9BwmUE/YH/BiPEPhMRHBwEJgLgAQSmU2dkJ rLKCt8nL4qwTNLgCZFj5s1hKf6b46kTgkjGTwRrAngha7KQxxNWTPxVe7VZbTg5cWy5RPQFiIEk pXCGv6mUyHuPwLC8G7SgyREtXk3DVcb+x+GIZI27/89BmLAVeTISjhud8gCHsEbp2QAm9pCa5BW DsOjBhbB2Key4GRs5hR+ycTpUW/SCGcfmMDns+zaxe/u1RQ4wSfNBq2doOTH1m3zYmGKjV5Xz9/ +lU4+PgsUKt1Tn8l77OQPkwzfaRXHYxZqQr26Gc5Mc8z7q2oASy0B7P9EOrWgn1hR86hNCzb3HW CNHcTVoktaIrir2L6RXJ X-Received: by 2002:a05:600c:3f18:b0:490:b025:f324 with SMTP id 5b1f17b1804b1-490c2628f1fmr175472145e9.32.1780804522245; Sat, 06 Jun 2026 20:55:22 -0700 (PDT) Received: from instance-20260604-012959.europe-west1-b.c.project-2c9d95d2-bf4e-4d5a-ac6.internal (250.69.76.34.bc.googleusercontent.com. [34.76.69.250]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490c2d37edbsm187854985e9.2.2026.06.06.20.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 20:55:21 -0700 (PDT) From: David Maximiliano Hermitte To: djwong@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+97e301b4b82ae803d21b@syzkaller.appspotmail.com, David Maximiliano Hermitte Subject: [PATCH v2] hfs: return -EFSCORRUPTED instead of BUG() in hfs_write_inode() Date: Sun, 7 Jun 2026 03:53:39 +0000 Message-ID: <20260607035339.1015062-1-davemadmaxxx@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hfs: return -EFSCORRUPTED instead of BUG() in hfs_write_inode() A corrupted or otherwise malformed HFS filesystem image can reach the default case in hfs_write_inode(). The current code calls BUG() there, which turns an on-disk filesystem condition into a kernel crash. Return -EFSCORRUPTED instead. This reports filesystem metadata corruption consistently with other major filesystems while avoiding a reachable kernel BUG. The issue is reproducible with the public syzbot C reproducer linked below. Before this change, the reproducer triggers a kernel BUG at fs/hfs/inode.c with RIP in hfs_write_inode(). After this change, the same reproducer no longer triggers kernel BUG, hfs_write_inode, KASAN, Oops, Call Trace, or RIP evidence in the validation window. Reported-by: syzbot+97e301b4b82ae803d21b@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D97e301b4b82ae803d21b Tested-by: David Maximiliano Hermitte Signed-off-by: David Maximiliano Hermitte --- Changes in v2: - Return -EFSCORRUPTED for metadata corruption, as suggested by Darrick. fs/hfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index 89b33a9d46d5..4192f660b64f 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c @@ -471,7 +471,6 @@ int hfs_write_inode(struct inode *inode, struct writeba= ck_control *wbc) hfs_btree_write(HFS_SB(inode->i_sb)->cat_tree); return 0; default: - BUG(); - return -EIO; + return -EFSCORRUPTED; } }