From nobody Mon Jun 8 04:20:40 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CBA42C11F1 for ; Sun, 7 Jun 2026 02:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800995; cv=none; b=Cqi8eZNycjja8QqJujKUHqLIApVCqJZayaQ0cYeZKttcJtgGqtzJEPvIsxgBMXJWkaBNf9gfgRCOD17xnnmAA+fBv0e00cXVYaZDrRLJIB8gwT2R15255rzEYsMUXmcBVFjB7MeP/E9k5ZdxuHNcmwUZ1eM0Hs182b36J5YyqII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800995; c=relaxed/simple; bh=wpKaZKrWe013sifb0QNoDnl4CTs0LqjAAk1K8fio8S0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrL/p7Naxa9FEGjw/aXxiZNSJhGy05EVwZRF4VYceAfcFAHuWSV1IF2ZokgI7r3VhzriZICSPfxHvXeKYwTRmfsh+m4pkR1P23JpqPDmfFeJWr9/WdEyuY3QWQ/bgcXStHU/vzb9bsUPbZIArRLRBTICEzp2t1JS4iUmC8Xirpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aoNFeD59; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aoNFeD59" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8422f395a4aso1913582b3a.0 for ; Sat, 06 Jun 2026 19:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800993; x=1781405793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fuEYuS/RHcQ1IGpUO+X/TlJgzFLm8ttQziKlSNGRsH8=; b=aoNFeD59Q9mVJp4jBtgBc5YoORP1Gs5gXKqpYCNpeh20kO4jioQsW4Ejg+qd4coBGt L0yxhJ0UH5NyWE31oVN99dop2yvlnf9Zbf4FO0kxuI6v7iIzDaFnNX6ZH2UBakFnQ6jC +VIYGI0evoZD2+3JYjZk6M6OGvWILViAbfpO9HDag9KbtbKJJntzmfvRoOZUFaim6uC3 9UjkinkFFZykGc8nYq6/yF3I3+wrGnuGb2yPrD7sgzgTIHVV6ivliob/H1ZGTZLqlBog 9dmIFcYW6Zjrm0lPmY9bL0CxxWh779ZT3YgPhokd1JB+ZZ4ys+4qmUZyg4IAnjEupew7 9Xhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800993; x=1781405793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fuEYuS/RHcQ1IGpUO+X/TlJgzFLm8ttQziKlSNGRsH8=; b=kIarW+t82TWyDJDrOr46TJ1GX8glbth6LQNs99Tif+j8NzpyQKp0Ffalfb67yNXacY 6duEneitn4G068zNStrNKhGszP4W4nliqn9uWrWInTgrg8LATp9ipOF08SxjZ3oaRwUm xcAX1u+tmzxxCwvMRmPPpw3Jz3t7lep45fT14T6xaH9idod6cg1UWln1yMyhFij2Mwzd oVF6GMvnevGdd2IdLi1Pj9NZm4RlTkyhZAMq/zoPI6Z1lZLGohMe6qRtErSBhTikpfgS /Jwrybwm+Ov0ziNi7iv0p7Qxk3IVAB6FMbUmP9vgEoPQA1fwbS6brSpRgtaFXTkFSODg BRSg== X-Forwarded-Encrypted: i=1; AFNElJ/Bd1KDte9fxmVDYUadlnKfdNwwdf6HAKljuYpV/sEhks8UNhIx8lSHPSOFj9S6hyVgEPrb1vDMLjQW0QM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb6M4hEGdOfrS9IcvLiI5D/qhKJlk5iymM/1qZvH6ZsGN/lLnX X/P8merhyHh3q30Wn5dAZjH2xE0LkzbtwLlKeXyvbqQRC27Lu4PBWHm9 X-Gm-Gg: Acq92OGYrVT/1GmIlYqs12XOvozborIu5MnmOJyNWn3DMyB/4PnoGcw47JiHso+br2V mkMtJNt7T9Si5F0V092uQEFYXhP0qAyBxH56C4Sk9PittOPI+D0XXAHwhTYXFpW21lb1QPePafj BCMQCd3iTVwkCd8PD0OPEAq7UmSswKrOS6fXcPxZ0M0kRPmZIMiZMPOMQHIyQFRX5NZaBE80lnU +dDdTqLP8aioYmkhGAmFCm1/YjJLHLq34k7x0ZfC1ZAdPp0H6bXQWqRYQQsxOLaNYXsurad4z23 HQLGvs+VcaTqU2gN/KnZ9nWCrc5Z1MFaPbtybaWtTIOgG66Y0PKo9sLGWC0joo8m/xcFCc8t45d NG76Tg5mABJHZPx6JnaIADbSeUw3/+Sb3UAf+H3ZQxsxjZSxkg+l79szVOs+zHoAgu2d+/eEIXo NX9uHBC/9KqYVddv8/WvuUxb5kCroF6nhv7FYdhYD26gRq/KsdsNwEUNhXWiJOPAem X-Received: by 2002:a05:6a00:a226:b0:842:1be8:f9d3 with SMTP id d2e1a72fcca58-842b68229e8mr7446642b3a.23.1780800992505; Sat, 06 Jun 2026 19:56:32 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:32 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] ALSA: ice1724: check S/PDIF control allocations Date: Sun, 7 Jun 2026 10:56:12 +0800 Message-ID: <20260607025613.3604194-8-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_vt1724_spdif_build_controls() creates S/PDIF controls and then sets kctl->id.device before calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation failure, so these device-id writes can dereference NULL. Check each live control allocation before using the returned pointer. Signed-off-by: Ruoyu Wang --- sound/pci/ice1712/ice1724.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/ice1712/ice1724.c b/sound/pci/ice1712/ice1724.c index 65bf48647d089..b16c84983b81a 100644 --- a/sound/pci/ice1712/ice1724.c +++ b/sound/pci/ice1712/ice1724.c @@ -2379,16 +2379,22 @@ static int snd_vt1724_spdif_build_controls(struct s= nd_ice1712 *ice) return err; =20 kctl =3D snd_ctl_new1(&snd_vt1724_spdif_default, ice); + if (!kctl) + return -ENOMEM; kctl->id.device =3D ice->pcm->device; err =3D snd_ctl_add(ice->card, kctl); if (err < 0) return err; kctl =3D snd_ctl_new1(&snd_vt1724_spdif_maskc, ice); + if (!kctl) + return -ENOMEM; kctl->id.device =3D ice->pcm->device; err =3D snd_ctl_add(ice->card, kctl); if (err < 0) return err; kctl =3D snd_ctl_new1(&snd_vt1724_spdif_maskp, ice); + if (!kctl) + return -ENOMEM; kctl->id.device =3D ice->pcm->device; err =3D snd_ctl_add(ice->card, kctl); if (err < 0) --=20 2.34.1