From nobody Mon Jun 8 04:20:40 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 547E52C21D0 for ; Sun, 7 Jun 2026 02:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800989; cv=none; b=jcWULie3zDXPgqol0ojpINSiehzjzO7y/mGbYvm5h45S6Ztnc0NYW3qy0VPiwmjkehGzaTHUiL5E9EEwgCiwiWZGY4vgFK/iXri89rtuydifqQjHQETvFd+8wURWtxHq2LKTYjYHr4WDUjU7RYfsWCa+pO4t4mIfppcN13w+Mw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800989; c=relaxed/simple; bh=9PKZKeFbz0/TTNTIXdi0z88j9mNVL5I4ys97cMPdWDs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AUhyHgF7W865P1ll176M4Z7pSyr0SsHxV9bVTOCavArxoFMrOcBjYFOblCKHdFT4a6nl+McN4OTsXTBg5E5H7J8EOxtL6KmHONMUmTlnpaI6D2KeUV/lxacnuRGyJLIW+/GnRAriITknv8folV/KSVIObwing+PgEsQ92eG/oh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AAq408Qe; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AAq408Qe" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8422871b42dso1900347b3a.3 for ; Sat, 06 Jun 2026 19:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800986; x=1781405786; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GhhJTx0YtHowdbDm60LKy/c56f1KmXFLHrUloPR59Vg=; b=AAq408Qeq4MqnE0L37w+f/SBm7PWg6hGYj52laEUtbOLYkQwbqRdX/m+bASw+3h+1P jKCUpC/ePDLWSQtrIVjQskCB0mhUWCogJTvN8yganleFrN5lK1tWQm4LuYiqXHSaBsG5 UHbfE7wZkphxRZA+90hjfEP46k+vzW9MdIMCeu5u6Y9QaAL0JNpY2UF9HTgAWgXsnOOH tBWzyY/VdF0bj+pM8CiACLSGYYaa3YcArjMUz9Lxax/MqY0nNLU3zR0ea7+MMj5JtS/A tInGcOuiqlteWriueoGDtpGnqgtryW6f+/uXraxP7zFKRS2qNYTFayBaB0iPM4l0xgVS C25A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800986; x=1781405786; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GhhJTx0YtHowdbDm60LKy/c56f1KmXFLHrUloPR59Vg=; b=SC+beF3kGqjiMAniBDWtJIhlngHfJut9IO+AVfwxQ2/rgxaLFBKmfYN0NpXozxLPBE g+E2Pbcjr91sMSE7MGk5RJvwhcRe1jhIiCgf/TlM1aopRExSCfLYmEfB4veu24zLkrSy tF7wdNtmyVfMvx44pC3gmSN8vPfk8Xtbg7y0xZKODwspdqf5ifXllFcEQDoDNlsDi8va nETY4hDR0towwri6UzgHbf2am9b0MhqBQ3LhIaR9P0eeN7n0cDjHB0aJW7m0/rpbsasZ F7MZRVikWrkw9XQ/yOZoyxiQ4scZvBk4A+T87z3r3vXFcZktVvBBamoWjXDTpVMUgYKh e3Kw== X-Forwarded-Encrypted: i=1; AFNElJ8kxATheJMS6WNowE7Dh+A14e7F8YYYnKA4mst28O0gCyETg7enBXFVa9QCXIHhROCVJdSLRXVaTu4yN4g=@vger.kernel.org X-Gm-Message-State: AOJu0YwO+Rim0BHSOVqZHrj6dRnMQUOPUaA1ZxvBLaLPZSlULmzaQ5a/ l8L4zaanMNiFA48r9XT0UfTexdL7cFu6lyKes+/XeIcSXDQAOw+C673V X-Gm-Gg: Acq92OHaPkUmaPDAIgjIUvCZDUVXrOTJDPV4ZSRi5nHHmmj4W/lChLlW+0QWaaSWDfT y+IKSpwwsuqA4T6KkGb1WdLriDgR9aAF4fUfsE+WJZD7pRYxsknG/VGszAFszUYX5fljt6ZaiEW 2Dozi0UCwz6Vz2LDs1kN0L1txHGdF1QDYxdIj/2OvgOly83TSRImnwfBWuboR+tNXnRcKs5A+L5 6KYLeIQPr4jUqo5HrLhw2mV5WuR3GDz0Wl6Bn3g8F2FqvNhblwCa2Pz4SMgdayxcCHCkNHju9aC q0HsKb7xvcMQmjrUtC+RRxwdJagCV1cPK0zxpZRPIfn3waGLffVom1XZxzrS+PKxd4coWKVK6Sg InoK7jlRdlkULpWA+FQN8BOkAt0ksMghZx7YVtuHtA7czYJfd4Gz3dc1jxEc3nKtXZLxmDdPAEQ ujwygWwfMImgg8VxhzwAqtLRqJMg03/tfBk6gqYkjXiAcxl5TfE92/TQ== X-Received: by 2002:a05:6a00:3498:b0:842:2ddb:e303 with SMTP id d2e1a72fcca58-842b0d5736amr11055732b3a.12.1780800986372; Sat, 06 Jun 2026 19:56:26 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:26 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] ALSA: es1938: check control allocation before private data setup Date: Sun, 7 Jun 2026 10:56:09 +0800 Message-ID: <20260607025613.3604194-5-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_es1938_mixer() creates mixer controls with snd_ctl_new1() and then stores hardware-volume pointers and private_free hooks in the returned controls before calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation failure, so these setup writes can dereference NULL. Check the allocation result before using the control pointer. Signed-off-by: Ruoyu Wang --- sound/pci/es1938.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c index 280125eff3624..b6dcb721fffce 100644 --- a/sound/pci/es1938.c +++ b/sound/pci/es1938.c @@ -1655,6 +1655,8 @@ static int snd_es1938_mixer(struct es1938 *chip) for (idx =3D 0; idx < ARRAY_SIZE(snd_es1938_controls); idx++) { struct snd_kcontrol *kctl; kctl =3D snd_ctl_new1(&snd_es1938_controls[idx], chip); + if (!kctl) + return -ENOMEM; switch (idx) { case 0: chip->master_volume =3D kctl; --=20 2.34.1