From nobody Mon Jun 8 04:20:40 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DCE329B78F for ; Sun, 7 Jun 2026 02:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800986; cv=none; b=RM5BnUFFZzwXzaPq2q1izXJdxJLJYM9eB3uDpROgZsiG5O8QzViN8Co8grrJAXEVVVpkKOf6wXCTNftNxvIRFAqOv6OPVW9HfEwvcY4FptrJRcvZZB8kZsfysYam3pZpC4iQGYK94+YtEf7I3MD+izsiDnu8BgTcyWqIkeq9rxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800986; c=relaxed/simple; bh=yMliidOc4SYTz6EjHiB+7OyjASAJYmS6YxyC7Dm3wpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ENK15JHp3tojnS2Nto0JpInOuBZm4Ff64NrKqn5H7JK4a5dfOFUXLBmU2jJM1HMa+Dz1/vxdWDCjlHRXVPKp9Vx1pbvlIrU4Vpn0WiNmNrHHVJ0h/MKYJkQXNkGvZGQGE0nJD2t5OJhYyrpu1EQCsoAJ+RksaAxOn6Ud/chODY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JUKNt7iC; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JUKNt7iC" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c85ba774551so1158563a12.0 for ; Sat, 06 Jun 2026 19:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800984; x=1781405784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G6+J7iafV32jkmL+iFuv++231asfPIESh8re4lrLcCI=; b=JUKNt7iC9vOtUnkoklqZ5IEBRuhBWDU5eij1dtuna9eUtKFIn925RFvjGrEfSf3dae 8xJQBnoheKc2tGtdA/lGoOB4ymgGYS/BAKNGbC7Yzl0ryhGfNp3loWDzKtgvLMBRvRY4 IITJV+LZIbpnNsoxjKfMxdoX+30u32IzcpgxejBfF0dcLNnan70XHeUYOYAB6TxhZgMD CqYapD4dImvb+WZDaCvtwJdKbs4Y7TI6uGXPOqktJIV/OZhncfwSPyuxZ1Pmp1fsgIVt IVWHWbcinFRGAOt3cTssjT57BwD16FhNAkYvOUFRcmteHxqikzfk6vwc4PGR1rp4E1hX LSJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800984; x=1781405784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G6+J7iafV32jkmL+iFuv++231asfPIESh8re4lrLcCI=; b=JXc+RJbv66u955V2g/IJRfakN0GtxYw6uWjAQBRXwu82Hgqz//RdqBLwtu1jqH5OPf sGj6hrxo2RfqZVYnvWCqfXn+pQv9epjg0jX1QptnpcXApl/IRln4kcyAHxFozeG5uDym O+FPNfdOg1pyTxuRczxyXdfzvb1TrrEsUF8ItDI2zoVAqha4Wx2ZswHSPEMgafxdFSKV lc5e/dB+GIqWi6M1uOAwvoBb5X2Tlq6UgLETyf0x2fIm0UMXSg/dAo9wQaS68NiA6EtM cGk3rP7M/MbVScyvp9HEgo4UClu7LmV1T1LGrz4qq7DLTesqGbmFn1QEFvt8+7m+GOHz WrzQ== X-Forwarded-Encrypted: i=1; AFNElJ9bWwD/ZLX/i3CRD6qO35rkRNoyhzkB3lYuHrHW5QcSo+n1pk/soRWMeDzyuOUSG8vrALYU6zPh9dk+nig=@vger.kernel.org X-Gm-Message-State: AOJu0YxGkZ8M+0dYKqCy+rwODTLvoBwiuttibI27g8roKElEmJ2TUjAa CSq2Cm/rmzDwysIG+DtTlsFHG8DQmENAIwGvf1v823PBuAfjANbspBLI X-Gm-Gg: Acq92OG+BtbmpX2nJNJlajF6BO+34qE0dR+1oS09UJ/FPg6qSkttflq/8Rn6UWJcpTD +ycT+8KiFvueiyrRM1TmaaHN33W82fgKW/UVjTkbfl1KQV0d4Lb5nz7DwTu3qqmkiVgl24Wf5NW 8aqI25Mp/5TczezLkE/luPHBb8cIT//TxvThYwa30plQG7a5Nds576w2omXvxuLCeEHmfEHgeM0 5j8O+EwJAVGVsME8iWqgaYNQsZu92m22J7HtvJC/g3hD/g3N/NxC8hrG9Q86gPK7WvRIE29Y5Ox qBJTMTMJiQRbrdYqrwqYQ/TEgHcCQQmc7RNphSWwKobBqdX8fT0TytaesOSJTxrqP0A+tc1U9qm peyTefD0EqL9zLNi8+MHrThoXsbU0ty9H/3xXglmAs+UYavuYJL+50fHSlA8N5BIIDmbp4WCMbL S7kDpfRA5MeMFAYW3Rhw2zg4+4hZAJRE17haf8KesjTrENKCBV8cKFJOB8TFwJUZaS X-Received: by 2002:a05:6a00:2351:b0:842:569d:b105 with SMTP id d2e1a72fcca58-842b0f8bd8bmr11031999b3a.34.1780800984332; Sat, 06 Jun 2026 19:56:24 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:24 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] ALSA: cmipci: check S/PDIF control allocations Date: Sun, 7 Jun 2026 10:56:08 +0800 Message-ID: <20260607025613.3604194-4-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_cmipci_mixer_new() creates several S/PDIF controls and adjusts kctl->id.device before adding each control to the card. If snd_ctl_new1() returns NULL, the id update dereferences NULL before snd_ctl_add() can reject the missing control. Check each S/PDIF control allocation before setting the device id. Signed-off-by: Ruoyu Wang --- sound/pci/cmipci.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c index cd73b68336394..ff4bfbf94b81b 100644 --- a/sound/pci/cmipci.c +++ b/sound/pci/cmipci.c @@ -2637,16 +2637,22 @@ static int snd_cmipci_mixer_new(struct cmipci *cm, = int pcm_spdif_device) } if (cm->can_ac3_hw) { kctl =3D snd_ctl_new1(&snd_cmipci_spdif_default, cm); + if (!kctl) + return -ENOMEM; kctl->id.device =3D pcm_spdif_device; err =3D snd_ctl_add(card, kctl); if (err < 0) return err; kctl =3D snd_ctl_new1(&snd_cmipci_spdif_mask, cm); + if (!kctl) + return -ENOMEM; kctl->id.device =3D pcm_spdif_device; err =3D snd_ctl_add(card, kctl); if (err < 0) return err; kctl =3D snd_ctl_new1(&snd_cmipci_spdif_stream, cm); + if (!kctl) + return -ENOMEM; kctl->id.device =3D pcm_spdif_device; err =3D snd_ctl_add(card, kctl); if (err < 0) --=20 2.34.1