From nobody Mon Jun 8 04:20:40 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2112BE026 for ; Sun, 7 Jun 2026 02:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800988; cv=none; b=ggi+7qRiVAJsqMEUVQpX4KFrElOc2wnnlr08Brb98XNiJHxQVvNqpu9mtQQW5D6CDZ0mzS9jzH0isPU2tNh1QYJrpJsx+UbLIyjHXEHXVS/AyreyaZvRosPoetafwlNqMop3H73Y4aBAem34ofedB4TY7sgfbfuNedZFWR8bWU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800988; c=relaxed/simple; bh=3FY6//6vtzqAsSgqvpCX2ErIfWKrgV1zgXUi9lFNflM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j/l9um9ASKGByean9T/5iLKKavRkMZf6ljxrH3PNRkosHrH86N5TdFBjY9F7PO+aoOZdCtbpvC6a7itLrGdzAv7NfShH7LvmkmV9oKFXXHiwkg/Mmmht3e8G+Sc/Cg95WtdZGioCCX2N4gdsqhH4rTjGhiuz8D3HYHABvjUU1Vs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Neb6bpMj; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Neb6bpMj" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-84234c83142so1266221b3a.1 for ; Sat, 06 Jun 2026 19:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800982; x=1781405782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RK1DXif8zlv9vjcnsmYHU0gqic48XFb34G5wZ3YmXvY=; b=Neb6bpMjE6hZOqxWoAGb5t2RgkqHUfc/BixntcoiP1cOEW53YKz4h99sk3c2knCbtA 0kn4XpFB8QmVfhuflM126U74Z3tkc9XAKfRgYV406Y6dB9cWVaSAfFKJkRl9k5/dEVeP lnUk3dRQBmEzPHy281/PJxWj0dbUOe2gvo37zD6RjkyOWQGNQ4htwCnpRUTX0T48sCvf CdgWWxmu2FzBZUFLnZlGEwD2AgY+HqTxp+gRdBm51/kqM4MPYs13RupGtk47KNjvbPS0 5u8Rci49rMUVPkyjJkeSyIprCNLHK+iSvzYYk9wSXs993QlOy3zO4RFkN0VDIQnQGRhh 5Png== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800982; x=1781405782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RK1DXif8zlv9vjcnsmYHU0gqic48XFb34G5wZ3YmXvY=; b=fGkgiH+6iDizCGrqFz2s87U84phX7zz9m5vFsWbzGhLV2UvLCF/ix0+dk1t6hfOJzV vIkZXaYjQDvL2qkIwknxwMta1iiEmCGHFjbboXrJPGihK7uVpw7QvdKfmNuQIKGxvQSg 4IEJh0EgsRYLb6cU6MdyhE/iTmnV9lVO8rrdpnFDddCXwQBd08g/cVUPwdRModD9qeUM RZWivy6v/SS8RGOtdoFbiPtPI8j35zg9xtX4FbSWQMA7cHCRJbagFYIftqaqMg2TZEBG sbberBrb6au6IeJjN0SZ30ZvYF9tz/XY3xxUQghUPzgsuzl4fBfyHU7wUiwxmeSsTz53 g6tg== X-Forwarded-Encrypted: i=1; AFNElJ+CJBNmmwTXUKGxJgRVzTLhWTMlDVRRohjuWHY9Uie2TKBFWQ2H+ECUk46On4o/XkkL9X/TUTtKLlyubf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2i5yY+Y0TLalMWcExvp1cpEMq1EdTPV8Zz3rQcBzlMKCRh/yw HzB1FVJZnNm568MW+CNdTkIaajXLcnbDHsMxyFE06Ftq+misinMm9OHSVxH52KsaKK8= X-Gm-Gg: Acq92OFv0gv1rZ5wC/l/1Qx49oN0NTHLkFebpiXFzDmCzQgCYFvAAMINzmpMdqVSSPL tSUt7uxphFH128MM9abWVzdApKuEwE/fFL9SzdVu6wGm5G+57DOuRRyjlHwzmdUwYqWVfNvwqsZ jzAVCXu3TeyltNbG4kx0EuNgBQ2bFF6rDHsUsMQE0ZlkvPOHH2RTOJrDkmV7nA8CD/z0kAs7xWM dJzHEE5yLJTQPjtqaYzrvJIQ4ska31Qvkkf/jcOPZuMJNqogUTxKLIfDcrU9vstW/g3DBrb2tk/ OI/rs4wsHlbqCOH1xU6XJAnl4GRclZNNtO0Tf0j2d9Adh5VRZtb+DFHQ4Z2lxZ1HZHJeEfoHOsM RzlHZy0UMu8hg9wU4yLLKfve0G7D4sCee2hQLASTqsYxeiOjeF/7nFDVqnvpzdyZ769CxpNR53U 5OAawWaI92lhFafzDL3hW8aewuH4jz0o8+wvGwBPnO92GH/6RN7aEBa/+cDU07qxSo X-Received: by 2002:a05:6a00:bc93:b0:842:3ea1:5dd1 with SMTP id d2e1a72fcca58-842b0e65ae6mr10344606b3a.14.1780800982296; Sat, 06 Jun 2026 19:56:22 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:22 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] ALSA: gus: check PCM volume control allocation Date: Sun, 7 Jun 2026 10:56:07 +0800 Message-ID: <20260607025613.3604194-3-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_gf1_pcm_new() creates a PCM volume control and then updates kctl->id.index before adding it to the card. snd_ctl_new1() can return NULL on allocation failure, so the id update can dereference NULL before snd_ctl_add() can handle the error. Return -ENOMEM when the control allocation fails. Signed-off-by: Ruoyu Wang --- sound/isa/gus/gus_pcm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c index a0757e1ede465..08ccb4d80adeb 100644 --- a/sound/isa/gus/gus_pcm.c +++ b/sound/isa/gus/gus_pcm.c @@ -851,6 +851,8 @@ int snd_gf1_pcm_new(struct snd_gus_card *gus, int pcm_d= ev, int control_index) kctl =3D snd_ctl_new1(&snd_gf1_pcm_volume_control1, gus); else kctl =3D snd_ctl_new1(&snd_gf1_pcm_volume_control, gus); + if (!kctl) + return -ENOMEM; kctl->id.index =3D control_index; err =3D snd_ctl_add(card, kctl); if (err < 0) --=20 2.34.1