From nobody Mon Jun 8 04:24:53 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2A61C3F0C for ; Sun, 7 Jun 2026 02:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800982; cv=none; b=C4D0C7DYUnFyefBSCyxFA6q2qERZWR4Gjha7VFzW8es3dOOtSpE2WI3nGkwiacd4HEfAqfPgdXKoe/X/dnWIpWUyGmS8pLbVij44B7D9Jppb698z55ll29G733AbHt+YqaR1qwpV9UoSercpJTbMNyS73IGs9KBt6PXPg9aaTuQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780800982; c=relaxed/simple; bh=5FNcs3NDeL/k1dkL9t4e6Eufvj+YEVBpECCujAHf7wI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BIEcIK2+aA/OMnlBfN4DeealX8EHcjYz+ZTOxH3vRR3XBEG5IJ+CSqymXt5KgpIwSezIkIJ10oDtNg5GQE4bn9aDPCouwgxAb5bhDWvPn00NhfODyzQNYYmpmE40rXigwpL7dsl1GAGm50aZu5FRk+eJqowCcVXPN5F/LtXhu18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UX6pHDb/; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UX6pHDb/" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8423f52af13so2285197b3a.2 for ; Sat, 06 Jun 2026 19:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780800980; x=1781405780; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1zsXRaOf5IDmLbzd8Q02XPNAH+WfbkuUGmBr77tfIe4=; b=UX6pHDb/qyUwhdHF6HqqQ5QgCxjZwAaZv6zr7T09h7PwLnUt/9VbErSUcSKAvs7Q5e 9FJr3gWNvegeZ6bJ+1HcXwPe69PO/dhEYSVzxUD3Qjc8dKTaxMqADnNeFX1uYzRUYoGW lBWIaLtU2EG1ikawfEM8bdjuPcNHCNlYwEgqN0OC2Mpc4OB6LmxEuJyKpIRfWYeI5Wwl 5+39BgB1fubLPVrthHuXiO6dFMwOnJF3wxloi1hMkb+FQq9x7IhXvg7IT9qEMXTztBue 3ifvM78cBhTeQTVeiJvRlT/1/wbv7ppIBZ2zjKYGkcBEG82ub0cg47BJvc6Rug4HeKRN 9P6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780800980; x=1781405780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1zsXRaOf5IDmLbzd8Q02XPNAH+WfbkuUGmBr77tfIe4=; b=Rl13IrCWbJ6encMVym6OmKJKzzcVg5sxVva/OpC0dvQ7sbqmDTBZ08vrgcz5bnmgxI FrSTyd1PrsY20qrc+YtJMP5PSui+Y2H+Ds5N/YWp733wPQVC2fakzO5wV/hOGssyDe4x cYFOjGYJhMs2Rx0cis5ytWGat34yGzCDRTenfeOsUoBjpXhgLka7U3fqqegNlX/qV1yu UAMPO1MfR9wLyaQ9KSu0RjiC40NyZA81sXqiZ/3eY6SiMQO57COjrK3CdgFxiuAMfrH0 2tRADtkFAqZ788kWBLn7gLE7sLZioE+w7Z241nua0QHPtkb8IU50iHzWbRtJp1iGjgtr +RnA== X-Forwarded-Encrypted: i=1; AFNElJ8CceI50EQhAvFSmxKImBKmscPSQhcrKG3z+Ltg0n2UgbS69XKp+BTSAyY8xpZ6JgpZKX8XeTY/r4RNKSk=@vger.kernel.org X-Gm-Message-State: AOJu0YwjEmxbzn57rY9Zdbhe8TPBKxA62UwQql7tKZrfH92EwIgCMwI1 JUoFOcwe3RMBoRY0lMwBBQKA17yInjCk9PUzquE0Flmrf5RE0cJhrMqG X-Gm-Gg: Acq92OF5fWHkG2hFeT71u/qJK/sMuZ4XWna5V/nc3rVJD29lv8yRissE4zgNA1xyZwT Qfe3U5djMKbJMPBI1PpV8bxisRbEnIYirqUcMtVV90Ry0xpuGK//ILNzMYhmRaYzYK2qpCsSYUA yLPrb5kxm6MgUxqLlCnIKiRd/syenfFPdQl9e3++3WPueCpYDeN9g0/BgrHhCBYsTwtdveQQyNF v9O56vRRKmXemnxIuRUTv5Z4sSwFEY+Mh/jAJwFruP74y5s1PUiLKhbw+5UunQKi2qFFYuTw7Mp oc0GtV+eVOFMWk+c5mbG2G1ca3uJIJ6XDIkE9tmiplKL4pbBgd8WSQUo2k/7tMrLtZUCIBNRbC2 ZjfjSY3V2hC0sJTDwcCIeQPlSYQ5AmlnwPKiutKCYGbXG1TPe1hex7W0lxqGydp51h1f5vCC+Hq fgOwvXf9UKv+TmM4vrpiqI25wRqkg2nkPl0J+pVy+uIwGLkcOuGKMy2sgsddPSG/SL X-Received: by 2002:a05:6a00:9093:b0:827:3d52:5d1a with SMTP id d2e1a72fcca58-842b0a880f2mr10018534b3a.0.1780800980283; Sat, 06 Jun 2026 19:56:20 -0700 (PDT) Received: from haichao.tail057a43.ts.net ([2001:da8:e000:1206:967f:7ce4:ec98:f08b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84282918b8csm13034210b3a.57.2026.06.06.19.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 19:56:20 -0700 (PDT) From: Ruoyu Wang To: tiwai@suse.de Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Ruoyu Wang Subject: [PATCH] ALSA: es18xx: check control allocation before private data setup Date: Sun, 7 Jun 2026 10:56:06 +0800 Message-ID: <20260607025613.3604194-2-ruoyuw560@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260607025613.3604194-1-ruoyuw560@gmail.com> References: <20260607025613.3604194-1-ruoyuw560@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" snd_es18xx_mixer() creates controls with snd_ctl_new1() and then stores hardware-volume bookkeeping in the returned control before calling snd_ctl_add(). snd_ctl_new1() can return NULL on allocation failure, so those private_free writes can dereference NULL before snd_ctl_add() gets a chance to reject the missing control. Check the returned control pointers before using them and return -ENOMEM on allocation failure. Signed-off-by: Ruoyu Wang --- sound/isa/es18xx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c index 1da7b400a17b6..2f454f7797ce2 100644 --- a/sound/isa/es18xx.c +++ b/sound/isa/es18xx.c @@ -1762,6 +1762,8 @@ static int snd_es18xx_mixer(struct snd_card *card) for (idx =3D 0; idx < ARRAY_SIZE(snd_es18xx_base_controls); idx++) { struct snd_kcontrol *kctl; kctl =3D snd_ctl_new1(&snd_es18xx_base_controls[idx], chip); + if (!kctl) + return -ENOMEM; if (chip->caps & ES18XX_HWV) { switch (idx) { case 0: @@ -1823,6 +1825,8 @@ static int snd_es18xx_mixer(struct snd_card *card) for (idx =3D 0; idx < ARRAY_SIZE(snd_es18xx_hw_volume_controls); idx++) { struct snd_kcontrol *kctl; kctl =3D snd_ctl_new1(&snd_es18xx_hw_volume_controls[idx], chip); + if (!kctl) + return -ENOMEM; if (idx =3D=3D 0) chip->hw_volume =3D kctl; else --=20 2.34.1