From nobody Mon Jun 8 05:26:07 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB7E82E62B4 for ; Sat, 6 Jun 2026 19:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780775610; cv=none; b=IfbLYITrLquLAWx9Jyr7G4TkvMrSG2CpTmcxD8YRa6uRfyifaqZyeL71fOHib3HSplohiV2hROwBxPlRIA3uelvxje2sIJvXveWPaZbhXJcU/pxUMiwWJNZVnYs6sX0i9yScAuYdu8pnVcciCN4vvmQPGimhpQ7Xyw4PaXwdCyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780775610; c=relaxed/simple; bh=NOmkyLOtHGCGAiV3Q2Kg/w74+bfpjSnGE8ztZpylcxw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fUv9dsEtlTP/gvejyzEjLTGAmXoaiLilG0nrHG9PCf60RycQN5OI1Xg3RJwAoPv6/GptS+wppFORkleVCkz5GkMcbfX5eOiR16PD/1PmXHOSxATn7eJUWm7cZDCRAPxZnhYgUDU0jbFcuBO6+kMpD+bq/yHglmbFLxrmQGwsh6U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KFp5sFiW; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KFp5sFiW" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2bf114b0cf9so26391065ad.2 for ; Sat, 06 Jun 2026 12:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780775608; x=1781380408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aLuFO9ervNW12wtXreSvxfJ9xeEFmOpfhq9k0XskIhs=; b=KFp5sFiWxsVqsNyhbTl0XvY0R1f32zeRBDYZ9DaUjRJifpgmKzbpiPMehRL48XJOI6 CzTc238x2DUBxjddVR95YPPaapBcMt+eNkEURQ/IODDNiwWN8TKrHxp80df3goCgpyEZ b6l2ePxpwALwE5Y6oA604f7AcZEB+ekxnae8dgKIKYNL1rBOYYB2vmn9IbL4qySuJZde aUrvgIXIbcgynA5+XH/S1Q1h7r/wtlWgPzB8mg/6Mp95uhdIcBMPGU9g47pvAsZrZ6V6 BdGznUzoNeF5Au8DgrS7HU3PPCeTbpxEEvvFXde/Bh48Nsq+icKMsGP80ZHrF50/w0Ce eFxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780775608; x=1781380408; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aLuFO9ervNW12wtXreSvxfJ9xeEFmOpfhq9k0XskIhs=; b=otullAH0w3LzNksNY50Nun+iesVlQIfy+9RfrkPSRnVX5Cy/Wx2NXfqXdcA8TcDiwL +sVOpsbJ8jecjb5kqsTDzdYc2T6hqWQjt0ZdY01Qp98U/zT3WdFMiInVI92Iq7tHhLyW MmaiyVBCqYlvx16O2gdDpaCyZxoxPXiIxyCU+nKNY7H9rUUbWML+N6iH/GJYYenhvEr0 octnodlIN2X4y71bbK/qRd6SjwRPxCdzrkGe58PEwIP2NdAOc91379k6jJwiCXoHwek4 o/sqOzcE3ZBarm5L7tht6vlE9pSTgM4nApY3ouLpuWqCcDclF28tukdj0gy+w6xsxzJ2 hRxg== X-Forwarded-Encrypted: i=1; AFNElJ+jWxVvWeNAK+xklXMu+koFm5iv2ohYssIHMqEp1pRFfKuJUz1/xiIGTAIx7zAeR1MnecZMLcg3GBxWhs8=@vger.kernel.org X-Gm-Message-State: AOJu0YxCrsufoBVy2ox9nLpfWZX3wOlLANXfhd6wmhcPyn4E8xEaQ2/c 4yzFC8MHxM75axbwg7tNgaV8lfO4wvxco1goitvVEmXIKhvF9E59GEIb X-Gm-Gg: Acq92OHn9KfgM93f46p6ggTP0mxg975WtIl9Xjd2kejdcK0ej9bXzwyBr4XEaWpTa8n i0gRKEcyFmxX+AKZGj7TSnrvVsIFPnV4B4YtR78kMBvkf+M8wCmQH2gRZ7LEDob1OhXlz9D8ccy VEYDxXjO9qfPqsLBrPgBRTf8TP9GAhLY8zExxPEwdAojcDNGNCQgbINb/6gtyVXHKsrmStKRH2l gQm99D3eDo36c/WdKtF+TleRG/9aewlD0tVq8mrG4b9BkWfkDfAxZCrs9uSPY52HEmCfvQ5Iupk t9GpcIo75AvuokPyicYUNupmxsm2Fmy0Ht6xxkxzC2NfBrBb0yZPyjSotvYLUKciayca6LKHPZq U0WC1uYOoB9p5afuLl1eyMKxf02B9hef16Qnd0mDO5d1f8LuIaN6Rb7i/24DxmNXfzSrxAs5cWe uky+Ex9c2CU1WVMC4e/ABMYjbAGhHuGqxsep+jkhIEolL2tYdcv8aiq2Yo2W8fFKS5gawHR55+Q IS2mcULKcK44JUEAk/YvTg9PtzAr8Ja8MSsodImMqcXAnIllfpWxw== X-Received: by 2002:a17:902:ce8f:b0:2c0:cb0e:ac42 with SMTP id d9443c01a7336-2c1e80f9d2bmr101988635ad.3.1780775608225; Sat, 06 Jun 2026 12:53:28 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.. ([2409:40c1:400d:d07e:31c5:fce9:e168:2f2f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16649fcdfsm170405075ad.78.2026.06.06.12.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 12:53:27 -0700 (PDT) From: Piyush Patle To: dri-devel@lists.freedesktop.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: nxp-ptn3460: replace deprecated DRM_ERROR macros Date: Sun, 7 Jun 2026 01:23:11 +0530 Message-ID: <20260606195316.28048-1-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace DRM_ERROR() with device-aware equivalents throughout: - In bridge callbacks (pre_enable, edid_read, attach), use drm_err(bridge->dev, ...). - In i2c helpers (read_bytes, write_byte, select_edid), use dev_err(&ptn_bridge->client->dev, ...). - In probe context, use dev_err(dev, ...), consistent with existing error paths in the same function. The kmalloc() failure message in ptn3460_edid_read() is dropped as the allocator already reports OOM conditions. No functional changes. Signed-off-by: Piyush Patle --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/= nxp-ptn3460.c index 7acb11f16dc1..6f09c1247d7d 100644 --- a/drivers/gpu/drm/bridge/nxp-ptn3460.c +++ b/drivers/gpu/drm/bridge/nxp-ptn3460.c @@ -54,13 +54,15 @@ static int ptn3460_read_bytes(struct ptn3460_bridge *pt= n_bridge, char addr, =20 ret =3D i2c_master_send(ptn_bridge->client, &addr, 1); if (ret < 0) { - DRM_ERROR("Failed to send i2c command, ret=3D%d\n", ret); + dev_err(&ptn_bridge->client->dev, + "Failed to send i2c command, ret=3D%d\n", ret); return ret; } =20 ret =3D i2c_master_recv(ptn_bridge->client, buf, len); if (ret < 0) { - DRM_ERROR("Failed to recv i2c data, ret=3D%d\n", ret); + dev_err(&ptn_bridge->client->dev, + "Failed to recv i2c data, ret=3D%d\n", ret); return ret; } =20 @@ -78,7 +80,8 @@ static int ptn3460_write_byte(struct ptn3460_bridge *ptn_= bridge, char addr, =20 ret =3D i2c_master_send(ptn_bridge->client, buf, ARRAY_SIZE(buf)); if (ret < 0) { - DRM_ERROR("Failed to send i2c command, ret=3D%d\n", ret); + dev_err(&ptn_bridge->client->dev, + "Failed to send i2c command, ret=3D%d\n", ret); return ret; } =20 @@ -94,7 +97,8 @@ static int ptn3460_select_edid(struct ptn3460_bridge *ptn= _bridge) ret =3D ptn3460_write_byte(ptn_bridge, PTN3460_EDID_SRAM_LOAD_ADDR, ptn_bridge->edid_emulation); if (ret) { - DRM_ERROR("Failed to transfer EDID to sram, ret=3D%d\n", ret); + dev_err(&ptn_bridge->client->dev, + "Failed to transfer EDID to sram, ret=3D%d\n", ret); return ret; } =20 @@ -104,7 +108,8 @@ static int ptn3460_select_edid(struct ptn3460_bridge *p= tn_bridge) =20 ret =3D ptn3460_write_byte(ptn_bridge, PTN3460_EDID_EMULATION_ADDR, val); if (ret) { - DRM_ERROR("Failed to write EDID value, ret=3D%d\n", ret); + dev_err(&ptn_bridge->client->dev, + "Failed to write EDID value, ret=3D%d\n", ret); return ret; } =20 @@ -134,7 +139,7 @@ static void ptn3460_pre_enable(struct drm_bridge *bridg= e) =20 ret =3D ptn3460_select_edid(ptn_bridge); if (ret) - DRM_ERROR("Select EDID failed ret=3D%d\n", ret); + drm_err(bridge->dev, "Select EDID failed ret=3D%d\n", ret); =20 ptn_bridge->enabled =3D true; } @@ -166,10 +171,8 @@ static const struct drm_edid *ptn3460_edid_read(struct= drm_bridge *bridge, ptn3460_pre_enable(&ptn_bridge->bridge); =20 edid =3D kmalloc(EDID_LENGTH, GFP_KERNEL); - if (!edid) { - DRM_ERROR("Failed to allocate EDID\n"); + if (!edid) goto out; - } =20 ret =3D ptn3460_read_bytes(ptn_bridge, PTN3460_EDID_ADDR, edid, EDID_LENGTH); @@ -233,7 +236,7 @@ static int ptn3460_bridge_attach(struct drm_bridge *bri= dge, ret =3D drm_connector_init(bridge->dev, &ptn_bridge->connector, &ptn3460_connector_funcs, DRM_MODE_CONNECTOR_LVDS); if (ret) { - DRM_ERROR("Failed to initialize connector with drm\n"); + drm_err(bridge->dev, "Failed to initialize connector with drm\n"); return ret; } drm_connector_helper_add(&ptn_bridge->connector, @@ -289,7 +292,7 @@ static int ptn3460_probe(struct i2c_client *client) GPIOD_OUT_LOW); if (IS_ERR(ptn_bridge->gpio_rst_n)) { ret =3D PTR_ERR(ptn_bridge->gpio_rst_n); - DRM_ERROR("cannot get gpio_rst_n %d\n", ret); + dev_err(dev, "cannot get gpio_rst_n %d\n", ret); return ret; } =20 --=20 2.43.0