From nobody Mon Jun 8 05:25:25 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819CF4071DF for ; Sat, 6 Jun 2026 18:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780770060; cv=none; b=CX1uzdt5Atl4m6MZY3yXc6ju1BqnBdlSkeKiWsd6jHNzwr9Wkkcj0WXMo3A68VOXI0AJyqLE1gceY6FqQncAemwZm1LfV5DEfguxu+UmU4YqBQGa+7aAKPXlnULN8HNZpdiomsjRxRWlpULK7C5rtfvyeCaxnwaDesFPbUlP3ec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780770060; c=relaxed/simple; bh=7COHGLjoK8PPkZdBpu/eVjBmUD6WgEwJh4XLyik6RDM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pwQ3+AqTLYpsqLM28s3UYk4zrWFG0oUQR+7ADDv6zM2O8pyChhQJ5nfLs+1ERB/iY3Kfn76N6T4mgo780tNC2mQygPV+IL2eXaUYu0ZilAPvwVvN2RnceE4LGh0ZP+pJ5FPFloziND0/PWogKLuuX4NLQSZ3CEorwTNPgIUVkkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F0luaFK8; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F0luaFK8" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-6604df9ba4eso2918025d50.0 for ; Sat, 06 Jun 2026 11:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780770058; x=1781374858; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJOL2zax2/vKa/9X7CY1ut7CJvUgBTjHdNXtMjsKN14=; b=F0luaFK8l8JaGMxrAvzNZsbGa8x6NfSk1FRBy/KKT9HSghwGKY7CsAZZCjqud6tdUE rtjhyEqGdIPEot4DxfwemVb2l9F7UxDz5m3TZzP+JfD69TAzyon4LPk1JPeRhFXdqe1G nCyFydIFl4q7anwvvsUB3t2+ZlE9kmyhXixQ/ckoQzh3h0f4b8I5CmHyCBgoYb+0tE3c sR3eyghuCrkd5+6rQ1uxeYwMRMLRi39mJVS1BpyYXxj5fzxxjbOqss/x/OnCj5MDH4Te 8PwGyPJ+k0bunnSZXMrNmplrFhs7/7UE62gBxWM0VQlOGmf3d5eMkC+1bDhwrutPl5HF 0vXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780770058; x=1781374858; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AJOL2zax2/vKa/9X7CY1ut7CJvUgBTjHdNXtMjsKN14=; b=Hro0MfUWiBvOnzFgIx8EFOF21F4DoxZ0RrtS0zbz63CPaK7EiEuUUuBBB/PcEhGLai U98pFI7pLAB3Bgq8PuwI9ZnT80zoDxeI4vT9X/GllzlFNj5/SIXuYdh784w25M/ij9MI cApdMkkY0FthSN5mKAEwjEozUYKuGXLj6GUJQ/lEBcDzkcQL66+O+jXf/Kp+8cRbXIcD dJSnoxOXQzcUb8QdsHZr1BKGGvN5dJ/O06hcexbqPx6o4fJe9/m5r+YjQ9QCbCjf+POl oH5N8VluTiaEjhfrSYhQ6IeH+KIEa6rCoLdIvJvZtc702Xv9fRLK7Ibcwp78FXtwFkWy PeHQ== X-Forwarded-Encrypted: i=1; AFNElJ8xrx+4jttVbLXWTLSj14pjhq2rOWLe5K7tBgxMmUh7TKBNE4YYI62XGY+q+inirGk/tCMeTJ+lyh4txBY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5EfHjxq/MfqCZDW4R0ymizwSHo9NKokbBR1Kk0zyd1RRQnRAv 0rxx+NaCXgZTHLCdkSomk1rLDm/EZ8tW9+o465AwATrXIaFWXVuXRyv4 X-Gm-Gg: Acq92OGuvzk9bIfI+CfpBuOxrHS+cOClbhz34v8KktCdwF+cC82GOjWMU8ve/rVVD3w U836BAhXCOmCDGm7YSbjkRr/kR/Hua83RYWmLgeBn91Opf1vYBDGu3JQNd9StNuxxe+MW0hJFst VZmYk25HLDKsCLJ8irBl9LB7xRbKOGOzTThM0jmIul9uymPku0LO8+ymIWjg1QTnvrZIuHgo/Jo eHHCSl+gBMdCRZhgHLmznXTdOq5BCTGM8UOnmVunRDe1kArUV8ac4zvzIaTndXsLNkfjzrAKO5q M1R0gnInyNxLly5NOkHLaq+JerZCQ+qP/4YsywEl5CZ9dTFFWqxS9TqWIFYYW5oDC+zL53af+a0 nSB7b6Pc1aDnkysLCD5DN0M2VRRZ5ixIKBZC6Jna+d4Ki/AbGaIYw+CG3eAOtWJ+jrN2JoavYuY qj2qOg//OUE85RJJqIYqykAHlYBbdsOUZwAGoubpZDdYebUBckd2rir0bdMoo4EbRypHC4cvYZB Gs= X-Received: by 2002:a05:690e:169a:b0:65d:7de1:2fe1 with SMTP id 956f58d0204a3-6610a64da22mr5744260d50.10.1780770058349; Sat, 06 Jun 2026 11:20:58 -0700 (PDT) Received: from i-use-arch-btw (c-67-187-47-172.hsd1.ga.comcast.net. [67.187.47.172]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-660d5f441f8sm7151562d50.3.2026.06.06.11.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 11:20:57 -0700 (PDT) From: Maxwell Doose To: Christian Brauner , Al Viro Cc: Maxwell Doose , Jeff Layton , Jan Kara , Kees Cook , Mateusz Guzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] fs: efs: namei: Use __free() over manual resource management Date: Sat, 6 Jun 2026 13:18:58 -0500 Message-ID: <20260606181905.241793-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Define a __free() for brelse() called brelease. The current code uses manual management of the file buffer heads. Remove manual brelse statements and initialize bh with __free(brelease) which removes and modernizes code. Signed-off-by: Maxwell Doose --- fs/efs/namei.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/efs/namei.c b/fs/efs/namei.c index 38961ee1d1af..ce7794d55e47 100644 --- a/fs/efs/namei.c +++ b/fs/efs/namei.c @@ -8,15 +8,15 @@ */ =20 #include +#include #include #include #include "efs.h" =20 +DEFINE_FREE(brelease, struct buffer_head *, if (_T) brelse(_T)) =20 static efs_ino_t efs_find_entry(struct inode *inode, const char *name, int= len) { - struct buffer_head *bh; - int slot, namelen; char *nameptr; struct efs_dir *dirblock; @@ -30,7 +30,8 @@ static efs_ino_t efs_find_entry(struct inode *inode, cons= t char *name, int len) =20 for(block =3D 0; block < inode->i_blocks; block++) { =20 - bh =3D sb_bread(inode->i_sb, efs_bmap(inode, block)); + struct buffer_head *bh __free(brelease) =3D sb_bread(inode->i_sb, + bfs_bmap(inode, block)); if (!bh) { pr_err("%s(): failed to read dir block %d\n", __func__, block); @@ -41,7 +42,6 @@ static efs_ino_t efs_find_entry(struct inode *inode, cons= t char *name, int len) =20 if (be16_to_cpu(dirblock->magic) !=3D EFS_DIRBLK_MAGIC) { pr_err("%s(): invalid directory block\n", __func__); - brelse(bh); return 0; } =20 @@ -53,11 +53,9 @@ static efs_ino_t efs_find_entry(struct inode *inode, con= st char *name, int len) =20 if ((namelen =3D=3D len) && (!memcmp(name, nameptr, len))) { inodenum =3D be32_to_cpu(dirslot->inode); - brelse(bh); return inodenum; } } - brelse(bh); } return 0; } --=20 2.54.0