From nobody Mon Jun 8 06:38:45 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8810D318EF0 for ; Sat, 6 Jun 2026 09:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780738135; cv=none; b=WqurdKShrqKqAA//PGf/VYuwttMScOJjStez6baF5YLKSjcepf/QE+mlbuPUeDpcxXj8hQ81JV9TXrscUiNFCmre/+84y9OtC0yrjYjv+ES9awg8x5ENE07Q8/SBverc/578a5y1iHK764qLfaUkNlW/e+L+UcO+WBY2IaMVZG0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780738135; c=relaxed/simple; bh=AeLpxBAivccqYk14/n6xZcJ2Fnnbo21VpBoS40sPoaQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BahP2b1ChNFQkNNYVvOlQxKet9lyRCLpnQfvv9dpNbWKtBzRXiuRykepqA9+VRj0T1ogn6328jtPCGEcQpjyD2exeSQA/cWUkexLP1m2g7YcZXRzUXFulVMwP9akIuEV/2CMeTj1ZigZJUPS65NHfffusISOGx2xsYA8r0pq7xQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk; spf=none smtp.mailfrom=tumelty.co.uk; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b=btT9Pazl; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b="btT9Pazl" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4905529b933so27748315e9.0 for ; Sat, 06 Jun 2026 02:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tumelty-co-uk.20251104.gappssmtp.com; s=20251104; t=1780738132; x=1781342932; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=52D5Me9x0J5hn+BdfKj6pTEMPbVUH7bHHg17ADO+b/o=; b=btT9PazliD/q788Zr/3X6vcu0Lrc5b/70CNTm/kEb9TCQuAG3xrjvxUWkQAhGcgX7G HbtWtbmIq+HPxKAHiSXQwMlG2tdDsKlNoPsqWWKCXD9op+WvOnRpagqx7FpxbQLpxa5T IKDHEqaOh4BHIwQFElzXmd8QDQ0laA+EEMms1FE2t3GNSdicR+q8W5ZaDolHQqlvgGYu kYE4eyLwte2NsootTs81/V6LruV7KIRRq8t3xHKsCrQehzhnCCLnwV7XjSGXwrBykAgh KvrTmQGb1r5S3ZLDgDSM424M9t2Q8GhrbylSem5/1+gdhECihrr6VYo8Q2hR64Gu6ki3 mgdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780738132; x=1781342932; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=52D5Me9x0J5hn+BdfKj6pTEMPbVUH7bHHg17ADO+b/o=; b=liTPMAKTn/taXewB6KHYEMYhy/fWYGR68sjeBWwjIQFfmzqkmQgxowOe531TeqzUnV 868ZgaYoUDESUkYzO50MRn1ELmhfW+tG58pGxg0Slhhtv6nXMXFpfc+SOtjQqcvJSVLg l191DPTt/7O/i7Q1WvD88lNtWzRRcVI+ywtCziAtwGuB0qXRA2ZDOkmDnDjdrPOpa3WG LkhZgx4fwOMWeVK1ved65d83fb1yZbGsRR55WK+Mp0GmbuNH00MPTrICa+uH7xAb3BCs Z6wl9kA2ofKh0vq5sBOLNwY7f1FGRs0Dp6Ji4rfK6hJIF4IzLgZ0KIc3W4GZa3grQThk OXMA== X-Forwarded-Encrypted: i=1; AFNElJ+FJWhH4spvnwL7cgs+XFgH0k7evdwhIWgTTPpqzIZzXtENqe9Y8tcTNhUw1ADbKh4QWjUTGUyozo0A16s=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8R5h4u4qDZBKAbkVeXWwuQTTTdZKPB9eRNGkTfKHT7BYluZze Rfw/cP46zQDNzHdvyVc6Tuc401C3sfUgEbP8d/oG2ZdeKimHo9R488ONnuw8OaBEdwQ= X-Gm-Gg: Acq92OHAx852n9uPiWOwa62aoCwh9YZvtzEO81z/RfeQURIaY/J1NEmXwwjRotbfAt7 r5p3eVAaBqsFqaDgGvmJkHeU3rY9DJVnmQgXKjbBP0ITJqE/bRPkZ+EROPCQhhLWJGM/WlXChVA B4/TrKb0QavIKLbvot9ZZvwR03vFkXd9h7oNMbIG2KDhP8V6pBw51tl2/FrW6vW6VI4sfCvayID QuKUkOGsbRiMOThBuK/OwLP5+M7s3SO4sLWLH2LfNGgE58l+vDk6VgM0rrqU9ZSAcirEC3fv4aR JQ3nEWAoynrWVoxgVl+T2H7dwi923lvFmW+2AdjEELwz8JpDnQrM6RMyvNFtcFDC4Ajiq0M3Pqb VJYGPtEM/doLTDEmyfxj9fdwKbt7lPv3WWqZ6JIGnLtKGraGHzqBnCuwGKUNObSRYr2Ll745nt4 Q61BJ2/rkUulLSYYnwNLHxmQVl X-Received: by 2002:a05:600c:34cb:b0:48e:6db3:ff3a with SMTP id 5b1f17b1804b1-490c25b09a2mr124843875e9.16.1780738131894; Sat, 06 Jun 2026 02:28:51 -0700 (PDT) Received: from nixos ([83.217.168.175]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cc140sm266862195e9.9.2026.06.06.02.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 02:28:51 -0700 (PDT) From: Rhys Tumelty To: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: error27@gmail.com, sakari.ailus@linux.intel.com, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rhys Tumelty Subject: [PATCH v2] staging: media: atomisp: remove unused macros Date: Sat, 6 Jun 2026 10:28:42 +0100 Message-ID: <20260606092842.179826-1-rhys@tumelty.co.uk> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" removed unused macros across the atomisp driver that are defined in .c files, but never used, which was flagged as errors in a W=3D2 build, due to -Werror=3Dunused-macros. Signed-off-by: Rhys Tumelty --- .../media/atomisp/pci/atomisp_compat_css20.c | 3 --- .../media/atomisp/pci/atomisp_gmin_platform.c | 3 --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 7 ------- drivers/staging/media/atomisp/pci/mmu/isp_mmu.c | 14 -------------- .../atomisp/pci/runtime/inputfifo/src/inputfifo.c | 3 --- drivers/staging/media/atomisp/pci/sh_css.c | 3 --- drivers/staging/media/atomisp/pci/sh_css_hrt.c | 2 -- drivers/staging/media/atomisp/pci/sh_css_metrics.c | 6 ------ 8 files changed, 41 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/dri= vers/staging/media/atomisp/pci/atomisp_compat_css20.c index be5f37f4a6fd..95edc98137cc 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c @@ -28,9 +28,6 @@ #include #include =20 -/* Assume max number of ACC stages */ -#define MAX_ACC_STAGES 20 - /* Ideally, this should come from CSS headers */ #define NO_LINK -1 =20 diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/dr= ivers/staging/media/atomisp/pci/atomisp_gmin_platform.c index 4026e98c5845..0eafd81c44cd 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c @@ -48,7 +48,6 @@ enum clock_rate { /* TI SND9039 PMIC register set */ #define LDO9_REG 0x49 #define LDO10_REG 0x4a -#define LDO11_REG 0x4b =20 #define LDO_2P8V_ON 0x2f /* 0x2e selects 2.85V ... */ #define LDO_2P8V_OFF 0x2e /* ... bottom bit is "enabled" */ @@ -99,8 +98,6 @@ static struct gmin_subdev gmin_subdevs[MAX_SUBDEVS]; #define PMIC_ACPI_TI "INT33F5" /* Dollar Cove TI PMIC */ #define PMIC_ACPI_CRYSTALCOVE "INT33FD" /* Crystal Cove PMIC */ =20 -#define PMIC_PLATFORM_TI "intel_soc_pmic_chtdc_ti" - static enum { PMIC_UNSET =3D 0, PMIC_REGULATOR, diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 900a67552d6a..eaaa3753abf9 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -36,13 +36,6 @@ =20 #include "device_access.h" =20 -/* Timeouts to wait for all subdevs to be registered */ -#define SUBDEV_WAIT_TIMEOUT 50 /* ms */ -#define SUBDEV_WAIT_TIMEOUT_MAX_COUNT 40 /* up to 2 seconds */ - -/* G-Min addition: pull this in from intel_mid_pm.h */ -#define CSTATE_EXIT_LATENCY_C1 1 - /* cross component debug message flag */ int dbg_level; module_param(dbg_level, int, 0644); diff --git a/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c b/drivers/stag= ing/media/atomisp/pci/mmu/isp_mmu.c index 5193a7eb7d9f..6a8c5ba27b02 100644 --- a/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c +++ b/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c @@ -29,20 +29,6 @@ #include "atomisp_internal.h" #include "mmu/isp_mmu.h" =20 -/* - * 64-bit x86 processor physical address layout: - * 0 - 0x7fffffff DDR RAM (2GB) - * 0x80000000 - 0xffffffff MMIO (2GB) - * 0x100000000 - 0x3fffffffffff DDR RAM (64TB) - * So if the system has more than 2GB DDR memory, the lower 2GB occupies t= he - * physical address 0 - 0x7fffffff and the rest will start from 0x10000000= 0. - * We have to make sure memory is allocated from the lower 2GB for devices - * that are only 32-bit capable(e.g. the ISP MMU). - * - * For any confusion, contact bin.gao@intel.com. - */ -#define NR_PAGES_2GB (SZ_2G / PAGE_SIZE) - static void free_mmu_map(struct isp_mmu *mmu, unsigned int start_isp_virt, unsigned int end_isp_virt); =20 diff --git a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputf= ifo.c b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c index 8e1efeb6372c..b084f9edb8a7 100644 --- a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c +++ b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c @@ -10,9 +10,7 @@ =20 #include "device_access.h" =20 -#define __INLINE_SP__ #include "sp.h" -#define __INLINE_ISP__ #include "isp.h" #define __INLINE_IRQ__ #include "irq.h" @@ -21,7 +19,6 @@ =20 #define __INLINE_EVENT__ #include "event_fifo.h" -#define __INLINE_SP__ =20 #include "input_system.h" /* MIPI_PREDICTOR_NONE,... */ =20 diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 6cda5925fa45..ec3ff31f76e0 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -61,9 +61,6 @@ #include #include "timed_ctrl.h" #include "ia_css_inputfifo.h" -#define WITH_PC_MONITORING 0 - -#define SH_CSS_VIDEO_BUFFER_ALIGNMENT 0 =20 =20 #include "ia_css_spctrl.h" diff --git a/drivers/staging/media/atomisp/pci/sh_css_hrt.c b/drivers/stagi= ng/media/atomisp/pci/sh_css_hrt.c index d4633572f8f3..1ef95308bd48 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_hrt.c +++ b/drivers/staging/media/atomisp/pci/sh_css_hrt.c @@ -13,9 +13,7 @@ =20 #define __INLINE_EVENT__ #include "event_fifo.h" -#define __INLINE_SP__ #include "sp.h" -#define __INLINE_ISP__ #include "isp.h" #define __INLINE_IRQ__ #include "irq.h" diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/s= taging/media/atomisp/pci/sh_css_metrics.c index edf473dd86ca..24cdd52283ba 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c @@ -12,12 +12,6 @@ =20 #include "sh_css_internal.h" =20 -#define MULTIPLE_PCS 0 -#define SUSPEND 0 -#define NOF_PCS 1 -#define RESUME_MASK 0x8 -#define STOP_MASK 0x0 - static bool pc_histogram_enabled; static struct sh_css_pc_histogram *isp_histogram; static struct sh_css_pc_histogram *sp_histogram; --=20 2.54.0