From nobody Mon Jun 8 06:38:26 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9199309DAF for ; Sat, 6 Jun 2026 09:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780737306; cv=none; b=QRY4DmLyZwUS4vPrQl7mrSOiUe0Lxgp/G7wXQT05lNqQSAVAsEVQKAgzzuYld6ZflCsY0azSPrJhzN8kHU0vNVtDFKcO9qAm+1OAalXykxGa8f/5FsHE7uLhktma603b+L4IrPQV46UjcVlomYFgzuN1cyQENaauwt6TQaSOS6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780737306; c=relaxed/simple; bh=3DD+R5dXdV0xvgOADHGCoVe/Bk4bLeMnXVtz+j8KA6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YOe1ryXfJa03CA5AnaQBtZ6UofMje78h/xcvnX/f0XGBKsREVrgWJ/rkb+B5WZ8ruRUQQbrpjHv7Ai2S5hexhyFDUZEP/pkOv/LUiDyXjxbINuCsr5Nu3PYkABevBWoJujI17OZxGb7wJ/b9bD0HK0W0jBtV526zNESGpREZ66U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk; spf=none smtp.mailfrom=tumelty.co.uk; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b=Z8LOqnCd; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=tumelty.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tumelty-co-uk.20251104.gappssmtp.com header.i=@tumelty-co-uk.20251104.gappssmtp.com header.b="Z8LOqnCd" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-45eee266c6cso2148509f8f.1 for ; Sat, 06 Jun 2026 02:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tumelty-co-uk.20251104.gappssmtp.com; s=20251104; t=1780737303; x=1781342103; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ShTmIxiCeoztzE7vYVTgDeJwdRJNsPvn6jC9h7itjdE=; b=Z8LOqnCdnQEHDw5hfsTN4xhA1/1TG6DpGXtqGiuY5dhWWBUl+d60qdkZ80+YwwMbdk 74a7SSWi57rvMNezZ2hgFwC/cf4s4W/2qfxSh/Wpg9H6c+DB3XME2rV3E42YrfmMbA+A 5IVhL3rFI+Qr2Wm+g2SyyRbfRvbxmXo+7NqKjsyGH3QGRSM8vU++UU/jbam4DD3ta037 8yi0qxZSHM96Sf7qr3mA/A2YDsYPEOH3AQdKb5TvcbVoXedkp7WWBTCN/Ro04HuBelNd 2lqcOzsEgJD8bcMpwdo5fwjfd1Ek3n91B/7xuYspNcIuMXYjhmg4gvUTXYg8CHmURq3N U68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780737303; x=1781342103; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ShTmIxiCeoztzE7vYVTgDeJwdRJNsPvn6jC9h7itjdE=; b=NzfyqyRs+28V5YBacRAaPKCVlkBX1xDkhDEtvWzReMT/A4ySIEz7kUFJpO9pPbRwzo 4JqdBAUCTGcYVKitlznK7H27xUwpKJZ7DYF6XHixcj0j8mIdJWOZWu2/UA8m/kkrrIO3 3CU4kzOvpotTtCK5rW7l8UMhpmMzx1neyzmMIW+o19ro49BRNDsHgHkNy7YAZn3v5MKe mfybNMh+OL9hJYB+mvfxiprNS3t5iVhyP7ll7izmuQpG2OTlCueGTrHbTWagDYy5IEpK D2OWyTmbbfjrhNopRGHCIsfgmqE/BX1YoaMyvrtbAgEwefr4HSUTQHIHtV+dDDO4xbpx +hDw== X-Forwarded-Encrypted: i=1; AFNElJ9OnyIFEDeoFcXsEKowKMvMnu0flkCIjdRoziyjJ7xGzjGdXctrFkINImySYC8px0fasWjKpvXpB6cMWzo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa3pc11nG/DNIE4sqzFdkB16ShSn18Hb/c61QS+sm7NS2MB8FW BfZauJs2CitPf2+6s4F4W7nSjuNhL+FvlpUiZkUn5OvmF+FG3nHafXsga2LG+GgG1j0= X-Gm-Gg: Acq92OEZkDDFF3OWHr8EkJzTm7iGdp+Ms9aPMAMmZEON5fCFwuDqYr+Rp8GqgMHk9mT 5/OPHHbhZGDVdHswxUiHj55OX2tuxTHUg/yzEaLMyWo92+XuuLHvqNCNyzK/g/IvsvlSVCcPOOK j4OEGPpfX/UC70JyIgSoip8de7akkWEs7JgLdj+QEwsS/wgnPdMccidbx/7b7D+AX8uL7ueePfF y2dCJIFe76qxM64k6p63N7z7YKxZabYaHro77Kowrah0tk+Z3Udg5yPUGe7C0HcGP6lR/O4Cxf3 pmv332kH6CahN84WZRqbF/z5FsDY44klTMTLCvQFybcfTNx+D48TgxLQCjE+esuTa6ThRa8lq5x kR+PimeZascm+uVCbtZkpDBZfhMzPJ/mhEKNm37ck99gVHSfqOfs9uPdd28ewZYul3tWpOqMsvh NJRmP6KpovOdhqnmMquqVfKgya X-Received: by 2002:a05:6000:15d2:b0:45e:f228:830d with SMTP id ffacd0b85a97d-460305061f8mr7222115f8f.23.1780737303199; Sat, 06 Jun 2026 02:15:03 -0700 (PDT) Received: from nixos ([83.217.168.175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f360bd6sm35535783f8f.36.2026.06.06.02.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 02:15:02 -0700 (PDT) From: Rhys Tumelty To: hansg@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: sakari.ailus@linux.intel.com, andy@kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rhys Tumelty Subject: [PATCH] staging: media: atomisp: remove unused macros Date: Sat, 6 Jun 2026 10:14:47 +0100 Message-ID: <20260606091447.168262-1-rhys@tumelty.co.uk> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" removed unused macros across the atomisp driver that are defined in .c files, but never used, which was flagged as errors in a W=3D2 build, due to -Werror=3Dunused-macros. Signed-off-by: Rhys Tumelty --- .../media/atomisp/pci/atomisp_compat_css20.c | 3 --- .../media/atomisp/pci/atomisp_gmin_platform.c | 3 --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 7 ------- .../atomisp/pci/hive_isp_css_common/host/debug.c | 1 - drivers/staging/media/atomisp/pci/mmu/isp_mmu.c | 14 -------------- .../atomisp/pci/runtime/inputfifo/src/inputfifo.c | 3 --- drivers/staging/media/atomisp/pci/sh_css.c | 3 --- drivers/staging/media/atomisp/pci/sh_css_hrt.c | 2 -- drivers/staging/media/atomisp/pci/sh_css_metrics.c | 6 ------ 9 files changed, 42 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/dri= vers/staging/media/atomisp/pci/atomisp_compat_css20.c index be5f37f4a6fd..95edc98137cc 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c @@ -28,9 +28,6 @@ #include #include =20 -/* Assume max number of ACC stages */ -#define MAX_ACC_STAGES 20 - /* Ideally, this should come from CSS headers */ #define NO_LINK -1 =20 diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/dr= ivers/staging/media/atomisp/pci/atomisp_gmin_platform.c index 4026e98c5845..0eafd81c44cd 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c @@ -48,7 +48,6 @@ enum clock_rate { /* TI SND9039 PMIC register set */ #define LDO9_REG 0x49 #define LDO10_REG 0x4a -#define LDO11_REG 0x4b =20 #define LDO_2P8V_ON 0x2f /* 0x2e selects 2.85V ... */ #define LDO_2P8V_OFF 0x2e /* ... bottom bit is "enabled" */ @@ -99,8 +98,6 @@ static struct gmin_subdev gmin_subdevs[MAX_SUBDEVS]; #define PMIC_ACPI_TI "INT33F5" /* Dollar Cove TI PMIC */ #define PMIC_ACPI_CRYSTALCOVE "INT33FD" /* Crystal Cove PMIC */ =20 -#define PMIC_PLATFORM_TI "intel_soc_pmic_chtdc_ti" - static enum { PMIC_UNSET =3D 0, PMIC_REGULATOR, diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 900a67552d6a..eaaa3753abf9 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -36,13 +36,6 @@ =20 #include "device_access.h" =20 -/* Timeouts to wait for all subdevs to be registered */ -#define SUBDEV_WAIT_TIMEOUT 50 /* ms */ -#define SUBDEV_WAIT_TIMEOUT_MAX_COUNT 40 /* up to 2 seconds */ - -/* G-Min addition: pull this in from intel_mid_pm.h */ -#define CSTATE_EXIT_LATENCY_C1 1 - /* cross component debug message flag */ int dbg_level; module_param(dbg_level, int, 0644); diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/deb= ug.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c index 8513e78856b2..d05832e7f337 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/debug.c @@ -12,7 +12,6 @@ #include "debug_private.h" #endif /* __INLINE_DEBUG__ */ =20 -#define __INLINE_SP__ #include "sp.h" =20 #include "assert_support.h" diff --git a/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c b/drivers/stag= ing/media/atomisp/pci/mmu/isp_mmu.c index 5193a7eb7d9f..6a8c5ba27b02 100644 --- a/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c +++ b/drivers/staging/media/atomisp/pci/mmu/isp_mmu.c @@ -29,20 +29,6 @@ #include "atomisp_internal.h" #include "mmu/isp_mmu.h" =20 -/* - * 64-bit x86 processor physical address layout: - * 0 - 0x7fffffff DDR RAM (2GB) - * 0x80000000 - 0xffffffff MMIO (2GB) - * 0x100000000 - 0x3fffffffffff DDR RAM (64TB) - * So if the system has more than 2GB DDR memory, the lower 2GB occupies t= he - * physical address 0 - 0x7fffffff and the rest will start from 0x10000000= 0. - * We have to make sure memory is allocated from the lower 2GB for devices - * that are only 32-bit capable(e.g. the ISP MMU). - * - * For any confusion, contact bin.gao@intel.com. - */ -#define NR_PAGES_2GB (SZ_2G / PAGE_SIZE) - static void free_mmu_map(struct isp_mmu *mmu, unsigned int start_isp_virt, unsigned int end_isp_virt); =20 diff --git a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputf= ifo.c b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c index 8e1efeb6372c..b084f9edb8a7 100644 --- a/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c +++ b/drivers/staging/media/atomisp/pci/runtime/inputfifo/src/inputfifo.c @@ -10,9 +10,7 @@ =20 #include "device_access.h" =20 -#define __INLINE_SP__ #include "sp.h" -#define __INLINE_ISP__ #include "isp.h" #define __INLINE_IRQ__ #include "irq.h" @@ -21,7 +19,6 @@ =20 #define __INLINE_EVENT__ #include "event_fifo.h" -#define __INLINE_SP__ =20 #include "input_system.h" /* MIPI_PREDICTOR_NONE,... */ =20 diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 6cda5925fa45..ec3ff31f76e0 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -61,9 +61,6 @@ #include #include "timed_ctrl.h" #include "ia_css_inputfifo.h" -#define WITH_PC_MONITORING 0 - -#define SH_CSS_VIDEO_BUFFER_ALIGNMENT 0 =20 =20 #include "ia_css_spctrl.h" diff --git a/drivers/staging/media/atomisp/pci/sh_css_hrt.c b/drivers/stagi= ng/media/atomisp/pci/sh_css_hrt.c index d4633572f8f3..1ef95308bd48 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_hrt.c +++ b/drivers/staging/media/atomisp/pci/sh_css_hrt.c @@ -13,9 +13,7 @@ =20 #define __INLINE_EVENT__ #include "event_fifo.h" -#define __INLINE_SP__ #include "sp.h" -#define __INLINE_ISP__ #include "isp.h" #define __INLINE_IRQ__ #include "irq.h" diff --git a/drivers/staging/media/atomisp/pci/sh_css_metrics.c b/drivers/s= taging/media/atomisp/pci/sh_css_metrics.c index edf473dd86ca..24cdd52283ba 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_metrics.c +++ b/drivers/staging/media/atomisp/pci/sh_css_metrics.c @@ -12,12 +12,6 @@ =20 #include "sh_css_internal.h" =20 -#define MULTIPLE_PCS 0 -#define SUSPEND 0 -#define NOF_PCS 1 -#define RESUME_MASK 0x8 -#define STOP_MASK 0x0 - static bool pc_histogram_enabled; static struct sh_css_pc_histogram *isp_histogram; static struct sh_css_pc_histogram *sp_histogram; --=20 2.54.0