From nobody Mon Jun 8 06:36:13 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6861DE8AE for ; Sat, 6 Jun 2026 00:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780706690; cv=none; b=mElg1OcpfOnUvESYR789pQxq5ws46caKch5+2L2RIxOxf4io4DGJGZIBkIyodLLL+Q6QKSvvMEMFtY266SThrT/n28u0/G9KvjvwFyAvWFPOIsqFntXIKqrOZb1/ASHRb3TcU2TfRUc9+EhIHxiqNw05YF0OCnx+VTapbWD0aV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780706690; c=relaxed/simple; bh=dRZK27N2byQcY1LNOqt6bEGbXPueyY87I0cDb1bEmh4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D7KgIeV2sm+K8EfWHWVoGXbFfrsuzR4D15kUiPU8ZB9+nT6+SltiVecyeScBZ4EtXebYzTViJ+7dKDp8L6JfkvNsRX5wKKRqaFIRKqWQXOV4L3PigvxVbXXUYdBN97Cft3W52vHzJcu0BWZkQekLzAze1H2BBR+BtJmBrNatm7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f5/5M9I2; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5/5M9I2" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7dc93d02916so27593997b3.3 for ; Fri, 05 Jun 2026 17:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780706688; x=1781311488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kVxvw0FXwX0MOWo86WK/chtHgtRPUdaNPh5FdNMHb7M=; b=f5/5M9I2T2wHJqIH4UKikTHz4DNUjVtT0sizHNaq3w65CzSR3QI0X9rcDwvYsREgeW hcoJroCpaqNtS2xgySchbleiAYC/W7OOHITrCAGfrlENSeLEQgmpJdRlwa/2/PKJiPf6 RWUHzX8UK5T0gmlltMi+Jw54uEhL+0J8jAZ9gsIbaMot8c3kUjfxNlCcUFVIUYCqrdco 0VAG10MXFlnALmskIHM7eQZHItli+mi2jgkFz0CNd/zYnFQkS2zf+XZERv/Gm6igEDjF GMBf8pO5mv+z3bzQ3McqwZRx/bMQGkiSw15P8fsRXaRK3cu+AAizHtrzFeTxLyo4gVDX p64Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780706688; x=1781311488; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kVxvw0FXwX0MOWo86WK/chtHgtRPUdaNPh5FdNMHb7M=; b=DPLIVLGj2+k6rMyOXEKyqWLK5o8nmlxmkkXqu6OeHtpXtXaIiRfYBF2JIPUQGQQeaF Nt6dbyrjLFVXHmAbYeA0yFtME8H+hKtREb3rUR6W4W2zNhdPT/FX/ClCGwkdZ8ujGhk4 q9BrtPlfgJpp+Kz2exm4tm22x1ZkpEzNG3Oqly+cGiFA9ZZYiMTf0hPxO3+23qEzZm0i AveV4YwdzhEPeJ58UhOpiaCa20U0xL0y8sn8RKC/+m9N6O8Kj5GwvaysCwALg0lFnp9u OpilwWEEiMRMLrJ2jJqBPabTocdykqJIta6KP+MBemtMyYpUc4Skc5YBpJRiVN6DUsL5 trKg== X-Forwarded-Encrypted: i=1; AFNElJ9PXBPW1DHUExbHhkwo3fMa8FY6su1+vDc9ucfHianawGv1e2QTB6OVBkIJvrLwhquwxS+TJA4HGp+0GzI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9ZYZ+p/+Irfm3rccOjB+OP3A7nWgVRYV5z5iFO2mT2b9QiXuZ kZHm6ku+c/rp9HUhJK5Xp3QK4qkEeZASV4zEEg4n5MDxhPf3BHLx76jt X-Gm-Gg: Acq92OF37HqPRrZXHLOznETYC4E+gcMK0KhA6Yr1Pay57gy7GhPoVpQfvisSZCXVDi8 y6xqSItcFK9iERuqZas1fSokOP7yk8LiGhVxt8HbTGPj9cFMWxEuPdvjO6nsGmg47dG6Ce1qoAg 2EWZtlchxfHDCEalWO02sXoIf9UUGfPYJomYy0L3g0iRwC5GDm70AeEZGEqMAZV/DjYW2vnS1+c R5VG/X0p1KwFjbIcuz0dugJORy0Pts8KMUmS8JHcSR1TpNJcl4IQQmf0SOlSZynNjXsgA+5sQXS MomXuGWFflqGOAZBmbDkSuIxQi6HjB0d5iZqRqDgc34ihw0kcU9eOD4xt2B4KnEkax195Y2CpJ3 4qk6woQFjNWXg/dqw9bNmNnimFH/KrGJw87tp3o/hSvrzNSKyCcaKT9iAhHx0+SLU7JiOw7F0lj AoYvjPJVEJEs/B+zNPBLl+LI/iyQKKUJ0bzH0ALiMp4MNNAEJV8tyQLh3VQKvQgQ88iYjDQ+kf9 JI= X-Received: by 2002:a05:690c:a9d:b0:7ec:59e7:459d with SMTP id 00721157ae682-7ed0cee82bdmr62097807b3.37.1780706687989; Fri, 05 Jun 2026 17:44:47 -0700 (PDT) Received: from i-use-arch-btw (c-67-187-47-172.hsd1.ga.comcast.net. [67.187.47.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea2148b168sm58212937b3.14.2026.06.05.17.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 17:44:47 -0700 (PDT) From: Maxwell Doose To: jic23@kernel.org Cc: Maxwell Doose , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3] iio: chemical: scd30: Use devm_mutex_init() over non-devm mutex_init() Date: Fri, 5 Jun 2026 19:42:04 -0500 Message-ID: <20260606004203.158853-2-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The current code uses mutex_init() instead of devm_mutex_init(), which is incorrect as the rest of the file uses the devm automatic resource management API. Fix this so that the mutex is set up in the same way as the rest of the device data structure. Signed-off-by: Maxwell Doose Reviewed-by: Andy Shevchenko --- v3: - Return ret instead of -ENOMEM. drivers/iio/chemical/scd30_core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30= _core.c index db5cc295aeab..f1f2507c03b2 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -714,7 +714,10 @@ int scd30_probe(struct device *dev, int irq, const cha= r *name, void *priv, state->pressure_comp =3D SCD30_PRESSURE_COMP_DEFAULT; state->meas_interval =3D SCD30_MEAS_INTERVAL_DEFAULT; state->command =3D command; - mutex_init(&state->lock); + ret =3D devm_mutex_init(dev, &state->lock); + if (ret) + return ret; + init_completion(&state->meas_ready); =20 dev_set_drvdata(dev, indio_dev); --=20 2.54.0