From nobody Mon Jun 8 06:36:24 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE411246782; Fri, 5 Jun 2026 23:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703493; cv=none; b=EBvKMysf5xgQZeeefRrQIiL61/jrJcrtkddewabGQTszMswUPKTEiV+bLHh4Big8AyB1Fz5QnrNQxEkrAkPka1G71dBe7KV4bWMNr7+T1a0t5o4uVe/IrmcVkFy4XE7cGgY7cg7GHcejHodXLq86F3XXiWcF1haaPxi+z4V+FEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703493; c=relaxed/simple; bh=qa3ZWWBQ2o3s9ahDXB5YmZfH2t0BKM1dpi9Ny4l5HO4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BZ34sGw6BhqpHCF5T9oR0tMwb8Wtp/pcbxvdPtWNRAU3TzI+KpnBuvhIbHC9DUTEjR6WgLL7XzM7bFW3FW91IPqi9mQPcCJOZTtlWbJA4Ir87xtL41JF8MdZ6EFcn2b9fFrR1hsvoq5usyV9uLSG8cIVcuHshWd+BTQsiJZJims= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OQaHM8WR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OQaHM8WR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53A501F00898; Fri, 5 Jun 2026 23:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780703492; bh=l4CVvZgRR1gb6eF3OEOwj8fb+3rz4r90kPcbC/vfZuE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=OQaHM8WRg5xUh7FippfWT+U4vfk8IwMhnGwtTmeZG8Zowq3qgL+RcsU7qHls26JXM qWEf2DXDblLM5WQGZUhXSQSjKBv0ZGWdQMajkCwkAS8JUP9abOOdkhvUIHzyVxoPF2 Fj5bDEzSPLn5m0wXsV5gseHCAKrxCZMZpKPulJaNLhkTwCEUTLNt0+rjZ0ngHc5QJI v/qUhmJDB9EhDY/XO0lIVknWM9j8c1QxQYaOZ+8iIeEh4KdyV1mmk9f1572ha/S+rx uCGIqhlyTCJPhi4HhvSnLw+zzYkgX/UIfj6yIsr/Mu49PClPQlhJje3ZYsNggG3gDU cnzgbqPS++2tQ== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH v2 1/4] perf timechart: Release event samples at the end Date: Fri, 5 Jun 2026 16:51:28 -0700 Message-ID: <20260605235131.2440270-2-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605235131.2440270-1-namhyung@kernel.org> References: <20260605235131.2440270-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add timechart__release() to free all data structures added during the sample processing. Signed-off-by: Namhyung Kim --- tools/perf/builtin-timechart.c | 68 ++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 04dbb944a42720b4..27d17268395ed760 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1548,6 +1548,73 @@ static void write_svg_file(struct timechart *tchart,= const char *filename) svg_close(); } =20 +static void timechart__release(struct timechart *tchart) +{ + struct per_pid *p =3D tchart->all_data; + struct power_event *pwr =3D tchart->power_events; + struct wake_event *we =3D tchart->wake_events; + + while (p) { + struct per_pid *next_pid =3D p->next; + struct per_pidcomm *c =3D p->all; + + while (c) { + struct per_pidcomm *next_comm =3D c->next; + struct cpu_sample *cs =3D c->samples; + struct io_sample *ios =3D c->io_samples; + + while (cs) { + struct cpu_sample *next =3D cs->next; + + zfree(&cs->backtrace); + cs->next =3D NULL; + free(cs); + + cs =3D next; + } + + while (ios) { + struct io_sample *next =3D ios->next; + + ios->next =3D NULL; + free(ios); + + ios =3D next; + } + + zfree(&c->comm); + c->next =3D NULL; + free(c); + + c =3D next_comm; + } + + p->next =3D NULL; + free(p); + + p =3D next_pid; + } + + while (pwr) { + struct power_event *next =3D pwr->next; + + pwr->next =3D NULL; + free(pwr); + + pwr =3D next; + } + + while (we) { + struct wake_event *next =3D we->next; + + zfree(&we->backtrace); + we->next =3D NULL; + free(we); + + we =3D next; + } +} + static int process_header(struct perf_file_section *section __maybe_unused, struct perf_header *ph, int feat, @@ -2079,6 +2146,7 @@ int cmd_timechart(int argc, const char **argv) =20 ret =3D __cmd_timechart(&tchart, output_name); out: + timechart__release(&tchart); zfree(&cpus_cstate_start_times); zfree(&cpus_cstate_state); zfree(&cpus_pstate_start_times); --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:24 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42D9E30BBB9; Fri, 5 Jun 2026 23:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703494; cv=none; b=toWW8TXl+nzG9akH1RRWS+gyeM9j2z6kRQhjlyxRs++s5zY48l9kVIuX6RGzP4WkaVOIhEsCF5LEQaIODzqwJCgSyqw+0HpMHyLNZ0rIZ2jj9jGzln0lSuO0nxDYX7qS4yIiiJU4N+GcIEhGmqdO/MNZhHLV6M9pp6szZxjJ6t0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703494; c=relaxed/simple; bh=a2UYEhuEvWJ/JEF/kW1P1dd0ZjwgDyUXGOvPckwwzN0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P+5Ge4w8Tf9VF1x75R11gY2UR79QyuWRj/9PIa7Rb6K3tMq5MgqRIR9KBadYckR6vVwP5atXWpbM8Z9J1DICJSNMuagMHoD5m9fh0BZLorQoS6lBMzlye+9fpjHB5VH0cy4hcBpW+FJMqxYF3j+9eN63H/J9c6qr1qZVlKh8sFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QSyyjuLr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QSyyjuLr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B730B1F0089A; Fri, 5 Jun 2026 23:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780703493; bh=FSIDH5ze8xd03i1gbY7CFmVriqWx9rWe6/9QW2Pwny0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=QSyyjuLr37mMAZHBvBuFiYxDb0oXSzas7HZkuWTydJa2ZnK7y/JWvo6tdREb3KnxS ZmXR8OhYyu8WuEFM35FjUfP801aFPgF1AZ4iulO4t2earV+8QXbKWN1R5uWR0K4aI8 KyTbswnQ30UAb9ZYZIWaLYP0huCKQD2zSooStn5vrSwY4FBpjCi2bnx4b2h7mlxWP+ 2Z6gBoub7kbhX+Gggpdiet9umUuU8sSfJr5qIQTgNNtJbZ2TxWLyyR5OwhVlIjN2mw Me8pDYI+MvFm8jKuY39wvUSvzCBTvssdGfwpn9fgzpE/3teeMkkaofcrQVO1uYFzWY +pBhVRaOdgvUg== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH v2 2/4] perf timechart: Fix memory leaks during record Date: Fri, 5 Jun 2026 16:51:29 -0700 Message-ID: <20260605235131.2440270-3-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605235131.2440270-1-namhyung@kernel.org> References: <20260605235131.2440270-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The command line options can be passed without copy as their lifetime is limited within the same function. Signed-off-by: Namhyung Kim --- tools/perf/builtin-timechart.c | 31 ++++++++++++++++++++----------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 27d17268395ed760..a73f0ab22fd64241 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1834,6 +1834,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ "syscalls:sys_exit_select", }; unsigned int poll_events_nr =3D ARRAY_SIZE(poll_events); + int ret; =20 rec_argc =3D common_args_nr + disk_events_nr * 4 + @@ -1852,7 +1853,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ =20 p =3D rec_argv; for (i =3D 0; i < common_args_nr; i++) - *p++ =3D strdup(common_args[i]); + *p++ =3D common_args[i]; =20 for (i =3D 0; i < disk_events_nr; i++) { if (!is_valid_tracepoint(disk_events[i])) { @@ -1861,7 +1862,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(disk_events[i]); + *p++ =3D disk_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1872,7 +1873,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(net_events[i]); + *p++ =3D net_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1883,7 +1884,7 @@ static int timechart__io_record(int argc, const char = **argv, const char *output_ } =20 *p++ =3D "-e"; - *p++ =3D strdup(poll_events[i]); + *p++ =3D poll_events[i]; *p++ =3D "--filter"; *p++ =3D filter; } @@ -1891,7 +1892,11 @@ static int timechart__io_record(int argc, const char= **argv, const char *output_ for (i =3D 0; i < (unsigned int)argc; i++) *p++ =3D argv[i]; =20 - return cmd_record(rec_argc, rec_argv); + ret =3D cmd_record(rec_argc, rec_argv); + + free(rec_argv); + free(filter); + return ret; } =20 =20 @@ -1902,6 +1907,7 @@ static int timechart__record(struct timechart *tchart= , int argc, const char **ar const char **rec_argv; const char **p; unsigned int record_elems; + int ret; =20 const char * const common_args[] =3D { "record", "-a", "-R", "-c", "1", "-o", output_data, @@ -1966,24 +1972,27 @@ static int timechart__record(struct timechart *tcha= rt, int argc, const char **ar =20 p =3D rec_argv; for (i =3D 0; i < common_args_nr; i++) - *p++ =3D strdup(common_args[i]); + *p++ =3D common_args[i]; =20 for (i =3D 0; i < backtrace_args_no; i++) - *p++ =3D strdup(backtrace_args[i]); + *p++ =3D backtrace_args[i]; =20 for (i =3D 0; i < tasks_args_nr; i++) - *p++ =3D strdup(tasks_args[i]); + *p++ =3D tasks_args[i]; =20 for (i =3D 0; i < power_args_nr; i++) - *p++ =3D strdup(power_args[i]); + *p++ =3D power_args[i]; =20 for (i =3D 0; i < old_power_args_nr; i++) - *p++ =3D strdup(old_power_args[i]); + *p++ =3D old_power_args[i]; =20 for (j =3D 0; j < (unsigned int)argc; j++) *p++ =3D argv[j]; =20 - return cmd_record(rec_argc, rec_argv); + ret =3D cmd_record(rec_argc, rec_argv); + + free(rec_argv); + return ret; } =20 static int --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:24 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD1136F903; Fri, 5 Jun 2026 23:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703494; cv=none; b=ghSCL5kWWFdNfDlELajEMSlIznn++UrnJ2AsqpkPj7oyX8tozEDhq3xH5NjoJSGxDpx8sLULH0SxqaRq/i99MbYm/95MvlXtSzy9XrO8RCb3NPihLLs8Ycx/XAhGDQb7CF2Trfg7VQt+T9ihmKEHNuIG/yG3sEZN1gstz4Jey4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703494; c=relaxed/simple; bh=pb/LBh5xXsHZVp2i+HG5TnZasum53aJ6yY1408iX7sM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hC/8lFrMUTy9ZEp4tFgdhDXpIwMgjRFdWhr6Le7D2KsmQ10YE3d6kqk5Y8XXWHUhxqWbc4J0BfAf4GZ+rZS+M15Fr8Jw4K+hIrmRcXD1N1pel1VeiwY0hYMcqylaSFvmS34HGEIXSD56ye5zmk+ziAh3XTk1nQGEwoFo/yYT2Gc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jWGkb0pS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jWGkb0pS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 271151F0089B; Fri, 5 Jun 2026 23:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780703493; bh=wZQaDS0K02xGerco7f1cxzy/n2Ou+5DVBEqgxI0HPeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jWGkb0pSCY7upgHxkvX8VbInLupjms3YNCgienIoBpaEo0e3VUPLCiq0U29+Azijp UlYdFnyNAHfIoIUMbPiFLtJjd7rYHu/3uFNeda6cG1ThFNpvjxGgfT2gY8kgc++X4/ lc6cNun3SGevuHSGn09zuzdkhieBsWrfYls+cx5faS73KhrL89xhce5st0y/+i8VSt pEp5RfNYvdn7tC6tdaqkrTNpGNrFVftSZvIEAs+esZuhdyEQz+5Tg+ua15b2DTD5BP 9Ol3Gs5357iaTjVHXnRjttoHT8lVvn61WZ8q/OildwGpcmPDzzLtnNNTx3nsZBbHye Mz/tBI/s5Y7Uw== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH v2 3/4] perf timechart: Fix memory leaks in draw_wakeups() Date: Fri, 5 Jun 2026 16:51:30 -0700 Message-ID: <20260605235131.2440270-4-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605235131.2440270-1-namhyung@kernel.org> References: <20260605235131.2440270-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The second loop for per_pidcommd is meaningful only when it doesn't have from and to tasks. Also make sure c->Y is set before copying the comm string otherwise it will be overwritten by next one. Signed-off-by: Namhyung Kim --- tools/perf/builtin-timechart.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index a73f0ab22fd64241..3f9153d5ecfb79b0 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1110,12 +1110,12 @@ static void draw_wakeups(struct timechart *tchart) c =3D c->next; } c =3D p->all; - while (c) { - if (p->pid =3D=3D we->waker && !from) { + while (c && (!from || !to)) { + if (c->Y && p->pid =3D=3D we->waker && !from) { from =3D c->Y; task_from =3D strdup(c->comm); } - if (p->pid =3D=3D we->wakee && !to) { + if (c->Y && p->pid =3D=3D we->wakee && !to) { to =3D c->Y; task_to =3D strdup(c->comm); } --=20 2.54.0.1032.g2f8565e1d1-goog From nobody Mon Jun 8 06:36:24 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1F7B3D3D18; Fri, 5 Jun 2026 23:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703495; cv=none; b=IaspjOqofc0cSZfQPpWNoTICq9K8AlgS1DJ2I+5afFpbLl4l9BWohHLYDPkj3OECvDls2fbVIKPV/Vb9hzUgU4DEFBmjaW+XDGLdKw7ygSKvTgSNJK2Ymv+s/Yxyau1a6YLfyXr4pGGSgsqdvIfXv+Lzuo7wutJQxsdviEdaGLU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780703495; c=relaxed/simple; bh=z3w19A16NH7NdvirA4opVoS2O6lRMszvIMrx9KkbOWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UDu3I/HAfFrzAfYwWIGMRtEK1D15q/FlWfeqEkP7g/anGfa6GvL81u+VfxPY1XQ7U2V2B6OjQpRQr7flbdKyiogqNX8I1t02DbBq0yE1aSLDflzpmAhYugz+z/2LlalZlzhJLEmpjz45xT9mfE82QT0Gqq2RdV1pzkio1H8NhTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GN86kGCn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GN86kGCn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 890081F00893; Fri, 5 Jun 2026 23:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780703493; bh=/4otRSM6EtEjjXJGLXf1QzGjALVdbnQQ4hssMzx/+os=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=GN86kGCngdA1o6G5qvFsj7DCPeUOEFtkz4onntOHjIx4/WP6aTLvSjoDOKNQ/oAOy cQ9bglKqpTz1khokmmYyCKpNJV84qNCud5Qh7CZwvpl05yvHpL1FOduTO5lfsbWTAR d1uzC3VkvJZVBsnS/DAOM3ahPocl80wg6LbfYk3D1wqicSKiswJge1n/+jAtpfXGiy Lhn6Y7JZ3xAYdCjEHrs0Wcw/Zf7HTjKkBY3cPkLClJj1BekmgNlG1C+Chc5rDnhWix o/1R87GL996BiuMolWpwMffjtfK26znspW+q988/Datp1v+yFy2SlgMmXWNW6Zj7CJ sZLkkp68FCa8g== From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ian Rogers , Jiri Olsa , Adrian Hunter , James Clark , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH v2 4/4] perf test: Update perf timechart test Date: Fri, 5 Jun 2026 16:51:31 -0700 Message-ID: <20260605235131.2440270-5-namhyung@kernel.org> X-Mailer: git-send-email 2.54.0.1032.g2f8565e1d1-goog In-Reply-To: <20260605235131.2440270-1-namhyung@kernel.org> References: <20260605235131.2440270-1-namhyung@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To include IO-only and backtrace modes to test different code paths. $ sudo perf test -vv timechart 135: perf timechart tests : Running 135: perf timechart tests: ---- start ---- test child forked, pid 2413665 perf timechart Basic test perf timechart Basic test [Success] perf timechart IO-only test perf timechart IO-only test [Success] perf timechart Backtrace test perf timechart Backtrace test [Success] ---- end(0) ---- 135: perf timechart tests : Ok =3D=3D=3D Test Summary =3D=3D=3D Passed main tests : 1 Passed subtests : 0 Skipped tests : 0 Failed tests : 0 Signed-off-by: Namhyung Kim --- tools/perf/tests/shell/timechart.sh | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/tools/perf/tests/shell/timechart.sh b/tools/perf/tests/shell/t= imechart.sh index b14b3472c2846b32..40072b32171a9a1c 100755 --- a/tools/perf/tests/shell/timechart.sh +++ b/tools/perf/tests/shell/timechart.sh @@ -9,7 +9,7 @@ perfdata=3D$(mktemp /tmp/__perf_timechart_test.perf.data.XX= XXX) output=3D$(mktemp /tmp/__perf_timechart_test.output.XXXXX.svg) =20 cleanup() { - rm -f "${perfdata}" + rm -f "${perfdata}"* rm -f "${output}" trap - EXIT TERM INT } @@ -22,38 +22,41 @@ trap_cleanup() { trap trap_cleanup EXIT TERM INT =20 test_timechart() { - echo "Basic perf timechart test" + NAME=3D$1 + OPTION=3D$2 + + echo "perf timechart ${NAME} test" =20 # Try to record timechart data. # perf timechart record uses system-wide recording and specific tracepoin= ts. # If it fails (e.g. permissions, missing tracepoints), skip the test. - if ! perf timechart record -o "${perfdata}" true > /dev/null 2>&1; then - echo "Basic perf timechart test [Skipped: perf timechart record failed (= permissions/events?)]" + if ! perf timechart record -o "${perfdata}" ${OPTION} true > /dev/null 2>= &1; then + echo "perf timechart ${NAME} test [Skipped: perf timechart record failed= (permissions/events?)]" return fi =20 # Generate the timechart if ! perf timechart -i "${perfdata}" -o "${output}" > /dev/null 2>&1; then - echo "Basic perf timechart test [Failed: perf timechart command failed]" + echo "perf timechart ${NAME} test [Failed: perf timechart command failed= ]" err=3D1 return fi =20 # Check if output file exists and is not empty if [ ! -s "${output}" ]; then - echo "Basic perf timechart test [Failed: output file is empty or missing= ]" + echo "perf timechart ${NAME} test [Failed: output file is empty or missi= ng]" err=3D1 return fi =20 # Check if it looks like an SVG if ! grep -q "svg" "${output}"; then - echo "Basic perf timechart test [Failed: output doesn't look like SVG]" + echo "perf timechart ${NAME} test [Failed: output doesn't look like SVG]" err=3D1 return fi =20 - echo "Basic perf timechart test [Success]" + echo "perf timechart ${NAME} test [Success]" } =20 if ! perf check feature -q libtraceevent ; then @@ -62,6 +65,9 @@ if ! perf check feature -q libtraceevent ; then exit 2 fi =20 -test_timechart +test_timechart "Basic" "" +test_timechart "IO-only" "-I" +test_timechart "Backtrace" "-g" + cleanup exit $err --=20 2.54.0.1032.g2f8565e1d1-goog