From nobody Mon Jun 8 06:36:41 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D8A63E1216 for ; Fri, 5 Jun 2026 20:05:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780689915; cv=none; b=WXqTZCWtdbJe6UFcY8LydcUeKhtYTk8psjRYai9/oLMJqGTb89VmgquCWz/i+2nUtCcEwMUlp2Izzu/xJEhU72pur8vcLHGP5bHZ/wbqrrBKSUswgxNv9OKDZ6JwnGfEXWq8GwvEOEZTOrckeX4zS6XXY3iUUY53nRQRMbQfIx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780689915; c=relaxed/simple; bh=Rk7IOlpOOQz6Wbk1TWfaxd5Da5lG4fM7Elqv7xX7BUo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GT3NTzw18no4h2asRfTrqv52bFDf3znumBlvmt2edLk9y9a3NM6s2yfh3jzcGyMvRfrz9iopTsb1PJfE4AOkWS+mHYRNvTub8IicmK9iEtAi5x63m38Znx0Ojbdqzw+lN7w0W0Aqipz3WWfQCzCoHSrdmaLRM3A9U/0M6V1edRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o1fRcs8b; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o1fRcs8b" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-36bcf3d2565so1744386a91.3 for ; Fri, 05 Jun 2026 13:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780689912; x=1781294712; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dNbRJmCRrzBsFXYqrB+uWE+oQVCCDNWPcO6WRGR2yX4=; b=o1fRcs8bK1V/KVutBpZ6hFutcoZzpjNFUbu+mgxAgWR5Wf7IlwKIlu1/Fs62oOwQRN Iw6TixiYFMlg7u9pNM4JYlnzqElnzo0EjMZ5AQ19rUo5odiiw79ntDjaNV5G0RCl+vI9 t5oUO7EhyB+AgHqwaY7QoAroOW1aVzjqvBIfL27S1D1Ajh+W0uRKS/XLK/o63K71oicV kJhVvCeJ1dvndGAWx2gHiktcmtyqixVNDllmqr1pY/XKs7Pe1dR+d8KV7Pw6QMEiI9hz Ay65E9hcxTlSSHLLS6iMM311lFx/oFQWhn0SPI11vbWWgvPo/IT5gKP+gyyj1vh81CSW MJ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780689912; x=1781294712; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dNbRJmCRrzBsFXYqrB+uWE+oQVCCDNWPcO6WRGR2yX4=; b=JO4wpFxZP88TT5YKoD1pN1DdqPUfschrc2FK+oyB/kpr1eG0H1irvSTiz15/w/Xcbk DsL9Mh3I4CSO9zOVxnU72MWQ3YGF/ochsaATktpj/Lw051e423HEJ7p1IOMv1noNvOKW dvOduBQkjdjH05xZPVcuEisMvXSDKy8CFQCF63a+uGY9rz4PvpS8zv+Pew9omxdD/ivU 4QlQGuRsIT5Yu/VJ6LNHceTRFaj6lZpsKiGHt0oetcBameyDXhdirTclK9FunG3ggkO2 1op0iVHc147Q8U86/N/4PsyBw8moSMwgK0RfwODajfG5X0icMRpk8/KGkleAZyy1SE0d VWqA== X-Forwarded-Encrypted: i=1; AFNElJ9lFFbLi+QAvg+GJzvl0K7Cd9PHglJ7aosuI9b/H80lpQlLEikmp6JtobB1FoZBzeiaQP+EV8/MkeTRGOc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq7ug/H9ouz1d0lmH2kWeCg1RkoF1tLMYcX0EZnaifiSG7resx fKKzwulY3nda2lLuyKI9asPxfvgkWQZKIT4MRawb4moOhw/emfI+87Sy X-Gm-Gg: Acq92OHVXsWQPsSYr976woeXW7nbCSsd3vXakyYHKqtthqZUBo4uUl8z2YIUEEzkrEV XolwM+zaL0IuYSkK8ziR4yd/2jZlDDbX0y6wFkNVG236bFTpQMsjnqYzyA9l63t/AjdaOWPvFpv KMSQaKgi5+WL4r52ZrBbZaK/zfQrg/xZpJax0zYRUbsXcEL+qJrww3bvJrIDZQ0OKXIj8SZN+YW AXlwigMQ0M6hlxmlNt+AkXm+NevTUE2lZoG6cbAhAYhb1RsfucU9uDnJlDuIyw48JT9Kv4aHBQO c6WGPtfw4inM4PGSlxraWwHquZAyaigPJ/FQZTqoZXGxZCRWLzPiGF9AwSxuX/ahfqC8OPDS9Gr gUcaZtArD34F3eGt6VDGzwkdmPvY2OlHGO7h/q3EAIFM5ijWkCjeXOelCG1x0dPjVC0e71sB8Tn vkwztPUaTiYLw4YsNYZ/bcVidh7Mte6EHxUtUdaMs/6LrRc5E61dFJk9lYJBXqdsF9KkC4tsdW X-Received: by 2002:a17:90b:5210:b0:36a:1ed8:6fe6 with SMTP id 98e67ed59e1d1-370f0b58cefmr5020296a91.24.1780689911521; Fri, 05 Jun 2026 13:05:11 -0700 (PDT) Received: from cps-manycore-1.. ([147.46.174.222]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf830b2sm6811667a91.4.2026.06.05.13.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 13:05:11 -0700 (PDT) From: Sechang Lim To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi Cc: Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Juntong Deng , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf v2] bpf: fix NULL pointer dereference in bpf_task_from_vpid() Date: Fri, 5 Jun 2026 20:04:57 +0000 Message-ID: <20260605200501.1619406-1-rhkrqnwk98@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bpf_task_from_vpid() looks up a task in the pid namespace of the current task, via find_task_by_vpid(): find_task_by_vpid(vpid) find_task_by_pid_ns(vpid, task_active_pid_ns(current)) find_pid_ns(nr, ns) -> idr_find(&ns->idr, nr) cgroup_skb programs run in softirq, which may interrupt a task that is itself in do_exit(). Once that task has passed exit_notify() -> release_task() -> __unhash_process(), its thread_pid is cleared, so task_active_pid_ns(current) returns NULL and find_pid_ns() dereferences &NULL->idr: BUG: kernel NULL pointer dereference, address: 0000000000000050 RIP: 0010:idr_find+0x11/0x30 lib/idr.c:176 Call Trace: find_pid_ns kernel/pid.c:370 [inline] find_task_by_pid_ns+0x3b/0xe0 kernel/pid.c:485 bpf_task_from_vpid+0x5b/0x200 kernel/bpf/helpers.c:2916 bpf_prog_run_array_cg+0x17e/0x530 kernel/bpf/cgroup.c:81 __cgroup_bpf_run_filter_skb+0x12b/0x250 kernel/bpf/cgroup.c:1612 sk_filter_trim_cap+0x1dc/0x4c0 net/core/filter.c:148 tcp_v4_rcv+0x18d1/0x2200 net/ipv4/tcp_ipv4.c:2223 do_exit+0xa63/0x1270 kernel/exit.c:1010 get_signal+0x141c/0x1530 kernel/signal.c:3037 Return NULL when called from interrupt context. Suggested-by: Yonghong Song =20 Fixes: 675c3596ff32 ("bpf: Add bpf_task_from_vpid() kfunc") Signed-off-by: Sechang Lim Acked-by: Yonghong Song --- v2: - Reject calls from interrupt context (Yonghong Song) v1: - https://lore.kernel.org/bpf/20260603204206.773482-1-rhkrqnwk98@gmail.com/ kernel/bpf/helpers.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index b5314c9fed3c..890202361b53 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -2912,6 +2912,9 @@ __bpf_kfunc struct task_struct *bpf_task_from_vpid(s3= 2 vpid) { struct task_struct *p; =20 + if (in_interrupt()) + return NULL; + rcu_read_lock(); p =3D find_task_by_vpid(vpid); if (p) --=20 2.43.0