From nobody Mon Jun 8 05:25:25 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C627638C41E for ; Fri, 5 Jun 2026 17:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780680661; cv=none; b=hE1oVgubjeTM2UwwR27mUSn4ptph14ol0aBNEojvT2HAnvetEUrtccHfq98dwRwAZBTy3VzeRgWncHp1hyXuQZJCHab6zmniCc5XfBQjcUxKh8EfqPgZlgdFfBWkC0HyFzIiV2U6UUF5eXQY8w2nhVStGIvIJSsG2Oi4s20Nrzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780680661; c=relaxed/simple; bh=0gNrJ3YIOU6NVAtWa683S47hAsOfCZvLyZLY69MbUtU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iZ3txpxQBgDnRJBpXJI4O42D5cyWvlaauoj/7HiReiBKl1N5RWKZoGMIYILE8xHXBcnqIBO1GyJwaDxSxpORThtw1VPbsHjfS+pDxjgOHirdGAvSrCvIng8FWlVUA/sFpdC7rggsm4+SZaQ/OxET3E+S/Gs5Y13R84vLYwgzDrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e2C1Drav; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e2C1Drav" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780680657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7uLXM0OI1h+4SUJMpu2ba6P7n++mGzI5a6+vQaq2dDE=; b=e2C1DravxSlRP5FhTZelvIflorcfSkGENbWz9PMeropiko2Yl1EDS/sVaqJbpUIEDPJD56 A7NvZT6Pecy+iykmOPozi8mBjsMym+VsRgeIdta34ek7GzU3YsswiVVr1aDCgpJexSiOaj k5HwYXD5Li9fm6GnaVbXZ8hI/fHsDGs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-SauCPuLpN4ymXK7aYIV42w-1; Fri, 05 Jun 2026 13:30:52 -0400 X-MC-Unique: SauCPuLpN4ymXK7aYIV42w-1 X-Mimecast-MFC-AGG-ID: SauCPuLpN4ymXK7aYIV42w_1780680651 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3720319560A1; Fri, 5 Jun 2026 17:30:51 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.88.138]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 649451800347; Fri, 5 Jun 2026 17:30:49 +0000 (UTC) From: Waiman Long To: Thomas Gleixner , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Waiman Long Subject: [PATCH v5] debugobjects: Don't call fill_pool() in early boot hardirq context Date: Fri, 5 Jun 2026 13:30:38 -0400 Message-ID: <20260605173038.495075-1-longman@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Content-Type: text/plain; charset="utf-8" When booting a debug PREEMPT_RT kernel on an arm64 system with grace processor, a "inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage" lockdep warning message was reported to the console. During early boot, interrupts are getting enabled before the scheduler is enabled. In this window (before SYSTEM_SCHEDULING is set) interrupts can fire and attempt to fill the pool from within the hardirq. This can lead to a deadlock the interrupt occurred while in the memory allocator. Add a new can_fill_pool() helper and reorder the exception rule and forbid this scenario by excluding allocations from hardirq. Fixes: 06e0ae988f6e ("debugobjects: Allow to refill the pool before SYSTEM_= SCHEDULING") Co-developed-by: Waiman Long Co-developed-by: Sebastian Andrzej Siewior Co-developed-by: Thomas Gleixner Reviewed-by: Sebastian Andrzej Siewior Signed-off-by: Waiman Long --- lib/debugobjects.c | 46 +++++++++++++++++++++++++++++++++++++--------- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c index b18a682fe3da..6fb00e08a4e2 100644 --- a/lib/debugobjects.c +++ b/lib/debugobjects.c @@ -720,6 +720,41 @@ static inline bool debug_objects_is_pi_blocked_on(void) #endif } =20 +static inline bool can_fill_pool(void) +{ + /* + * On !RT enabled kernels there are no restrictions and spinlock_t and + * raw_spinlock_t are the same types. + */ + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) + return true; + + /* + * On RT enabled kernels, the task must not be blocked on a lock as + * that could corrupt the PI state when blocking on a lock in the + * allocation path. + */ + if (debug_objects_is_pi_blocked_on()) + return false; + + /* + * On RT enabled kernels the pool refill should happen in preemptible + * context. + */ + if (preemptible()) + return true; + + /* + * Though during system boot before scheduling is set up, preemption is + * disabled and the pool can get exhausted. Before scheduling is active + * a task cannot be blocked on a sleeping lock, but it might hold a lock + * and if interrupted then hard interrupt context might run into a lock + * inversion. So exclude hard interrupt context from allocations before + * scheduling is active. + */ + return system_state < SYSTEM_SCHEDULING && !in_hardirq(); +} + static void debug_objects_fill_pool(void) { if (!static_branch_likely(&obj_cache_enabled)) @@ -734,18 +769,11 @@ static void debug_objects_fill_pool(void) if (likely(!pool_should_refill(&pool_global))) return; =20 - /* - * On RT enabled kernels the pool refill must happen in preemptible - * context and not enqueued on an rt_mutex -- for !RT kernels we rely - * on the fact that spinlock_t and raw_spinlock_t are basically the - * same type and this lock-type inversion works just fine. - */ - if (!IS_ENABLED(CONFIG_PREEMPT_RT) || system_state < SYSTEM_SCHEDULING || - (preemptible() && !debug_objects_is_pi_blocked_on())) { + if (can_fill_pool()) { /* * Annotate away the spinlock_t inside raw_spinlock_t warning * by temporarily raising the wait-type to LD_WAIT_CONFIG, matching - * the preemptible() condition above. + * the preemptible() condition in can_fill_pool(). */ static DEFINE_WAIT_OVERRIDE_MAP(fill_pool_map, LD_WAIT_CONFIG); lock_map_acquire_try(&fill_pool_map); --=20 2.54.0