From nobody Mon Jun 8 05:25:28 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 858F53FFFB6 for ; Fri, 5 Jun 2026 15:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780672413; cv=none; b=PFQ9pC7S4rnEa6f9YOfKx//vKpsNgCncYfvvX1PTuzN8GSSA/9akHfKIwkgxmCRcYMcV6Wa/I6hOPaaE/dC7Uht1ksUJ7TIcV1h5GUC/gdyJBSsNM5BAJ3/vffLtI6imZKR9Moa+6GlZDrnKGqH6FtQtA5imDTnGCQ8DXfDUyvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780672413; c=relaxed/simple; bh=6zI0+5Unw3aM4B++TrI955Pmj/b67v+3oLnd/DwQ2ws=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j8PYCOlvUFc610fkNGCHqy7RcXLm+wH3rS9GUh82jHkoTzDfc9L+NNhoFFtxJ1dTszw7oh1DHCdPSkIK2ClxczHxcGZ/ZXB3tgjzgFpgwT1cINnOQa/WB5HX21ndYUqX1apJoi1TEsQXEHTc0ICZQVOZe7vHPXuMIppAyMZQi0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com; spf=pass smtp.mailfrom=trailofbits.com; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b=YqNH+Nsa; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trailofbits.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=trailofbits.com header.i=@trailofbits.com header.b="YqNH+Nsa" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-9159bad8c98so227851085a.3 for ; Fri, 05 Jun 2026 08:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trailofbits.com; s=google; t=1780672411; x=1781277211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MUzsgU5C8dNE/wG8dusnMomxOEkXYrmT6T12TQh+ff8=; b=YqNH+Nsa1vnKN8bLjtg0xCAYK+HpXtDv5bRgr9RP1mO7b9ouveknjMqGLwXbl3l1Xb xFLnZFeDk571fPAtIwQfAuRdhaa7tByIdmcK49IK3t2oP0pjwsJIQlAeRrxIH8fkUDa1 sZodiyPYWkhwLoVf+TR+wNEB77wNk4Ho/WJMBQl25t5hZbtDLqZ4vj0Hz9/kq5GyK+lm LRmq3TaBKWH52kk66pyo+/7ftkx2Tm6MjgmQCrmTjsb6bVRPQMrea7UGk3Oq7keO7waz v+Y2hvCVRmv7OzrJBj+xAKRT51X71mPFoPB0XRDGlupuhIakcQf5Pe4E1Lp3kpHILf4z olaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780672411; x=1781277211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MUzsgU5C8dNE/wG8dusnMomxOEkXYrmT6T12TQh+ff8=; b=GXhFKTva4nkhfzIl4WudroSlT4LeQxq/TYjhJcrtzY09QzBY9MTWJ8BfcLVGtj+hUP 6jYF08xt/GDH6aLzjl47+s1CoAU5+U+mQcR5N+yNkkpl2RkMC52r/81HckKYNXqFyzwC Tvd/V/x7NahZxjvbiWDcWkXmIF33wJVg4XsZvlFyAR9RQow7Rd7AzGnaqDQluL1mGTiE Yasxpf1n56455OQLWvFj35wZhC5ojkLEedD+Ki5xokChrZfVI7esZUUj9WewT/7RVj38 p0vAl/Ek0r31Vpe91dh1wpG4RzpjvHMN+sH7rvfYpCbUqWBYzOm3Mp4PEA4EGnLG4CB5 45cA== X-Forwarded-Encrypted: i=1; AFNElJ+SgQBT+ydGrM25CFfPkNF313TidSRrrIC65IG5VGf9qEJJB/1o50SGa1fzLrwu9zuNx0Gud7dKwsOonGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1KKiYV07DQ3OTVAtE6LtWF8AhmJd4OokXkMUYMV5Ze7/gK1Np jXcR0kiEI91oYLHP9Zuj4i5rw8YbSbqXigPKaNG+/OVZ7vyU+bNFV3gZwBrNNv3drNw= X-Gm-Gg: Acq92OGeQIOGDzpCvYwT4sUv6CZmPQlmiAU8fcEktSqrHkETb8F/ZVBzvdsYFsWr2C+ 771YlDg3pZmzCWH5/YVMDgKi/buCYj3mtdu93NcTkup0IdFktG/0yNzfaoFSZgJjEpDzeubdZtE vkDyyX797I19s01c9sIQpq5mzg6/69ibBe4RmFWaVjBxCn3xKdZGMHAObs2r/mLkdSxRxSLWYaB 1iRyTHqm6T7D96r79P33aFsxYP6KX+aYSRR/9M6Fq0KvOCKX9Q+527mCfzm369b20tFxKxLZRaV xiPp27nvAJuyhUsBPW38qXNxY/N+o7BkG3Xrjtynm3aC/5nZQF00h0wtWwpGtoLEsRUmIGBuM1s murLKCCvp6NZ6n5qFXQ5aVzyP7W9CcfO/tiLwg/KUHdcXGTTLe446llNqEfWM7tfL+Oz3zRzWJM uPWS1/abUFX6+6hh20JEdb3GsJJOtHjOh5KQtAaw== X-Received: by 2002:a05:620a:6cc7:b0:915:5cbd:1e56 with SMTP id af79cd13be357-915a9dbe488mr763995785a.41.1780672411537; Fri, 05 Jun 2026 08:13:31 -0700 (PDT) Received: from localhost ([161.35.96.86]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-9158a2465e7sm934901085a.19.2026.06.05.08.13.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 08:13:30 -0700 (PDT) From: Samuel Moelius To: Andrew Lunn Cc: Samuel Moelius , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] net: pfcp: allocate per-cpu tstats for PFCP netdevs Date: Fri, 5 Jun 2026 15:13:15 +0000 Message-ID: <20260605151315.2124527-1-sam.moelius@trailofbits.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PFCP uses dev_get_tstats64() as its ndo_get_stats64 callback, but pfcp_link_setup() does not request NETDEV_PCPU_STAT_TSTATS. The net core therefore leaves dev->tstats NULL for PFCP devices. Creating a PFCP rtnetlink device can immediately ask the new netdev for stats while building the RTM_NEWLINK notification. That reaches dev_get_tstats64() and dereferences the NULL dev->tstats pointer. Set pcpu_stat_type to NETDEV_PCPU_STAT_TSTATS during PFCP link setup so the net core allocates the storage expected by dev_get_tstats64(). Assisted-by: Codex:gpt-5.5-cyber-preview Signed-off-by: Samuel Moelius --- drivers/net/pfcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/pfcp.c b/drivers/net/pfcp.c index 28e6bc4a1f14..a6aa30ae0af7 100644 --- a/drivers/net/pfcp.c +++ b/drivers/net/pfcp.c @@ -148,6 +148,7 @@ static void pfcp_link_setup(struct net_device *dev) dev->flags =3D IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST; dev->priv_flags |=3D IFF_NO_QUEUE; =20 + dev->pcpu_stat_type =3D NETDEV_PCPU_STAT_TSTATS; netif_keep_dst(dev); } =20 --=20 2.43.0