From nobody Mon Jun 8 05:25:26 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 804103EFD0C for ; Fri, 5 Jun 2026 14:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671490; cv=none; b=l/hF6rjuaLJYgMeJU4H+OFiM1Dla/dACP81tIivxble6sOtFbFG9pUDGJSerGu1DipSd4UEvxHONxtu2XRXI1ftwLjLwyZGxYzQLYUrkm6d8F1XOQVSR98EL+/rvuCPoaAo0n3QiGUrfh1/wRLHTWk/1ZwkRfVgOE8nuhTLMt8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671490; c=relaxed/simple; bh=r1iZ8a8iXyFQ7e9Yk84WkiexC6WpGev9TRhdGflQeHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZNiKpmwOgV0RUkMQW/QDRg5Vf+AH+iGQLWueKq6pH8UVGeZDQThvUYUP1N0SROQL9q4YXBtviY7gv0D7tpuGc/vwFS9ejjD46INr23pPMz8STVEaVF1K5gpxrWAXjbnN61dIY/0Q3Vu4nWmKHzE/txuKzPQKtc8TtnEgJRHr6hQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HTNNqYmZ; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HTNNqYmZ" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36b8e1760ccso1298335a91.0 for ; Fri, 05 Jun 2026 07:58:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780671489; x=1781276289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QBALkfms9XINseZbRMjuo3U/MLkG0sUOcIH6JBjP30w=; b=HTNNqYmZLRAoLk4iXYiwjSK8k5m8Fs6u9WeisDtypgFcvCNmHFBNuKz9LHLgrwCSDd eSWj5N+TcSEIjmWVBHza98mFMus+nIG187pk+sqzFfwhMjzfwyhjgIw/h9wpH2Yv9bua FfV99zXXvuqWw9Gj3pA5XocaGKqGXYGSEt/a+QOYn8qbMMHmmFctiawaRFGj+DmpAvyT cMMeAN0sAg0xqMIhDSvLiXbGksmT1mJi/9yw7TvpO/HxY+MirMo2rF8kc03beKDBZZNZ +y9ETDTEvle1xbftVHduSvO9A5AFrl/Eq0tccqP1gCtcBbjKvVeXCyrGGAswO6Rn4kv2 QK+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780671489; x=1781276289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QBALkfms9XINseZbRMjuo3U/MLkG0sUOcIH6JBjP30w=; b=V0Umw4R0FttKSxnJoobhP802ZPV3csEqmuQmeZsfmnWD3eBRTPLAfzeg6PxROY+zpd cz6t2Imrm38sIoCpfJpVyZSWhJHPfpHgYYPYiw6cpZQGbRj1vcMogoYSLbsowRh4mIp6 Zrj6k/2FGiPldGe5Xl+bTsNGmKXFjWvPG1WEQdExNYl1XybR9NVQ106I1qQfZDtqxacC 3nidykYO0RXFB2zch8zZ2UeA4IIdmpLMav71IXx0HHfNSLUt3m4XpISiSi81hZLd/Kb8 L8BUlMsglC1/33UCM2+QZQ7L5ppqmRtn5hV0yw/+/l1SRk3q8C+9lEhLx2mlU/vGiqi/ S1mg== X-Forwarded-Encrypted: i=1; AFNElJ9ZIZ6fR5QY/SX9yzVnP+Bruo7YPFXgVd2TW9FPRowHkxLFMUWxgAy1VDl0tDedCBG+BeyCqsdreyX5SJ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwUb5v4ko+qqN65i03deQuRqj52NitFPNgNR01bi+L1Q6y8yzgJ ubm+3wQ2oaot92yzeolypn/56KA4o8Shy8GAelit1neAQ5ShOZ+QDA0i X-Gm-Gg: Acq92OESkk01oUX5UQwI++LPsrJF+ZT02OX6qlm0msSRpPfyFPwX+5ubc6mqipo5kEV QYkVrFeZTlt5/mgCIasgs98S9HFwPpU5DotIrflnJfSLtCDyTVPWu88juOBMkuhD9FYCXwdlrep /3yd6KhEUa/k43DTB2LM1j7dpe6iHHALHJ7mdaeMoDxilLLz0Lc4U/+C2MUcdedexYoKrD3M/az ucgxbxP84bXAPytkRbfjVZPKWxYAL1i5fNGFIKSpzyksHdvRuXahSPLTT70QLEvZ7q74iWVbxqT yub1EGmFH0JHe3jBxpWKB5XUAPDM7mJ//bzBrFKKbgRS9N60FLKv+7uzrJYJmQ5Xl+R4NM/QLRH h0AbuWqqoJQ8C9WzwtSeREdl6k2HoBPUsT5W/pEx95dmSvfhT1yFJjt4AOT2zPepAcsYoLsp7o4 nyWROgg9Zv5mqMWTIvNXP6fhglDSKxrM0jG3tifHFEX3opUFvzlJlJc8U6jnGfJlJN X-Received: by 2002:a17:90a:d643:b0:36b:b4a1:2939 with SMTP id 98e67ed59e1d1-370efda7ab1mr5078417a91.15.1780671488822; Fri, 05 Jun 2026 07:58:08 -0700 (PDT) Received: from m-upc-A520M-HDV.flets-east.jp ([2400:2410:3f60:500:1cda:ba68:a654:c3cf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f70a28c0esm7058231a91.12.2026.06.05.07.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 07:58:08 -0700 (PDT) From: Yuyang Huang To: Yuyang Huang Cc: "David S. Miller" , David Ahern , Eric Dumazet , Ido Schimmel , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next 1/2] ipv6: mcast: annotate data-races around mca_flags Date: Fri, 5 Jun 2026 23:57:58 +0900 Message-ID: <20260605145759.59639-2-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260605145759.59639-1-sigefriedhyy@gmail.com> References: <20260605145759.59639-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" /proc/net/igmp6 walks IPv6 multicast memberships under RCU and prints mca_flags without holding idev->mc_lock. The multicast paths update the field while holding idev->mc_lock. Annotate this intentional lockless snapshot with READ_ONCE() and the matching writers with WRITE_ONCE(). Signed-off-by: Yuyang Huang --- net/ipv6/mcast.c | 52 +++++++++++++++++++++++++++++------------------- 1 file changed, 32 insertions(+), 20 deletions(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index b8901c921c5e..bd3972730aa0 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -676,7 +676,7 @@ static void igmp6_group_added(struct ifmcaddr6 *mc) return; =20 if (!(mc->mca_flags&MAF_LOADED)) { - mc->mca_flags |=3D MAF_LOADED; + WRITE_ONCE(mc->mca_flags, mc->mca_flags | MAF_LOADED); if (ndisc_mc_map(&mc->mca_addr, buf, dev, 0) =3D=3D 0) dev_mc_add(dev, buf); } @@ -712,7 +712,7 @@ static void igmp6_group_dropped(struct ifmcaddr6 *mc) return; =20 if (mc->mca_flags&MAF_LOADED) { - mc->mca_flags &=3D ~MAF_LOADED; + WRITE_ONCE(mc->mca_flags, mc->mca_flags & ~MAF_LOADED); if (ndisc_mc_map(&mc->mca_addr, buf, dev, 0) =3D=3D 0) dev_mc_del(dev, buf); } @@ -886,7 +886,7 @@ static struct ifmcaddr6 *mca_alloc(struct inet6_dev *id= ev, =20 if (ipv6_addr_is_ll_all_nodes(&mc->mca_addr) || IPV6_ADDR_MC_SCOPE(&mc->mca_addr) < IPV6_ADDR_SCOPE_LINKLOCAL) - mc->mca_flags |=3D MAF_NOREPORT; + WRITE_ONCE(mc->mca_flags, mc->mca_flags | MAF_NOREPORT); =20 return mc; } @@ -1167,7 +1167,7 @@ static void igmp6_group_queried(struct ifmcaddr6 *ma,= unsigned long resptime) =20 if (!mod_delayed_work(mld_wq, &ma->mca_work, delay)) refcount_inc(&ma->mca_refcnt); - ma->mca_flags |=3D MAF_TIMER_RUNNING; + WRITE_ONCE(ma->mca_flags, ma->mca_flags | MAF_TIMER_RUNNING); } =20 /* mark EXCLUDE-mode sources */ @@ -1195,7 +1195,7 @@ static bool mld_xmarksources(struct ifmcaddr6 *pmc, i= nt nsrcs, } } } - pmc->mca_flags &=3D ~MAF_GSQUERY; + WRITE_ONCE(pmc->mca_flags, pmc->mca_flags & ~MAF_GSQUERY); if (scount =3D=3D nsrcs) /* all sources excluded */ return false; return true; @@ -1227,10 +1227,10 @@ static bool mld_marksources(struct ifmcaddr6 *pmc, = int nsrcs, } } if (!scount) { - pmc->mca_flags &=3D ~MAF_GSQUERY; + WRITE_ONCE(pmc->mca_flags, pmc->mca_flags & ~MAF_GSQUERY); return false; } - pmc->mca_flags |=3D MAF_GSQUERY; + WRITE_ONCE(pmc->mca_flags, pmc->mca_flags | MAF_GSQUERY); return true; } =20 @@ -1499,18 +1499,25 @@ static void __mld_query_work(struct sk_buff *skb) } } else { for_each_mc_mclock(idev, ma) { + unsigned int flags; + if (!ipv6_addr_equal(&group, &ma->mca_addr)) continue; - if (ma->mca_flags & MAF_TIMER_RUNNING) { + flags =3D ma->mca_flags; + + if (flags & MAF_TIMER_RUNNING) { /* gsquery <- gsquery && mark */ if (!mark) - ma->mca_flags &=3D ~MAF_GSQUERY; + WRITE_ONCE(ma->mca_flags, + flags & ~MAF_GSQUERY); } else { /* gsquery <- mark */ if (mark) - ma->mca_flags |=3D MAF_GSQUERY; + WRITE_ONCE(ma->mca_flags, + flags | MAF_GSQUERY); else - ma->mca_flags &=3D ~MAF_GSQUERY; + WRITE_ONCE(ma->mca_flags, + flags & ~MAF_GSQUERY); } if (!(ma->mca_flags & MAF_GSQUERY) || mld_marksources(ma, ntohs(mlh2->mld2q_nsrcs), mlh2->mld2q_srcs)) @@ -1618,8 +1625,9 @@ static void __mld_report_work(struct sk_buff *skb) if (ipv6_addr_equal(&ma->mca_addr, &mld->mld_mca)) { if (cancel_delayed_work(&ma->mca_work)) refcount_dec(&ma->mca_refcnt); - ma->mca_flags &=3D ~(MAF_LAST_REPORTER | - MAF_TIMER_RUNNING); + WRITE_ONCE(ma->mca_flags, + ma->mca_flags & ~(MAF_LAST_REPORTER | + MAF_TIMER_RUNNING)); break; } } @@ -2018,8 +2026,10 @@ static struct sk_buff *add_grec(struct sk_buff *skb,= struct ifmcaddr6 *pmc, if (pgr) pgr->grec_nsrcs =3D htons(scount); =20 - if (isquery) - pmc->mca_flags &=3D ~MAF_GSQUERY; /* clear query state */ + if (isquery) { + /* clear query state */ + WRITE_ONCE(pmc->mca_flags, pmc->mca_flags & ~MAF_GSQUERY); + } return skb; } =20 @@ -2612,7 +2622,8 @@ static void igmp6_join_group(struct ifmcaddr6 *ma) =20 if (!mod_delayed_work(mld_wq, &ma->mca_work, delay)) refcount_inc(&ma->mca_refcnt); - ma->mca_flags |=3D MAF_TIMER_RUNNING | MAF_LAST_REPORTER; + WRITE_ONCE(ma->mca_flags, ma->mca_flags | + MAF_TIMER_RUNNING | MAF_LAST_REPORTER); } =20 static int ip6_mc_leave_src(struct sock *sk, struct ipv6_mc_socklist *iml, @@ -2713,8 +2724,8 @@ static void mld_mca_work(struct work_struct *work) igmp6_send(&ma->mca_addr, ma->idev->dev, ICMPV6_MGM_REPORT); else mld_send_report(ma->idev, ma); - ma->mca_flags |=3D MAF_LAST_REPORTER; - ma->mca_flags &=3D ~MAF_TIMER_RUNNING; + WRITE_ONCE(ma->mca_flags, (ma->mca_flags | MAF_LAST_REPORTER) & + ~MAF_TIMER_RUNNING); mutex_unlock(&ma->idev->mc_lock); =20 ma_put(ma); @@ -2972,13 +2983,14 @@ static int igmp6_mc_seq_show(struct seq_file *seq, = void *v) { struct ifmcaddr6 *im =3D (struct ifmcaddr6 *)v; struct igmp6_mc_iter_state *state =3D igmp6_mc_seq_private(seq); + unsigned int mca_flags =3D READ_ONCE(im->mca_flags); =20 seq_printf(seq, "%-4d %-15s %pi6 %5d %08X %ld\n", state->dev->ifindex, state->dev->name, &im->mca_addr, - READ_ONCE(im->mca_users), im->mca_flags, - (im->mca_flags & MAF_TIMER_RUNNING) ? + READ_ONCE(im->mca_users), mca_flags, + (mca_flags & MAF_TIMER_RUNNING) ? jiffies_to_clock_t(im->mca_work.timer.expires - jiffies) : 0); return 0; } --=20 2.43.0 From nobody Mon Jun 8 05:25:26 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D023FB05D for ; Fri, 5 Jun 2026 14:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671494; cv=none; b=jApwDcxW81lMO0PTyHks5WWCLd6LJB8IhUjmSNiuo8Z0wRAFpD8Tn27S5mZpAEZlODu0lUcgC6GTv9TaSI068B9Nmg7ZnQ2oL7CUTe0YTjNOAi579l91LRX3MCSUsGkeOMGRPPN/1RYHAYx2/G2Rbjsojy6dmbLg8IPEjUm7p6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671494; c=relaxed/simple; bh=g/Vf5S/ImH9NFAJ8TFesAonWYxBfyXfhedQepyu5x4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iCEPSd/O+BXU04H7Muq3/cBNIIgi7XOfNee71gwLEPLvxGHu5RlJGisaxC78PYdjPCo2q6VCQrG/SL0g2j3GTZsd18/Li8Y3NtGY7bDoEG9DqfoNMFTEOZ+sGBwZyWp0uB+LDk64qwkKNf3AH+2XLVZCjHQpuWkooZzvknyk9p0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UAwJwzYZ; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UAwJwzYZ" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-36d6bb38b44so1423964a91.0 for ; Fri, 05 Jun 2026 07:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780671492; x=1781276292; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g6llRc9O739ZmXHdXtpVluJELJf01erqJYXeZGoa0Iw=; b=UAwJwzYZ0v2xgArabsiWgErFmQVFXuEB+E9QobILKvEx2eZMBuV+A3LJBzjzXsRoyL 8odLsqgTRVPfhY8ZIbQdJRZtaa2lGo06dCRZhLxV3NhJTFlUIltJzLcZyzIFb5GOjyY9 RKsD86MUyMRHQkMhpP+lI4CtSXHbomDfMOWpALtC4p3ZcclhoEawcBdg20CcZ/6w94cn aEn9JQt6Z+xQxWeRc+m43867nDbX9WwjQAsFx3XY3D/fp/l1DzQZb/wNwwYQOUI8Yg98 byGrgyFgECXcKt5sx0Kbq8zkYNd88lZy1yXwCk6HdOLWUlRyypYIzYWmiezJN76mWBO1 JXBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780671492; x=1781276292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=g6llRc9O739ZmXHdXtpVluJELJf01erqJYXeZGoa0Iw=; b=lG9kGVSAfwnZX6nsCJOAGfmCjBQLugMlNJm2MsVWkJ4INjOLb0cncYL84hhDK6eBQI FILsVmnIJn7mEObxxka2qGHRsZ+B9+XoaAiplAQKd7IzgMnxsQ9p4z57Vhtz08iF/DsK VSpjrlCMylslUFN6VVl18NTt+LQ7/pYoutI7HJncijcEYyAP3mLm9itGR3i7CUEPIE0y FFQvjxpqTjw1T82OkqblIg9BR+yM8iS9Zlq2PbMGL64sOjMrwaxrzPDR9XtWxF2nG7oD jXM/hLDlixYYbhxNO0deda7PaLFI3bbMNAK9iW8EoBEeJBjzYwB/xemOfg/WMBChaZEt VzsA== X-Forwarded-Encrypted: i=1; AFNElJ97gINffzFmUnfuE6+tixdgD8kySxed4Wlr2cRTTcqkkYVBZAmGXowSiNNLgn5qDpvWxhJ8l4CoCY+OAd8=@vger.kernel.org X-Gm-Message-State: AOJu0YxI52i0OICytmyTqVsvZS7eY9QfRGSi4LHVxdBl6/0373QaVvud 11TOLNnmgcjXNb4mlIFM8v27/R/qJV20E+dK2cBqRc1KD4HsNahDIpf/ X-Gm-Gg: Acq92OHAhBQGnDDkblfJLcc+7sQLbBe8UoqHDd1e84x39XJDqxBvhU8wQieIqOhHTEP 5jD65jSHgSm3uljPvIWuBXOLqvtlT9LfRvmNlwugUKmP58IXi+2PckSR2S7DUtx4h+1BvI0Pu7h x9ueFFV3hRwyF2Ks18NoE/iUqCtmCETbP0w9xN3Fhebn7pPF6b9qe+c2CPRMmX+rPD8jieQBhST BzMeHhjkEku9YugOQ2glZf4tSXAlLeJ+VJeFLuwRAHGUSBxWWKYn5VliVaFge3mesWpSvCjXAWe XSFQF0Dx8UzjlVbekDN884ss3OnYO2k25xlEzNNh9NfS27qkAzsUkOAFyf+Lw5JfYSu0UGlI+Mv 6oJFULdB9/5TssSOVbQyoZmeHv4VE3EexLO6Pr0DhymHZh8dulRAMbQy7aBqtARWRtlBdmNdWsN lLWzzaG8iYD7MDxhGF8MZCBRmZ/MmpTA6IvXFzyXBy77IdyDJcGj2X5tXUGkCvvxrg5PiojEfli x8= X-Received: by 2002:a17:90b:5827:b0:36b:a0fa:ff96 with SMTP id 98e67ed59e1d1-370ef1f2cdemr4307027a91.12.1780671492081; Fri, 05 Jun 2026 07:58:12 -0700 (PDT) Received: from m-upc-A520M-HDV.flets-east.jp ([2400:2410:3f60:500:1cda:ba68:a654:c3cf]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f70a28c0esm7058231a91.12.2026.06.05.07.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 07:58:11 -0700 (PDT) From: Yuyang Huang To: Yuyang Huang Cc: "David S. Miller" , David Ahern , Eric Dumazet , Ido Schimmel , Jakub Kicinski , Paolo Abeni , Simon Horman , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net-next 2/2] ipv6: mcast: annotate igmp6 timer expiry race Date: Fri, 5 Jun 2026 23:57:59 +0900 Message-ID: <20260605145759.59639-3-sigefriedhyy@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260605145759.59639-1-sigefriedhyy@gmail.com> References: <20260605145759.59639-1-sigefriedhyy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" /proc/net/igmp6 walks IPv6 multicast memberships under RCU and reads mca_work.timer.expires to print the remaining multicast timer. The delayed-work timer can be updated concurrently. Annotate the intentional lockless procfs snapshot with READ_ONCE(). Signed-off-by: Yuyang Huang --- net/ipv6/mcast.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index bd3972730aa0..184e57469086 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -2983,6 +2983,7 @@ static int igmp6_mc_seq_show(struct seq_file *seq, vo= id *v) { struct ifmcaddr6 *im =3D (struct ifmcaddr6 *)v; struct igmp6_mc_iter_state *state =3D igmp6_mc_seq_private(seq); + unsigned long expires =3D READ_ONCE(im->mca_work.timer.expires); unsigned int mca_flags =3D READ_ONCE(im->mca_flags); =20 seq_printf(seq, @@ -2991,7 +2992,7 @@ static int igmp6_mc_seq_show(struct seq_file *seq, vo= id *v) &im->mca_addr, READ_ONCE(im->mca_users), mca_flags, (mca_flags & MAF_TIMER_RUNNING) ? - jiffies_to_clock_t(im->mca_work.timer.expires - jiffies) : 0); + jiffies_to_clock_t(expires - jiffies) : 0); return 0; } =20 --=20 2.43.0