From nobody Mon Jun 8 05:26:09 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046053B2D0D for ; Fri, 5 Jun 2026 14:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780669840; cv=none; b=CeGtzstSd2lumJMy6zdfke7ovZxbaFDIh4dGtYD2ZDMHjxaaVp864vBZH/ZuSG9LBcCo75Aryd0P9MWwBpx4YhJXO0SWtZMSregtvRSqfvaJQGkfmTQFH3s3CcgHskp3VxuD7/Pm1XVwXiVqc1BZw3OlEPVLdvBTIpkZ3qMkHSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780669840; c=relaxed/simple; bh=EVj/w6iK3+b4kNl2JDaF+zi/oZ4jg0tk/C1v/bSAc1E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YGZibrahyEEXii0sF32nc/SSeKvNf6cZ3ACjL/EFbpqGKQuhBObsRCvqOnlPwZQ2ku/y2A1dyyNvGxGPJAY7W/3mDueWqI2ca92HCee4hoWDk/dguQh34xGcqAAG7g4vGJF75O5RHAC5VLhxkR1+VLnfykrqYMU+gV8Hp2BiOF4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XLCqL1r9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=STxW+lzq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XLCqL1r9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="STxW+lzq" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 655AVxs82975085 for ; Fri, 5 Jun 2026 14:30:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=YYr53TWlFvQ9X3G8WUw05dDowvGVXxiHZ6r UrNQhMqQ=; b=XLCqL1r9PEVlz/K281DECkdMMmGaJHtmUG9SyD2N+w8KA5Wv4Dl kRBCmlw2a6NZuVTT/sbMHfz8qNOQo43ryWwkO/V7vl2N5MDj3yBWe5uSgZKC9FKD 53P6pMshkpq+updZXJ1KhYi95hzrdVSYoe9GVGmpNi7IXtuRka62vRfzLSl9udID nLIUz+I+xZabscPNnwvQx+OzaqtWeVPWNbdpPxkdbuQL9hKg3rtnZt3HYHp8DlDi gwVLsHkRhTupqBf9NqVRChl7RSRk6sZ53rEivBKYt/RlXoZPga8Z2168TCcMcI39 xhd4FXc2zIR+BrXkFdyIJGD15P6wnWBBR3Q== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ekpnuafev-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Jun 2026 14:30:37 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-6cfdce65690so774646137.3 for ; Fri, 05 Jun 2026 07:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780669837; x=1781274637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YYr53TWlFvQ9X3G8WUw05dDowvGVXxiHZ6rUrNQhMqQ=; b=STxW+lzqQlxkFiZdogDMgMNp2O3G0RRk9JpDQ5KonzDtiRKG0W/JlAmefEbRIxviS+ pEy38R6g4DgloGMYy6fk0LCZwbWv1rHH5Pqg8qZqiHm5V2ey3/U/BGTgT7vlkqw/zUoQ EsIK0EhN1w5OyerDpEXeaAOme6MZZegq0u5NAoQl2JPCZFzqoiVf7vFfmUHkYMcBosvI 2bsJLs/U+vythSlGuVEan33ACgrpq+abWOvfZvEY3x0xmSWp4U7g0ZLbrGIqGNYf8cN9 gkCoJk9k7Z8dzciHN85lzoV8Ak6Ya5SBsywq+tYFd+F+m4qW7ytRyEV9g8Zyd5T3wEjR Iduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780669837; x=1781274637; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YYr53TWlFvQ9X3G8WUw05dDowvGVXxiHZ6rUrNQhMqQ=; b=afBAimO3C92TBW2oxUpGPKPhy63ZlFoV3O/mBTcyaxTUu3BOhGyJgXx9dJGpvegIjq 1RQXV7BT/fOmYOE8n5t15lDKhd/2BRYJz9lPsF/vhVxpD6ZT6vzQTwREc9xWfWIV1+NN YUYTP5cRxOCzCjaOzZVh5tynK+ehYEuKxaCDnLRZSx7RYxh49ecEaiViaD4fZ6CFAczF 9TvNkJ6zhhSi/ACEyJ8iAa5C+/yaL4Ocq219iCZrLcD2Z2llV9CdJ1U7WPEZXC4Uy51h rh+ysoLBX0WZXQyrdUFbgE1dUTywbusiqpNSzpqvTPfeUcWccvjcXLnHYIxxuwKa6G77 XlSw== X-Forwarded-Encrypted: i=1; AFNElJ9YrFwl455DOqOS0xpvVdapEDISoJNENYvRIYMiabN1VyiZc9miWuQqwLGu1BhBBlW91+W9dMn9GFrb5qc=@vger.kernel.org X-Gm-Message-State: AOJu0YzDt2M9gmtqf5TDNjeIGc0sLbIxOO0vSki0p5QWNuBXqR1UImj2 mc9wkB95YI5/BJ0tsCxxqFs+E+6y3HYRnzcRxakz6rK+NY3zDrjUXMf84Y5yFBpse7/tY3b80k5 qMbjW8QPSjcH/CMd8iVbaXni30pEXXh3tukJwU7qVBGKOHsZ5Q8pC9QFD6H70mJMBRcs= X-Gm-Gg: Acq92OEuLmyE1RAPn7ruSsawb5LmH/vnl6pQXQ3mHNbzhqH13ylTyNNDIWMxAnBEXhg YwMZQn08Lp49RnJFy6Wu2FGj7bdqBN9SaqWvfDp+H9wTqaRm5LKr9axAZoAGAn/qUbywtJSPSxk 3i6Yq1T2zDJX8GdKkFSAnMR1ozltmqyzO/Kh3arbOvT3C2wHFNUVK5irOXpdCNKQev3eOCcmm+M 09psyK8enOG7mxcWMwxQW+iQL+5Hh70mFRGQqT0DR3ETtU5F4YRXkd3EVe4pfRSPOmiMsQO/kWE dC35FKNoMSeETfy7XveIobwKEZjznBzo4nY01dJZZV4YMlsU12viGEzSID9uXI4gRTMEh7C0BOq RmqP8w6M8IeOq0jSSLo0fgz4g2iDGSE7S9MZMrOOcik3rpubcsfdmxm6HVV88ZFs= X-Received: by 2002:a05:6102:5490:b0:6e2:501c:3c93 with SMTP id ada2fe7eead31-6ff0eba884dmr1941952137.14.1780669836896; Fri, 05 Jun 2026 07:30:36 -0700 (PDT) X-Received: by 2002:a05:6102:5490:b0:6e2:501c:3c93 with SMTP id ada2fe7eead31-6ff0eba884dmr1941844137.14.1780669836424; Fri, 05 Jun 2026 07:30:36 -0700 (PDT) Received: from QCOM-LDTZRie9bq.qualcomm.com ([212.136.9.4]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64303892sm3814609a12.0.2026.06.05.07.30.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2026 07:30:35 -0700 (PDT) From: Peter Hilber To: "Michael S . Tsirkin" , Jason Wang Cc: Trilok Soni , virtio-dev@lists.linux.dev, Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Peter Hilber Subject: [PATCH] virtio-mmio: add support for transport version 3 Date: Fri, 5 Jun 2026 16:29:21 +0200 Message-ID: <20260605142921.2824-1-peter.hilber@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: -Ca3j4NAotm6yOB5LHGXSbzdCFb5GV14 X-Authority-Analysis: v=2.4 cv=Ksl9H2WN c=1 sm=1 tr=0 ts=6a22dd8d cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=dNlqnMcrdpbb+gQrTujlOQ==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=SLj1U74zwwqa45oC7IgA:9 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA1MDE0MiBTYWx0ZWRfX/SMzRdpafWq4 9meTfUwLcrSWQmMYrjnVQMtO2seA/lHdOLDeqUWjrlnITM3WX9vAB/rl8h+rZypZMi8Hfhj3Ig6 FuPq1WGrawqP7B+6JuU3Mf2nbvzDa6JwyMed2j6PkLHf9sOk6PZjEXsjkAZVf2653pr3m/Foguw 3ya84ZJGe35jakAt2CF75r4VxDv1C4GgqiNyFFeSdG/nXnKhw9E5vFpcuDUfxTHnEDtMGxIpv9e ZfacZMGP9/n+mQ7kPwsYgh1rdHNfvCmm5Nko38nQJONtkBcE/J73Os0sfOTirEKpCGS+4KX4Doe LyrWOnujaveWtq5uTCnNZnSUpX4BG0ZHairkS7wJhQvDwXS4rQx0VgRRosm9y8lD4nELY4sWFc4 wmWcgmu0y3py6ifvyI+o5Z6U8NqCl3KyQafYlHSPuKd+98oKTv1PWaJ/oDt6vo3L/jaaaAiCQlX KCgkxs+WgOEDGk48UVA== X-Proofpoint-ORIG-GUID: -Ca3j4NAotm6yOB5LHGXSbzdCFb5GV14 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-05_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606050142 Content-Type: text/plain; charset="utf-8" Virtio MMIO transport version 3 allows device reset to complete asynchronously. Unlike version 2, where writing zero to Status must complete the reset before the write returns, version 3 requires the driver to poll Status until it reads back zero before considering reset complete. Update virtio-mmio accordingly: accept transport version 3 and, during reset, wait for Status to become zero. Keep the polling loop unbounded, consistent with virtio-pci, since the reset callback does not return an error code. Signed-off-by: Peter Hilber Link: https://github.com/oasis-tcs/virtio-spec/commit/bb1dd2e1fe89b862f38f1= 5873d835a698b196f89 --- drivers/virtio/virtio_mmio.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 510b7c4efdff..316f03b97356 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -55,6 +55,7 @@ #define pr_fmt(fmt) "virtio-mmio: " fmt =20 #include +#include #include #include #include @@ -114,9 +115,9 @@ static int vm_finalize_features(struct virtio_device *v= dev) vring_transport_features(vdev); =20 /* Make sure there are no mixed devices */ - if (vm_dev->version =3D=3D 2 && + if (vm_dev->version >=3D 2 && !__virtio_test_bit(vdev, VIRTIO_F_VERSION_1)) { - dev_err(&vdev->dev, "New virtio-mmio devices (version 2) must provide VI= RTIO_F_VERSION_1 feature!\n"); + dev_err(&vdev->dev, "New virtio-mmio devices (version >=3D 2) must provi= de VIRTIO_F_VERSION_1 feature!\n"); return -EINVAL; } =20 @@ -254,6 +255,12 @@ static void vm_reset(struct virtio_device *vdev) =20 /* 0 status means a reset. */ writel(0, vm_dev->base + VIRTIO_MMIO_STATUS); + + if (vm_dev->version >=3D 3) { + /* Wait for reset to complete. */ + while (vm_get_status(vdev)) + fsleep(1000); + } } =20 =20 @@ -600,7 +607,7 @@ static int virtio_mmio_probe(struct platform_device *pd= ev) =20 /* Check device version */ vm_dev->version =3D readl(vm_dev->base + VIRTIO_MMIO_VERSION); - if (vm_dev->version < 1 || vm_dev->version > 2) { + if (vm_dev->version < 1 || vm_dev->version > 3) { dev_err(&pdev->dev, "Version %ld not supported!\n", vm_dev->version); rc =3D -ENXIO; --=20 2.43.0